From nobody Sun May 5 19:08:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623054172; cv=none; d=zohomail.com; s=zohoarc; b=ct9+LfPZcVWosdsWYiCbFOaBO4AFEkbd+rlzb/0tcz2o9+dFWcSwr+cEvVnshXk3ypPFs79PnCDJ+8/VODWgvzQgS1jjBW8l/Luf3j5NwQDqoHKXwKC1VZYabY2w/xkeQziMfTTFtlKszxADriAbDXHpNC+6lupyyKsNzfo0MAM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623054172; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=i2ipxCAlt/SoU3fU6XkRZSz51wZ0/Y/V080RKYc8ZvY=; b=Pb5a7JQb7mSKpT6yVHWTPOzZEPEaDQhgK9VK0h0JHaJ2ITmfmvcMtgcGg5yW/UI0CU7ebaCXcSoBBWho+xl3/7P22AS/R4nE3DK8MAFEVkAOWh2biiB5WonRKbcmnX8YUd1x0wAZMi2Q/vGcgQQcaQrfF2JSXf0C4SHUSDOxEJA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1623054172823563.543710596663; Mon, 7 Jun 2021 01:22:52 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-xxwNOt5xOOWIJ_VQp4Wjew-1; Mon, 07 Jun 2021 04:22:50 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BC12780EDAC; Mon, 7 Jun 2021 08:22:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9100E10023AF; Mon, 7 Jun 2021 08:22:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 267A044A5A; Mon, 7 Jun 2021 08:22:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1578InPv031453 for ; Mon, 7 Jun 2021 04:18:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id 97F5519714; Mon, 7 Jun 2021 08:18:49 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B89319D9D for ; Mon, 7 Jun 2021 08:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623054171; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=i2ipxCAlt/SoU3fU6XkRZSz51wZ0/Y/V080RKYc8ZvY=; b=Gosubn+NjgqMpZWwwE+f4Gu7dWuninmH6LvXXniIiPjh83YiVhK7aGr5AoD8n+p2FgPfE7 mhcMO8s4y1Li8h8EnWsP23ctpXs3mRFCqgz/7nSdzfvp0iyuV4MxCry7yLTSd+5FFVKuSO 9BKrGcjH9rCZkl9ckpRN9qlnnavfbeU= X-MC-Unique: xxwNOt5xOOWIJ_VQp4Wjew-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/3] doRemoteOpen: Drop @daemonPath Date: Mon, 7 Jun 2021 10:18:40 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The @daemonPath variable in doRemoteOpen() is no longer used after faf8354674. Remove it. Signed-off-by: Michal Privoznik --- src/remote/remote_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index da672b0d00..c03c68ec30 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -729,9 +729,6 @@ doRemoteOpen(virConnectPtr conn, virConf *conf, unsigned int flags) { -#ifndef WIN32 - g_autofree char *daemonPath =3D NULL; -#endif g_autofree char *tls_priority =3D NULL; g_autofree char *name =3D NULL; g_autofree char *command =3D NULL; --=20 2.31.1 From nobody Sun May 5 19:08:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623054186; cv=none; d=zohomail.com; s=zohoarc; b=f58U5R6p7Q7UDr4buoaFoNv9ETakSYu5SjgK/lab1D2bvM6IPd4oDOWmWyzYsQrA6bM08UGQoYvtD1DfS4xvza7f/q+ST/BSWvDnUF6nlSEJ+WA+eeInWVl1e7Yipd44oxOqH5IP9pLYpJ7N/T5cYEYTagf4DZQ+Joou1Xk8B7w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623054186; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/8bn3qREJptmKRUTVycezVHF/oAtePvFqC2uRlMzCWk=; b=UMtfiya2ucL1Df229WHp4cWe7/Chi4RkYtlTZqpANlnuCSdKblWeXFXXcry2VQ/25Q9jSdktB0AgtboRfaq8OpiEDM0gg5due+ryImFBZtH72OD2nrNwsmV6lX9oLWMHTUzoAs+q9eurnnmLHN8L68iILO0kiOgC3RfqF076+d0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1623054186359777.0099226333963; Mon, 7 Jun 2021 01:23:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-P1l1aBSsMUSkzK9aQvQy-Q-1; Mon, 07 Jun 2021 04:23:03 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85C86101371C; Mon, 7 Jun 2021 08:22:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C4B02AE89; Mon, 7 Jun 2021 08:22:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0802044A5B; Mon, 7 Jun 2021 08:22:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1578IoHd031458 for ; Mon, 7 Jun 2021 04:18:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7130D19D9D; Mon, 7 Jun 2021 08:18:50 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8BD119714 for ; Mon, 7 Jun 2021 08:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623054185; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/8bn3qREJptmKRUTVycezVHF/oAtePvFqC2uRlMzCWk=; b=UoMHFdwEppGTU4WhFTdC4+Oyecq+0c/pqYfAQloSLtsfqb8ED5fX1eRlfI2jyUKmiSl0Gv Z+9oG5YkoXZSZ/Cz74EE8z+N9/3wsJ7zlGnpC47j1uVovDBclR1Wk9vM0XNhSxqk00pkws ZZHUnSrsbSUBJbDso7bGNGerMUpIOO4= X-MC-Unique: P1l1aBSsMUSkzK9aQvQy-Q-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/3] virnetsocket: Mark @spawnDaemonPath of virNetSocketNewConnectUNIX() unused Date: Mon, 7 Jun 2021 10:18:41 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The virNetSocketNewConnectUNIX() function was changed in 48f66cfe3e. And its WIN32 version (which just reports an error) was updated too, but this new argument @spawnDaemonPath was not marked as unused. Signed-off-by: Michal Privoznik --- src/rpc/virnetsocket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index c3fae8b626..212089520d 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -774,7 +774,7 @@ int virNetSocketNewConnectUNIX(const char *path, } #else int virNetSocketNewConnectUNIX(const char *path G_GNUC_UNUSED, - const char *spawnDaemonPath, + const char *spawnDaemonPath G_GNUC_UNUSED, virNetSocket **retsock G_GNUC_UNUSED) { virReportSystemError(ENOSYS, "%s", --=20 2.31.1 From nobody Sun May 5 19:08:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623054208; cv=none; d=zohomail.com; s=zohoarc; b=V7ZKEPMQK4czfaWKw14Jomh2/r+3OZebQfF/z5gKJZaffykQM0KX6H1fznh06NsFYyW+OqDsfKY6OWbURlizN+JodclBznnB/eRZmFh9BN3NT+GmFk5Slw7tF7aTZ/BEwYI0RPvRATNYlNhM7cqg2Xqmi+Jc5KRDhbEZj72i1nU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623054208; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Eqh0uNH7lLi02eKKAKXlknEkOq80gHX/BV8+tIcBhNI=; b=h66PGvxyb7Kg+GPU3UX1dHW76DztrTf5EC1vSiBRy0jcKO/YBJqont4a6tTGPsRxTFzjb/cj+lEtJ+m6kC7teMWS1u3Ko2kk2vFd1nbsIFyBe4nTW3vzMM108Y3z68G5g2TsMh7C5xfiPQMe2YglKjzt46Do9c1QtAoU9zh6H84= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1623054208621133.60340975895588; Mon, 7 Jun 2021 01:23:28 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-TnmIEX3TPC-Htj8i8fhVVA-1; Mon, 07 Jun 2021 04:23:25 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 88D7F101371F; Mon, 7 Jun 2021 08:23:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 38C805C26D; Mon, 7 Jun 2021 08:23:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EC2C31800BB8; Mon, 7 Jun 2021 08:23:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1578Ip0O031472 for ; Mon, 7 Jun 2021 04:18:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4AB7B19714; Mon, 7 Jun 2021 08:18:51 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id C281D19D9D for ; Mon, 7 Jun 2021 08:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623054207; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Eqh0uNH7lLi02eKKAKXlknEkOq80gHX/BV8+tIcBhNI=; b=LZ+60JF8MNLie4GnTojWyzxv+NmJR2HPlA204UVVE1857EVU0UKArMMXVvYv8UYW3fjjZ1 ZNUYgcTNbVonEAbasfWg7ZicoBJlzNPL34QUeYqe9/MihRmULt9DSA7sqoX7y333xP0pyB dB5lpCGUKtYF3inxYzmAzgqnALt/sbs= X-MC-Unique: TnmIEX3TPC-Htj8i8fhVVA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/3] remoteGetUNIXSocket: Complete variable rename for WIN32 Date: Mon, 7 Jun 2021 10:18:42 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" In fcdcf8f70cf the remoteGetUNIXSocket() function was changed and one new variable was introduced (among other things): @env_name. However, for WIN32 case the variable changed name to @env_path which builds mingw builds. Signed-off-by: Michal Privoznik --- src/remote/remote_sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_sockets.c b/src/remote/remote_sockets.c index ed4e4a329c..0f85b999fd 100644 --- a/src/remote/remote_sockets.c +++ b/src/remote/remote_sockets.c @@ -163,7 +163,7 @@ remoteGetUNIXSocket(remoteDriverTransport transport, #ifndef WIN32 const char *env_name =3D remoteGetDaemonPathEnv(); #else - const char *env_path =3D NULL; + const char *env_name =3D NULL; #endif =20 VIR_DEBUG("Choosing remote socket for transport=3D%s mode=3D%s driver= =3D%s flags=3D0x%x", --=20 2.31.1