On Fri, Jun 04, 2021 at 03:10:39PM +0200, Michal Privoznik wrote:
> See 4/6 for more info. The rest is just cleanup.
>
> Michal Prívozník (6):
> ch_conf: Move error reporting into chExtractVersionInfo()
> chExtractVersionInfo: Don't check for retversion != NULL
> ch_conf: Dissolve chExtractVersionInfo() in chExtractVersion()
> ch_driver: Don't error out if CH_CMD was not found
> chExtractVersion: use g_auto*
> chExtractVersion: Drop @ret
>
> src/ch/ch_conf.c | 53 +++++++++++++++++-----------------------------
> src/ch/ch_driver.c | 15 +++++++++----
> 2 files changed, 30 insertions(+), 38 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
/me facepalms for not actually testing startup with the libvirtd
daemon.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|