[PATCH 0/6] util: virerror: Avoid stack'd buffers for error message formatting

Peter Krempa posted 6 patches 3 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1614698410.git.pkrempa@redhat.com
src/qemu/qemu_process.c |  12 +--
src/util/virerror.c     | 188 ++++++++++++++++++++++------------------
src/util/virerror.h     |   2 -
src/util/virprocess.c   |  10 ++-
4 files changed, 116 insertions(+), 96 deletions(-)
[PATCH 0/6] util: virerror: Avoid stack'd buffers for error message formatting
Posted by Peter Krempa 3 years ago
We don't need OOM resiliency nowadays.

Peter Krempa (6):
  util: virerror: Don't use stack'd buffers in error report helpers
  util: virerror: Avoid a copy of the error messages
  util: virprocess: Use local maximum error message size
  qemuProcessReportLogError: Remove unnecessary math for max error
    message
  qemuProcessReportLogError: Don't mark "%s: %s" as translatable
  util: virerror: Remove VIR_ERROR_MAX_LENGTH macro

 src/qemu/qemu_process.c |  12 +--
 src/util/virerror.c     | 188 ++++++++++++++++++++++------------------
 src/util/virerror.h     |   2 -
 src/util/virprocess.c   |  10 ++-
 4 files changed, 116 insertions(+), 96 deletions(-)

-- 
2.29.2

Re: [PATCH 0/6] util: virerror: Avoid stack'd buffers for error message formatting
Posted by Ján Tomko 3 years ago
On a Tuesday in 2021, Peter Krempa wrote:
>We don't need OOM resiliency nowadays.
>
>Peter Krempa (6):
>  util: virerror: Don't use stack'd buffers in error report helpers
>  util: virerror: Avoid a copy of the error messages
>  util: virprocess: Use local maximum error message size
>  qemuProcessReportLogError: Remove unnecessary math for max error
>    message
>  qemuProcessReportLogError: Don't mark "%s: %s" as translatable
>  util: virerror: Remove VIR_ERROR_MAX_LENGTH macro
>
> src/qemu/qemu_process.c |  12 +--
> src/util/virerror.c     | 188 ++++++++++++++++++++++------------------
> src/util/virerror.h     |   2 -
> src/util/virprocess.c   |  10 ++-
> 4 files changed, 116 insertions(+), 96 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano