From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541169; cv=none; d=zohomail.com; s=zohoarc; b=Wy3UaNbVQozZwPThe7LuZ4v7+L12L0qHYqv26Br0/h3i2YTm08Hq/dYwoemmPf7STNOtF42VRsNBSnOjDwrEfgHeyCWKqYaczLBfPg4yRAU8LYiI7x2itEfqG8lq/D5OgA0FQyGY1vwBCSkctWbfcvxUKQls/Egv5aiYRHEDzdQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541169; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DgqvtvUvplWI/+I85QlPp+b1F5wTTyRGXMVHEh91e5Y=; b=XoC15DA2wU+Y6O9bk5+H3F9hKDtdZJ9M1YLPOPos9ri5aUSxFlVxb5fLRTkev+ScEGFYvlY8KH8iWC0VEGQg9VetCiNuwtvbfBnz612Lpn0mfFeRrcq8UkagBQOEbUAZ2Vi5l+U+KgnJT2m49ppr/+yDkyduyEH2Gj5BmbDZ6ww= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1605541169335625.3409690807345; Mon, 16 Nov 2020 07:39:29 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-554-SAassQc3Nu-joOfDRs0cQA-1; Mon, 16 Nov 2020 10:39:26 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D6CE18CB726; Mon, 16 Nov 2020 15:39:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C3446EF65; Mon, 16 Nov 2020 15:39:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3B46C5812A; Mon, 16 Nov 2020 15:39:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFd4kg022522 for ; Mon, 16 Nov 2020 10:39:04 -0500 Received: by smtp.corp.redhat.com (Postfix) id F3AFF6EF55; Mon, 16 Nov 2020 15:39:03 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F59E6EF51 for ; Mon, 16 Nov 2020 15:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541168; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DgqvtvUvplWI/+I85QlPp+b1F5wTTyRGXMVHEh91e5Y=; b=BoOlWkVgNL3ohDkyr22h8WXYVjBh3kBf9ApCsqyrWAxO9BdjdxjTiYP2Cte27UkKKS2aP2 tKsyDLW+cHGAS8GDwWgQMUiD82r/B3bO4DV95q6llL6bOPiCzI3bgFh5i1k69MRvHTKuMX KglcG8z3PtRO5J6lVi/i/4uvWTYXBmg= X-MC-Unique: SAassQc3Nu-joOfDRs0cQA-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 01/11] domain_conf: remove unused rc variable Date: Mon, 16 Nov 2020 16:38:48 +0100 Message-Id: <23eeb4d06269d836f5ed018b20f3485d65191f2d.1605541084.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Leftover after commit <479a8c1fa1e0f58d3165c0446cd1abd72160256e>. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9199771dc0..5c30227212 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -27074,7 +27074,6 @@ virDomainNetDefFormat(virBufferPtr buf, virBufferEscapeString(buf, "\n", virDomainNetGetModelString(def)); if (virDomainNetIsVirtioModel(def)) { - int rc =3D 0; g_autofree char *str =3D NULL; g_autofree char *gueststr =3D NULL; g_autofree char *hoststr =3D NULL; @@ -27099,9 +27098,6 @@ virDomainNetDefFormat(virBufferPtr buf, virBufferAdjustIndent(buf, -2); virBufferAddLit(buf, "\n"); } - - if (rc < 0) - return -1; } } if (def->backend.tap || def->backend.vhost) { --=20 2.26.2 From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541274; cv=none; d=zohomail.com; s=zohoarc; b=L9aMCqnGq5dxzIisq3YjkwqMeolDqTWVJ5AnMyUtvQwTZSXPMVCk64/xIyDbr75vRfY/GZkwZep5QldKOeIMY492bpN/bghy3yFXX/R312eku4Gmf/4seUEpt4YzgXl5jTYgA0O/BnyE1Gv9BhMDnpNHoBCXghJ4g/JJ0vX+pus= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541274; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=19JFcMC2qAjD3oMoSCB9QIlkLdqfZ31pLynNmX9F/ko=; b=aFoqVpW14sZKOeIY/BTpaZLbChv+c7WNoTaqIZDDmkJZAGPJAHWV0rj1gejZMW6bEFk6jmoEPM5Dvw/SSpQeA+NR90ZX/O8yP34rVcSvkjJyU56ygaDSQPAshwjRzB0n8ZmctQbycCz4r+IMytb09Cd8DbpN1SfIM4api9RFR0c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605541274137755.6828655139154; Mon, 16 Nov 2020 07:41:14 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-407-kEkYgRLQP1OLEYbkR2KDPg-1; Mon, 16 Nov 2020 10:39:52 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1476A106B309; Mon, 16 Nov 2020 15:39:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE5D75C5B7; Mon, 16 Nov 2020 15:39:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A55B1183D025; Mon, 16 Nov 2020 15:39:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFd4A6022532 for ; Mon, 16 Nov 2020 10:39:04 -0500 Received: by smtp.corp.redhat.com (Postfix) id D7C646EF55; Mon, 16 Nov 2020 15:39:04 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54BC86EF51 for ; Mon, 16 Nov 2020 15:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541273; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=19JFcMC2qAjD3oMoSCB9QIlkLdqfZ31pLynNmX9F/ko=; b=ERcdfMWynvsck6pd1WElhwqlFxiGnPHz4OvEhUZPZ8ywqLZtIUjb7p2GpA1y79nqAnI+jO fgTEJhV4w4Iy8mJ7Nr4WFx5z2aidi/SE2tM5TYOaBOoEPEMnCQpRUiGCeYpuHIrk+VECNQ r3sB/Irs2EQPPvnydUZYGLEc1T0/wR8= X-MC-Unique: kEkYgRLQP1OLEYbkR2KDPg-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 02/11] domain_conf: fix NULL dereference on error in virDomainObjCopyPersistentDef Date: Mon, 16 Nov 2020 16:38:49 +0100 Message-Id: <62ca001eb2c96ec894770da13b353a978bc6436a.1605541084.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The issue was introduced together with the function itself by commit . Calling `virDomainObjGetPersistentDef` may return NULL which is later passed to `virDomainDefFormat` where the `def` attribute is marked as NONNULL and later in `virDomainDefFormatInternalSetRootName` it is actually defererenced without any other check. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5c30227212..eaad72ad0a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -30933,6 +30933,12 @@ virDomainObjCopyPersistentDef(virDomainObjPtr dom, virDomainDefPtr cur; =20 cur =3D virDomainObjGetPersistentDef(xmlopt, dom, parseOpaque); + if (!cur) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Get persistent config failed")); + return NULL; + } + return virDomainDefCopy(cur, xmlopt, parseOpaque, false); } =20 --=20 2.26.2 From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541244; cv=none; d=zohomail.com; s=zohoarc; b=UdjBwE/mMX/cxV4+9N8F0ycqnoa31oXLpxpFIJB+UwLFH4pFc+ML2wyPzJJ56Ehqz6pz+CnIT5u4rS/KTgvvXjOlza0SOoTyMURrWCCb0Wsz96fnPkwgIhF1/uc4zVI2XWqcS3smhJM0Z58AUk2oDZIdZaWg7+cE7BsdvOs7CSw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541244; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vVT8Be8/cR+HYsphGwYcKAM/RL4mPOmh9GslotRh0Z4=; b=DgM4as5LKt87CVZm8Vs2oqmoA91nvaaV00XE341Ie5azRKnNHUq5X9tb5a+X7VT8EY+vUTkSqolkUyQYEZyfdNiokf4tDlP725rHGsaVWKSWbpBQ7pPVPlSeUekoy14KLd6wXZpQVZyYIKbygdoWdzJPBwMQXDCwvyPX5fc2XM0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605541244735614.7098536841645; Mon, 16 Nov 2020 07:40:44 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-mRG8WfbRPNu-KhTKNwRLRQ-1; Mon, 16 Nov 2020 10:39:42 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0C5C8C18EA; Mon, 16 Nov 2020 15:39:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD99455769; Mon, 16 Nov 2020 15:39:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 79D3758130; Mon, 16 Nov 2020 15:39:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFd5Ww022543 for ; Mon, 16 Nov 2020 10:39:05 -0500 Received: by smtp.corp.redhat.com (Postfix) id BB2BC6EF55; Mon, 16 Nov 2020 15:39:05 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 382816EF51 for ; Mon, 16 Nov 2020 15:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541243; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vVT8Be8/cR+HYsphGwYcKAM/RL4mPOmh9GslotRh0Z4=; b=Adyh8aj5pDitW52AuXdx4ka3QJTEZGEXkyya1vQ+a/CpGMDivWaftb9m5LopSCFvBfTNzS JHXAx/YwNRS5JWljT9HzR7yCh2mLXVyv4RkcvaJcWQs8Mlf5XijY0/G8uq132YKHEiZKBU jLy56b6tK/lwf1cQ6B4wR0f9IA1Kz+0= X-MC-Unique: mRG8WfbRPNu-KhTKNwRLRQ-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 03/11] hyperv_wmi: remove unreachable cleanup code Date: Mon, 16 Nov 2020 16:38:50 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" In the cleanup section @data will always be NULL. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/hyperv/hyperv_wmi.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 866b347bc2..efd0659051 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv/hyperv_wmi.c @@ -942,7 +942,6 @@ hypervEnumAndPull(hypervPrivate *priv, hypervWqlQueryPt= r wqlQuery, hypervObject *head =3D NULL; hypervObject *tail =3D NULL; WsXmlNodeH node =3D NULL; - XML_TYPE_PTR data =3D NULL; hypervObject *object; =20 query_string =3D virBufferContentAndReset(wqlQuery->query); @@ -983,6 +982,8 @@ hypervEnumAndPull(hypervPrivate *priv, hypervWqlQueryPt= r wqlQuery, response =3D NULL; =20 while (enumContext !=3D NULL && *enumContext !=3D '\0') { + XML_TYPE_PTR data =3D NULL; + response =3D wsmc_action_pull(priv->client, wmiInfo->resourceUri, = options, filter, enumContext); =20 @@ -1030,8 +1031,6 @@ hypervEnumAndPull(hypervPrivate *priv, hypervWqlQuery= Ptr wqlQuery, object->info =3D wmiInfo; object->data =3D data; =20 - data =3D NULL; - if (head =3D=3D NULL) { head =3D object; } else { @@ -1059,13 +1058,6 @@ hypervEnumAndPull(hypervPrivate *priv, hypervWqlQuer= yPtr wqlQuery, if (filter !=3D NULL) filter_destroy(filter); =20 - if (data !=3D NULL) { - if (ws_serializer_free_mem(serializerContext, data, - wmiInfo->serializerInfo) < 0) { - VIR_ERROR(_("Could not free deserialized data")); - } - } - VIR_FREE(query_string); ws_xml_destroy_doc(response); VIR_FREE(enumContext); --=20 2.26.2 From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541196; cv=none; d=zohomail.com; s=zohoarc; b=lWrg2Aejc3TAXMgBqTFhyxa2r1MN8D5FdsASoGuX36Kr/nZrU/yIPUX94J6E48hFcK+1XNZ1IvSIYqxwJLgJANb8vSh44422KwvX9+vgOByJdQ4UIkQy1gV9jZXzSgoduzq7JP5ZHN5TwVNmZXJP36ZXhYNEw6wJnDTKS67uviE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541196; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Slo3oKcCdtmQIwLylGwWNlATYOFZEELnUN5dJgugQSs=; b=YxxNMDP2NKcsWwUqB61purD8141ayCq02nVVF9MPwWh6/WZ4UOrFE0qcx6rxR0cDREiJhtHZd6kFr5INzbKKU3xupY3OeWQGyNOlnaXEQvDKEZkXTgtLyOqe5Y0Gs/1WURbgrhWojunqesUHI21TBSQqOYYsQFG+9hEdqSi3wBw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605541196044208.4057861058144; Mon, 16 Nov 2020 07:39:56 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-w2wIdcIjMI-GIgmJ5jbOlw-1; Mon, 16 Nov 2020 10:39:52 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D02271028D5C; Mon, 16 Nov 2020 15:39:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE9305B4C1; Mon, 16 Nov 2020 15:39:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7B0B95812D; Mon, 16 Nov 2020 15:39:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFd6vs022551 for ; Mon, 16 Nov 2020 10:39:06 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9F24A6EF55; Mon, 16 Nov 2020 15:39:06 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1BC696EF51 for ; Mon, 16 Nov 2020 15:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541195; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Slo3oKcCdtmQIwLylGwWNlATYOFZEELnUN5dJgugQSs=; b=FIkReV5Ex4RA6zDbh6BoEAioQpNACZJDOC6uSgPZFUxF52GZr1tLjOmqMOeyAY4q0rLEE4 wh9x55oK5AglvAGrMw1jaZ7KIz2DVkbB5tdpBNr3/KPJJGyLZDRpnxtWxYLMPQMdKA5lta EzIWKdmFpX9PFgAeoZck9Ck3jQkNdgU= X-MC-Unique: w2wIdcIjMI-GIgmJ5jbOlw-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 04/11] interface_backend_udev: refactor udevListInterfacesByStatus Date: Mon, 16 Nov 2020 16:38:51 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit <2f3b7a5555c4cf4127ff3f8e00746eafcc91432c> replaced VIR_STRDUP by g_strdup which made the error: path mostly useless. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/interface/interface_backend_udev.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interfa= ce_backend_udev.c index 4e0a80765c..ce007fd29e 100644 --- a/src/interface/interface_backend_udev.c +++ b/src/interface/interface_backend_udev.c @@ -204,7 +204,8 @@ udevListInterfacesByStatus(virConnectPtr conn, virReportError(VIR_ERR_INTERNAL_ERROR, _("failed to get list of %s interfaces on host"), virUdevStatusString(status)); - goto error; + udev_unref(udev); + return -1; } =20 /* Do the scan to load up the enumeration */ @@ -239,16 +240,6 @@ udevListInterfacesByStatus(virConnectPtr conn, udev_unref(udev); =20 return count; - - error: - if (enumerate) - udev_enumerate_unref(enumerate); - udev_unref(udev); - - for (names_len =3D 0; names_len < count; names_len++) - VIR_FREE(names[names_len]); - - return -1; } =20 static int --=20 2.26.2 From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541205; cv=none; d=zohomail.com; s=zohoarc; b=FaCRv6yNefZsrY30/kQjhq2DBNNFPZm/GLy5fU48IdtrjS+fUFPQfGrLlN3UG+347HHt/ZHGQ7s3wu06v2acx1xxlrMeZZdLELM0bwnbL0sx79vaeBA0Qfzoz1snEbM0CGdfP0sSR39Ik2ZiuyJ/73CdI1Rgtw/zxh2DNKbysLM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541205; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Uaq7y3F5nLURzURUuqth8QOcPmdraNZsNuptdBYGdqE=; b=BBkOTfHI61jWL+pE+dv1sATO5F7Qcq6s93ELp3ADJi7Bj1sXp8SkhuSttlVsyasuFVFkegq/3dgk36PUGK/E2bISBAFBneH3czL2PZ4Wfsl0457SS+ESMyBtm90PPAAqNUqD6r3HzG820i5bnwJwruNKbP6wPbVDMqNiGD/BNl8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605541205090666.1653435973151; Mon, 16 Nov 2020 07:40:05 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-kB1sfjekONyxKeBiQY354g-1; Mon, 16 Nov 2020 10:39:52 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F2FE1028D6D; Mon, 16 Nov 2020 15:39:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5652E19646; Mon, 16 Nov 2020 15:39:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1F1C3183D023; Mon, 16 Nov 2020 15:39:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFd7n5022559 for ; Mon, 16 Nov 2020 10:39:07 -0500 Received: by smtp.corp.redhat.com (Postfix) id 829EA6EF51; Mon, 16 Nov 2020 15:39:07 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0004B6EF58 for ; Mon, 16 Nov 2020 15:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541203; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Uaq7y3F5nLURzURUuqth8QOcPmdraNZsNuptdBYGdqE=; b=BHIXbRRsgnBlaaW/65qFOCQ0pSg8kgp92LyOlUfo0RwSVjG1HrE0d1Nub+JYRM1pghQIgx 9GXD38D7mhmUg7Z91HYhowQnh+PTRT4p4BfLuWze/Ih6GPkdxSCtWI1A7YRKwmiy0AkFXb 5whsloeiwK5g2UwFwEqz+FIrPKzmiFE= X-MC-Unique: kB1sfjekONyxKeBiQY354g-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 05/11] qemu_command: fix FD usage in qemuBuildInterfaceCommandLine Date: Mon, 16 Nov 2020 16:38:52 +0100 Message-Id: <6798ecda5d3a184e8002ba1d52762a4b2144851d.1605541084.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" If virCommandPassFD() is called with VIR_COMMAND_PASS_FD_CLOSE_PARENT the passed FD is closed and should not be used after that call. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0eec35da16..0580feb475 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -8142,7 +8142,7 @@ qemuBuildInterfaceCommandLine(virQEMUDriverPtr driver, g_autofree char *fdset =3D NULL; g_autofree char *addfdarg =3D NULL; =20 - virCommandPassFD(cmd, vdpafd, VIR_COMMAND_PASS_FD_CLOSE_PARENT); + virCommandPassFD(cmd, vdpafd, 0); fdset =3D qemuVirCommandGetFDSet(cmd, vdpafd); if (!fdset) goto cleanup; --=20 2.26.2 From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541199; cv=none; d=zohomail.com; s=zohoarc; b=L3fLKlRylRP5q8TzruECkvlglpKPesdQJYG6HHjStVuIQAtQuT66Cm6bSwUhsbEr/WIGhjfVUXCyd0BVz6X8dMwOWj1iDX2aPHNSwrRG8MOcwNz8Ls9myQAVD/bbW6VqlfmHaBgj2YzZ25pUn/AicmsSatnIEpMMzl7CEO3XqFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541199; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9lx+AyGFA0F9rWErT/F1u90W3U6Aq5mQhX9irnVaxUE=; b=U6Y3g9QcxDvTkNc1Acu05cX9RNJoMraoM+SB6ky94LKZlyuvdx8RZXDUZMGVbe3MLK2q7jw6X7ohobQNNsC3tZ/fB2pYhdr/JjZPrZda2JeOJRWVjntgb+3wBtyDhz2DZ8g4KDx5PjBL1K9Q0N/wQMGz68Ca+HDhvaxrB8Ya0Q8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1605541199471862.3191059202255; Mon, 16 Nov 2020 07:39:59 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-BrwRockPOwO6ijsSyRlvcQ-1; Mon, 16 Nov 2020 10:39:56 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 32F54802B75; Mon, 16 Nov 2020 15:39:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E0DD5DA33; Mon, 16 Nov 2020 15:39:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CA0A2183D027; Mon, 16 Nov 2020 15:39:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFd8ov022569 for ; Mon, 16 Nov 2020 10:39:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id 662D86EF55; Mon, 16 Nov 2020 15:39:08 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id D714A6EF51 for ; Mon, 16 Nov 2020 15:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541198; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9lx+AyGFA0F9rWErT/F1u90W3U6Aq5mQhX9irnVaxUE=; b=LaaYkYO5ATidPQoGEEWqH1iuThhtjZlGYfrOg93ItM3YaUWrXCv1W72f4GSMNS+U2YCD5+ jz7bH0zsAe6F3JkAggHGiAYpO8j3VY0FCFYMLrlrASX+H+e77XvAapt7pcF8GIoB/OcxA3 YRMaMRxSRLMxIO0+EeveXT7vmWZJbK4= X-MC-Unique: BrwRockPOwO6ijsSyRlvcQ-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 06/11] qemu_monitor_json: explicitly ignore return values Date: Mon, 16 Nov 2020 16:38:53 +0100 Message-Id: <9009306d4d328ef06eab2dfd7fc201f484d8ea2d.1605541084.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- src/qemu/qemu_monitor_json.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 723bdb4426..51730a5fe3 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -1370,8 +1370,8 @@ qemuMonitorJSONHandleMemoryFailure(qemuMonitorPtr mon, } =20 if (flagsjson) { - virJSONValueObjectGetBoolean(flagsjson, "action-required", &ar); - virJSONValueObjectGetBoolean(flagsjson, "recursive", &recursive); + ignore_value(virJSONValueObjectGetBoolean(flagsjson, "action-requi= red", &ar)); + ignore_value(virJSONValueObjectGetBoolean(flagsjson, "recursive", = &recursive)); } =20 mf.recipient =3D recipient; --=20 2.26.2 From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541177; cv=none; d=zohomail.com; s=zohoarc; b=RgckJBWB1kh+PDJ9kHi4qQEdysudTXQElQ4SGHbTeSWHRc3bPC2eugc1yRpSYmedaVW/zcv4nwy7yGHItKJNCOU1BhZhJ3436ppuVcGCbwpoYZlufQ2etOxvVlLnhTUBF8j3XDLsx4e6dgqHP6T5BpYy39rbNFsiEqYodu3hQok= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541177; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dGF913xRIt5hnwbxR5096yHZJiKw3TSBSlGy2NBbnqY=; b=AfQY6lh+MA5pagiMlZgSQlM6HCvzCXlXpctlqe4XURubXAqbNXv1QtQQxBtxjblYOpq9IJ48GX07gSB6zQZMhib6ZQW25aVGcH52TVgRv2bBuQpQylsahLhYDraFQEgqsUdbGkVmRcZ6yKod7+Ps+u9vCuYAbBjIVXw6RYpp1pI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605541177865293.50767305464774; Mon, 16 Nov 2020 07:39:37 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-NkUENGJiM3CjyoqT7mz0Ag-1; Mon, 16 Nov 2020 10:39:34 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30383801FD8; Mon, 16 Nov 2020 15:39:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C8821002C0D; Mon, 16 Nov 2020 15:39:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C31D6183D021; Mon, 16 Nov 2020 15:39:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFd9Zq022581 for ; Mon, 16 Nov 2020 10:39:09 -0500 Received: by smtp.corp.redhat.com (Postfix) id 49F296EF51; Mon, 16 Nov 2020 15:39:09 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB36C6EF58 for ; Mon, 16 Nov 2020 15:39:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541176; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=dGF913xRIt5hnwbxR5096yHZJiKw3TSBSlGy2NBbnqY=; b=OVVdFvcUJFGTQ+TBpREtCHdJQ8G8/PyT+FNi6nDZq+Rm8YvvdU0Cs1UtvbpaHktYYhDCGn jf+MVNPY728UGdGQAVwLcxYjYgODT8Y4uA62CGuVxzsAptvuv+4YMV7RWzxwQEMJWga2Tb P1eeveZhLLdZoPl4vnwhjHM4teULPZw= X-MC-Unique: NkUENGJiM3CjyoqT7mz0Ag-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 07/11] qemu_process: no need to check for NULL Date: Mon, 16 Nov 2020 16:38:54 +0100 Message-Id: <89a10d7e45f256145640f83bc60abf95638864f2.1605541084.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/qemu/qemu_process.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index e2a3d87527..579b3c3713 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1105,24 +1105,20 @@ qemuProcessHandleGraphics(qemuMonitorPtr mon G_GNUC= _UNUSED, return 0; =20 error: - if (localAddr) { - VIR_FREE(localAddr->service); - VIR_FREE(localAddr->node); - VIR_FREE(localAddr); - } - if (remoteAddr) { - VIR_FREE(remoteAddr->service); - VIR_FREE(remoteAddr->node); - VIR_FREE(remoteAddr); - } - if (subject) { - for (i =3D 0; i < subject->nidentity; i++) { - VIR_FREE(subject->identities[i].type); - VIR_FREE(subject->identities[i].name); - } - VIR_FREE(subject->identities); - VIR_FREE(subject); + VIR_FREE(localAddr->service); + VIR_FREE(localAddr->node); + VIR_FREE(localAddr); + + VIR_FREE(remoteAddr->service); + VIR_FREE(remoteAddr->node); + VIR_FREE(remoteAddr); + + for (i =3D 0; i < subject->nidentity; i++) { + VIR_FREE(subject->identities[i].type); + VIR_FREE(subject->identities[i].name); } + VIR_FREE(subject->identities); + VIR_FREE(subject); =20 return -1; } --=20 2.26.2 From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541332; cv=none; d=zohomail.com; s=zohoarc; b=ItS/bQWs00b0XH1NaRJqBniuViHb2pzWUSptFtPSC669G0JyfFboBx+hFm3NWCPfcCtNmtneJGaYjhcVOSza+ehCXeq3W16yMmeaYWTTHnohyLFokDSOUVeblcFwVt+Qrj1vKcpinFhdYAUi9qSQULTUFHvcWrZd8lWCTgscKvQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541332; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CwUe3c6giw2BnLymd6X7rohqHh9JqSynYNZvAmvD8SU=; b=FyVaChS7sevhboQXZZACaEaLGwoi2kEaiJG7wUy3WcyGbmouFnosEKn81BxjU+iGeIlIBmhf4yJUKEiWaCf4Dp3vtIzhfO2F09gOFphEu215fVQY3DFLWmdAESKEMveYC5SBvGyZNWe5OIgsrO9rQXPUMVynRc5r0PbFrORnSCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605541332687495.2721946464361; Mon, 16 Nov 2020 07:42:12 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-592-WZmlX5RpOyiRbK-EnSFcbQ-1; Mon, 16 Nov 2020 10:39:53 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1483F195D561; Mon, 16 Nov 2020 15:39:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4EFA1002D73; Mon, 16 Nov 2020 15:39:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B206258128; Mon, 16 Nov 2020 15:39:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFdAW6022594 for ; Mon, 16 Nov 2020 10:39:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id 2D4316EF55; Mon, 16 Nov 2020 15:39:10 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E7F46EF51 for ; Mon, 16 Nov 2020 15:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541331; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=CwUe3c6giw2BnLymd6X7rohqHh9JqSynYNZvAmvD8SU=; b=QGFfsVIvezIYvynzyuhx2xRMSU1XOoqbi4PE5m/GtxB/nwAkYK+eID1rMQmv/YzRTaucX/ 3ZuKTgLxB4TNj/7OytDjfEcEbOve/EZt4wBgdqzC8l820q08uGnq36+qKaf7gqvFwdl3kN nmRsifYYJxUAlSzfj9FofhcuNQ2DfIk= X-MC-Unique: WZmlX5RpOyiRbK-EnSFcbQ-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 08/11] remote_driver: remove unreachable cleanup code Date: Mon, 16 Nov 2020 16:38:55 +0100 Message-Id: <501369d481f785b23b2da8e35c9187f1de5eca21.1605541084.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" In the cleanup section @info_ret will always be NULL. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/remote/remote_driver.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 9cd2fd36ae..dd5e8eeed2 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -2248,7 +2248,6 @@ remoteDomainGetIOThreadInfo(virDomainPtr dom, remote_domain_get_iothread_info_args args; remote_domain_get_iothread_info_ret ret; remote_domain_iothread_info *src; - virDomainIOThreadInfoPtr *info_ret =3D NULL; =20 remoteDriverLock(priv); =20 @@ -2273,6 +2272,8 @@ remoteDomainGetIOThreadInfo(virDomainPtr dom, } =20 if (info) { + virDomainIOThreadInfoPtr *info_ret =3D NULL; + if (!ret.info.info_len) { *info =3D NULL; rv =3D ret.ret; @@ -2293,17 +2294,11 @@ remoteDomainGetIOThreadInfo(virDomainPtr dom, info_ret[i]->cpumaplen =3D src->cpumap.cpumap_len; } *info =3D info_ret; - info_ret =3D NULL; } =20 rv =3D ret.ret; =20 cleanup: - if (info_ret) { - for (i =3D 0; i < ret.info.info_len; i++) - virDomainIOThreadInfoFree(info_ret[i]); - VIR_FREE(info_ret); - } xdr_free((xdrproc_t)xdr_remote_domain_get_iothread_info_ret, (char *) &ret); =20 @@ -7638,7 +7633,6 @@ remoteDomainGetFSInfo(virDomainPtr dom, remote_domain_get_fsinfo_args args; remote_domain_get_fsinfo_ret ret; remote_domain_fsinfo *src; - virDomainFSInfoPtr *info_ret =3D NULL; =20 remoteDriverLock(priv); =20 @@ -7661,6 +7655,8 @@ remoteDomainGetFSInfo(virDomainPtr dom, } =20 if (info) { + virDomainFSInfoPtr *info_ret =3D NULL; + if (!ret.info.info_len) { *info =3D NULL; rv =3D ret.ret; @@ -7690,17 +7686,11 @@ remoteDomainGetFSInfo(virDomainPtr dom, } =20 *info =3D info_ret; - info_ret =3D NULL; } =20 rv =3D ret.ret; =20 cleanup: - if (info_ret) { - for (i =3D 0; i < ret.info.info_len; i++) - virDomainFSInfoFree(info_ret[i]); - VIR_FREE(info_ret); - } xdr_free((xdrproc_t)xdr_remote_domain_get_fsinfo_ret, (char *) &ret); =20 --=20 2.26.2 From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541278; cv=none; d=zohomail.com; s=zohoarc; b=ebFqnDQIcDMLKi6w+h0GsqecuDDhoT/fsMKS69UPWFQH29YoBBvzCrgaXKLb9tgx/odPai3aXBb0E23HB+irCjnK5EpAKOtCoGcvsZrYTJj6pEUPYgcRYs9RqS2QnqEUqQOnqx15q4tH0ZPw6sLxm0IOEbRpUQ10KvScMbl/byU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541278; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=giyKa+yWCYOP0ZyxcHjBKKySGSGoBpHFomxIyMrrrls=; b=fTBsbdRC7DhCUS42JE/3DLJTbBCxamg+UAm4yguDMPx0rwZoC+1ppgpSUFiPIMvVIfswBjg9MWsmNiQIAVQp82vgqS2k71K93XheDQJCVcYNL5KQf9OrLYDGzF6TJkH23+pSTNW1wJxJtmeh0kL06AjL7weuhxXJVwf4ZcGsmlw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605541278381244.246838032102; Mon, 16 Nov 2020 07:41:18 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-141-O-V39qElNTqeHOzfwx-oOw-1; Mon, 16 Nov 2020 10:39:58 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CBE831028D42; Mon, 16 Nov 2020 15:39:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA18E6EF55; Mon, 16 Nov 2020 15:39:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 730B0183D027; Mon, 16 Nov 2020 15:39:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFdB5W022602 for ; Mon, 16 Nov 2020 10:39:11 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1201F6EF55; Mon, 16 Nov 2020 15:39:11 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 82CC96EF51 for ; Mon, 16 Nov 2020 15:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541277; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=giyKa+yWCYOP0ZyxcHjBKKySGSGoBpHFomxIyMrrrls=; b=CNhcj18x+Gc6/D0N16a9pYkqQE1ewDhF+rkPSdph15dDqsegH4dRIuFitnkAhc3fUfUeic 2ppElOX471UHnIplUpUUX7nXHU/6S3HJ0Shx7DxRbOjwmF3GaYmYrv03fDSwQg95H7jYZe 10cnFMXgg7utgPtTZhAdZOkjwswP330= X-MC-Unique: O-V39qElNTqeHOzfwx-oOw-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 09/11] virdevmapper: fix stat comparison in virDMSanitizepath Date: Mon, 16 Nov 2020 16:38:56 +0100 Message-Id: <1bcf20e016f222bc02836de22a41259db45ecd32.1605541084.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Introduced by commit <22494556542c676d1b9e7f1c1f2ea13ac17e1e3e>. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/util/virdevmapper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virdevmapper.c b/src/util/virdevmapper.c index 6c39a2a44d..c4719d0670 100644 --- a/src/util/virdevmapper.c +++ b/src/util/virdevmapper.c @@ -204,7 +204,7 @@ virDMSanitizepath(const char *path) g_autofree char *tmp =3D g_strdup_printf(DEV_DM_DIR "/%s", ent->d_= name); =20 if (stat(tmp, &sb[1]) =3D=3D 0 && - sb[0].st_rdev =3D=3D sb[0].st_rdev) { + sb[0].st_rdev =3D=3D sb[1].st_rdev) { return g_steal_pointer(&tmp); } } --=20 2.26.2 From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541178; cv=none; d=zohomail.com; s=zohoarc; b=CBJcxCuT6nQjj1rpE6zaXDndqWDoVTJ7OzLTUve4upTR1kIsGJ2jxV7mmyOP9xAMcZ9TLHIFFB0W8/a28mF6MjV6o4RfmQIFMfWNra6aFsEoIzPc7F4fgNBCX107nBp6KPoAQBSk6mARrBYsS4ZKNSfRQLPVT+E8lIQSc0c1DHo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541178; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aNX3RaPTqVQREQ3M1QOijU9Z3GP6gsU0Q+RmDgWikyM=; b=n1KLMjBtyjhxkV45bK5Y21JiTghNSEtsE2/7TX3lWIu9vn5MTM/7TMBE3yOsTYXhzwrNK+DnHoKx3t7T9AskLSeqTKGjDEDBmL7WBEERwE+Uus8P/kOVmod5/RR7AZ1YASBeyIBZgwwonfSeHPy9Yr1ej9THXWR9p3A+tw80RmI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1605541178051566.3357776625687; Mon, 16 Nov 2020 07:39:38 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-AwEYiLQdMBaIRfG5TyEktw-1; Mon, 16 Nov 2020 10:39:33 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5568918CB727; Mon, 16 Nov 2020 15:39:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31E0455769; Mon, 16 Nov 2020 15:39:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EFC2158122; Mon, 16 Nov 2020 15:39:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFdBXn022608 for ; Mon, 16 Nov 2020 10:39:11 -0500 Received: by smtp.corp.redhat.com (Postfix) id EAE026EF55; Mon, 16 Nov 2020 15:39:11 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 676296EF51 for ; Mon, 16 Nov 2020 15:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541176; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=aNX3RaPTqVQREQ3M1QOijU9Z3GP6gsU0Q+RmDgWikyM=; b=IdIp+VxgKl8QyIPIBU55HCRDkRceaxqLnhm14WlFkitT5dXfjZztxnlPlVC6+gweog4gDR a1iX7ldAieGOhQD4a/U1GwM//SlGjZLafJa0VbfKDfHO1AoXlmMvvcmxFF3uoa3772vFli 7diU6e9T7thCNjJTtGOvo5zZXhA1bLA= X-MC-Unique: AwEYiLQdMBaIRfG5TyEktw-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 10/11] vbox_common: unlock vbox_driver_lock before return Date: Mon, 16 Nov 2020 16:38:57 +0100 Message-Id: <61e47a4999f90ab83db854923c70c436e071302b.1605541084.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/vbox/vbox_common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 26168c3c5b..fc897735b0 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -245,6 +245,9 @@ vboxGetDriverConnection(void) if (!vbox_driver) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Failed to create vbox driver object.")); + + virMutexUnlock(&vbox_driver_lock); + return NULL; } } --=20 2.26.2 From nobody Sat Feb 7 07:17:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605541335; cv=none; d=zohomail.com; s=zohoarc; b=Jf6stxTB24EHUYbKaXTEitliM1lEyV/1egndZlWOdA54iiagApd/PXzyuZUgp6vRAbxaQcFJ+FHEUwQBY7/ACDzTRuyoDSzajiamVMGq/a9cn3lf182AKSYnY5fzqQGbL8EzKzXFOesfh68qOlFl/XXqwyn6B5MHl0gMpWdMWwY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605541335; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RkxK8AqO9aKtv9dFaZw30VET5NMjMmNjZtlFJkMd2uI=; b=XpxW2S+hsPd8xbaT2BPwVfUBSDHf2OHkvB7Q/VSeeq+eTKZ+HP7TlLW+F7tYy5ToLVoS4m9CAlgKQK9Klvyj4uzRbDzKer8VqOwpnhHQVcMrTxCrW4wQgUQWMzfncOhXDMFTioKXw79vOjJOKtc+7ySdf/j9KBox4BI40GsUFm0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605541335085813.525417710773; Mon, 16 Nov 2020 07:42:15 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-sCBu4cacMWKh6NFz6rFaYw-1; Mon, 16 Nov 2020 10:40:00 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 88C2A1028D51; Mon, 16 Nov 2020 15:39:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67C9755764; Mon, 16 Nov 2020 15:39:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3187C183D02B; Mon, 16 Nov 2020 15:39:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AGFdC2N022620 for ; Mon, 16 Nov 2020 10:39:12 -0500 Received: by smtp.corp.redhat.com (Postfix) id D1ADF6EF55; Mon, 16 Nov 2020 15:39:12 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4DC466EF51 for ; Mon, 16 Nov 2020 15:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605541334; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=RkxK8AqO9aKtv9dFaZw30VET5NMjMmNjZtlFJkMd2uI=; b=e/bw9A5Oap3JnWOY0JOJEyNsRynynXYzUhZM7FQnj1wPgpHVyCBmh5WrLkC9TRymox7Kuq yju6wGoVUyp3E0h8SdKuRE2CZVxZb3Zr1EPKmUuPWyoGYM7vOJRSGmEfiBlmf+/+dqZJiI 48JQ39Rv9A9/syLWE4EVYjVV0Vw1h/k= X-MC-Unique: sCBu4cacMWKh6NFz6rFaYw-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 11/11] testutils: call va_end before return Date: Mon, 16 Nov 2020 16:38:58 +0100 Message-Id: <78d9a6d7b31ce622968931c3132d2d94418d9c7a.1605541084.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- tests/testutils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testutils.c b/tests/testutils.c index 2e586e98bf..7ecf7923b8 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -771,6 +771,7 @@ int virTestMain(int argc, while ((lib =3D va_arg(ap, const char *))) { if (!virFileIsExecutable(lib)) { perror(lib); + va_end(ap); return EXIT_FAILURE; } =20 --=20 2.26.2