[libvirt PATCH 00/10] use g_autoptr with cgroups (glib chronicles)

Pavel Hrdina posted 10 patches 2 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1602167149.git.phrdina@redhat.com
src/libvirt-lxc.c                 |   5 +-
src/lxc/lxc_cgroup.c              |  20 +--
src/lxc/lxc_container.c           |  37 ++---
src/lxc/lxc_controller.c          |   2 +-
src/lxc/lxc_domain.c              |   2 +-
src/lxc/lxc_process.c             |   9 +-
src/qemu/qemu_cgroup.c            |  87 ++++++-----
src/qemu/qemu_domain.c            |   3 +-
src/qemu/qemu_driver.c            | 139 ++++++------------
src/qemu/qemu_process.c           |   2 +-
src/util/vircgroup.c              | 198 +++++++++++--------------
src/util/vircgroup.h              |   4 +-
src/util/vircgroupv1.c            |   9 +-
tests/vircgrouptest.c             | 236 +++++++++++-------------------
tools/virt-host-validate-common.c |   4 +-
15 files changed, 305 insertions(+), 452 deletions(-)

[libvirt PATCH 00/10] use g_autoptr with cgroups (glib chronicles)

Posted by Pavel Hrdina 2 weeks ago
Pavel Hrdina (10):
  qemu_cgroup: introduce qemuRestoreCgroupThread helper
  util: vircgroup: use GLib alloc functions
  util: vircgroup: change virCgroupFree to take only virCgroupPtr
  util: vircgroup: introduce g_autoptr() for virCgroup
  libvirt-lxc: use g_autoptr for virCgroup
  lxc: use g_autoptr for virCgroup
  qemu: use g_autoptr for virCgroup
  util: use g_autoptr for virCgroup
  tests: use g_autoptr for virCgroup
  tools: use g_autoptr for virCgroup

 src/libvirt-lxc.c                 |   5 +-
 src/lxc/lxc_cgroup.c              |  20 +--
 src/lxc/lxc_container.c           |  37 ++---
 src/lxc/lxc_controller.c          |   2 +-
 src/lxc/lxc_domain.c              |   2 +-
 src/lxc/lxc_process.c             |   9 +-
 src/qemu/qemu_cgroup.c            |  87 ++++++-----
 src/qemu/qemu_domain.c            |   3 +-
 src/qemu/qemu_driver.c            | 139 ++++++------------
 src/qemu/qemu_process.c           |   2 +-
 src/util/vircgroup.c              | 198 +++++++++++--------------
 src/util/vircgroup.h              |   4 +-
 src/util/vircgroupv1.c            |   9 +-
 tests/vircgrouptest.c             | 236 +++++++++++-------------------
 tools/virt-host-validate-common.c |   4 +-
 15 files changed, 305 insertions(+), 452 deletions(-)

-- 
2.26.2

Re: [libvirt PATCH 00/10] use g_autoptr with cgroups (glib chronicles)

Posted by Jonathon Jongsma 2 weeks ago
On Thu,  8 Oct 2020 16:26:53 +0200
Pavel Hrdina <phrdina@redhat.com> wrote:

> Pavel Hrdina (10):
>   qemu_cgroup: introduce qemuRestoreCgroupThread helper
>   util: vircgroup: use GLib alloc functions
>   util: vircgroup: change virCgroupFree to take only virCgroupPtr
>   util: vircgroup: introduce g_autoptr() for virCgroup
>   libvirt-lxc: use g_autoptr for virCgroup
>   lxc: use g_autoptr for virCgroup
>   qemu: use g_autoptr for virCgroup
>   util: use g_autoptr for virCgroup
>   tests: use g_autoptr for virCgroup
>   tools: use g_autoptr for virCgroup
> 
>  src/libvirt-lxc.c                 |   5 +-
>  src/lxc/lxc_cgroup.c              |  20 +--
>  src/lxc/lxc_container.c           |  37 ++---
>  src/lxc/lxc_controller.c          |   2 +-
>  src/lxc/lxc_domain.c              |   2 +-
>  src/lxc/lxc_process.c             |   9 +-
>  src/qemu/qemu_cgroup.c            |  87 ++++++-----
>  src/qemu/qemu_domain.c            |   3 +-
>  src/qemu/qemu_driver.c            | 139 ++++++------------
>  src/qemu/qemu_process.c           |   2 +-
>  src/util/vircgroup.c              | 198 +++++++++++--------------
>  src/util/vircgroup.h              |   4 +-
>  src/util/vircgroupv1.c            |   9 +-
>  tests/vircgrouptest.c             | 236
> +++++++++++------------------- tools/virt-host-validate-common.c |
> 4 +- 15 files changed, 305 insertions(+), 452 deletions(-)
> 

Aside from the minor comment on path 3,

Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>