[libvirt PATCH 0/3] virsh-completer: Use Glib memory functions (glib chronicles)

Ján Tomko posted 3 patches 1 week ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1600099538.git.jtomko@redhat.com
tools/virsh-completer-checkpoint.c | 11 ++++----
tools/virsh-completer-domain.c     | 44 ++++++++++--------------------
tools/virsh-completer-host.c       |  6 ++--
tools/virsh-completer-interface.c  |  6 ++--
tools/virsh-completer-network.c    | 25 +++++++----------
tools/virsh-completer-nodedev.c    | 12 +++-----
tools/virsh-completer-nwfilter.c   | 12 +++-----
tools/virsh-completer-pool.c       | 12 +++-----
tools/virsh-completer-secret.c     |  8 ++----
tools/virsh-completer-snapshot.c   |  5 ++--
tools/virsh-completer-volume.c     |  5 ++--
tools/virsh-completer.c            |  5 ++--
12 files changed, 55 insertions(+), 96 deletions(-)

[libvirt PATCH 0/3] virsh-completer: Use Glib memory functions (glib chronicles)

Posted by Ján Tomko 1 week ago
Ján Tomko (3):
  virsh-completer: use g_clear_pointer in virshCommaStringListComplete
  virsh-completer: use g_free instead of VIR_FREE
  virsh-completer: use g_new0 instead of VIR_ALLOC_N

 tools/virsh-completer-checkpoint.c | 11 ++++----
 tools/virsh-completer-domain.c     | 44 ++++++++++--------------------
 tools/virsh-completer-host.c       |  6 ++--
 tools/virsh-completer-interface.c  |  6 ++--
 tools/virsh-completer-network.c    | 25 +++++++----------
 tools/virsh-completer-nodedev.c    | 12 +++-----
 tools/virsh-completer-nwfilter.c   | 12 +++-----
 tools/virsh-completer-pool.c       | 12 +++-----
 tools/virsh-completer-secret.c     |  8 ++----
 tools/virsh-completer-snapshot.c   |  5 ++--
 tools/virsh-completer-volume.c     |  5 ++--
 tools/virsh-completer.c            |  5 ++--
 12 files changed, 55 insertions(+), 96 deletions(-)

-- 
2.26.2

Re: [libvirt PATCH 0/3] virsh-completer: Use Glib memory functions (glib chronicles)

Posted by Michal Privoznik 1 week ago
On 9/14/20 6:08 PM, Ján Tomko wrote:
> Ján Tomko (3):
>    virsh-completer: use g_clear_pointer in virshCommaStringListComplete
>    virsh-completer: use g_free instead of VIR_FREE
>    virsh-completer: use g_new0 instead of VIR_ALLOC_N
> 
>   tools/virsh-completer-checkpoint.c | 11 ++++----
>   tools/virsh-completer-domain.c     | 44 ++++++++++--------------------
>   tools/virsh-completer-host.c       |  6 ++--
>   tools/virsh-completer-interface.c  |  6 ++--
>   tools/virsh-completer-network.c    | 25 +++++++----------
>   tools/virsh-completer-nodedev.c    | 12 +++-----
>   tools/virsh-completer-nwfilter.c   | 12 +++-----
>   tools/virsh-completer-pool.c       | 12 +++-----
>   tools/virsh-completer-secret.c     |  8 ++----
>   tools/virsh-completer-snapshot.c   |  5 ++--
>   tools/virsh-completer-volume.c     |  5 ++--
>   tools/virsh-completer.c            |  5 ++--
>   12 files changed, 55 insertions(+), 96 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal