From nobody Fri May 3 20:17:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596532391; cv=none; d=zohomail.com; s=zohoarc; b=XZgyQSRR4FoSBzO/SoLt6C/Uj1nbcXmf5EgHTvNaBylC1zTFnfH9TymQQ1IyYznF1SHZDhI/7/LK1FIiQr3aEaQoObr8YVjaEel1+IoO/yBw07Wtjh4F6cV3vQdpEgyzb3JXhNhzRy47JP9qRFisxx69as8UZB9S2Ltz5ZkT0GQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596532391; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iJv/bXxETKgHL9JyDKJUojP2h2Y1NHNK6zQYOKbBp7w=; b=X1H1EowDYVfODMYoQBe1oS0R+NsTiOOfi2FrGPNCALXZyYSeROsjRtlQzwzTb+3RdEUihKqSgiDZE/5w8paiVwbpgQjhhrqD6d+9UbRggTi2hQLs81zYA5ZnsO2KcHA2/4U1XcCc1xY23q6AGK0+u03vGZYA/6oE7HYOB6lwPyA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1596532391914749.5406147053012; Tue, 4 Aug 2020 02:13:11 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-tCy6d5okMYuRO_tT2O-L0Q-1; Tue, 04 Aug 2020 05:13:08 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A3CF18C63CB; Tue, 4 Aug 2020 09:13:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A2965DA33; Tue, 4 Aug 2020 09:13:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E7A2A1809557; Tue, 4 Aug 2020 09:13:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0749BF5O032186 for ; Tue, 4 Aug 2020 05:11:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id 36D5487E3D; Tue, 4 Aug 2020 09:11:15 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.192.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id A79E787E3B for ; Tue, 4 Aug 2020 09:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596532390; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=iJv/bXxETKgHL9JyDKJUojP2h2Y1NHNK6zQYOKbBp7w=; b=i1Xppt+pNg3maThnnrEEMTnicoytGTBXnvUza6ExGlRDXWbLg1p0D9IYO7TkT6+iSAkiQ/ xkIgZvQWSD4HwhwpOJ9a4upJgvxZVtlVQIWZ8UvayEC/eHKbuCrcPPAqQt6YDrbCCaKcFj Fe29m/O9i9VYMyHK219oEvcv4p2I+g8= X-MC-Unique: tCy6d5okMYuRO_tT2O-L0Q-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 1/2] remote: remove duplicated header Date: Tue, 4 Aug 2020 11:11:09 +0200 Message-Id: <49388a5830d6d15b36d8edceb37d5e4c30d5f746.1596532192.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We already include viraccessapicheck.h few lines above. Signed-off-by: Pavel Hrdina Reviewed-by: J=C3=A1n Tomko --- src/remote/remote_daemon_dispatch.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon= _dispatch.c index c91b5d3293..dacfa4e9fb 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -50,7 +50,6 @@ #include "virpolkit.h" #include "virthreadjob.h" #include "configmake.h" -#include "access/viraccessapicheck.h" =20 #define VIR_FROM_THIS VIR_FROM_RPC =20 --=20 2.26.2 From nobody Fri May 3 20:17:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596532352; cv=none; d=zohomail.com; s=zohoarc; b=TiMaLg+SumaXsDJhQGmCQMboA1a3H+h7tLzigZGgq0GLFyXjiyyKAOhgla/9PLsx+vxh0VMuuaaNFUk7Ub1AIJL+UnwtZB4U2OZfD83CIeuwzt3EZukTpTgOIbal9LUOyDE+pyumkpoCSbk6U4zNvjUFGwC42zVXF7Q+7dZG2Q8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596532352; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Y3lpAapozTcQilpmaBqM6hYQvCFLZLYLNQZm7pIYaSA=; b=WRquq2hNL5Jjssc70i5M5Ri0HNdcCdeDGvxN/MfgdZHJqjG6hkYC6ScDOc8gFduhkgXwT26/al7M2kR6LTZ52QqW4HmMu1m0bexye7CUk8bhAOML1jYXRLYDY0TPavujgiftR70vaofwXc4HL4ZsH5qwYzmNKWFJTLKTUaBg5fs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1596532352225733.019083132645; Tue, 4 Aug 2020 02:12:32 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-Z8knbmzWOVmPkpd7u3uOcw-1; Tue, 04 Aug 2020 05:12:28 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E723E58; Tue, 4 Aug 2020 09:12:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C94C171796; Tue, 4 Aug 2020 09:12:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9690A1800BB2; Tue, 4 Aug 2020 09:12:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0749BGK5032197 for ; Tue, 4 Aug 2020 05:11:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1E28987E3D; Tue, 4 Aug 2020 09:11:16 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.192.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8E60887E3B for ; Tue, 4 Aug 2020 09:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596532350; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Y3lpAapozTcQilpmaBqM6hYQvCFLZLYLNQZm7pIYaSA=; b=ZfkPnn66liBxULQVQDU3GADHTe/wzOFrnFM/l7ydOGXiH5ZUKYfr1k5Fps8SjIYtroCQ6X jCLITVoNOZgOBddO2rUO95Jw5B69qFfUKaRzvj1COsi/En0DwmA5gHRZvuRMAXcscUF9rk NcyXy9khCLBj7xu3XRFOFghTnOpi/6s= X-MC-Unique: Z8knbmzWOVmPkpd7u3uOcw-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 2/2] src/logging: no need to include log_protocol.h in log_manager.h Date: Tue, 4 Aug 2020 11:11:10 +0200 Message-Id: <139220959b1e78c83900b62aca7ab551dbfd19c9.1596532192.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The header log_manager.h doesn't use anything from log_protocol.h and the only other place than logging using log_protocol.h is qemu_command.c where we can include log_protocol.h directly to have enum value VIR_LOG_MANAGER_PROTOCOL_DOMAIN_OPEN_LOG_FILE_TRUNCATE available. Fixes race-condition compilation error with meson: In file included from ../tests/qemuhotplugmock.c:21: In file included from ../src/qemu/qemu_hotplug.h:25: In file included from ../src/qemu/qemu_domain.h:42: ../src/logging/log_manager.h:25:10: fatal error: 'logging/log_protocol.h' f= ile not found ^~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Reported-by: J=C3=A1n Tomko Signed-off-by: Pavel Hrdina Reviewed-by: J=C3=A1n Tomko --- src/logging/log_manager.h | 2 -- src/qemu/qemu_command.c | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/logging/log_manager.h b/src/logging/log_manager.h index cca1573841..ae3ae2b4c5 100644 --- a/src/logging/log_manager.h +++ b/src/logging/log_manager.h @@ -22,8 +22,6 @@ =20 #include "internal.h" =20 -#include "logging/log_protocol.h" - typedef struct _virLogManager virLogManager; typedef virLogManager *virLogManagerPtr; =20 diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0655d8359d..01812cd39b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -64,6 +64,7 @@ # include #endif #include "logging/log_manager.h" +#include "logging/log_protocol.h" #include "virutil.h" =20 #include --=20 2.26.2