From nobody Sat Feb 7 10:44:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596407153; cv=none; d=zohomail.com; s=zohoarc; b=gdDqQ0CxJ68ZniAedrtjAdHBi1tFX5Mq/PWU7+GBPuOuNaLg7c3q1c8ZgVLsLObrG6RXf3JKR5nUsuceU2H+6J7+gqpIgz8RqfkZWSNN7O41MusF5Hq3c6UoFcLsxqzFEvAPRZ5Cc8h8U8moPKVFji0GHLLJWNJbp+FMZTY+D+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596407153; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BivpND0TooutZWDxN2M8hnQwXiLmQQNONxVAGB46EJU=; b=hI9Lv69CNNr9B/0eBI5vzewAaV7z13URTt05gc0YG/xC3H4t2dogzqP4/q0cUVTGD9lQPzwbFA0b0giVlLRNKmnS2eDm/NMnov6TcMHGVcXGnaAkFM9jCuwSEwFvYsVfY17Ae4h0LYcxsg7ZWhDf/UYbj2TyZ1q1inRURky36JE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1596407153409811.0363574535785; Sun, 2 Aug 2020 15:25:53 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-sSErl0xjNxSQe235OQIp7g-1; Sun, 02 Aug 2020 18:25:50 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98A76800461; Sun, 2 Aug 2020 22:25:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78DA269314; Sun, 2 Aug 2020 22:25:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4A7359A109; Sun, 2 Aug 2020 22:25:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 072MPeME011941 for ; Sun, 2 Aug 2020 18:25:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 405A587E2B; Sun, 2 Aug 2020 22:25:40 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 969E387E1C for ; Sun, 2 Aug 2020 22:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596407152; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BivpND0TooutZWDxN2M8hnQwXiLmQQNONxVAGB46EJU=; b=CPVgWI/5ynwfoSA5B9KrlKeGNkkS0K8bVtGVYfwKBltuG6sUR8j26rDRCEZebNyQAlFk2n iYqSxXBQPfc/GjF4UcJ0+kRWxt/FRfKrAHXm/5fayquRLMVPg2GTSd+Z5dKuZplc+kKrAe IU6M75Bx+57ehz0765TFGWXocIMwTa8= X-MC-Unique: sSErl0xjNxSQe235OQIp7g-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/6] virt-login-shell: correctly calculate string length Date: Mon, 3 Aug 2020 00:25:29 +0200 Message-Id: <37c4f6c783d9cf46c908ea9eb3ca1b89555a707c.1596407101.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) virLoginShellGetShellArgv was not dereferencing the pointer to the string list containing the shell parameters from the config file, thus setting some random number as shargvlen. Signed-off-by: J=C3=A1n Tomko Fixes: 740e4d705284ba0598258291c2656f50075486f0 Reviewed-by: Martin Kletzander --- tools/virt-login-shell-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virt-login-shell-helper.c b/tools/virt-login-shell-helpe= r.c index d9db883ee6..2db349754e 100644 --- a/tools/virt-login-shell-helper.c +++ b/tools/virt-login-shell-helper.c @@ -104,7 +104,7 @@ static int virLoginShellGetShellArgv(virConfPtr conf, (*shargv)[0] =3D g_strdup("/bin/sh"); *shargvlen =3D 1; } else { - *shargvlen =3D virStringListLength((const char *const *)shargv); + *shargvlen =3D virStringListLength((const char *const *)*shargv); } return 0; } --=20 2.26.2 From nobody Sat Feb 7 10:44:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596407152; cv=none; d=zohomail.com; s=zohoarc; b=G/F+Ev5l9MzyOlv9TueSaBqWzZPUknP2selKcgJLsyxeG4nvRYgkdeDlte/ClY49WtSoH3q/DfzSN5pK6y/viRPgV3Ask9EzmQw9Rm4RnipDuLmP/DiuNaJ6vysolts4akO5LSqIf0hozl01wqvJOvdMU3mZPBy88Hq41RX18RM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596407152; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6VsY6O17Rpv83PKhbWVMGigphtuUdZTNavbdlAvr9F0=; b=F/aCmlYKq8zcnQtJNzkLas+AC2MWWRPUusEOkVATUn1Pl090dRPSulEymuTupq29TypTMWnW8reSHPX6l2X53pPwKwaE0bUFIBl0cN2+0oB6u/wNG1w8cAc0xgTqCCHULfAbK3roQjwsnh7cFxej5+akpGVe67/AhlNo8mo6xGY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1596407152757491.7169718036357; Sun, 2 Aug 2020 15:25:52 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-31UOZcfHPumnrec7aZ0zgQ-1; Sun, 02 Aug 2020 18:25:48 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2A2AE10059B2; Sun, 2 Aug 2020 22:25:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0731660BEC; Sun, 2 Aug 2020 22:25:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C97011809557; Sun, 2 Aug 2020 22:25:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 072MPf0u011954 for ; Sun, 2 Aug 2020 18:25:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7E32687B26; Sun, 2 Aug 2020 22:25:41 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4603712EB for ; Sun, 2 Aug 2020 22:25:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596407151; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6VsY6O17Rpv83PKhbWVMGigphtuUdZTNavbdlAvr9F0=; b=emNAx+lQJrt5W+ISJA27eWHKiahx4PlBnY/6oB7KzjNdK+WCL6j1bTeZhF+3wQpVhLKc+A 8U5/ni7USGsSnPoxPR24oJiJj+9M/g8LQ58WiybKVKscKVUZ8A9peYaI2i317M5EjUt7HB t5uU/BHWWJ+NGXaqzpSGU9Ae/Nw1BT8= X-MC-Unique: 31UOZcfHPumnrec7aZ0zgQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 2/6] conf: use g_strdupv instead of virStringListCopy Date: Mon, 3 Aug 2020 00:25:30 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Also remove the temporary variable - even virStringListCopy aborts on OOM now. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- src/conf/domain_capabilities.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index 837b004334..4b867dd997 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -199,14 +199,10 @@ virDomainCapsCPUModelsAdd(virDomainCapsCPUModelsPtr c= puModels, char **blockers) { g_autofree char * nameCopy =3D NULL; - VIR_AUTOSTRINGLIST blockersCopy =3D NULL; virDomainCapsCPUModelPtr cpu; =20 nameCopy =3D g_strdup(name); =20 - if (virStringListCopy(&blockersCopy, (const char **)blockers) < 0) - return -1; - if (VIR_RESIZE_N(cpuModels->models, cpuModels->nmodels_max, cpuModels->nmodels, 1) < 0) return -1; @@ -216,7 +212,7 @@ virDomainCapsCPUModelsAdd(virDomainCapsCPUModelsPtr cpu= Models, =20 cpu->usable =3D usable; cpu->name =3D g_steal_pointer(&nameCopy); - cpu->blockers =3D g_steal_pointer(&blockersCopy); + cpu->blockers =3D g_strdupv(blockers); =20 return 0; } --=20 2.26.2 From nobody Sat Feb 7 10:44:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596407284; cv=none; d=zohomail.com; s=zohoarc; b=C67r5DMMArQoqCTN/mFKWbhnR24UeWbtl3qxBzgplWuFXTxn6bMK8iyDc9Eh4sHikcAeUOMNZRxtQ+uZVI+gYFz1cmmMrwBCZAHII1lRu3OJxrixzx/kmlnajSKDabCMVUX+KbVBcKZCHiMzFrw97gzi+ekAbPcm7zX3BYFom5o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596407284; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oeG7XOqW4u8fdzD9aWtl7Ellt9QHb7xweyldxOGfqJo=; b=YABJ8u/5l7oZnRISNsBTvXXS/hjsOwJBqrgwp40mQ3uRg12ruUIOdW7Ztg+qVMsKrKkVafFX4vF8FEhVwVWg1nPjSl/rnQ3RRy4kiQ9R/dpqL1nUzvcur6xPRs9/xtcgrh08HmWvKMAOtXy0VbtPwrwhanFA4V9PaFzjtWJlRww= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1596407284094957.870838972011; Sun, 2 Aug 2020 15:28:04 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-2NbiwBA6Mci8qwIAx5CbzA-1; Sun, 02 Aug 2020 18:25:55 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB91D800470; Sun, 2 Aug 2020 22:25:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA7F219C4F; Sun, 2 Aug 2020 22:25:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7B5D19A10E; Sun, 2 Aug 2020 22:25:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 072MPg0b011960 for ; Sun, 2 Aug 2020 18:25:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id B6EF887E27; Sun, 2 Aug 2020 22:25:42 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECC39712EB for ; Sun, 2 Aug 2020 22:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596407282; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=oeG7XOqW4u8fdzD9aWtl7Ellt9QHb7xweyldxOGfqJo=; b=UBylu4hLKQltAgREkKWRj0OQl+wBgQknhcb2ZN6wcpATs60E5sVYMBMf1llfHOrUF1zLeh phrjMZJI6Ygx0IkeFjP3jP6swlfPZCKTVf3q8wQzROvQVmzM/zZZuf7Nj39L6jMwsd1U9c LPC4xzXU5VFxl4QwJPPirRihealkrmU= X-MC-Unique: 2NbiwBA6Mci8qwIAx5CbzA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 3/6] util: remove virStringListCopy Date: Mon, 3 Aug 2020 00:25:31 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The g_strdupv function from GLib provides the same functionality. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- src/util/virstring.c | 37 ------------------------------------- src/util/virstring.h | 3 --- 2 files changed, 40 deletions(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index 2d7ddc4676..9da811b2ec 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -259,43 +259,6 @@ virStringListMerge(char ***dst, } =20 =20 -/** - * virStringListCopy: - * @dst: where to store the copy of @strings - * @src: a NULL-terminated array of strings - * - * Makes a deep copy of the @src string list and stores it in @dst. Callers - * are responsible for freeing @dst. - * - * Returns 0 on success, -1 on error. - */ -int -virStringListCopy(char ***dst, - const char **src) -{ - char **copy =3D NULL; - size_t i; - - *dst =3D NULL; - - if (!src) - return 0; - - if (VIR_ALLOC_N(copy, virStringListLength(src) + 1) < 0) - goto error; - - for (i =3D 0; src[i]; i++) - copy[i] =3D g_strdup(src[i]); - - *dst =3D copy; - return 0; - - error: - virStringListFree(copy); - return -1; -} - - /** * virStringListFree: * @strings: a NULL-terminated array of strings to free diff --git a/src/util/virstring.h b/src/util/virstring.h index 360c68395c..462a6c092c 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -47,9 +47,6 @@ void virStringListRemove(char ***strings, int virStringListMerge(char ***dst, char ***src); =20 -int virStringListCopy(char ***dst, - const char **src); - void virStringListFree(char **strings); void virStringListAutoFree(char ***strings); void virStringListFreeCount(char **strings, --=20 2.26.2 From nobody Sat Feb 7 10:44:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596407162; cv=none; d=zohomail.com; s=zohoarc; b=A05tl0bmc6p54xkdj13nSXRnHNmHmjPoMb/MV582D9uaKGR3zaKZMzrkHQvl5CzmoHpozsLoo7CV1Wz9KHiy7wdAMXrMgMZrU2Z5hqfWJyKoyQgsjMDxa1RzFH/QOJDfJNavrAICMUQFgePbx7BzmBGO0PClzo5RWiXni7tciCY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596407162; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QLGwADgDWnsE/CDRaIyjzlfZrO+OU6OVfIudnKFYQHY=; b=eiIFBAjprUJWPhdrC8KIt2xyEwtDwMR5qR4ZOMv6sblZ4FoBkJwE+BDfz9PapKuF6YbPgYDy5Tt4X15ZALl4/Pj6W4BPUtFlXAYZxrghf0caKEJw1Mtchw3+/gUN2dDSIpFc0SwFPJFuL+HS7QZHiH3P9muNf/74eCqnKh04Ny0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1596407162576859.835263644557; Sun, 2 Aug 2020 15:26:02 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-LxP_b_1UN2uRlDJlYiB2Ow-1; Sun, 02 Aug 2020 18:25:57 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0444E800466; Sun, 2 Aug 2020 22:25:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D691E19C4F; Sun, 2 Aug 2020 22:25:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AA58A9A110; Sun, 2 Aug 2020 22:25:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 072MPidL011970 for ; Sun, 2 Aug 2020 18:25:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5205D87E27; Sun, 2 Aug 2020 22:25:44 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 24789712EB for ; Sun, 2 Aug 2020 22:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596407161; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=QLGwADgDWnsE/CDRaIyjzlfZrO+OU6OVfIudnKFYQHY=; b=D+2GJifcTFEt2t7Bha9w3Si9qhcGvXUZVPz4WNKQlIW/j4YJ2vZRbjuYzpiqQ7KF3JGGfe ZSwPKjpWUhW21GrZtDWCqtEJgpcs95nSuwj1wX/aWX+29YATMQHngQ7bVYjvfwnnC0Pj2j jFbUSkrar3PwPWYsRaNBMc4Du//J/7M= X-MC-Unique: LxP_b_1UN2uRlDJlYiB2Ow-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 4/6] Use g_strfeev instead of virStringFreeList Date: Mon, 3 Aug 2020 00:25:32 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Both accept a NULL value gracefully and virStringFreeList does not zero the pointer afterwards, so a straight replace is safe. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_parse_command.c | 10 +++++----- src/conf/domain_capabilities.c | 2 +- src/conf/node_device_conf.c | 2 +- src/cpu/cpu_arm.c | 2 +- src/cpu/cpu_ppc64.c | 2 +- src/libxl/libxl_conf.c | 6 +++--- src/libxl/xen_common.c | 12 ++++++------ src/libxl/xen_xl.c | 12 ++++++------ src/libxl/xen_xm.c | 2 +- src/lxc/lxc_container.c | 2 +- src/lxc/lxc_native.c | 20 ++++++++++---------- src/qemu/qemu_agent.c | 4 ++-- src/qemu/qemu_capabilities.c | 8 ++++---- src/qemu/qemu_conf.c | 6 +++--- src/qemu/qemu_domain.c | 8 ++++---- src/qemu/qemu_driver.c | 4 ++-- src/qemu/qemu_migration_params.c | 2 +- src/qemu/qemu_monitor_json.c | 14 +++++++------- src/qemu/qemu_process.c | 2 +- src/remote/remote_daemon_dispatch.c | 2 +- src/remote/remote_driver.c | 2 +- src/storage/storage_backend_rbd.c | 2 +- src/storage/storage_backend_sheepdog.c | 2 +- src/storage/storage_backend_zfs.c | 2 +- src/util/vircgroup.c | 4 ++-- src/util/vircgroupv2.c | 2 +- src/util/virconf.c | 2 +- src/util/virfile.c | 2 +- src/util/virfirmware.c | 4 ++-- src/util/virlog.c | 8 ++++---- src/util/virmacmap.c | 2 +- src/util/virresctrl.c | 14 +++++++------- src/util/virstring.c | 4 ++-- src/util/viruri.c | 2 +- src/vbox/vbox_common.c | 10 +++++----- src/vbox/vbox_snapshot_conf.c | 18 +++++++++--------- src/vbox/vbox_tmpl.c | 2 +- src/vz/vz_sdk.c | 2 +- tests/qemumonitorjsontest.c | 12 ++++++------ tests/qemuxml2argvtest.c | 2 +- tests/vboxsnapshotxmltest.c | 2 +- tests/virconftest.c | 2 +- tests/virfiletest.c | 2 +- tests/virstringtest.c | 8 ++++---- tools/virsh-checkpoint.c | 2 +- tools/virsh-domain.c | 12 ++++++------ tools/virsh-host.c | 10 +++++----- tools/virsh-nodedev.c | 6 +++--- tools/virsh-pool.c | 4 ++-- tools/virsh-snapshot.c | 4 ++-- tools/virt-login-shell-helper.c | 6 +++--- tools/vsh.c | 12 ++++++------ 53 files changed, 146 insertions(+), 146 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 22d0b24ec4..86e6640359 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -666,7 +666,7 @@ virAppendBootloaderArgs(virCommandPtr cmd, virDomainDef= Ptr def) /* XXX: Handle quoted? */ blargs =3D virStringSplit(def->os.bootloaderArgs, " ", 0); virCommandAddArgSet(cmd, (const char * const *)blargs); - virStringListFree(blargs); + g_strfreev(blargs); } =20 static virCommandPtr diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_comman= d.c index 76423730d9..b2d2280872 100644 --- a/src/bhyve/bhyve_parse_command.c +++ b/src/bhyve/bhyve_parse_command.c @@ -246,7 +246,7 @@ bhyveCommandLineToArgv(const char *nativeConfig, } else { /* To prevent a use-after-free here, only free the argument li= st * when it is definitely not going to be used */ - virStringListFree(arglist); + g_strfreev(arglist); } } =20 @@ -254,13 +254,13 @@ bhyveCommandLineToArgv(const char *nativeConfig, if (!(*bhyve_argv =3D _bhyve_argv)) goto error; =20 - virStringListFree(lines); + g_strfreev(lines); return 0; =20 error: VIR_FREE(_loader_argv); VIR_FREE(_bhyve_argv); - virStringListFree(lines); + g_strfreev(lines); return -1; } =20 @@ -884,8 +884,8 @@ bhyveParseCommandLineString(const char* nativeConfig, } =20 cleanup: - virStringListFree(loader_argv); - virStringListFree(bhyve_argv); + g_strfreev(loader_argv); + g_strfreev(bhyve_argv); return def; error: virDomainDefFree(def); diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index 4b867dd997..d61108e125 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -114,7 +114,7 @@ virDomainCapsCPUModelsDispose(void *obj) =20 for (i =3D 0; i < cpuModels->nmodels; i++) { VIR_FREE(cpuModels->models[i].name); - virStringListFree(cpuModels->models[i].blockers); + g_strfreev(cpuModels->models[i].blockers); } =20 VIR_FREE(cpuModels->models); diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 2f63772917..79f3f67a1a 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -112,7 +112,7 @@ virNodeDeviceDefFree(virNodeDeviceDefPtr def) VIR_FREE(def->sysfs_path); VIR_FREE(def->parent_sysfs_path); VIR_FREE(def->devnode); - virStringListFree(def->devlinks); + g_strfreev(def->devlinks); =20 caps =3D def->caps; while (caps) { diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index addeb4100e..374a4d6f6c 100644 --- a/src/cpu/cpu_arm.c +++ b/src/cpu/cpu_arm.c @@ -124,7 +124,7 @@ virCPUarmDataClear(virCPUarmData *data) if (!data) return; =20 - virStringListFree(data->features); + g_strfreev(data->features); } =20 static void diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 6b3590ab6a..5b34c00a18 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -801,7 +801,7 @@ virCPUppc64DriverGetModels(char ***models) =20 error: if (models) { - virStringListFree(*models); + g_strfreev(*models); *models =3D NULL; } goto cleanup; diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 8e63d40376..7c2c015015 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -1922,7 +1922,7 @@ libxlDriverGetDom0MaxmemConf(libxlDriverConfigPtr cfg, goto cleanup; } } - virStringListFree(mem_tokens); + g_strfreev(mem_tokens); mem_tokens =3D NULL; } =20 @@ -1938,8 +1938,8 @@ libxlDriverGetDom0MaxmemConf(libxlDriverConfigPtr cfg, ret =3D 0; =20 cleanup: - virStringListFree(cmd_tokens); - virStringListFree(mem_tokens); + g_strfreev(cmd_tokens); + g_strfreev(mem_tokens); return ret; } =20 diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 475c64f944..75fe7e0644 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl/xen_common.c @@ -1061,20 +1061,20 @@ xenParseVifBridge(virDomainNetDefPtr net, char *bri= dge) nvlans++; =20 if (VIR_ALLOC_N(net->vlan.tag, nvlans) < 0) { - virStringListFree(vlanstr_list); + g_strfreev(vlanstr_list); return -1; } =20 for (i =3D 1; i <=3D nvlans; i++) { if (virStrToLong_ui(vlanstr_list[i], NULL, 10, &tag) < 0) { - virStringListFree(vlanstr_list); + g_strfreev(vlanstr_list); return -1; } net->vlan.tag[i - 1] =3D tag; } net->vlan.nTags =3D nvlans; net->vlan.trunk =3D true; - virStringListFree(vlanstr_list); + g_strfreev(vlanstr_list); =20 if (VIR_ALLOC(net->virtPortProfile) < 0) return -1; @@ -1270,11 +1270,11 @@ xenParseVif(char *entry, const char *vif_typename) =20 for (i =3D 0; ip_list[i]; i++) { if (virDomainNetAppendIPAddress(net, ip_list[i], 0, 0) < 0) { - virStringListFree(ip_list); + g_strfreev(ip_list); goto cleanup; } } - virStringListFree(ip_list); + g_strfreev(ip_list); } =20 if (script && script[0]) @@ -1679,7 +1679,7 @@ xenMakeIPList(virNetDevIPInfoPtr guestIP) ret =3D virStringListJoin((const char**)address_array, " "); =20 cleanup: - virStringListFree(address_array); + g_strfreev(address_array); return ret; } =20 diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index f9dc18ab18..432635cef2 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -318,15 +318,15 @@ xenParseXLCPUID(virConfPtr conf, virDomainDefPtr def) policy) < 0) goto cleanup; =20 - virStringListFree(name_and_value); + g_strfreev(name_and_value); name_and_value =3D NULL; } =20 ret =3D 0; =20 cleanup: - virStringListFree(name_and_value); - virStringListFree(cpuid_pairs); + g_strfreev(name_and_value); + g_strfreev(cpuid_pairs); return ret; } =20 @@ -528,7 +528,7 @@ xenParseXLVnuma(virConfPtr conf, VIR_FREE(tmp); tmp =3D g_strdup(vtoken); =20 - virStringListFree(token); + g_strfreev(token); if (!(token =3D virStringSplitCount(tmp, ",", 0, &= ndistances))) goto cleanup; =20 @@ -590,7 +590,7 @@ xenParseXLVnuma(virConfPtr conf, cleanup: if (ret) VIR_FREE(cpu); - virStringListFree(token); + g_strfreev(token); VIR_FREE(tmp); =20 return ret; @@ -1402,7 +1402,7 @@ xenFormatXLCPUID(virConfPtr conf, virDomainDefPtr def) ret =3D 0; =20 cleanup: - virStringListFree(cpuid_pairs); + g_strfreev(cpuid_pairs); VIR_FREE(cpuid_string); return ret; } diff --git a/src/libxl/xen_xm.c b/src/libxl/xen_xm.c index 81b64a2fb4..edf86abc64 100644 --- a/src/libxl/xen_xm.c +++ b/src/libxl/xen_xm.c @@ -281,7 +281,7 @@ xenParseXMDiskList(virConfPtr conf, virDomainDefPtr def) ret =3D 0; =20 cleanup: - virStringListFree(disks); + g_strfreev(disks); return ret; } =20 diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 24a3b6d626..6e98f133a9 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -553,7 +553,7 @@ static int lxcContainerUnmountSubtree(const char *prefi= x, ret =3D 0; =20 cleanup: - virStringListFree(mounts); + g_strfreev(mounts); =20 return ret; } diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index cc545f5fda..58b9db8f08 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -136,12 +136,12 @@ static char ** lxcStringSplit(const char *string) result[ntokens - 2] =3D g_strdup(parts[i]); } =20 - virStringListFree(parts); + g_strfreev(parts); return result; =20 error: - virStringListFree(parts); - virStringListFree(result); + g_strfreev(parts); + g_strfreev(result); return NULL; } =20 @@ -166,13 +166,13 @@ lxcParseFstabLine(char *fstabLine) fstab->type =3D g_strdup(parts[2]); fstab->options =3D g_strdup(parts[3]); =20 - virStringListFree(parts); + g_strfreev(parts); =20 return fstab; =20 error: lxcFstabFree(fstab); - virStringListFree(parts); + g_strfreev(parts); return NULL; } =20 @@ -312,7 +312,7 @@ lxcAddFstabLine(virDomainDefPtr def, lxcFstabPtr fstab) ret =3D 1; =20 cleanup: - virStringListFree(options); + g_strfreev(options); return ret; } =20 @@ -575,11 +575,11 @@ lxcNetworkParseDataIPs(const char *name, virReportError(VIR_ERR_INVALID_ARG, _("Invalid CIDR address: '%s'"), value->str); =20 - virStringListFree(ipparts); + g_strfreev(ipparts); return -1; } =20 - virStringListFree(ipparts); + g_strfreev(ipparts); =20 if (VIR_APPEND_ELEMENT(parseData->ips, parseData->nips, ip) < 0) return -1; @@ -1070,7 +1070,7 @@ lxcBlkioDeviceWalkCallback(const char *name, virConfV= aluePtr value, void *data) ret =3D 0; =20 cleanup: - virStringListFree(parts); + g_strfreev(parts); return ret; } =20 @@ -1114,7 +1114,7 @@ lxcSetCapDrop(virDomainDefPtr def, virConfPtr propert= ies) =20 def->features[VIR_DOMAIN_FEATURE_CAPABILITIES] =3D VIR_DOMAIN_CAPABILI= TIES_POLICY_ALLOW; =20 - virStringListFree(toDrop); + g_strfreev(toDrop); } =20 virDomainDefPtr diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index af8df49daa..22efd2d42a 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -2165,7 +2165,7 @@ qemuAgentGetInterfaces(qemuAgentPtr agent, } =20 /* Has to be freed for each interface. */ - virStringListFree(ifname); + g_strfreev(ifname); =20 /* as well as IP address which - moreover - * can be presented multiple times */ @@ -2251,7 +2251,7 @@ qemuAgentGetInterfaces(qemuAgentPtr agent, virDomainInterfaceFree(ifaces_ret[i]); } VIR_FREE(ifaces_ret); - virStringListFree(ifname); + g_strfreev(ifname); =20 goto cleanup; } diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 1a2cb874c0..589f2eda58 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3166,7 +3166,7 @@ virQEMUCapsGetCPUFeatures(virQEMUCapsPtr qemuCaps, else ret =3D 0; =20 - virStringListFree(list); + g_strfreev(list); return ret; } =20 @@ -3222,7 +3222,7 @@ virQEMUCapsProbeQMPTPM(virQEMUCapsPtr qemuCaps, virQEMUCapsTPMModelsToCaps[i].caps); } } - virStringListFree(entries); + g_strfreev(entries); =20 if ((nentries =3D qemuMonitorGetTPMTypes(mon, &entries)) < 0) return -1; @@ -3235,7 +3235,7 @@ virQEMUCapsProbeQMPTPM(virQEMUCapsPtr qemuCaps, virQEMUCapsSet(qemuCaps, virQEMUCapsTPMTypesToCaps[i].caps= ); } } - virStringListFree(entries); + g_strfreev(entries); =20 return 0; } @@ -3324,7 +3324,7 @@ virQEMUCapsProbeQMPCommandLine(virQEMUCapsPtr qemuCap= s, break; } } - virStringListFree(values); + g_strfreev(values); } =20 return 0; diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 4762f2a88a..d7a30b35e5 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -300,7 +300,7 @@ static void virQEMUDriverConfigDispose(void *obj) =20 virBitmapFree(cfg->namespaces); =20 - virStringListFree(cfg->cgroupDeviceACL); + g_strfreev(cfg->cgroupDeviceACL); VIR_FREE(cfg->uri); =20 VIR_FREE(cfg->configBaseDir); @@ -365,7 +365,7 @@ static void virQEMUDriverConfigDispose(void *obj) VIR_FREE(cfg->snapshotImageFormat); VIR_FREE(cfg->autoDumpPath); =20 - virStringListFree(cfg->securityDriverNames); + g_strfreev(cfg->securityDriverNames); =20 VIR_FREE(cfg->lockManagerName); =20 @@ -374,7 +374,7 @@ static void virQEMUDriverConfigDispose(void *obj) VIR_FREE(cfg->memoryBackingDir); VIR_FREE(cfg->swtpmStorageDir); =20 - virStringListFree(cfg->capabilityfilters); + g_strfreev(cfg->capabilityfilters); } =20 =20 diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 2058290870..e5d6430a89 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1687,7 +1687,7 @@ qemuDomainObjPrivateAlloc(void *opaque) void qemuDomainObjPrivateDataClear(qemuDomainObjPrivatePtr priv) { - virStringListFree(priv->qemuDevices); + g_strfreev(priv->qemuDevices); priv->qemuDevices =3D NULL; =20 virCgroupFree(&priv->cgroup); @@ -1749,7 +1749,7 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivatePtr= priv) =20 priv->dbusDaemonRunning =3D false; =20 - virStringListFree(priv->dbusVMStateIds); + g_strfreev(priv->dbusVMStateIds); priv->dbusVMStateIds =3D NULL; =20 priv->dbusVMState =3D false; @@ -3129,7 +3129,7 @@ qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt, priv->namespaces =3D NULL; virObjectUnref(priv->monConfig); priv->monConfig =3D NULL; - virStringListFree(priv->qemuDevices); + g_strfreev(priv->qemuDevices); priv->qemuDevices =3D NULL; return -1; } @@ -7729,7 +7729,7 @@ qemuDomainUpdateDeviceList(virQEMUDriverPtr driver, if (rc < 0) return -1; =20 - virStringListFree(priv->qemuDevices); + g_strfreev(priv->qemuDevices); priv->qemuDevices =3D aliases; return 0; } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0ad6359102..257ba12093 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1401,7 +1401,7 @@ qemuGetSchedInfo(unsigned long long *cpuWait, ret =3D 0; =20 cleanup: - virStringListFree(lines); + g_strfreev(lines); return ret; } =20 @@ -13479,7 +13479,7 @@ qemuConnectBaselineHypervisorCPU(virConnectPtr conn, cleanup: virCPUDefListFree(cpus); virCPUDefFree(cpu); - virStringListFree(features); + g_strfreev(features); =20 return cpustr; } diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_par= ams.c index fc282960da..04434e9557 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -1462,7 +1462,7 @@ qemuMigrationCapsCheck(virQEMUDriverPtr driver, cleanup: virBitmapFree(migEvent); virJSONValueFree(json); - virStringListFree(caps); + g_strfreev(caps); return ret; } =20 diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 83f169e31b..9cdf6c0f7f 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -6119,7 +6119,7 @@ int qemuMonitorJSONGetCommands(qemuMonitorPtr mon, =20 =20 cleanup: - virStringListFree(commandlist); + g_strfreev(commandlist); virJSONValueFree(cmd); virJSONValueFree(reply); return ret; @@ -6178,7 +6178,7 @@ int qemuMonitorJSONGetEvents(qemuMonitorPtr mon, eventlist =3D NULL; =20 cleanup: - virStringListFree(eventlist); + g_strfreev(eventlist); virJSONValueFree(cmd); virJSONValueFree(reply); return ret; @@ -6299,7 +6299,7 @@ qemuMonitorJSONGetCommandLineOptionParameters(qemuMon= itorPtr mon, if (!qemuMonitorGetOptions(mon)) qemuMonitorSetOptions(mon, virJSONValueNewArray()); =20 - virStringListFree(paramlist); + g_strfreev(paramlist); virJSONValueFree(cmd); virJSONValueFree(reply); return ret; @@ -6397,7 +6397,7 @@ int qemuMonitorJSONGetObjectTypes(qemuMonitorPtr mon, typelist =3D NULL; =20 cleanup: - virStringListFree(typelist); + g_strfreev(typelist); virJSONValueFree(cmd); virJSONValueFree(reply); return ret; @@ -6727,7 +6727,7 @@ qemuMonitorJSONParsePropsList(virJSONValuePtr cmd, proplist =3D NULL; =20 cleanup: - virStringListFree(proplist); + g_strfreev(proplist); return ret; } =20 @@ -6911,7 +6911,7 @@ qemuMonitorJSONGetMigrationCapabilities(qemuMonitorPt= r mon, list =3D NULL; =20 cleanup: - virStringListFree(list); + g_strfreev(list); virJSONValueFree(cmd); virJSONValueFree(reply); return ret; @@ -7351,7 +7351,7 @@ qemuMonitorJSONGetStringArray(qemuMonitorPtr mon, con= st char *qmpCmd, list =3D NULL; =20 cleanup: - virStringListFree(list); + g_strfreev(list); virJSONValueFree(cmd); virJSONValueFree(reply); return ret; diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ec6ca14bbd..fc48792b5d 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -3732,7 +3732,7 @@ qemuProcessUpdateDevices(virQEMUDriverPtr driver, ret =3D 0; =20 cleanup: - virStringListFree(old); + g_strfreev(old); return ret; } =20 diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon= _dispatch.c index 85ca78a261..c91b5d3293 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -5903,7 +5903,7 @@ remoteDispatchConnectGetCPUModelNames(virNetServerPtr= server G_GNUC_UNUSED, cleanup: if (rv < 0) virNetMessageSaveError(rerr); - virStringListFree(models); + g_strfreev(models); return rv; } =20 diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 653c68472a..0331060a2d 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -6529,7 +6529,7 @@ remoteConnectGetCPUModelNames(virConnectPtr conn, rv =3D ret.ret; =20 cleanup: - virStringListFree(retmodels); + g_strfreev(retmodels); =20 xdr_free((xdrproc_t) xdr_remote_connect_get_cpu_model_names_ret, (char= *) &ret); =20 diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backen= d_rbd.c index 08dc5a19dc..cb298419e6 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -746,7 +746,7 @@ virStorageBackendRBDRefreshPool(virStoragePoolObjPtr po= ol) ret =3D 0; =20 cleanup: - virStringListFree(names); + g_strfreev(names); virStorageBackendRBDFreeState(&ptr); return ret; } diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_b= ackend_sheepdog.c index 853a53115f..f253c0ed57 100644 --- a/src/storage/storage_backend_sheepdog.c +++ b/src/storage/storage_backend_sheepdog.c @@ -167,7 +167,7 @@ virStorageBackendSheepdogRefreshAllVol(virStoragePoolOb= jPtr pool) return -1; } =20 - virStringListFree(cells); + g_strfreev(cells); cells =3D NULL; } =20 diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backen= d_zfs.c index 172245c847..dc692f47ed 100644 --- a/src/storage/storage_backend_zfs.c +++ b/src/storage/storage_backend_zfs.c @@ -253,7 +253,7 @@ virStorageBackendZFSRefreshPool(virStoragePoolObjPtr po= ol G_GNUC_UNUSED) if (STREQ(lines[i], "")) continue; =20 - virStringListFree(tokens); + g_strfreev(tokens); if (!(tokens =3D virStringSplitCount(lines[i], "\t", 0, &count))) goto cleanup; =20 diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index e20cc71c78..08758b5306 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -542,7 +542,7 @@ virCgroupGetValueForBlkDev(const char *str, =20 ret =3D 0; error: - virStringListFree(lines); + g_strfreev(lines); return ret; } =20 @@ -803,7 +803,7 @@ virCgroupSetPartitionSuffix(const char *path, char **re= s) ret =3D 0; =20 cleanup: - virStringListFree(tokens); + g_strfreev(tokens); return ret; } =20 diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c index 80f596542c..6b9c5eed70 100644 --- a/src/util/vircgroupv2.c +++ b/src/util/vircgroupv2.c @@ -284,7 +284,7 @@ virCgroupV2ParseControllersFile(virCgroupPtr group, tmp++; } =20 - virStringListFree(contList); + g_strfreev(contList); =20 return 0; } diff --git a/src/util/virconf.c b/src/util/virconf.c index 77ca3f9b79..8575dd8849 100644 --- a/src/util/virconf.c +++ b/src/util/virconf.c @@ -932,7 +932,7 @@ int virConfGetValueStringList(virConfPtr conf, if (!cval) return 0; =20 - virStringListFree(*values); + g_strfreev(*values); *values =3D NULL; =20 switch (cval->type) { diff --git a/src/util/virfile.c b/src/util/virfile.c index af150421e7..6599971ba5 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -2038,7 +2038,7 @@ virFileGetMountSubtreeImpl(const char *mtabpath, =20 cleanup: if (ret < 0) - virStringListFree(mounts); + g_strfreev(mounts); endmntent(procmnt); return ret; } diff --git a/src/util/virfirmware.c b/src/util/virfirmware.c index 9a0610c647..513ec56621 100644 --- a/src/util/virfirmware.c +++ b/src/util/virfirmware.c @@ -84,7 +84,7 @@ virFirmwareParse(const char *str, virFirmwarePtr firmware) =20 ret =3D 0; cleanup: - virStringListFree(token); + g_strfreev(token); return ret; } =20 @@ -128,6 +128,6 @@ virFirmwareParseList(const char *list, =20 ret =3D 0; cleanup: - virStringListFree(token); + g_strfreev(token); return ret; } diff --git a/src/util/virlog.c b/src/util/virlog.c index dabfe7e501..7b59f2ae5b 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1537,7 +1537,7 @@ virLogParseOutput(const char *src) } =20 cleanup: - virStringListFree(tokens); + g_strfreev(tokens); return ret; } =20 @@ -1612,7 +1612,7 @@ virLogParseFilter(const char *src) goto cleanup; =20 cleanup: - virStringListFree(tokens); + g_strfreev(tokens); return ret; } =20 @@ -1672,7 +1672,7 @@ virLogParseOutputs(const char *src, virLogOutputPtr *= *outputs) *outputs =3D list; list =3D NULL; cleanup: - virStringListFree(strings); + g_strfreev(strings); return ret; } =20 @@ -1722,7 +1722,7 @@ virLogParseFilters(const char *src, virLogFilterPtr *= *filters) *filters =3D list; list =3D NULL; cleanup: - virStringListFree(strings); + g_strfreev(strings); return ret; } =20 diff --git a/src/util/virmacmap.c b/src/util/virmacmap.c index 4a57edede8..4b5e24718d 100644 --- a/src/util/virmacmap.c +++ b/src/util/virmacmap.c @@ -55,7 +55,7 @@ virMacMapHashFree(void *payload, const void *name G_GNUC_UNUSED, void *opaque G_GNUC_UNUSED) { - virStringListFree(payload); + g_strfreev(payload); return 0; } =20 diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 3563fc560d..4266712456 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -216,7 +216,7 @@ virResctrlInfoDispose(void *obj) } =20 if (resctrl->monitor_info) - virStringListFree(resctrl->monitor_info->features); + g_strfreev(resctrl->monitor_info->features); =20 VIR_FREE(resctrl->membw_info); VIR_FREE(resctrl->levels); @@ -230,7 +230,7 @@ virResctrlInfoMonFree(virResctrlInfoMonPtr mon) if (!mon) return; =20 - virStringListFree(mon->features); + g_strfreev(mon->features); VIR_FREE(mon); } =20 @@ -755,7 +755,7 @@ virResctrlGetMonitorInfo(virResctrlInfoPtr resctrl) ret =3D 0; cleanup: VIR_FREE(featurestr); - virStringListFree(features); + g_strfreev(features); VIR_FREE(info_monitor); return ret; } @@ -1533,7 +1533,7 @@ virResctrlAllocParseMemoryBandwidthLine(virResctrlInf= oPtr resctrl, =20 ret =3D 0; cleanup: - virStringListFree(mbs); + g_strfreev(mbs); return ret; } =20 @@ -1707,7 +1707,7 @@ virResctrlAllocParseCacheLine(virResctrlInfoPtr resct= rl, =20 ret =3D 0; cleanup: - virStringListFree(caches); + g_strfreev(caches); return ret; } =20 @@ -1733,7 +1733,7 @@ virResctrlAllocParse(virResctrlInfoPtr resctrl, =20 ret =3D 0; cleanup: - virStringListFree(lines); + g_strfreev(lines); return ret; } =20 @@ -2768,7 +2768,7 @@ virResctrlMonitorStatsFree(virResctrlMonitorStatsPtr = stat) if (!stat) return; =20 - virStringListFree(stat->features); + g_strfreev(stat->features); VIR_FREE(stat->vals); VIR_FREE(stat); } diff --git a/src/util/virstring.c b/src/util/virstring.c index 9da811b2ec..a63f92d9a7 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -282,7 +282,7 @@ void virStringListAutoFree(char ***strings) if (!*strings) return; =20 - virStringListFree(*strings); + g_strfreev(*strings); *strings =3D NULL; } =20 @@ -985,7 +985,7 @@ virStringSearch(const char *str, =20 cleanup: if (ret < 0) { - virStringListFree(*matches); + g_strfreev(*matches); *matches =3D NULL; } return ret; diff --git a/src/util/viruri.c b/src/util/viruri.c index 492454a3df..9c74093c4b 100644 --- a/src/util/viruri.c +++ b/src/util/viruri.c @@ -368,7 +368,7 @@ virURIResolveAlias(virConfPtr conf, const char *alias, = char **uri) =20 if (aliases && *aliases) { ret =3D virURIFindAliasMatch(aliases, alias, uri); - virStringListFree(aliases); + g_strfreev(aliases); } else { ret =3D 0; } diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 15f8eb074a..b5a99867dc 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -5005,7 +5005,7 @@ vboxSnapshotRedefine(virDomainPtr dom, tmp =3D virStringReplace(newSnapshotPtr->storageController, searchResultTab[it], uuidReplacing); - virStringListFree(searchResultTab); + g_strfreev(searchResultTab); searchResultTab =3D NULL; VIR_FREE(newSnapshotPtr->storageController); if (!tmp) @@ -5405,9 +5405,9 @@ vboxSnapshotRedefine(virDomainPtr dom, VIR_FREE(currentSnapshotXmlFilePath); VBOX_UTF16_FREE(machineNameUtf16); VBOX_UTF8_FREE(machineName); - virStringListFree(realReadOnlyDisksPath); - virStringListFree(realReadWriteDisksPath); - virStringListFree(searchResultTab); + g_strfreev(realReadOnlyDisksPath); + g_strfreev(realReadWriteDisksPath); + g_strfreev(searchResultTab); virVboxSnapshotConfHardDiskFree(newHardDisk); VIR_FREE(hardDiskToOpen); VIR_FREE(newSnapshotPtr); @@ -7256,7 +7256,7 @@ vboxDomainSnapshotDeleteMetadataOnly(virDomainSnapsho= tPtr snapshot) VBOX_RELEASE(machine); VBOX_UTF16_FREE(settingsFilePathUtf16); VBOX_UTF8_FREE(settingsFilepath); - virStringListFree(searchResultTab); + g_strfreev(searchResultTab); VIR_FREE(snapshotMachineDesc); VBOX_UTF16_FREE(machineNameUtf16); VBOX_UTF8_FREE(machineName); diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c index 5c3269b825..6b95311328 100644 --- a/src/vbox/vbox_snapshot_conf.c +++ b/src/vbox/vbox_snapshot_conf.c @@ -103,7 +103,7 @@ virVBoxSnapshotConfCreateVBoxSnapshotConfHardDiskPtr(xm= lNodePtr diskNode, VIR_FREE(nodes); VIR_FREE(location); VIR_FREE(tmp); - virStringListFree(searchTabResult); + g_strfreev(searchTabResult); if (result < 0) { virVboxSnapshotConfHardDiskFree(hardDisk); hardDisk =3D NULL; @@ -271,7 +271,7 @@ virVBoxSnapshotConfRetrieveSnapshot(xmlNodePtr snapshot= Node, } VIR_FREE(nodes); VIR_FREE(uuid); - virStringListFree(searchTabResult); + g_strfreev(searchTabResult); return snapshot; } =20 @@ -451,8 +451,8 @@ virVBoxSnapshotConfSerializeSnapshot(xmlNodePtr node, xmlUnlinkNode(snapshotsNode); xmlFreeNode(snapshotsNode); } - virStringListFree(firstRegex); - virStringListFree(secondRegex); + g_strfreev(firstRegex); + g_strfreev(secondRegex); VIR_FREE(uuid); VIR_FREE(timeStamp); return result; @@ -730,7 +730,7 @@ virVBoxSnapshotConfLoadVboxFile(const char *filePath, =20 VIR_FREE(currentStateModifiedString); VIR_FREE(currentSnapshotAttribute); - virStringListFree(searchResultTab); + g_strfreev(searchResultTab); if (ret < 0) { virVBoxSnapshotConfMachineFree(machineDescription); machineDescription =3D NULL; @@ -1211,8 +1211,8 @@ virVBoxSnapshotConfSaveVboxFile(virVBoxSnapshotConfMa= chinePtr machine, =20 xmlFreeDoc(xml); =20 - virStringListFree(firstRegex); - virStringListFree(secondRegex); + g_strfreev(firstRegex); + g_strfreev(secondRegex); return ret; } =20 @@ -1297,7 +1297,7 @@ virVBoxSnapshotConfGetRWDisksPathsFromLibvirtXML(cons= t char *filePath, xmlFreeDoc(xml); xmlXPathFreeContext(xPathContext); if (result < 0) { - virStringListFree(ret); + g_strfreev(ret); nodeSize =3D -1; } else { *rwDisksPath =3D ret; @@ -1358,7 +1358,7 @@ virVBoxSnapshotConfGetRODisksPathsFromLibvirtXML(cons= t char *filePath, xmlFreeDoc(xml); xmlXPathFreeContext(xPathContext); if (result < 0) { - virStringListFree(ret); + g_strfreev(ret); nodeSize =3D -1; } else { *roDisksPath =3D ret; diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index a8ffd9f148..d37ffd9a6b 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -1600,7 +1600,7 @@ _vrdeServerGetPorts(vboxDriverPtr data, IVRDEServer *= VRDEServer, } =20 cleanup: - virStringListFree(matches); + g_strfreev(matches); VBOX_UTF8_FREE(portUtf8); VBOX_UTF16_FREE(VRDEPortsValue); VBOX_UTF16_FREE(VRDEPortsKey); diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index b5e69b385f..dbbf38ac29 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -796,7 +796,7 @@ prlsdkGetFSInfo(PRL_HANDLE prldisk, =20 cleanup: VIR_FREE(buf); - virStringListFree(matches); + g_strfreev(matches); return ret; } =20 diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 741e36a491..77e70c1dc4 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -611,7 +611,7 @@ testQemuMonitorJSONGetTPMModels(const void *opaque) ret =3D 0; =20 cleanup: - virStringListFree(tpmmodels); + g_strfreev(tpmmodels); return ret; } =20 @@ -672,7 +672,7 @@ testQemuMonitorJSONGetCommandLineOptionParameters(const= void *opaque) =20 #undef CHECK =20 - virStringListFree(params); + g_strfreev(params); params =3D NULL; =20 /* present but empty */ @@ -698,7 +698,7 @@ testQemuMonitorJSONGetCommandLineOptionParameters(const= void *opaque) goto cleanup; } =20 - virStringListFree(params); + g_strfreev(params); params =3D NULL; =20 /* no such option */ @@ -727,7 +727,7 @@ testQemuMonitorJSONGetCommandLineOptionParameters(const= void *opaque) ret =3D 0; =20 cleanup: - virStringListFree(params); + g_strfreev(params); return ret; } =20 @@ -1186,7 +1186,7 @@ testQemuMonitorJSONGetDeviceAliases(const void *opaqu= e) } =20 cleanup: - virStringListFree(aliases); + g_strfreev(aliases); return ret; } =20 @@ -2269,7 +2269,7 @@ testQemuMonitorJSONqemuMonitorJSONGetMigrationCapabil= ities(const void *opaque) =20 cleanup: virJSONValueFree(json); - virStringListFree(caps); + g_strfreev(caps); virBitmapFree(bitmap); return ret; } diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index e0e3d0d4a9..3da94f3f2f 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -159,7 +159,7 @@ fakeStorageVolLookupByName(virStoragePoolPtr pool, NULL, NULL); =20 cleanup: - virStringListFree(volinfo); + g_strfreev(volinfo); return ret; =20 fallback: diff --git a/tests/vboxsnapshotxmltest.c b/tests/vboxsnapshotxmltest.c index 054e2a8e0d..7e3f85cc58 100644 --- a/tests/vboxsnapshotxmltest.c +++ b/tests/vboxsnapshotxmltest.c @@ -39,7 +39,7 @@ testFilterXML(char *xml) ret =3D virBufferContentAndReset(&buf); =20 cleanup: - virStringListFree(xmlLines); + g_strfreev(xmlLines); return ret; } =20 diff --git a/tests/virconftest.c b/tests/virconftest.c index 83077342a9..ab29b5b712 100644 --- a/tests/virconftest.c +++ b/tests/virconftest.c @@ -441,7 +441,7 @@ static int testConfParseStringList(const void *opaque G= _GNUC_UNUSED) =20 ret =3D 0; cleanup: - virStringListFree(str); + g_strfreev(str); return ret; } =20 diff --git a/tests/virfiletest.c b/tests/virfiletest.c index d410bb68e4..1392536b74 100644 --- a/tests/virfiletest.c +++ b/tests/virfiletest.c @@ -88,7 +88,7 @@ static int testFileGetMountSubtree(const void *opaque) data->mounts, data->nmounts); =20 cleanup: - virStringListFree(gotmounts); + g_strfreev(gotmounts); return ret; } #endif /* ! defined HAVE_MNTENT_H && defined HAVE_GETMNTENT_R */ diff --git a/tests/virstringtest.c b/tests/virstringtest.c index bee49e6cb6..8b8d2acced 100644 --- a/tests/virstringtest.c +++ b/tests/virstringtest.c @@ -134,7 +134,7 @@ static int testSplit(const void *args) =20 ret =3D 0; cleanup: - virStringListFree(got); + g_strfreev(got); =20 return ret; } @@ -192,7 +192,7 @@ static int testAdd(const void *args) =20 ret =3D 0; cleanup: - virStringListFree(list); + g_strfreev(list); VIR_FREE(got); return ret; } @@ -227,7 +227,7 @@ static int testRemove(const void *args) =20 ret =3D 0; cleanup: - virStringListFree(list); + g_strfreev(list); return ret; } =20 @@ -331,7 +331,7 @@ testStringSearch(const void *opaque) ret =3D 0; =20 cleanup: - virStringListFree(matches); + g_strfreev(matches); return ret; } =20 diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c index 821212f86b..411eac7fc8 100644 --- a/tools/virsh-checkpoint.c +++ b/tools/virsh-checkpoint.c @@ -185,7 +185,7 @@ virshParseCheckpointDiskspec(vshControl *ctl, cleanup: if (ret < 0) vshError(ctl, _("unable to parse diskspec: %s"), str); - virStringListFree(array); + g_strfreev(array); return ret; } =20 diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index aaf3b9a6a5..7ab5d3810a 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -887,7 +887,7 @@ virshParseRateStr(vshControl *ctl, =20 ret =3D 0; cleanup: - virStringListFree(tok); + g_strfreev(tok); return ret; } =20 @@ -4085,14 +4085,14 @@ cmdStartGetFDs(vshControl *ctl, fds[nfds - 1] =3D fd; } =20 - virStringListFree(fdlist); + g_strfreev(fdlist); =20 *fdsret =3D fds; *nfdsret =3D nfds; return 0; =20 error: - virStringListFree(fdlist); + g_strfreev(fdlist); VIR_FREE(fds); return -1; } @@ -5978,7 +5978,7 @@ cmdShutdown(vshControl *ctl, const vshCmd *cmd) ret =3D true; cleanup: virshDomainFree(dom); - virStringListFree(modes); + g_strfreev(modes); return ret; } =20 @@ -6058,7 +6058,7 @@ cmdReboot(vshControl *ctl, const vshCmd *cmd) ret =3D true; cleanup: virshDomainFree(dom); - virStringListFree(modes); + g_strfreev(modes); return ret; } =20 @@ -9365,7 +9365,7 @@ virshParseEventStr(const char *event, =20 ret =3D 0; cleanup: - virStringListFree(tok); + g_strfreev(tok); return ret; } =20 diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 0fd77cbae5..64bfcd0e34 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -1193,7 +1193,7 @@ vshExtractCPUDefXMLs(vshControl *ctl, return cpus; =20 error: - virStringListFree(cpus); + g_strfreev(cpus); goto cleanup; } =20 @@ -1267,7 +1267,7 @@ cmdCPUCompare(vshControl *ctl, const vshCmd *cmd) ret =3D true; =20 cleanup: - virStringListFree(cpus); + g_strfreev(cpus); =20 return ret; } @@ -1329,7 +1329,7 @@ cmdCPUBaseline(vshControl *ctl, const vshCmd *cmd) } =20 VIR_FREE(result); - virStringListFree(list); + g_strfreev(list); return ret; } =20 @@ -1705,7 +1705,7 @@ cmdHypervisorCPUCompare(vshControl *ctl, ret =3D true; =20 cleanup: - virStringListFree(cpus); + g_strfreev(cpus); return ret; } =20 @@ -1795,7 +1795,7 @@ cmdHypervisorCPUBaseline(vshControl *ctl, } =20 VIR_FREE(result); - virStringListFree(list); + g_strfreev(list); return ret; } =20 diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index 7f091d7cf8..7b3e13c27d 100644 --- a/tools/virsh-nodedev.c +++ b/tools/virsh-nodedev.c @@ -154,7 +154,7 @@ cmdNodeDeviceDestroy(vshControl *ctl, const vshCmd *cmd) =20 ret =3D true; cleanup: - virStringListFree(arr); + g_strfreev(arr); if (dev) virNodeDeviceFree(dev); return ret; @@ -508,7 +508,7 @@ cmdNodeListDevices(vshControl *ctl, const vshCmd *cmd G= _GNUC_UNUSED) } =20 cleanup: - virStringListFree(caps); + g_strfreev(caps); virshNodeDeviceListFree(list); return ret; } @@ -578,7 +578,7 @@ cmdNodeDeviceDumpXML(vshControl *ctl, const vshCmd *cmd) =20 ret =3D true; cleanup: - virStringListFree(arr); + g_strfreev(arr); VIR_FREE(xml); if (device) virNodeDeviceFree(device); diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index 622b1396d0..fd43d3bb62 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -1175,7 +1175,7 @@ cmdPoolList(vshControl *ctl, const vshCmd *cmd G_GNUC= _UNUSED) for (i =3D 0; i < npoolTypes; i++) { if ((poolType =3D virStoragePoolTypeFromString(poolTypes[i])) = < 0) { vshError(ctl, _("Invalid pool type '%s'"), poolTypes[i]); - virStringListFree(poolTypes); + g_strfreev(poolTypes); return false; } =20 @@ -1226,7 +1226,7 @@ cmdPoolList(vshControl *ctl, const vshCmd *cmd G_GNUC= _UNUSED) break; } } - virStringListFree(poolTypes); + g_strfreev(poolTypes); } =20 if (!(list =3D virshStoragePoolListCollect(ctl, flags))) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 4ac6cb1dcd..7376676df4 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -253,7 +253,7 @@ virshParseSnapshotMemspec(vshControl *ctl, virBufferPtr= buf, const char *str) cleanup: if (ret < 0) vshError(ctl, _("unable to parse memspec: %s"), str); - virStringListFree(array); + g_strfreev(array); return ret; } =20 @@ -321,7 +321,7 @@ virshParseSnapshotDiskspec(vshControl *ctl, virBufferPt= r buf, const char *str) cleanup: if (ret < 0) vshError(ctl, _("unable to parse diskspec: %s"), str); - virStringListFree(array); + g_strfreev(array); return ret; } =20 diff --git a/tools/virt-login-shell-helper.c b/tools/virt-login-shell-helpe= r.c index 2db349754e..cc6836382a 100644 --- a/tools/virt-login-shell-helper.c +++ b/tools/virt-login-shell-helper.c @@ -84,7 +84,7 @@ static int virLoginShellAllowedUser(virConfPtr conf, name, conf_file); cleanup: VIR_FREE(gname); - virStringListFree(users); + g_strfreev(users); return ret; } =20 @@ -329,7 +329,7 @@ main(int argc, char **argv) if (autoshell) { tmp =3D virGetUserShell(uid); if (tmp) { - virStringListFree(shargv); + g_strfreev(shargv); shargvlen =3D 1; if (VIR_ALLOC_N(shargv[0], shargvlen + 1) < 0) { VIR_FREE(tmp); @@ -410,7 +410,7 @@ main(int argc, char **argv) virDomainFree(dom); if (conn) virConnectClose(conn); - virStringListFree(shargv); + g_strfreev(shargv); VIR_FREE(shcmd); VIR_FREE(term); VIR_FREE(name); diff --git a/tools/vsh.c b/tools/vsh.c index b65e99cbd2..ee93c769d7 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2581,7 +2581,7 @@ vshReadlineCommandGenerator(const char *text) =20 if (STREQLEN(name, text, len)) { if (VIR_REALLOC_N(ret, ret_size + 2) < 0) { - virStringListFree(ret); + g_strfreev(ret); return NULL; } ret[ret_size] =3D g_strdup(name); @@ -2646,7 +2646,7 @@ vshReadlineOptionsGenerator(const char *text, continue; =20 if (VIR_REALLOC_N(ret, ret_size + 2) < 0) { - virStringListFree(ret); + g_strfreev(ret); return NULL; } =20 @@ -2740,7 +2740,7 @@ vshReadlineParse(const char *text, int state) =20 vshCommandFree(partial); partial =3D NULL; - virStringListFree(list); + g_strfreev(list); list =3D NULL; list_index =3D 0; =20 @@ -2790,7 +2790,7 @@ vshReadlineParse(const char *text, int state) if (completer_list && (vshCompleterFilter(&completer_list, text) < 0 || virStringListMerge(&list, &completer_list) < 0)) { - virStringListFree(completer_list); + g_strfreev(completer_list); goto cleanup; } } @@ -2814,7 +2814,7 @@ vshReadlineParse(const char *text, int state) if (!ret) { vshCommandFree(partial); partial =3D NULL; - virStringListFree(list); + g_strfreev(list); list =3D NULL; list_index =3D 0; } @@ -3404,7 +3404,7 @@ cmdComplete(vshControl *ctl, const vshCmd *cmd) =20 ret =3D true; cleanup: - virStringListFree(matches); + g_strfreev(matches); return ret; } =20 --=20 2.26.2 From nobody Sat Feb 7 10:44:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596407155; cv=none; d=zohomail.com; s=zohoarc; b=jeK9CCULGMDuQsc9bFepdmvbJfPWZJZvJRJhTLKSYWrL7V1Y5M6ay4Tm/MnTlP7M0+QIf/49cyfl7ByScsVeiss9P2c+d60BL1iG2CJo5He+ttrfTvHBNJAwSs4xhZw7GDbKPiKaHymg22AY4u11Tqf+8PakPvI6D+qSZq3r7T4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596407155; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZbdwjYuCQoICJfKQt262Zu3ZWL6tZpnn02PAapcGeHM=; b=Ghf+xt8mmwCJZlRtDd9cqCpgiC6moI8jZlJDmEpt/F/3egU3g8UjTAWdcBLkaZz1Z+2vUhy7f5HL04A3xLiJgaIYrutRF6IvBfg2jTTZI474HK9dKKeALHtKyFNg1ysagokKwYEmjTZoEiEtQVsDpaci8VNlPwi79T49w0LTu2c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1596407155436787.4396311150801; Sun, 2 Aug 2020 15:25:55 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-tEWj0dWAOG2agP9BMgblWA-1; Sun, 02 Aug 2020 18:25:51 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7FB0E805721; Sun, 2 Aug 2020 22:25:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F78887E2D; Sun, 2 Aug 2020 22:25:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2ECDD1800B71; Sun, 2 Aug 2020 22:25:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 072MPjnK011983 for ; Sun, 2 Aug 2020 18:25:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7C85487E2C; Sun, 2 Aug 2020 22:25:45 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id C2A1187E2B for ; Sun, 2 Aug 2020 22:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596407154; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZbdwjYuCQoICJfKQt262Zu3ZWL6tZpnn02PAapcGeHM=; b=MoNlVsrCc5NawR6gWb3HZM+EufBMCBTTdKIe/vp81NsPUkJkOHSNbh0U0jqYXmt0gbb3Bv GhMNZhePHRTSyvrNLFUZ4lERWX6s39bMmnvBZy/nO/uHi5hBKsdtfNToAyQvmlAitJdXQR w76W9XhIutPwn0hOLMyd4AYmQ8Iq7s4= X-MC-Unique: tEWj0dWAOG2agP9BMgblWA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 5/6] util: recommend g_strfreev instead of virStringListFree Date: Mon, 3 Aug 2020 00:25:33 +0200 Message-Id: <740f036af3e7b98fc92de875433f315ed210b305.1596407101.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- src/util/virfile.c | 4 ++-- src/util/virstring.c | 8 ++++---- tools/vsh.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 6599971ba5..4b683a597c 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -2067,7 +2067,7 @@ virFileGetMountSubtreeImpl(const char *mtabpath G_GNU= C_UNUSED, * the path @prefix, sorted alphabetically. * * The @mountsret array will be NULL terminated and should - * be freed with virStringListFree + * be freed with g_strfreev * * Returns 0 on success, -1 on error */ @@ -2090,7 +2090,7 @@ int virFileGetMountSubtree(const char *mtabpath, * the path @prefix, reverse-sorted alphabetically. * * The @mountsret array will be NULL terminated and should - * be freed with virStringListFree + * be freed with g_strfreev * * Returns 0 on success, -1 on error */ diff --git a/src/util/virstring.c b/src/util/virstring.c index a63f92d9a7..b31d4743f2 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -64,7 +64,7 @@ VIR_LOG_INIT("util.string"); * before calling virStringSplit(). * * Return value: a newly-allocated NULL-terminated array of strings. Use - * virStringListFree() to free it. + * g_strfreev() to free it. */ char ** virStringSplitCount(const char *string, @@ -252,7 +252,7 @@ virStringListMerge(char ***dst, for (i =3D 0; i <=3D src_len; i++) (*dst)[i + dst_len] =3D (*src)[i]; =20 - /* Don't call virStringListFree() as it would free strings in + /* Don't call g_strfreev() as it would free strings in * @src. */ VIR_FREE(*src); return 0; @@ -900,7 +900,7 @@ int virStringSortRevCompare(const void *a, const void *= b) * @matches: pointer to an array to be filled with NULL terminated list of= matches * * Performs a POSIX extended regex search against a string and return all = matching substrings. - * The @matches value should be freed with virStringListFree() when no lon= ger + * The @matches value should be freed with g_strfreev() when no longer * required. * * @code @@ -920,7 +920,7 @@ int virStringSortRevCompare(const void *a, const void *= b) * // matches[2] =3D=3D "bbb3c75c-d60f-43b0-b802-fd56b84a4222" * // matches[3] =3D=3D NULL; * - * virStringListFree(matches); + * g_strfreev(matches); * @endcode * * Returns: -1 on error, or number of matches diff --git a/tools/vsh.c b/tools/vsh.c index ee93c769d7..b3be31264d 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -130,7 +130,7 @@ vshNameSorter(const void *a, const void *b) /* * Convert the strings separated by ',' into array. The returned * array is a NULL terminated string list. The caller has to free - * the array using virStringListFree or a similar method. + * the array using g_strfreev or a similar method. * * Returns the length of the filled array on success, or -1 * on error. --=20 2.26.2 From nobody Sat Feb 7 10:44:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596407230; cv=none; d=zohomail.com; s=zohoarc; b=RtFKzTTTbT5Oo1tQl9xXhgVSsyxguUM0QFg3JBhx0WaOC0cqxKWetmMfb2Qchv10sze3ebLQzafAfowUyXKOa1wwIbUY4LeehUQBNPbEFLpYpB0X8lRAM4DKOnu2sqdneDBCvqzcQsOnzqHZi+6SXNxoaemwCcENoPACbufPmeA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596407230; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lmRCPxMa4WljxoloMffUDWcOKqAYZa/YRS/rL3+rx3Y=; b=Tssr52MaZ6L+BW7BmBbLwdeAHPu8oGA92K9209dERbwYyoQtGbSlqjucn0MVFBrmNioA97rpu6gNN+uzrFnMWnVU6uypNXozkjXRoL6xMrXUYDb6Qgwko/wc5ZIbeRDVMlgyhXqkPnb4bCh0lJVecV7m0PZs3uvJm6xMRqbyP/U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1596407230344693.0693514611643; Sun, 2 Aug 2020 15:27:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-BhjNNiCgN7WZw5-mM7SKoQ-1; Sun, 02 Aug 2020 18:25:56 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1B5A800473; Sun, 2 Aug 2020 22:25:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B571B88F22; Sun, 2 Aug 2020 22:25:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 866581806B0D; Sun, 2 Aug 2020 22:25:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 072MPkaV011990 for ; Sun, 2 Aug 2020 18:25:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9AFB587E2C; Sun, 2 Aug 2020 22:25:46 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id E121C87E2B for ; Sun, 2 Aug 2020 22:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596407229; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lmRCPxMa4WljxoloMffUDWcOKqAYZa/YRS/rL3+rx3Y=; b=NXsctCWDd8Z71rk+Zh0VcJ+qSufJyKNyve3gEs7tHp8a5nkpA+HZoEacZZxvmEeD0LCjkY EV0hUZPTHV7CBW5asamgnAYgt/J/JrrHFoL4j1MQkyWK3fbkbn4zivMfxR7nKRp6ZCHLV6 2c6UxkLtpz5E9zUOSg0l0O1HkPZFUAQ= X-MC-Unique: BhjNNiCgN7WZw5-mM7SKoQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 6/6] util: delete virStringListFree Date: Mon, 3 Aug 2020 00:25:34 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Now that everything uses g_strfreev, this function is no longer needed. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- src/libvirt_private.syms | 1 - src/util/virstring.c | 18 ------------------ src/util/virstring.h | 1 - 3 files changed, 20 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index eea31a736d..53d0e02433 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -3216,7 +3216,6 @@ virStringIsEmpty; virStringIsPrintable; virStringListAdd; virStringListAutoFree; -virStringListFree; virStringListFreeCount; virStringListGetFirstWithPrefix; virStringListHasString; diff --git a/src/util/virstring.c b/src/util/virstring.c index b31d4743f2..c31f2ede8f 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -259,24 +259,6 @@ virStringListMerge(char ***dst, } =20 =20 -/** - * virStringListFree: - * @strings: a NULL-terminated array of strings to free - * - * Frees a NULL-terminated array of strings, and the array itself. - * If called on a NULL value, virStringListFree() simply returns. - */ -void virStringListFree(char **strings) -{ - char **tmp =3D strings; - while (tmp && *tmp) { - VIR_FREE(*tmp); - tmp++; - } - VIR_FREE(strings); -} - - void virStringListAutoFree(char ***strings) { if (!*strings) diff --git a/src/util/virstring.h b/src/util/virstring.h index 462a6c092c..7e6103c9d2 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -47,7 +47,6 @@ void virStringListRemove(char ***strings, int virStringListMerge(char ***dst, char ***src); =20 -void virStringListFree(char **strings); void virStringListAutoFree(char ***strings); void virStringListFreeCount(char **strings, size_t count); --=20 2.26.2