[libvirt PATCH 00/31] fixes and cleanups for current build system

Pavel Hrdina posted 31 patches 3 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1593692174.git.phrdina@redhat.com
Test syntax-check failed
There is a newer version of this series
build-aux/syntax-check.mk            |   4 +-
configure.ac                         |  26 +-
docs/Makefile.am                     |  12 +-
docs/wrapstring.xsl                  |  56 ---
m4/virt-driver-modules.m4            |   3 -
m4/virt-external-programs.m4         |   8 +-
m4/virt-nss.m4                       |   2 +-
m4/virt-sanlock.m4                   |  33 +-
m4/virt-secdriver-selinux.m4         |  24 +-
m4/virt-selinux.m4                   |  17 -
m4/virt-xdr.m4                       |  39 +-
po/Makefile.am                       |   6 +-
po/POTFILES.in                       | 726 +++++++++++++--------------
scripts/check-remote-protocol.py     |   5 +-
src/Makefile.am                      |  25 +-
src/admin/Makefile.inc.am            |   1 +
src/libvirt.c                        |   2 +-
src/libvirt_private.syms             |   3 +-
src/libxl/Makefile.inc.am            |   1 -
src/locking/Makefile.inc.am          |   2 +
src/locking/lock_daemon.c            |   2 +-
src/locking/lock_driver_sanlock.c    |  38 --
src/logging/Makefile.inc.am          |   2 +-
src/logging/log_daemon.c             |   2 +-
src/qemu/Makefile.inc.am             |   1 -
src/qemu/qemu_shim.c                 |   2 +-
src/remote/Makefile.inc.am           |  13 +-
src/remote/remote_daemon.c           |   2 +-
src/security/virt-aa-helper.c        |   2 +-
src/storage/Makefile.inc.am          |   4 -
src/util/Makefile.inc.am             |   3 -
src/util/virfile.c                   |  25 +-
src/util/virfile.h                   |   4 +-
src/util/virnetdevmidonet.c          |   4 +-
src/util/virnetdevopenvswitch.c      |  16 +-
tests/Makefile.am                    |  10 +-
tests/commandhelper.c                |   2 +-
tests/nssmock.c                      |   2 +-
tests/nsstest.c                      |   2 +-
tests/qemucapsprobe.c                |   2 +-
tests/securityselinuxhelper.c        |   5 +-
tests/testutils.c                    |   2 +-
tools/virsh-secret.c                 |   2 +-
tools/virsh.c                        |   2 +-
tools/virt-admin.c                   |   2 +-
tools/wireshark/src/packet-libvirt.c |  19 +-
46 files changed, 472 insertions(+), 693 deletions(-)
delete mode 100644 docs/wrapstring.xsl
[libvirt PATCH 00/31] fixes and cleanups for current build system
Posted by Pavel Hrdina 3 years, 9 months ago
While working on rewrite to Meson I discovered some parts of our
current build system that could be improved to help with the
transition to Meson. It will make the review of the Meson patches
a bit easier.

Pavel Hrdina (31):
  build: use DLOPEN_LIBS directly
  configure: drop check for unsupported FreeBSD
  configure: introduce FLAT_NAMESPACE_FLAGS
  configure: remove usage of AC_HEADER_MAJOR
  Makefile: drop undefined LIB_CLOCK_GETTIME
  docs: remove incorrect generated files by apibuild.py
  docs: remove unused wrapstring.xsl file
  docs: drop %.png: %.fig rule
  m4: virt-sanlock: drop check for sanlock_inq_lockspace
  m4: virt-sanlock: use pkg-config to find libsanlock_client
  m4: virt-sanlock: drop check for SANLK_INQ_WAIT
  m4: virt-sanlock: drop check for sanlock_killpath()
  m4: virt-sanlock: drop check for sanlock_write_lockspace()
  m4: virt-secdriver-selinux: drop obsolete function checks
  m4: virt-selinux: drop check for selabel_open signature change
  m4: virt-xdr: rewrite XDR check
  po: change the format of POTFILES.in
  scripts: check-remote-protocol: remove unused OBJEXT argument
  src: Makefile: remove LOCK_CHECKING_CFLAGS leftover
  src: remove unnecessary -I$(srcdir)/secret include
  src: remote: Makefile: drop CFLAGS and LDFLAGS duplication
  src: logging: Makefile: drop undefined LOG_DRIVER
  src: util: rename some program macros
  src: util: Makefile: drop undefined LDEXP_LIBM
  src: util: Makefile: drop undefined OPENPTY_LIBS
  src: remote: Makefile: properly format sysconfdir in virtproxyd.conf
  src: unify virFileActivateDirOverride()
  tests: commandhelper: change how we detect if running as daemon
  tests: use WITH_NSS instead of NSS
  tools: virsh-secret: fix compilation error
  tools: wireshark: fix compilation errors

 build-aux/syntax-check.mk            |   4 +-
 configure.ac                         |  26 +-
 docs/Makefile.am                     |  12 +-
 docs/wrapstring.xsl                  |  56 ---
 m4/virt-driver-modules.m4            |   3 -
 m4/virt-external-programs.m4         |   8 +-
 m4/virt-nss.m4                       |   2 +-
 m4/virt-sanlock.m4                   |  33 +-
 m4/virt-secdriver-selinux.m4         |  24 +-
 m4/virt-selinux.m4                   |  17 -
 m4/virt-xdr.m4                       |  39 +-
 po/Makefile.am                       |   6 +-
 po/POTFILES.in                       | 726 +++++++++++++--------------
 scripts/check-remote-protocol.py     |   5 +-
 src/Makefile.am                      |  25 +-
 src/admin/Makefile.inc.am            |   1 +
 src/libvirt.c                        |   2 +-
 src/libvirt_private.syms             |   3 +-
 src/libxl/Makefile.inc.am            |   1 -
 src/locking/Makefile.inc.am          |   2 +
 src/locking/lock_daemon.c            |   2 +-
 src/locking/lock_driver_sanlock.c    |  38 --
 src/logging/Makefile.inc.am          |   2 +-
 src/logging/log_daemon.c             |   2 +-
 src/qemu/Makefile.inc.am             |   1 -
 src/qemu/qemu_shim.c                 |   2 +-
 src/remote/Makefile.inc.am           |  13 +-
 src/remote/remote_daemon.c           |   2 +-
 src/security/virt-aa-helper.c        |   2 +-
 src/storage/Makefile.inc.am          |   4 -
 src/util/Makefile.inc.am             |   3 -
 src/util/virfile.c                   |  25 +-
 src/util/virfile.h                   |   4 +-
 src/util/virnetdevmidonet.c          |   4 +-
 src/util/virnetdevopenvswitch.c      |  16 +-
 tests/Makefile.am                    |  10 +-
 tests/commandhelper.c                |   2 +-
 tests/nssmock.c                      |   2 +-
 tests/nsstest.c                      |   2 +-
 tests/qemucapsprobe.c                |   2 +-
 tests/securityselinuxhelper.c        |   5 +-
 tests/testutils.c                    |   2 +-
 tools/virsh-secret.c                 |   2 +-
 tools/virsh.c                        |   2 +-
 tools/virt-admin.c                   |   2 +-
 tools/wireshark/src/packet-libvirt.c |  19 +-
 46 files changed, 472 insertions(+), 693 deletions(-)
 delete mode 100644 docs/wrapstring.xsl

-- 
2.26.2

Re: [libvirt PATCH 00/31] fixes and cleanups for current build system
Posted by Pavel Hrdina 3 years, 8 months ago
On Thu, Jul 02, 2020 at 02:24:58PM +0200, Pavel Hrdina wrote:
> While working on rewrite to Meson I discovered some parts of our
> current build system that could be improved to help with the
> transition to Meson. It will make the review of the Meson patches
> a bit easier.
> 
> Pavel Hrdina (31):
>   build: use DLOPEN_LIBS directly
>   configure: drop check for unsupported FreeBSD
>   configure: introduce FLAT_NAMESPACE_FLAGS
>   configure: remove usage of AC_HEADER_MAJOR
>   Makefile: drop undefined LIB_CLOCK_GETTIME
>   docs: remove incorrect generated files by apibuild.py
>   docs: remove unused wrapstring.xsl file
>   docs: drop %.png: %.fig rule
>   m4: virt-sanlock: drop check for sanlock_inq_lockspace
>   m4: virt-sanlock: use pkg-config to find libsanlock_client
>   m4: virt-sanlock: drop check for SANLK_INQ_WAIT
>   m4: virt-sanlock: drop check for sanlock_killpath()
>   m4: virt-sanlock: drop check for sanlock_write_lockspace()
>   m4: virt-secdriver-selinux: drop obsolete function checks
>   m4: virt-selinux: drop check for selabel_open signature change
>   m4: virt-xdr: rewrite XDR check
>   po: change the format of POTFILES.in
>   scripts: check-remote-protocol: remove unused OBJEXT argument
>   src: Makefile: remove LOCK_CHECKING_CFLAGS leftover
>   src: remove unnecessary -I$(srcdir)/secret include
>   src: remote: Makefile: drop CFLAGS and LDFLAGS duplication
>   src: logging: Makefile: drop undefined LOG_DRIVER
>   src: util: rename some program macros
>   src: util: Makefile: drop undefined LDEXP_LIBM
>   src: util: Makefile: drop undefined OPENPTY_LIBS
>   src: remote: Makefile: properly format sysconfdir in virtproxyd.conf
>   src: unify virFileActivateDirOverride()
>   tests: commandhelper: change how we detect if running as daemon
>   tests: use WITH_NSS instead of NSS
>   tools: virsh-secret: fix compilation error
>   tools: wireshark: fix compilation errors

Ping?

I know that this is not that popular part of libvirt code-base to work
on but it would be nice to have it pushed quickly so I can send a
followup series that switches from autoconf to Meson and it depends on
these cleanup patches.

Pavel
Re: [libvirt PATCH 00/31] fixes and cleanups for current build system
Posted by Michal Privoznik 3 years, 8 months ago
On 7/2/20 2:24 PM, Pavel Hrdina wrote:
> While working on rewrite to Meson I discovered some parts of our
> current build system that could be improved to help with the
> transition to Meson. It will make the review of the Meson patches
> a bit easier.
> 
> Pavel Hrdina (31):
>    build: use DLOPEN_LIBS directly
>    configure: drop check for unsupported FreeBSD
>    configure: introduce FLAT_NAMESPACE_FLAGS
>    configure: remove usage of AC_HEADER_MAJOR
>    Makefile: drop undefined LIB_CLOCK_GETTIME
>    docs: remove incorrect generated files by apibuild.py
>    docs: remove unused wrapstring.xsl file
>    docs: drop %.png: %.fig rule
>    m4: virt-sanlock: drop check for sanlock_inq_lockspace
>    m4: virt-sanlock: use pkg-config to find libsanlock_client
>    m4: virt-sanlock: drop check for SANLK_INQ_WAIT
>    m4: virt-sanlock: drop check for sanlock_killpath()
>    m4: virt-sanlock: drop check for sanlock_write_lockspace()
>    m4: virt-secdriver-selinux: drop obsolete function checks
>    m4: virt-selinux: drop check for selabel_open signature change
>    m4: virt-xdr: rewrite XDR check
>    po: change the format of POTFILES.in
>    scripts: check-remote-protocol: remove unused OBJEXT argument
>    src: Makefile: remove LOCK_CHECKING_CFLAGS leftover
>    src: remove unnecessary -I$(srcdir)/secret include
>    src: remote: Makefile: drop CFLAGS and LDFLAGS duplication
>    src: logging: Makefile: drop undefined LOG_DRIVER
>    src: util: rename some program macros
>    src: util: Makefile: drop undefined LDEXP_LIBM
>    src: util: Makefile: drop undefined OPENPTY_LIBS
>    src: remote: Makefile: properly format sysconfdir in virtproxyd.conf
>    src: unify virFileActivateDirOverride()
>    tests: commandhelper: change how we detect if running as daemon
>    tests: use WITH_NSS instead of NSS
>    tools: virsh-secret: fix compilation error
>    tools: wireshark: fix compilation errors
> 
>   build-aux/syntax-check.mk            |   4 +-
>   configure.ac                         |  26 +-
>   docs/Makefile.am                     |  12 +-
>   docs/wrapstring.xsl                  |  56 ---
>   m4/virt-driver-modules.m4            |   3 -
>   m4/virt-external-programs.m4         |   8 +-
>   m4/virt-nss.m4                       |   2 +-
>   m4/virt-sanlock.m4                   |  33 +-
>   m4/virt-secdriver-selinux.m4         |  24 +-
>   m4/virt-selinux.m4                   |  17 -
>   m4/virt-xdr.m4                       |  39 +-
>   po/Makefile.am                       |   6 +-
>   po/POTFILES.in                       | 726 +++++++++++++--------------
>   scripts/check-remote-protocol.py     |   5 +-
>   src/Makefile.am                      |  25 +-
>   src/admin/Makefile.inc.am            |   1 +
>   src/libvirt.c                        |   2 +-
>   src/libvirt_private.syms             |   3 +-
>   src/libxl/Makefile.inc.am            |   1 -
>   src/locking/Makefile.inc.am          |   2 +
>   src/locking/lock_daemon.c            |   2 +-
>   src/locking/lock_driver_sanlock.c    |  38 --
>   src/logging/Makefile.inc.am          |   2 +-
>   src/logging/log_daemon.c             |   2 +-
>   src/qemu/Makefile.inc.am             |   1 -
>   src/qemu/qemu_shim.c                 |   2 +-
>   src/remote/Makefile.inc.am           |  13 +-
>   src/remote/remote_daemon.c           |   2 +-
>   src/security/virt-aa-helper.c        |   2 +-
>   src/storage/Makefile.inc.am          |   4 -
>   src/util/Makefile.inc.am             |   3 -
>   src/util/virfile.c                   |  25 +-
>   src/util/virfile.h                   |   4 +-
>   src/util/virnetdevmidonet.c          |   4 +-
>   src/util/virnetdevopenvswitch.c      |  16 +-
>   tests/Makefile.am                    |  10 +-
>   tests/commandhelper.c                |   2 +-
>   tests/nssmock.c                      |   2 +-
>   tests/nsstest.c                      |   2 +-
>   tests/qemucapsprobe.c                |   2 +-
>   tests/securityselinuxhelper.c        |   5 +-
>   tests/testutils.c                    |   2 +-
>   tools/virsh-secret.c                 |   2 +-
>   tools/virsh.c                        |   2 +-
>   tools/virt-admin.c                   |   2 +-
>   tools/wireshark/src/packet-libvirt.c |  19 +-
>   46 files changed, 472 insertions(+), 693 deletions(-)
>   delete mode 100644 docs/wrapstring.xsl
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal