From nobody Wed Apr 24 09:28:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593416651; cv=none; d=zohomail.com; s=zohoarc; b=itEsnKxfIoS5L6kKlG7cNwMNobLppR0O8RxvDK1fpRZZaBGCloImhxXQn9cBnRVxVcMpkGxM6Ta54pmpcN8pSbshQ6FDQ9kxf07jNE3tDeUNFroYxkn666fZhijLTBVf4sQkhULIw1eDUJ+bOvWNRFMz1lMof8wqSM/arxRWwZA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593416651; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x6R8EzmHyNu2wRDc3thdGcenjsI+G+VWlXlLydaldn4=; b=nz10yhnr+SGOA3cfamvThrE1XqkSlS6px3xirw79u3Si7rZ+73YgFuSZXn7fA2rvINyR8SV+8sRNwKygAGUjROW9+paIS0rqe842gfyFSePAp901UBbzPpjbD7TdgWpNGN/XNKt0cq+inkur9CeScjQ+fmYAVGBUAYux0exxgPM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1593416651984924.11717330993; Mon, 29 Jun 2020 00:44:11 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-iXHkNJ4yP4Wa7W54HOH27w-1; Mon, 29 Jun 2020 03:44:08 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 038D6802ED4; Mon, 29 Jun 2020 07:44:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5E7C9CFEB; Mon, 29 Jun 2020 07:44:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A26C21809557; Mon, 29 Jun 2020 07:44:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05T7hiec004555 for ; Mon, 29 Jun 2020 03:43:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3F3885C1D4; Mon, 29 Jun 2020 07:43:44 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.241]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4DD65C1BD for ; Mon, 29 Jun 2020 07:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593416650; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=x6R8EzmHyNu2wRDc3thdGcenjsI+G+VWlXlLydaldn4=; b=anehk+b1xz45nmQPMn+IEwjLNrk3Z4rUjaK72eMe7bs0zXfIttCTz/6Kl/0ULG0omqrrvb EK6YsezxmcfHEX8IxUgCwnQOjl9BtO5aWyjyfYTkG4okRg+VquwzrG9m87NmBx/k9cKSFC 5c1FAx5KffpFK0ttR/Te/u0gweX1HWo= X-MC-Unique: iXHkNJ4yP4Wa7W54HOH27w-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/3] qemuhotplugtest: Free monitor iff successfully initialized Date: Mon, 29 Jun 2020 09:43:36 +0200 Message-Id: <0ec1c5c20fcd6c6072d1e386d3070767a481b6cd.1593416559.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" If initializing test monitor in testQemuHotplugCpuPrepare() fails, the control jumps to error label where testQemuHotplugCpuDataFree() is called. But since the data->mon is NULL due to aforementioned failure, qemuMonitorTestGetMonitor() dereferences a NULL pointer leading to a SIGSEGV. Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani --- tests/qemuhotplugtest.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index ba3fc4d814..ba30cf5aa6 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -399,9 +399,11 @@ testQemuHotplugCpuDataFree(struct testQemuHotplugCpuDa= ta *data) virObjectUnref(data->vm); } =20 - mon =3D qemuMonitorTestGetMonitor(data->mon); - virObjectLock(mon); - qemuMonitorTestFree(data->mon); + if (data->mon) { + mon =3D qemuMonitorTestGetMonitor(data->mon); + virObjectLock(mon); + qemuMonitorTestFree(data->mon); + } VIR_FREE(data); } =20 --=20 2.26.2 From nobody Wed Apr 24 09:28:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593416639; cv=none; d=zohomail.com; s=zohoarc; b=A8aJQ7JCQnaSsJP1OK/7fE+GGQv/so10wkgNHQgyCyFL4BWwnjSeO/zNy4h9iHbPuDhvsQ3xj980nCmtkPg3jTRvCLa6z7DjQXjEfOu8r5zurXgyaX2xzsSM/uMRBDcPWuyQ/7jRAX4Iw0Y1CG0Dm/yqH2XExP0FglDt027AZto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593416639; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HTcfXyy2LGs8KuqiqwFfbmXzYTI0Gm/uP2/OcTnKDvY=; b=WVrPxs7uiiuD6NsxXKybmpscboAPo7X+b+OY3DuUHWioJRCojdVdMKmT2u+8q54GF/fvLczbrO6q2iCup+91CoKwwUq3HZ4/8dMSYci6B4zZdfoQubxOSPCZUYaeePiq5dUx9h8lmlOP5XsxjHDGr0x0KQb4qh+nhDVVW01i8Po= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1593416639837236.68900946816166; Mon, 29 Jun 2020 00:43:59 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-9-mc2IWM9OMCOuAR_JwxPJLA-1; Mon, 29 Jun 2020 03:43:54 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6C695800D5C; Mon, 29 Jun 2020 07:43:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D8CA1002388; Mon, 29 Jun 2020 07:43:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 99F89180954D; Mon, 29 Jun 2020 07:43:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05T7hjUw004563 for ; Mon, 29 Jun 2020 03:43:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1BB7E5C1D2; Mon, 29 Jun 2020 07:43:45 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.241]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9165F5C1BD for ; Mon, 29 Jun 2020 07:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593416636; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HTcfXyy2LGs8KuqiqwFfbmXzYTI0Gm/uP2/OcTnKDvY=; b=CTVSb3wAH/QJE07rkmaZQ4g3enDQAg2xgKjSuvESzAboN2Ut+glJJlGIoQPQHalhe/YZQQ XiK+Iw1auL4d5NOVRpBvsRw64Qi1szoSJECcxzfuoq5Cha17YCc7LVTyh60KHXGcOpqafd AeMCLoBmBBOEIYYW6PD8zvwDVbWZTmE= X-MC-Unique: mc2IWM9OMCOuAR_JwxPJLA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/3] domain_conf: Move zPCI validation from formatter to validator Date: Mon, 29 Jun 2020 09:43:37 +0200 Message-Id: <97d965a9842a6d90d01c94f2adae0df40fe05726.1593416559.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" In 076591009ad a validation code was added to virDomainDeviceInfoFormat() which reports an error if zPCI address entered in was incomplete. But, there are two problems with this approach. The first problem is the placement of the code - it doesn't belong into XML formatter rather than XML validator. The second one is that the code doesn't check if the PCI address it's validating has zPCI extension and thus the error is reported for normal PCI addresses too, hence the change of the function that's being called. The second problem is addressed in d482cf6bef which doesn't address the first problem. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 4 ---- src/qemu/qemu_validate.c | 6 ++++++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 33f177b16f..0c883cd834 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7523,10 +7523,6 @@ virDomainDeviceInfoFormat(virBufferPtr buf, } =20 if (virZPCIDeviceAddressIsPresent(&info->addr.pci.zpci)) { - if (virZPCIDeviceAddressIsIncomplete(&info->addr.pci.zpci)) - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Missing uid or fid attribute of zPCI add= ress")); - virBufferAsprintf(&childBuf, "\n", info->addr.pci.zpci.uid.value, diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 78efa68584..2d3a2ec93a 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1028,6 +1028,12 @@ qemuValidateDomainDeviceDefZPCIAddress(virDomainDevi= ceInfoPtr info, return -1; } =20 + if (virDeviceInfoPCIAddressExtensionIsWanted(info)) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("Missing uid or fid attribute of zPCI address")); + return -1; + } + /* We don't need to check fid because fid covers * all range of uint32 type. */ --=20 2.26.2 From nobody Wed Apr 24 09:28:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593416638; cv=none; d=zohomail.com; s=zohoarc; b=cvJPIWoQKgxfRpICESYdkaakP/19vNkXP9+qbzEPzpjZ1vfPv1/HTWHlp8rAvn1V3UhfztnvvEtb+3P0gbR30xghhPZeJFaKIp+1y/abHV+C9WA08Use9W666GAIcnNEuiJPgLW9+X2lqAHmHMjKRA84C7igMzHUYSBj1aBYMDU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593416638; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h9EpJtOtPPnJBKRh+vFmUUXFd10As1ozJBPSd8bBsPg=; b=lMzDUHBtWvH8RkTFoneZwKNcrdWNop8D+Pe6URGlC2FSNgWB+G/A057z84hYYBE22bYbnwC7cupbxUsTqsBogqEIkbXzqvLI/Pctbt26J/Ckj6yLRDOLZczsubIDKc2ryIbZ8S5RQiq/O74Ds3aq4vo4Q+bJ1lVCztKz5Mi+gHg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1593416638931508.56702891366876; Mon, 29 Jun 2020 00:43:58 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-127-M0fc8pddOaCKi6d9ctrDHQ-1; Mon, 29 Jun 2020 03:43:54 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 81832BFC0; Mon, 29 Jun 2020 07:43:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C0075C1BD; Mon, 29 Jun 2020 07:43:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 776298788F; Mon, 29 Jun 2020 07:43:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05T7hjM5004571 for ; Mon, 29 Jun 2020 03:43:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id ED1DF5C1D2; Mon, 29 Jun 2020 07:43:45 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.241]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E4FA5C1BD for ; Mon, 29 Jun 2020 07:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593416637; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=h9EpJtOtPPnJBKRh+vFmUUXFd10As1ozJBPSd8bBsPg=; b=AaPAPpvlavVyTWPTbdI4gcfz94ANXwe8ZPfSeHSWvsK6Zd3aeRMN60upy3uT1g0xTP6BEh N1Ev8ZjZh2m8vFw68SIpJRcJlqaj/1XvXNaz7LMtxNcW6X26C+uDaaE6ZmtlKkMqusotee ZKeLs2OrlO4RCRg1knuZg7d9JOAfCBM= X-MC-Unique: M0fc8pddOaCKi6d9ctrDHQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/3] qemu_validate: Fix how qemuValidateDomainDeviceDefZPCIAddress() is called Date: Mon, 29 Jun 2020 09:43:38 +0200 Message-Id: <7e6930c712f30683364a72e9281b992359a11264.1593416559.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" To make the code future proof, the rest of the qemuValidateDomainDeviceDefAddress() has to be executed (even though there is nothing there yet) instead of returning directly. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 2d3a2ec93a..ed1497c425 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1063,7 +1063,8 @@ qemuValidateDomainDeviceDefAddress(const virDomainDev= iceDef *dev, =20 switch ((virDomainDeviceAddressType) info->type) { case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI: - return qemuValidateDomainDeviceDefZPCIAddress(info, qemuCaps); + if (qemuValidateDomainDeviceDefZPCIAddress(info, qemuCaps) < 0) + return -1; =20 case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE: /* Address validation might happen before we have had a chance to --=20 2.26.2