From nobody Sat Apr 20 11:20:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589449136; cv=none; d=zohomail.com; s=zohoarc; b=FXDjtSLl2x2AfilK1anY9RyoSdfsghBdUA/BDefOf3E8RDErukleupAKyw3brMXCx8rz9OuV6OvEhno1SowtXTX4CZmvIHjTWhlKNfbrn4U95CikuE8n6YwxTwM5WXb/1dF+S5rynibpYI5N4ov0FLGfaiwupTOayjMwjowcBKw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589449136; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kKrehGHidEIloctBtFLOlj/iEC8aM7086b2+S14poYk=; b=PDIQoTyoNvksYW8mwFh+Z5GgPZCPCFYePMgmCtLBQN5QYe9ypi62ppexELSKe9S3diV3QAeAvqDnnXwBNJG8b8yPq1AAoWxkzsY8QFiZX7JJJnWSIAJmV7zRZVwZQwjEHDmu1RAXfLkxWnRlAYgayPi4AjldlgKzTFjTCPTa1Ks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1589449136401918.5505247752816; Thu, 14 May 2020 02:38:56 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-268-V9rfWwOBP2qG18eCnedO0g-1; Thu, 14 May 2020 05:38:52 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0FB448FB041; Thu, 14 May 2020 09:38:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EEED54735E; Thu, 14 May 2020 09:38:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 060394E982; Thu, 14 May 2020 09:38:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04E9cGe4011803 for ; Thu, 14 May 2020 05:38:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 97C9C5D75A; Thu, 14 May 2020 09:38:16 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5B3A6590D for ; Thu, 14 May 2020 09:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589449135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kKrehGHidEIloctBtFLOlj/iEC8aM7086b2+S14poYk=; b=V3hboJuppceYkkQ02pCb/TTM8Y3o2p21wPG53gxkrP1l7HwXbYXG8KUufU1gV+HGeRWIaB WGoL9DvH6nHHujhmXHOgNAxh+oGN/IY+m9c36cmIVWMu0qKF8O5ZWiRX9FfM3X3UBp/IRS +6OjTORaHfJxzXiZ38Md/bxn1zBflfc= X-MC-Unique: V9rfWwOBP2qG18eCnedO0g-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/2] qemuDomainStorageSourcePrivateDispose: Free httpcookie Date: Thu, 14 May 2020 11:37:41 +0200 Message-Id: <57744d389e691503bd8bc8dd5d02fbbbb7ba10fe.1589449040.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" =3D=3D156803=3D=3D 58 (40 direct, 18 indirect) bytes in 1 blocks are defini= tely lost in loss record 306 of 463 =3D=3D156803=3D=3D at 0x4839EC6: calloc (vg_replace_malloc.c:762) =3D=3D156803=3D=3D by 0x5791AC0: g_malloc0 (in /usr/lib64/libglib-2.0.so= .0.6400.1) =3D=3D156803=3D=3D by 0x48F60DC: virAlloc (viralloc.c:48) =3D=3D156803=3D=3D by 0x18DD74: qemuStorageSourcePrivateDataAssignSecinf= o (qemu_domain.c:2384) =3D=3D156803=3D=3D by 0x18DFD5: qemuStorageSourcePrivateDataParse (qemu_= domain.c:2433) =3D=3D156803=3D=3D by 0x49EC884: virDomainStorageSourceParse (domain_con= f.c:9857) =3D=3D156803=3D=3D by 0x49ECBA3: virDomainDiskBackingStoreParse (domain_= conf.c:9909) =3D=3D156803=3D=3D by 0x49F129D: virDomainDiskDefParseXML (domain_conf.c= :10785) =3D=3D156803=3D=3D by 0x4A1804E: virDomainDefParseXML (domain_conf.c:215= 43) =3D=3D156803=3D=3D by 0x4A1B60C: virDomainObjParseXML (domain_conf.c:222= 54) =3D=3D156803=3D=3D by 0x4A1BFE9: virDomainObjParseNode (domain_conf.c:22= 429) =3D=3D156803=3D=3D by 0x4A1C0B4: virDomainObjParseFile (domain_conf.c:22= 443 Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/qemu/qemu_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index a1b250fd0b..d0528dbfe0 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1229,6 +1229,7 @@ qemuDomainStorageSourcePrivateDispose(void *obj) =20 g_clear_pointer(&priv->secinfo, qemuDomainSecretInfoFree); g_clear_pointer(&priv->encinfo, qemuDomainSecretInfoFree); + g_clear_pointer(&priv->httpcookie, qemuDomainSecretInfoFree); } =20 =20 --=20 2.26.2 From nobody Sat Apr 20 11:20:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589449211; cv=none; d=zohomail.com; s=zohoarc; b=Id7VW3GCqXBjHIM+W0ANIu80lshhF/bwDEIfRarNYHDSrXRtmTc7RKpOfXinlGpRPMsOOWkd3EAosO9x9zNKXX71dOV3bnJ5USYnh4KbwPC82H5t1ViEPaIfHke3os+40J7730SMbN1GU6HgBm993lLEIVDm4HP/ZTpLMCzbfHw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589449211; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7PpI/g+8o0ufXuVQHsw6A1bFnn8Xh0iXyOpTl+UERhQ=; b=BsrNWbA2IxkfsLWwNfjT5ZxaC4oMhYIYiFSb54dyhd0UqWU2ysRbb3t6Ad0DJ7xcLRN7aQWFPs4VRjfYqC//SCiJ7o8XBNzyrG/sWApKmGGNDSAxMGuI2YkLdLqJXxG35ol7Exx7nhkEa+fVw9w5dWxs42ocoqH2A5yjU05M670= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1589449211609440.714330662099; Thu, 14 May 2020 02:40:11 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-MluC-H45N060jChUIW3b1w-1; Thu, 14 May 2020 05:39:05 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4DA0F890512; Thu, 14 May 2020 09:38:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2DA985D9F3; Thu, 14 May 2020 09:38:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EA95D1809543; Thu, 14 May 2020 09:38:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04E9cHAc011813 for ; Thu, 14 May 2020 05:38:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id 92FE45DA81; Thu, 14 May 2020 09:38:17 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id CBC545DE4A for ; Thu, 14 May 2020 09:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589449210; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7PpI/g+8o0ufXuVQHsw6A1bFnn8Xh0iXyOpTl+UERhQ=; b=JhBeMLbVGHEHGNcSHNbuq93UlbpCeBdzUh593b4Q92fkkjkHRsgMNg1vNZeoOsiNyRB82L 7cpHMB+tx3CKucU1P582UiBVKczhIvZYAfcqueq8zDH+zyy++tBh+QgXEzL8R3ENpfe14j zfGLK5Lsi78z6Umd5qsllN2A5n+pH+E= X-MC-Unique: MluC-H45N060jChUIW3b1w-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/2] qemuBlockJobDataDisposeJobdata: Free data.commit.disabledBitmapsBase Date: Thu, 14 May 2020 11:37:42 +0200 Message-Id: <4ac96fa34b2e3b6c747bdccc2081d54c84d81a02.1589449040.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" =3D=3D179663=3D=3D 35 (24 direct, 11 indirect) bytes in 1 blocks are defini= tely lost in loss record 205 of 461 =3D=3D179663=3D=3D at 0x4839EC6: calloc (vg_replace_malloc.c:762) =3D=3D179663=3D=3D by 0x5791AC0: g_malloc0 (in /usr/lib64/libglib-2.0.so= .0.6400.1) =3D=3D179663=3D=3D by 0x190C79: qemuDomainObjPrivateXMLParseBlockjobData= Commit (qemu_domain.c:3295) =3D=3D179663=3D=3D by 0x190DF7: qemuDomainObjPrivateXMLParseBlockjobData= Specific (qemu_domain.c:3331) =3D=3D179663=3D=3D by 0x19157D: qemuDomainObjPrivateXMLParseBlockjobData= (qemu_domain.c:3469) =3D=3D179663=3D=3D by 0x1918E8: qemuDomainObjPrivateXMLParseBlockjobs (q= emu_domain.c:3498) =3D=3D179663=3D=3D by 0x193841: qemuDomainObjPrivateXMLParse (qemu_domai= n.c:3944) =3D=3D179663=3D=3D by 0x4A1BA9D: virDomainObjParseXML (domain_conf.c:223= 06) =3D=3D179663=3D=3D by 0x4A1BFE9: virDomainObjParseNode (domain_conf.c:22= 429) =3D=3D179663=3D=3D by 0x4A1C0B4: virDomainObjParseFile (domain_conf.c:22= 443) =3D=3D179663=3D=3D by 0x1431E1: testCompareStatusXMLToXMLFiles (qemuxml2= xmltest.c:61) =3D=3D179663=3D=3D by 0x177722: virTestRun (testutils.c:142) Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/qemu/qemu_blockjob.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index e51499532f..17dc08476b 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -84,6 +84,11 @@ qemuBlockJobDataDisposeJobdata(qemuBlockJobDataPtr job) virObjectUnref(job->data.backup.store); g_free(job->data.backup.bitmap); } + + if (job->type =3D=3D QEMU_BLOCKJOB_TYPE_COMMIT || + job->type =3D=3D QEMU_BLOCKJOB_TYPE_ACTIVE_COMMIT) { + virStringListFree(job->data.commit.disabledBitmapsBase); + } } =20 =20 --=20 2.26.2