From nobody Fri May 3 06:54:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) client-ip=216.205.24.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585323016; cv=none; d=zohomail.com; s=zohoarc; b=LJmd2k7pSP8+aDmDhW1OA0wTvvSI6IJIz+dLGBhKolNYK/uGUIYDVqvPo2sGaP4bpfKa9DBRK9ysc8ILz1zJvyxnIPBQ3Y7eOoymBj2rEkVvEhAG9xiBDOlaVD9ONwp4UpwB99Bt4GuVKgw7TmincxGY+fw9/FsiiXVv1HrLA5A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585323016; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b/Ct6ZDa6QEmQ5cTZYBCh+B863QU0yk0jrtzsT1t/6c=; b=NbF/RRxncdZDu0vqxPM9BW8GyvFeykXd03VmoOKQM5oD4Gd10g5wyojKUqcg4w3GX80GDnUwy+Sm0wbf9y1eZ9aRn7bC7QlWmCaBl9DfykluczcfVnEYqtAQamAli9IOahqSaNZrWDPKGUlfJbL7Fjf8O6XjXl/JCQgTDPBzU3E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.zohomail.com with SMTPS id 1585323016078128.1788475038411; Fri, 27 Mar 2020 08:30:16 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-u8-o0PoxMsSKcKL8y5sK9A-1; Fri, 27 Mar 2020 11:30:12 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B38658017CE; Fri, 27 Mar 2020 15:30:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6DF035E02B; Fri, 27 Mar 2020 15:30:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A9E3F18089C8; Fri, 27 Mar 2020 15:30:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02RFU1FA010324 for ; Fri, 27 Mar 2020 11:30:01 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4B3C51001F43; Fri, 27 Mar 2020 15:30:01 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD2951001B07 for ; Fri, 27 Mar 2020 15:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585323014; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=b/Ct6ZDa6QEmQ5cTZYBCh+B863QU0yk0jrtzsT1t/6c=; b=E7vn4PWD9IdoxBnF1lsoRviDjQiXu4HKqrIZ5heeRrzc+/7EP4NsdD3RuPEnqj0xB5U0z7 dp8CcZlvCPB6E2fTD0+6OdjMmpKgJKsm9x/vnhCjDMi5p2Ee2mwor42l+3KZdPUFPsPhRf cgsIt9fSSWMZ3LJkWtwGGNiUth6XzpA= X-MC-Unique: u8-o0PoxMsSKcKL8y5sK9A-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/2] syntax-check: Disallow plain fork() in src/libvirt.c Date: Fri, 27 Mar 2020 16:29:54 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The last usage of plain fork() was removed in v0.9.7-rc1~50, but we forgot to update the syntax-check exemption list accordingly. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 45bcf45e80..888e358848 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -2016,7 +2016,7 @@ exclude_file_name_regexp--sc_prohibit_close =3D \ exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF =3D \ (^tests/(virhostcpu|virpcitest)data/|docs/js/.*\.js|docs/fonts/.*\.woff|= \.diff|tests/virconfdata/no-newline\.conf$$) =20 -_src2=3Dsrc/(util/(vircommand|virdaemon)|libvirt|lxc/lxc_controller) +_src2=3Dsrc/(util/(vircommand|virdaemon)|lxc/lxc_controller) exclude_file_name_regexp--sc_prohibit_fork_wrappers =3D \ (^($(_src2)|tests/testutils)\.c$$) =20 --=20 2.24.1 From nobody Fri May 3 06:54:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585323015; cv=none; d=zohomail.com; s=zohoarc; b=eXLP0SjjN4WVJkGXZC2CP2i/nR3D7nMnd0zkuX/z9jOswhWv+68LUoR/6B7Fgg0ZWS7M3hsmcPLHZauT5wGHvgU7LZqacs/Hc3QGJzhf/b9o8Z/s4wzk03F5To5stHIf4fxK5vMMzMvQ/osqN0hLOBIu+11i7dXrfjlO6ySOZC8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585323015; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=haDR8CByccW+luk6tN5MeNLOGBCs7NkrUJz/PQ06R/o=; b=hwT7Kubby8v+QqEtwYQIZNxLvRegt23a6yUXURLixqwPICZLmjTWZhpjHm87JugQT0nk9XdsXQ9j0JxRG3RIB6cFnv6ICJl5jrF8iqAqX6QJbRobGdRRHcdLFdPtQo1EBjI8P83Q+Wr7eOasRwLcSr7bT6j2fJmWyo5eiz0l78U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 1585323015019498.55232711282736; Fri, 27 Mar 2020 08:30:15 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-z1r4-2WSPiCDGo8LW8D-mg-1; Fri, 27 Mar 2020 11:30:11 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8E35CDB66; Fri, 27 Mar 2020 15:30:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 278B6194BB; Fri, 27 Mar 2020 15:30:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8750B18089CD; Fri, 27 Mar 2020 15:30:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02RFU2KC010338 for ; Fri, 27 Mar 2020 11:30:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id 317E11001B07; Fri, 27 Mar 2020 15:30:02 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0EFA1001F43 for ; Fri, 27 Mar 2020 15:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585323013; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=haDR8CByccW+luk6tN5MeNLOGBCs7NkrUJz/PQ06R/o=; b=EoaSPeTURy6ZtR9lx/21CIVNaq0IOe8yG0Ll3zEXxQB0SIfmfYPCLcWDXknQvwsgTt3vUM 2j2z9YcT+cvLYicH7/Nx0zUdMrCxpYUolxvVGgIda3beW3ferH5mOcXrfxb3NLMXEKkG9I S+DNN02lTUV+bGu+I30S7KJo1q6XnG0= X-MC-Unique: z1r4-2WSPiCDGo8LW8D-mg-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/2] syntax-check.mk: Drop needless _src2 variable Date: Fri, 27 Mar 2020 16:29:55 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The aim was to break a long line, but it is not long anymore. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- build-aux/syntax-check.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 888e358848..db3c0cff0f 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -2016,9 +2016,8 @@ exclude_file_name_regexp--sc_prohibit_close =3D \ exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF =3D \ (^tests/(virhostcpu|virpcitest)data/|docs/js/.*\.js|docs/fonts/.*\.woff|= \.diff|tests/virconfdata/no-newline\.conf$$) =20 -_src2=3Dsrc/(util/(vircommand|virdaemon)|lxc/lxc_controller) exclude_file_name_regexp--sc_prohibit_fork_wrappers =3D \ - (^($(_src2)|tests/testutils)\.c$$) + (^(src/(util/(vircommand|virdaemon)|lxc/lxc_controller)|tests/testutils)= \.c$$) =20 exclude_file_name_regexp--sc_prohibit_gethostname =3D ^src/util/vir(util|l= og)\.c$$ =20 --=20 2.24.1