[PATCH 0/6] Parse back some legacy backing store strings

Peter Krempa posted 6 patches 3 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1584646504.git.pkrempa@redhat.com
src/util/virbitmap.c                          |  14 +--
src/util/virhostcpu.c                         |   6 +-
src/util/virjson.c                            | 105 ++++++++++++++----
src/util/virtpm.c                             |   3 +-
tests/virbitmaptest.c                         |   8 +-
.../deflatten-dotted-array-in.json            |  27 +++++
.../deflatten-dotted-array-out.json           |  43 +++++++
tests/virjsontest.c                           |   1 +
tests/virstoragetest.c                        |  18 +++
9 files changed, 182 insertions(+), 43 deletions(-)
create mode 100644 tests/virjsondata/deflatten-dotted-array-in.json
create mode 100644 tests/virjsondata/deflatten-dotted-array-out.json

[PATCH 0/6] Parse back some legacy backing store strings

Posted by Peter Krempa 3 weeks ago
See patch 4 for code and 6 for what we try to parse back.

Peter Krempa (6):
  virBitmapNewEmpty: Use g_new0 to allocate and remove error checking
  virJSONValueObjectDeflattenWorker: Refactor cleanup
  util: json: Extract deflattening of keys into a separate function
  virjson: Deflatten arrays generated by the json->commandline generator
  jsontest: Add test cases for deflattening of arrays
  tests: virstoragetest: validate that array deflattening works for
    gluster

 src/util/virbitmap.c                          |  14 +--
 src/util/virhostcpu.c                         |   6 +-
 src/util/virjson.c                            | 105 ++++++++++++++----
 src/util/virtpm.c                             |   3 +-
 tests/virbitmaptest.c                         |   8 +-
 .../deflatten-dotted-array-in.json            |  27 +++++
 .../deflatten-dotted-array-out.json           |  43 +++++++
 tests/virjsontest.c                           |   1 +
 tests/virstoragetest.c                        |  18 +++
 9 files changed, 182 insertions(+), 43 deletions(-)
 create mode 100644 tests/virjsondata/deflatten-dotted-array-in.json
 create mode 100644 tests/virjsondata/deflatten-dotted-array-out.json

-- 
2.24.1

Re: [PATCH 0/6] Parse back some legacy backing store strings

Posted by Michal Prívozník 2 weeks ago
On 19. 3. 2020 20:35, Peter Krempa wrote:
> See patch 4 for code and 6 for what we try to parse back.
> 
> Peter Krempa (6):
>   virBitmapNewEmpty: Use g_new0 to allocate and remove error checking
>   virJSONValueObjectDeflattenWorker: Refactor cleanup
>   util: json: Extract deflattening of keys into a separate function
>   virjson: Deflatten arrays generated by the json->commandline generator
>   jsontest: Add test cases for deflattening of arrays
>   tests: virstoragetest: validate that array deflattening works for
>     gluster
> 
>  src/util/virbitmap.c                          |  14 +--
>  src/util/virhostcpu.c                         |   6 +-
>  src/util/virjson.c                            | 105 ++++++++++++++----
>  src/util/virtpm.c                             |   3 +-
>  tests/virbitmaptest.c                         |   8 +-
>  .../deflatten-dotted-array-in.json            |  27 +++++
>  .../deflatten-dotted-array-out.json           |  43 +++++++
>  tests/virjsontest.c                           |   1 +
>  tests/virstoragetest.c                        |  18 +++
>  9 files changed, 182 insertions(+), 43 deletions(-)
>  create mode 100644 tests/virjsondata/deflatten-dotted-array-in.json
>  create mode 100644 tests/virjsondata/deflatten-dotted-array-out.json
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal