From nobody Mon May 6 11:06:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583928851; cv=none; d=zohomail.com; s=zohoarc; b=MWqRMGN1c9A+wHipqIvtO8tugKSXg3jSgdfEgHHbTaKMAZK1G/0vvENFCoAPUAoBtH8jOQX6rWdEh6vycAoZ2gKBH+iLppeV3mVaI4HipEbUBoR+fxHb+tA1c0WBB3PU9hv3ylC34DvQ/aPTaajQah40L8k2Mi+3QmtkRZ27zsM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583928851; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cIlfhGzLU3wsHg2n0VTUclvSG3S9FXxmHHyzJF7RcfI=; b=HyhVAnA03jnnKuG7ByqB/ic0hKDRD5YZJED+u5Ra8W24UY+znGXVN0l3afgiuT5DbIoKSNPqMbLF8jJ+iLmdB/bHua7mSD9Ylg+7A2zLYD5Sd//2rSoEB6GgRsidxE/yvThR8R2KMwlgOiQev41e7v3t8G0Uw2cXp/HWcJrWpIg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1583928851096298.00258044168027; Wed, 11 Mar 2020 05:14:11 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-gPudR99jP867w3pPEagatQ-1; Wed, 11 Mar 2020 08:14:03 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3CCD313F8; Wed, 11 Mar 2020 12:13:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 921E390519; Wed, 11 Mar 2020 12:13:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E2BA786A19; Wed, 11 Mar 2020 12:13:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02BCDqVj007414 for ; Wed, 11 Mar 2020 08:13:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id 122FD73865; Wed, 11 Mar 2020 12:13:52 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-54.brq.redhat.com [10.40.200.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7040C5C13D for ; Wed, 11 Mar 2020 12:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583928847; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cIlfhGzLU3wsHg2n0VTUclvSG3S9FXxmHHyzJF7RcfI=; b=J8cRhD5llqOTrWpKR9ofQTVvaJeoHmQ1pwpykqF/aZEToUs2wkEiYzCTICXNG+U7hvsWWY z27SRmJoF+hrPvocNMKZs+37IkcFrNxciTAZPt7ETCcd4qYxYRwLC7dxhXwyqFjNEgYjws 8IFKtG9AY0x2qVtj6oVr58jgsUJYaL4= X-MC-Unique: gPudR99jP867w3pPEagatQ-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 1/3] domain_conf: fix ATTRIBUTE_NONNULL for virDomainDefFormat Date: Wed, 11 Mar 2020 13:13:43 +0100 Message-Id: <329c00be363612a4ba3cff5fe2401f41669261fd.1583928792.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit <92d412149ce563da48ba299ec49c07d825370cbf> introduced `xmlopt` attribute to `virDomainDefFormat` function and marked it as NONNULL which is not correct because in hyperv dirver we call that function with NULL as `xmlopt`. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 91b776c28a..8d6bc5057d 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3132,7 +3132,7 @@ unsigned int virDomainDefFormatConvertXMLFlags(unsign= ed int flags); char *virDomainDefFormat(virDomainDefPtr def, virDomainXMLOptionPtr xmlopt, unsigned int flags) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); + ATTRIBUTE_NONNULL(1); char *virDomainObjFormat(virDomainObjPtr obj, virDomainXMLOptionPtr xmlopt, unsigned int flags) --=20 2.24.1 From nobody Mon May 6 11:06:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583928862; cv=none; d=zohomail.com; s=zohoarc; b=hA6KvYiThHFYmj5cCGQVPMTj/7KV7Mf3VYPsypnV7wxZmMzMqH15OA2X/JTvEGv7nwXFaZGkGEZF1WeZjIJLT4k8Uomp8OCG/hVBdnV7PU2zzbMThSCtUlGHQh68OP7+tZcovO6rui17CZ57AnPxsuP7pDT5OK3dK1dcR3ADO90= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583928862; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yZ41UZ3nOCyQaITYF0IdxyMHM7bEoU/RtEPn+TUVLm4=; b=kALAYjPkRwnlMpxaiuBqo1Y84iKoxzH4KgMHgamQk2h/UHS/312HmDKMKlfvvkxEx9jDjIR5rJJYjMwAEGRh2ogP26lBp9UAT9wR61QURg5ELyRe6VvHrfkKydu2RcEPU6VKWLkeY9Ij6U3rSyOpJfqEBK38AFsQRLIIcVjKlV0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 158392886258574.2025305137804; Wed, 11 Mar 2020 05:14:22 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-e3_PS0pZOyusyNm2ljTtRg-1; Wed, 11 Mar 2020 08:14:17 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F9541B2C983; Wed, 11 Mar 2020 12:14:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7A0960C18; Wed, 11 Mar 2020 12:14:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 87EB286A20; Wed, 11 Mar 2020 12:14:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02BCDrhg007424 for ; Wed, 11 Mar 2020 08:13:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 151B073865; Wed, 11 Mar 2020 12:13:53 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-54.brq.redhat.com [10.40.200.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 737A85C13D for ; Wed, 11 Mar 2020 12:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583928860; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yZ41UZ3nOCyQaITYF0IdxyMHM7bEoU/RtEPn+TUVLm4=; b=WUZ6q/rT++2WZNFnZY2h5DkKWAtlHMLjWG+zUSA1ozyUTAYfNs+y/TniO8DfVXQKQTdu6s eOw4g3pa0PkcPz5PDgQIxNoEhP++Ly2lKDpZIJSmedUf2X5sHrHHbZSnr99hlmWhmjpY2V xEWt39LqpaRCUng5PiJL+e4bQ6g7VCg= X-MC-Unique: e3_PS0pZOyusyNm2ljTtRg-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 2/3] libvirt_internal: fix ATTRIBUTE_NONNULL for virStateInitialize Date: Wed, 11 Mar 2020 13:13:44 +0100 Message-Id: <672fb6643123a119e2b7835d1667c80bac44165b.1583928792.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit <207709a03149e910323be2c8d1305313b30cdeaa> added `root` attribute to `virStateInitialize` function and marked it as NONNULL which is not correct because in `daemonRunStateInit` we call it with NULL. Signed-off-by: Pavel Hrdina --- src/libvirt_internal.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libvirt_internal.h b/src/libvirt_internal.h index 00ef7aaf25..72c61274a7 100644 --- a/src/libvirt_internal.h +++ b/src/libvirt_internal.h @@ -33,8 +33,7 @@ int virStateInitialize(bool privileged, bool mandatory, const char *root, virStateInhibitCallback inhibit, - void *opaque) - ATTRIBUTE_NONNULL(2); + void *opaque); int virStateCleanup(void); int virStateReload(void); int virStateStop(void); --=20 2.24.1 From nobody Mon May 6 11:06:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583928862; cv=none; d=zohomail.com; s=zohoarc; b=mpRtAv7hHX4dPGFGhoovqRgd1C9e4tpoQh/1uz19vScTWYipOA8Pc3qCmAop5Cx3/NdfRw/D355tLkNNhdyxX3zEalJSUKsHbzL1Rql+vASdE428lF48AbTPBpGyWSmK5d3boduJeA/0uesHcOXy8htXOxCQFuE6XMic8Nn0+Hk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583928862; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ygYJX59u3TWbn0dXN0w8JVYcEKMM+5NMT31p293Gn6M=; b=EyZ3gCWCycl8Jn2FKO+IGK+6Xy7ptx9YD24qLM0HH3UBd6eRFGMwBbfWNc9GhVIy1UpiFDVX0Z3SavRRetfRm5M1JwEv9Er9lUciss37T5FGwhNxKROyJZLGQv0fbREd/yZEC+Y4K+8NbsoZ5erseC8gypjR+QkKlUNpH4Yt8Ck= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1583928862382779.7222168987862; Wed, 11 Mar 2020 05:14:22 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-E6f6C2SdMA6VGJh9aJxTJw-1; Wed, 11 Mar 2020 08:14:17 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F6D2107ACC4; Wed, 11 Mar 2020 12:14:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 233F960C88; Wed, 11 Mar 2020 12:14:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 866471832E26; Wed, 11 Mar 2020 12:14:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02BCDscW007429 for ; Wed, 11 Mar 2020 08:13:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 65ACC73865; Wed, 11 Mar 2020 12:13:54 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-54.brq.redhat.com [10.40.200.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D2B55C13D for ; Wed, 11 Mar 2020 12:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583928859; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ygYJX59u3TWbn0dXN0w8JVYcEKMM+5NMT31p293Gn6M=; b=fhqfzCakJcy9IQwm0JOwIkweQyaH4OXDviJkAEm1CgzoA5JI0E5OorZ6HSI4Xt2rexxCqs u9hJCdcMJCmraOdw+bKwT3OpOsbnYShMfWVKj9HVADA7+OFHLES5uwsvM1BTW4FnJwYic2 ToZ5L3eeCSMPTk0n4+800zPaVvEZbGc= X-MC-Unique: E6f6C2SdMA6VGJh9aJxTJw-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 3/3] vircommand: fix ATTRIBUTE_NONNULL for virCommandAddArg* Date: Wed, 11 Mar 2020 13:13:45 +0100 Message-Id: <5fd4b1b37e2c9b69cc2cb25614ece660281f08c3.1583928792.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit <912c6b22fc622cd7c7d29c7f8eaeb816b266daac> added checks to `virCommandAddArg` and `virCommandAddArgPair` functions for some attributes which were marked as NONNULL. Remove the ATTRIBUTE_NONNULL as well. Signed-off-by: Pavel Hrdina --- src/util/vircommand.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/util/vircommand.h b/src/util/vircommand.h index 9086f9a90c..80f71e22f6 100644 --- a/src/util/vircommand.h +++ b/src/util/vircommand.h @@ -117,7 +117,7 @@ void virCommandAddEnvPassCommon(virCommandPtr cmd); void virCommandAddEnvXDG(virCommandPtr cmd, const char *baseDir); =20 void virCommandAddArg(virCommandPtr cmd, - const char *val) ATTRIBUTE_NONNULL(2); + const char *val); =20 void virCommandAddArgBuffer(virCommandPtr cmd, virBufferPtr buf); @@ -128,8 +128,7 @@ void virCommandAddArgFormat(virCommandPtr cmd, =20 void virCommandAddArgPair(virCommandPtr cmd, const char *name, - const char *val) - ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); + const char *val); =20 void virCommandAddArgSet(virCommandPtr cmd, const char *const*vals) ATTRIBUTE_NONNULL(2); --=20 2.24.1