[libvirt PATCH 0/7] valgrind-inspired fixes

Ján Tomko posted 7 patches 4 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1582331034.git.jtomko@redhat.com
tests/.valgrind.supp        | 13 +++++++++++++
tests/Makefile.am           |  2 +-
tests/qemumonitorjsontest.c | 29 ++++++++---------------------
tests/virsystemdtest.c      |  5 ++++-
4 files changed, 26 insertions(+), 23 deletions(-)
[libvirt PATCH 0/7] valgrind-inspired fixes
Posted by Ján Tomko 4 years, 1 month ago
First, clean up some valgrind noise.
Then, fix some reported leaks in the test suite.
Last, refactor some touched tests.

Ján Tomko (7):
  tests: valgrind.supp: suppress g_type_register_static leaks
  tests: valgrind: do not trace system binaries
  qemumonitorjsontest: do not leak qapiData.schema
  qemumonitorjsontest: use virCPUDefNew()
  virsystemdtest: do not leak socket path
  qemumonitorjsontest: GetCPUModelComparison: use g_auto
  qemumonitorjsontest: GetCPUModelBaseline: use g_auto

 tests/.valgrind.supp        | 13 +++++++++++++
 tests/Makefile.am           |  2 +-
 tests/qemumonitorjsontest.c | 29 ++++++++---------------------
 tests/virsystemdtest.c      |  5 ++++-
 4 files changed, 26 insertions(+), 23 deletions(-)

-- 
2.24.1

Re: [libvirt PATCH 0/7] valgrind-inspired fixes
Posted by Michal Prívozník 4 years ago
On 22. 2. 2020 1:24, Ján Tomko wrote:
> First, clean up some valgrind noise.
> Then, fix some reported leaks in the test suite.
> Last, refactor some touched tests.
> 
> Ján Tomko (7):
>   tests: valgrind.supp: suppress g_type_register_static leaks
>   tests: valgrind: do not trace system binaries
>   qemumonitorjsontest: do not leak qapiData.schema
>   qemumonitorjsontest: use virCPUDefNew()
>   virsystemdtest: do not leak socket path
>   qemumonitorjsontest: GetCPUModelComparison: use g_auto
>   qemumonitorjsontest: GetCPUModelBaseline: use g_auto
> 
>  tests/.valgrind.supp        | 13 +++++++++++++
>  tests/Makefile.am           |  2 +-
>  tests/qemumonitorjsontest.c | 29 ++++++++---------------------
>  tests/virsystemdtest.c      |  5 ++++-
>  4 files changed, 26 insertions(+), 23 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal