From nobody Tue Apr 30 02:26:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1580140842789781.6256465685989; Mon, 27 Jan 2020 08:00:42 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-v5MvkYGcOjyZWxS-BGikVQ-1; Mon, 27 Jan 2020 11:00:34 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15D41801E67; Mon, 27 Jan 2020 16:00:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 881458888B; Mon, 27 Jan 2020 16:00:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 96B4618089C8; Mon, 27 Jan 2020 16:00:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00RG0KWX005203 for ; Mon, 27 Jan 2020 11:00:20 -0500 Received: by smtp.corp.redhat.com (Postfix) id 370D081208; Mon, 27 Jan 2020 16:00:20 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3D28811FA for ; Mon, 27 Jan 2020 16:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580140841; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lBBB32tGK8TV30g2dQLIAfTccmlPaU720IyXcpcuRl8=; b=VftaecsPCtzi8X+c7m09UnTMEweymDnim+vFnJRtfgUz9cw38UrmZr1l2+Vl6GywxnS8is ojxgyGgYxpdnZfx9Ylu9QPOv7QhOjYAkygzllwAPwWmG7Mz5MJueJ5gaBEBV+/Y8iJn7UC t3DIiFWQRQmSLkgUKYM+CVEHxp8iVys= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/4] docs: fix virt-qemu-run man page Date: Mon, 27 Jan 2020 17:00:10 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: v5MvkYGcOjyZWxS-BGikVQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Fix a documentation generation error: System Message: WARNING/2 (, line 15); backlink Inline literal start-string without end-string. As well as the 'independant' typo. Signed-off-by: J=C3=A1n Tomko Fixes: d6006672788ec0f0290d35c76ceb9672476d1ea8 Reviewed-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- Did not investigate whether the generator can be told to use stderr instead of hiding the errors in the output files. docs/manpages/virt-qemu-run.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virt-qemu-run.rst b/docs/manpages/virt-qemu-run.= rst index 7f66f7c3ab..5074a928b7 100644 --- a/docs/manpages/virt-qemu-run.rst +++ b/docs/manpages/virt-qemu-run.rst @@ -14,13 +14,13 @@ Run a standalone QEMU guest SYNOPSIS =3D=3D=3D=3D=3D=3D=3D=3D =20 -``virt-qemu-run [OPTIONS...] [IGUEST-XML] +``virt-qemu-run [OPTIONS...] [GUEST-XML]`` =20 DESCRIPTION =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 This tool provides a way to run a standalone QEMU guest such that it -is completely independant of libvirtd. It makes use of the embedded +is completely independent of libvirtd. It makes use of the embedded QEMU driver support to run the VM placing files under an isolated directory tree. When the guest is run with this tool it is invisible to libvirtd and thus also invisible to other libvirt tools such as --=20 2.21.0 From nobody Tue Apr 30 02:26:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1580140860073232.01027983426968; Mon, 27 Jan 2020 08:01:00 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-231-DoLm2Zh7PnmOttZgWlP9mw-1; Mon, 27 Jan 2020 11:00:51 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1945D13E8; Mon, 27 Jan 2020 16:00:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD6AD85747; Mon, 27 Jan 2020 16:00:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6DF138578F; Mon, 27 Jan 2020 16:00:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00RG0LPI005211 for ; Mon, 27 Jan 2020 11:00:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id 033A981208; Mon, 27 Jan 2020 16:00:21 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 82191811FA for ; Mon, 27 Jan 2020 16:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580140858; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=QcztKOBammBDK9Cb/hBy82nz5xWXb8JM9H/Ji+ytQzM=; b=TYgUNDpZQBos8+XBUZ1KYS7LPFC0zqVwZsD0s26EA8s5wICFcnlzXqT4BFe1Hsaxpb7LYb 73Rfc/bJOj+/u+W5VbGyOjFm1M5a8i6iQex5FjdOTv0cf9sjMYFXNv4d3Ep8GAc+Lbg22y 9PTmgxRRc7z5tZQDnpHeMyiL4o6VXbw= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 2/4] docs: fix since version in driver documentation Date: Mon, 27 Jan 2020 17:00:11 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: DoLm2Zh7PnmOttZgWlP9mw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Also one stray angle bracket. Signed-off-by: J=C3=A1n Tomko Fixes: 068efae5b1a9efeea4a9c3bc0ae80747da5024fb Fixes: 3e9076e777aff2f4b08330ed17e559fcfb6b3529 Reviewed-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- docs/drvqemu.html.in | 4 ++-- docs/drvsecret.html.in | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/drvqemu.html.in b/docs/drvqemu.html.in index f6abb45706..87542afd27 100644 --- a/docs/drvqemu.html.in +++ b/docs/drvqemu.html.in @@ -66,7 +66,7 @@ qemu+ssh://root@example.com/system (remote access, SSH = tunnelled)

Embedded driver

=20

- Since 6.0.0 the QEMU driver has experimental support for operating + Since 6.1.0 the QEMU driver has experimental support for operating in an embedded mode. In this scenario, rather than connecting to the libvirtd daemon, the QEMU driver runs in the client application process directly. To use this the client application must have @@ -149,7 +149,7 @@ qemu+ssh://root@example.com/system (remote access, SS= H tunnelled) when opening a future connection.

=20 -

API usage with event loop>

+

API usage with event loop

=20

To use the QEMU driver in embedded mode the application must diff --git a/docs/drvsecret.html.in b/docs/drvsecret.html.in index 9a05fe1f09..1bd7d75215 100644 --- a/docs/drvsecret.html.in +++ b/docs/drvsecret.html.in @@ -35,7 +35,7 @@ secret+ssh://root@example.com/system (remote access, SS= H tunnelled)

Embedded driver

=20

- Since 6.0.0 the secret driver has experimental support for operating + Since 6.1.0 the secret driver has experimental support for operating in an embedded mode. In this scenario, rather than connecting to the libvirtd daemon, the secret driver runs in the client application process directly. To open the driver in embedded mode the app use the --=20 2.21.0 From nobody Tue Apr 30 02:26:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1580140863510242.8095322981037; Mon, 27 Jan 2020 08:01:03 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-oJ8tG1RoO9apuGjWxnYnOg-1; Mon, 27 Jan 2020 11:00:58 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F29C8100551A; Mon, 27 Jan 2020 16:00:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C324286433; Mon, 27 Jan 2020 16:00:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 755EB18089C8; Mon, 27 Jan 2020 16:00:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00RG0Lda005228 for ; Mon, 27 Jan 2020 11:00:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id C83D581208; Mon, 27 Jan 2020 16:00:21 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5155E811FA for ; Mon, 27 Jan 2020 16:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580140862; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6+Yplx2Mf1MqOAjIg6ksl9DBt7VOWvagKDgTXbTpfK8=; b=Bo/s7nEgjYYtlDWOr1V+QJmh4Rw/6mMM+jdrJw4r6GeheuD3AlJwMHCT7j8jLOK4IXJZJP Lsa+QU7YyVYXbvTlDDIH9RymSEG7aDzk0KgP0xkulj5MMjfDTfaB4LASLpgLyYC0NUmimc oltqr9yyY3iYv38so7oydQ5hoI7I1K8= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 3/4] qemu_shim: cosmetic fixes Date: Mon, 27 Jan 2020 17:00:12 +0100 Message-Id: <0a0d2d09065eea31e27965947030c00123e1d14b.1580140706.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: oJ8tG1RoO9apuGjWxnYnOg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Remove bogus G_GNUC_UNUSED attribute and add a missing space. Signed-off-by: J=C3=A1n Tomko Fixes: d6006672788ec0f0290d35c76ceb9672476d1ea8 Reviewed-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_shim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_shim.c b/src/qemu/qemu_shim.c index f4616f97b2..ccdb4f6b5b 100644 --- a/src/qemu/qemu_shim.c +++ b/src/qemu/qemu_shim.c @@ -45,7 +45,7 @@ qemuShimEventLoop(void *opaque G_GNUC_UNUSED) /* Runs in event loop thread context */ static void qemuShimEventLoopStop(int watch G_GNUC_UNUSED, - int fd G_GNUC_UNUSED, + int fd, int event G_GNUC_UNUSED, void *opaque G_GNUC_UNUSED) { @@ -102,7 +102,7 @@ int main(int argc, char **argv) GOptionContext *ctx; GOptionEntry entries[] =3D { { "secret", 's', 0, G_OPTION_ARG_STRING_ARRAY, &secrets, "Load sec= ret file", "SECRET-XML-FILE,SECRET-VALUE-FILE" }, - { "root", 'r', 0, G_OPTION_ARG_STRING, &root, "Root directory", "D= IR"}, + { "root", 'r', 0, G_OPTION_ARG_STRING, &root, "Root directory", "D= IR" }, { "debug", 'd', 0, G_OPTION_ARG_NONE, &debug, "Debug output", NULL= }, { "verbose", 'v', 0, G_OPTION_ARG_NONE, &verbose, "Verbose output"= , NULL }, { 0 } --=20 2.21.0 From nobody Tue Apr 30 02:26:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1580140876535609.6339270389302; Mon, 27 Jan 2020 08:01:16 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-so7EDw2mO6SzFomuKUS7nw-1; Mon, 27 Jan 2020 11:00:54 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F2FA107ACC4; Mon, 27 Jan 2020 16:00:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F318489E7D; Mon, 27 Jan 2020 16:00:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8CBB18577A; Mon, 27 Jan 2020 16:00:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00RG0M6q005235 for ; Mon, 27 Jan 2020 11:00:22 -0500 Received: by smtp.corp.redhat.com (Postfix) id 961A485747; Mon, 27 Jan 2020 16:00:22 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 203AB811FA for ; Mon, 27 Jan 2020 16:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580140875; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FEpOfYoX16cIxHw/GFj04d5aTW5F7BvkyK2LhBEuRcU=; b=LI3kp/Px7asjkCInRjg946Br8cPI1DKs5PPOo+l1sdbeBT7+GNiN93hY2kTfe3o67QmES2 JF9EQO+3Vzwrx3UMnaRUD5aHCJbPsia+IJBOL58QlYEOUd5dn3ECiydR9ypjrJ1bGP5u9n hcwQweTVjHlrrb8XO+YMhQQxVO7mfLE= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 4/4] qemu: snapshot: go through cleanup on error Date: Mon, 27 Jan 2020 17:00:13 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: so7EDw2mO6SzFomuKUS7nw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" A recent commit added an error check for too-nested backing chains followed by a return, even though errors above jump to cleanup. Signed-off-by: J=C3=A1n Tomko Fixes: b168fa88b85dec181882816ab65a59a6c4500667 Reviewed-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index fc080b4a48..048855b533 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -14654,7 +14654,7 @@ qemuDomainSnapshotCreateInactiveExternal(virQEMUDri= verPtr driver, snapdisk->src->format =3D VIR_STORAGE_FILE_QCOW2; =20 if (qemuDomainStorageSourceValidateDepth(defdisk->src, 1, defdisk-= >dst) < 0) - return -1; + goto cleanup; =20 /* creates cmd line args: qemu-img create -f qcow2 -o */ if (!(cmd =3D virCommandNewArgList(qemuImgPath, --=20 2.21.0