From nobody Mon Apr 29 13:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579273242; cv=none; d=zohomail.com; s=zohoarc; b=PhFT8eQPmnEfg9eBzscMnOxf3KyPtDkrrPeuIk94xb/zUQAzfEpJl8IaozrNbYBNR8r1xyvL4eCU58h2N7is6aEWewexPb6N4Eeg/uwFEDBtnIRz9YhXqsRowc5s+KGKXQ1nsT9cfWg8fL+HUZZEdx6RKYHu5us4wMIURHM0sxk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579273242; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fDVam2cSrb/tf8RXBVM40zxtjMdLsg8kYAzPlBAyglw=; b=hP9KdUDeKiKSKpby71PosvqRm9xOsqFfNpxbAXsZyZQWCwUGZfzVCMyJIEtPHHmpkLEJSq3/DvPznM3AjnrZVttKqiqJY/s0kbADNClsJvu1U7qEAzRW7cTty0fINR1skr2tvI17sx/EValYvJKV/32PaZCP3om0E7l3rkaWqKQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1579273242222303.7087860964649; Fri, 17 Jan 2020 07:00:42 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-135-HrAZ9vbnNqiWZFZzfZbBfA-1; Fri, 17 Jan 2020 10:00:35 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A3AAA0CBF; Fri, 17 Jan 2020 15:00:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3EAB1BC6D; Fri, 17 Jan 2020 15:00:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 20F0118089CD; Fri, 17 Jan 2020 15:00:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00HF0OYn013730 for ; Fri, 17 Jan 2020 10:00:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id EE9B3101F942; Fri, 17 Jan 2020 15:00:23 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id C037810027A9 for ; Fri, 17 Jan 2020 15:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579273241; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fDVam2cSrb/tf8RXBVM40zxtjMdLsg8kYAzPlBAyglw=; b=A5XCiuxe/FtYvkdHrJqzj+ePJKO5+r6TwE7nYAz92uM2eLP48NV43kQGI0Pe7/Bo/Dongw 0TydT0C4XDYCdibbOHjKK5PfGtiZqAotKmIVCLI7Pgcq0ND9n3Qz5IynbO4zC7hloL0GTI p/Ye9lHdtIAdWYR4Ff+4LSjvkpnIEOo= From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 01/10] secret: move virSecretGetSecretString into virsecret Date: Fri, 17 Jan 2020 16:00:08 +0100 Message-Id: <894556ca813ad3c4ebb01083b7971d73b4f53c8b.1579272954.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: HrAZ9vbnNqiWZFZzfZbBfA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The function virSecretGetSecretString calls into secret driver and is used from other hypervisors drivers and as such makes more sense in util. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- po/POTFILES.in | 1 - src/libvirt_private.syms | 5 +- src/libxl/libxl_conf.c | 2 +- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_process.c | 2 +- src/qemu/qemu_tpm.c | 2 +- src/secret/Makefile.inc.am | 11 --- src/secret/secret_util.c | 102 --------------------- src/secret/secret_util.h | 33 ------- src/storage/storage_backend_iscsi.c | 2 +- src/storage/storage_backend_iscsi_direct.c | 2 +- src/storage/storage_backend_rbd.c | 2 +- src/storage/storage_util.c | 2 +- src/util/virsecret.c | 69 ++++++++++++++ src/util/virsecret.h | 8 ++ 15 files changed, 86 insertions(+), 159 deletions(-) delete mode 100644 src/secret/secret_util.c delete mode 100644 src/secret/secret_util.h diff --git a/po/POTFILES.in b/po/POTFILES.in index faf173584e..e266871907 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -190,7 +190,6 @@ @SRCDIR@/src/rpc/virnetsshsession.c @SRCDIR@/src/rpc/virnettlscontext.c @SRCDIR@/src/secret/secret_driver.c -@SRCDIR@/src/secret/secret_util.c @SRCDIR@/src/security/security_apparmor.c @SRCDIR@/src/security/security_dac.c @SRCDIR@/src/security/security_driver.c diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 89ce6b4278..b63feb4054 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1448,10 +1448,6 @@ virLogManagerFree; virLogManagerNew; =20 =20 -# secret/secret_util.h -virSecretGetSecretString; - - # security/security_driver.h virSecurityDriverLookup; =20 @@ -3001,6 +2997,7 @@ virSecurityLabelDefNew; =20 =20 # util/virsecret.h +virSecretGetSecretString; virSecretLookupDefClear; virSecretLookupDefCopy; virSecretLookupFormatSecret; diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 2488bb9d32..e41e84e3e2 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -41,7 +41,7 @@ #include "libxl_conf.h" #include "libxl_utils.h" #include "virstoragefile.h" -#include "secret_util.h" +#include "virsecret.h" #include "cpu/cpu.h" #include "xen_common.h" #include "xen_xl.h" diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index b1ac7c5aa2..ce0c5b78cd 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -56,7 +56,7 @@ #include "vircrypto.h" #include "virrandom.h" #include "virsystemd.h" -#include "secret_util.h" +#include "virsecret.h" #include "logging/log_manager.h" #include "locking/domain_lock.h" #include "virdomainsnapshotobjlist.h" diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 420d1c9c93..1cac0dc886 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -83,7 +83,7 @@ #include "virnuma.h" #include "virstring.h" #include "virhostdev.h" -#include "secret_util.h" +#include "virsecret.h" #include "configmake.h" #include "nwfilter_conf.h" #include "netdev_bandwidth_conf.h" diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c index 28800a100c..262e6c4f07 100644 --- a/src/qemu/qemu_tpm.c +++ b/src/qemu/qemu_tpm.c @@ -42,7 +42,7 @@ #include "configmake.h" #include "qemu_tpm.h" #include "virtpm.h" -#include "secret_util.h" +#include "virsecret.h" =20 #define VIR_FROM_THIS VIR_FROM_NONE =20 diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am index d332060e38..4f0956a7a4 100644 --- a/src/secret/Makefile.inc.am +++ b/src/secret/Makefile.inc.am @@ -5,11 +5,6 @@ SECRET_DRIVER_SOURCES =3D \ secret/secret_driver.c \ $(NULL) =20 -SECRET_UTIL_SOURCES =3D \ - secret/secret_util.h \ - secret/secret_util.c \ - $(NULL) - =20 DRIVER_SOURCE_FILES +=3D $(addprefix $(srcdir)/,$(SECRET_DRIVER_SOURCES)) STATEFUL_DRIVER_SOURCE_FILES +=3D \ @@ -17,14 +12,8 @@ STATEFUL_DRIVER_SOURCE_FILES +=3D \ =20 EXTRA_DIST +=3D \ $(SECRET_DRIVER_SOURCES) \ - $(SECRET_UTIL_SOURCES) \ $(NULL) =20 -noinst_LTLIBRARIES +=3D libvirt_secret.la -libvirt_la_BUILT_LIBADD +=3D libvirt_secret.la -libvirt_secret_la_CFLAGS =3D $(AM_CFLAGS) -libvirt_secret_la_LDFLAGS =3D $(AM_LDFLAGS) -libvirt_secret_la_SOURCES =3D $(SECRET_UTIL_SOURCES) =20 if WITH_SECRETS mod_LTLIBRARIES +=3D libvirt_driver_secret.la diff --git a/src/secret/secret_util.c b/src/secret/secret_util.c deleted file mode 100644 index 27e164a425..0000000000 --- a/src/secret/secret_util.c +++ /dev/null @@ -1,102 +0,0 @@ -/* - * secret_util.c: secret related utility functions - * - * Copyright (C) 2016 Red Hat, Inc. - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library. If not, see - * . - * - */ - -#include - -#include "secret_util.h" -#include "viralloc.h" -#include "virerror.h" -#include "virlog.h" -#include "virobject.h" -#include "viruuid.h" -#include "datatypes.h" - -#define VIR_FROM_THIS VIR_FROM_SECRET - -VIR_LOG_INIT("secret.secret_util"); - - -/* virSecretGetSecretString: - * @conn: Pointer to the connection driver to make secret driver call - * @seclookupdef: Secret lookup def - * @secretUsageType: Type of secret usage for usage lookup - * @secret: returned secret as a sized stream of unsigned chars - * @secret_size: Return size of the secret - either raw text or base64 - * - * Lookup the secret for the usage type and return it as raw text. - * It is up to the caller to encode the secret further. - * - * Returns 0 on success, -1 on failure. On success the memory in secret - * needs to be cleared and free'd after usage. - */ -int -virSecretGetSecretString(virConnectPtr conn, - virSecretLookupTypeDefPtr seclookupdef, - virSecretUsageType secretUsageType, - uint8_t **secret, - size_t *secret_size) -{ - virSecretPtr sec =3D NULL; - int ret =3D -1; - - switch (seclookupdef->type) { - case VIR_SECRET_LOOKUP_TYPE_UUID: - sec =3D conn->secretDriver->secretLookupByUUID(conn, seclookupdef-= >u.uuid); - break; - - case VIR_SECRET_LOOKUP_TYPE_USAGE: - sec =3D conn->secretDriver->secretLookupByUsage(conn, secretUsageT= ype, - seclookupdef->u.usag= e); - break; - } - - if (!sec) - goto cleanup; - - /* NB: NONE is a byproduct of the qemuxml2argvtest test mocking - * for UUID lookups. Normal secret XML processing would fail if - * the usage type was NONE and since we have no way to set the - * expected usage in that environment, let's just accept NONE */ - if (sec->usageType !=3D VIR_SECRET_USAGE_TYPE_NONE && - sec->usageType !=3D secretUsageType) { - char uuidstr[VIR_UUID_STRING_BUFLEN]; - - virUUIDFormat(seclookupdef->u.uuid, uuidstr); - virReportError(VIR_ERR_INVALID_ARG, - _("secret with uuid %s is of type '%s' not " - "expected '%s' type"), - uuidstr, virSecretUsageTypeToString(sec->usageType), - virSecretUsageTypeToString(secretUsageType)); - goto cleanup; - } - - *secret =3D conn->secretDriver->secretGetValue(sec, secret_size, 0, - VIR_SECRET_GET_VALUE_INTE= RNAL_CALL); - - if (!*secret) - goto cleanup; - - ret =3D 0; - - cleanup: - virObjectUnref(sec); - return ret; -} diff --git a/src/secret/secret_util.h b/src/secret/secret_util.h deleted file mode 100644 index ff23df63b7..0000000000 --- a/src/secret/secret_util.h +++ /dev/null @@ -1,33 +0,0 @@ -/* - * secret_util.h: secret related utility functions - * - * Copyright (C) 2016 Red Hat, Inc. - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library. If not, see - * . - * - */ - -#pragma once - -#include "internal.h" -#include "virsecret.h" - -int virSecretGetSecretString(virConnectPtr conn, - virSecretLookupTypeDefPtr seclookupdef, - virSecretUsageType secretUsageType, - uint8_t **ret_secret, - size_t *ret_secret_size) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(4) - ATTRIBUTE_NONNULL(5) G_GNUC_WARN_UNUSED_RESULT; diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_back= end_iscsi.c index ee39cbf88d..c02fbb5eaa 100644 --- a/src/storage/storage_backend_iscsi.c +++ b/src/storage/storage_backend_iscsi.c @@ -39,7 +39,7 @@ #include "virobject.h" #include "virstring.h" #include "viruuid.h" -#include "secret_util.h" +#include "virsecret.h" #include "storage_util.h" =20 #define VIR_FROM_THIS VIR_FROM_STORAGE diff --git a/src/storage/storage_backend_iscsi_direct.c b/src/storage/stora= ge_backend_iscsi_direct.c index 3a5e2bb9f0..c37c671db6 100644 --- a/src/storage/storage_backend_iscsi_direct.c +++ b/src/storage/storage_backend_iscsi_direct.c @@ -24,7 +24,7 @@ #include =20 #include "datatypes.h" -#include "secret_util.h" +#include "virsecret.h" #include "storage_backend_iscsi_direct.h" #include "storage_util.h" #include "viralloc.h" diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backen= d_rbd.c index 88e7a4b236..f0b7653736 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -33,7 +33,7 @@ #include "virrandom.h" #include "rados/librados.h" #include "rbd/librbd.h" -#include "secret_util.h" +#include "virsecret.h" #include "storage_util.h" =20 #define VIR_FROM_THIS VIR_FROM_STORAGE diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index ebc262278d..987d937b04 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -62,7 +62,7 @@ #include "viralloc.h" #include "internal.h" #include "secret_conf.h" -#include "secret_util.h" +#include "virsecret.h" #include "vircrypto.h" #include "viruuid.h" #include "virstoragefile.h" diff --git a/src/util/virsecret.c b/src/util/virsecret.c index 174ce544c0..f44d964198 100644 --- a/src/util/virsecret.c +++ b/src/util/virsecret.c @@ -21,6 +21,7 @@ =20 #include =20 +#include "datatypes.h" #include "viralloc.h" #include "virerror.h" #include "virlog.h" @@ -125,3 +126,71 @@ virSecretLookupFormatSecret(virBufferPtr buf, virBufferAddLit(buf, "/>\n"); } } + + +/* virSecretGetSecretString: + * @conn: Pointer to the connection driver to make secret driver call + * @seclookupdef: Secret lookup def + * @secretUsageType: Type of secret usage for usage lookup + * @secret: returned secret as a sized stream of unsigned chars + * @secret_size: Return size of the secret - either raw text or base64 + * + * Lookup the secret for the usage type and return it as raw text. + * It is up to the caller to encode the secret further. + * + * Returns 0 on success, -1 on failure. On success the memory in secret + * needs to be cleared and free'd after usage. + */ +int +virSecretGetSecretString(virConnectPtr conn, + virSecretLookupTypeDefPtr seclookupdef, + virSecretUsageType secretUsageType, + uint8_t **secret, + size_t *secret_size) +{ + virSecretPtr sec =3D NULL; + int ret =3D -1; + + switch (seclookupdef->type) { + case VIR_SECRET_LOOKUP_TYPE_UUID: + sec =3D conn->secretDriver->secretLookupByUUID(conn, seclookupdef-= >u.uuid); + break; + + case VIR_SECRET_LOOKUP_TYPE_USAGE: + sec =3D conn->secretDriver->secretLookupByUsage(conn, secretUsageT= ype, + seclookupdef->u.usag= e); + break; + } + + if (!sec) + goto cleanup; + + /* NB: NONE is a byproduct of the qemuxml2argvtest test mocking + * for UUID lookups. Normal secret XML processing would fail if + * the usage type was NONE and since we have no way to set the + * expected usage in that environment, let's just accept NONE */ + if (sec->usageType !=3D VIR_SECRET_USAGE_TYPE_NONE && + sec->usageType !=3D secretUsageType) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + + virUUIDFormat(seclookupdef->u.uuid, uuidstr); + virReportError(VIR_ERR_INVALID_ARG, + _("secret with uuid %s is of type '%s' not " + "expected '%s' type"), + uuidstr, virSecretUsageTypeToString(sec->usageType), + virSecretUsageTypeToString(secretUsageType)); + goto cleanup; + } + + *secret =3D conn->secretDriver->secretGetValue(sec, secret_size, 0, + VIR_SECRET_GET_VALUE_INTE= RNAL_CALL); + + if (!*secret) + goto cleanup; + + ret =3D 0; + + cleanup: + virObjectUnref(sec); + return ret; +} diff --git a/src/util/virsecret.h b/src/util/virsecret.h index 8bc8a24e0f..bf056cb3b2 100644 --- a/src/util/virsecret.h +++ b/src/util/virsecret.h @@ -56,3 +56,11 @@ int virSecretLookupParseSecret(xmlNodePtr secretnode, void virSecretLookupFormatSecret(virBufferPtr buf, const char *secrettype, virSecretLookupTypeDefPtr def); + +int virSecretGetSecretString(virConnectPtr conn, + virSecretLookupTypeDefPtr seclookupdef, + virSecretUsageType secretUsageType, + uint8_t **ret_secret, + size_t *ret_secret_size) + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(4) + ATTRIBUTE_NONNULL(5) G_GNUC_WARN_UNUSED_RESULT; --=20 2.23.0 From nobody Mon Apr 29 13:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579273305; cv=none; d=zohomail.com; s=zohoarc; b=lDNytH0o51AdOVEqlvPOTBlv/MsDBMOWr9249QQxAU/f1zKrsvcFGXC541KYSeYg0G072QOf3GfHNQi3fyV6HHUBTTXEPa63ZLQ5LCmcH6XCthelY07uxUy7WugMCeQdopY+WKfmDQegBo46Ow0zkC9EDGfJcDY3JL5J14hdl7g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579273305; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KWbK7AaUpo+DVx1uuF/gy8v4Osdr4HFscjG0rJU9i2Q=; b=RWx3SLpVOkM0w2VltOBx/nNglkEI2ym4KjTyzxZwpNeVPCTzEK17jK/zhWFc/hwY9SVgAo1fIJPTJP0fy7+KUAZJi5b0W2NairUaB2fzeQ/g+B7cxBd23Lm0LXxajdrLpHBTk3SlgScB6g3mYmQClwLX50ScKOmq7tpn2bmQccA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1579273305820126.65973334232683; Fri, 17 Jan 2020 07:01:45 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20--VkQDdSgNDq70CqSQzXJMg-1; Fri, 17 Jan 2020 10:01:42 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 94E51100550E; Fri, 17 Jan 2020 15:01:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6246960CC0; Fri, 17 Jan 2020 15:01:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0770A8708F; Fri, 17 Jan 2020 15:01:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00HF0P82013742 for ; Fri, 17 Jan 2020 10:00:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id 70806101F942; Fri, 17 Jan 2020 15:00:25 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95CC910027A9 for ; Fri, 17 Jan 2020 15:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579273304; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=KWbK7AaUpo+DVx1uuF/gy8v4Osdr4HFscjG0rJU9i2Q=; b=cHWX4eRGkVKe/lynnwEdj7G22QSdvjAgoGmZt4spXthrj/U3d+77IUxz3hvPx58PNJtB+D S3IfQLZrrzl8R4rCNIKimSyXZjeFnBuoSEjlnDkX73iiiziUiRL0cZuwnEyJ/MvwECAx/1 1EXj+Z9S+oHhtvTF3R7TS+Qg6iK83xE= From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 02/10] configure.ac: add check for getegid function Date: Fri, 17 Jan 2020 16:00:09 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: -VkQDdSgNDq70CqSQzXJMg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We already use this function and so far we've been lucky that the same check is done by gnulib. This will change once we will drop gnulib and also make it obvious that we have to do the same check in Meson as well. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 7d69b8bcb4..58c4454707 100644 --- a/configure.ac +++ b/configure.ac @@ -354,6 +354,7 @@ dnl Availability of various common functions (non-fatal= if missing), dnl and various less common threadsafe functions AC_CHECK_FUNCS_ONCE([\ fallocate \ + getegid \ geteuid \ getgid \ getifaddrs \ --=20 2.23.0 From nobody Mon Apr 29 13:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579273256; cv=none; d=zohomail.com; s=zohoarc; b=Ll6hPFLOjRkS+XpNxOpy5Ye1cJirlXm227P5+3BBxuSIGyuaJN7P0ztjbHoxsZRR8guP1qgKPRL9Kr6D7PmEXJs31ZOJvvQ38GlQUsuJ7idxdSdjHR318vXCfmRQfi1ebBg/fm2WuCrVh1FVmukcjyRrz3YeH3aFDvGXu7iUlS0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579273256; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=T5AVuvfQDJ2Wi6rQ0WAo1aREE4+w10bbz/8QN5LbUME=; b=RJ4WXdAdb2xDXP0pJcG8Tb9HrWCALnhaisf1x6ctUXIy35m9ci+KP2kdxBsodG1tT7lc2EMEMQJWWtC/giDZDStEU/D75klKwsDEQWsrqweM0IX0wPWz7YkjyItHDPKgojAY5g0rfGSMkf4VjYgXs82c1DIzAfiO2ufEZGHBeQg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1579273256307139.5043109377482; Fri, 17 Jan 2020 07:00:56 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-4FWqaitbN6uMK0bYzvyObA-1; Fri, 17 Jan 2020 10:00:53 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 295A41800D48; Fri, 17 Jan 2020 15:00:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE9D089D1C; Fri, 17 Jan 2020 15:00:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E741218089CF; Fri, 17 Jan 2020 15:00:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00HF0QTN013753 for ; Fri, 17 Jan 2020 10:00:26 -0500 Received: by smtp.corp.redhat.com (Postfix) id E40CF1084194; Fri, 17 Jan 2020 15:00:26 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3D24010027A9 for ; Fri, 17 Jan 2020 15:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579273255; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=T5AVuvfQDJ2Wi6rQ0WAo1aREE4+w10bbz/8QN5LbUME=; b=IGaroeJK1vYfcsIBooM3peP8Yv+X8q251r1OX9K6IfcS1KS/FOreKLNNNVYTd62b5D81FW Tz4cSvFtNWiuBF51sWCGJXlzdQVh3zXew8s++zZkzE5114DewwYKm05rtiDAyzQrhHc1BN NC6BM9rAOWfopwEmflRm2hKa3wMXKcc= From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 03/10] bootstrap.conf: add threadlib module Date: Fri, 17 Jan 2020 16:00:10 +0100 Message-Id: <8b1baea3639efb027a79c1e15a32585f50dfd19a.1579272954.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: 4FWqaitbN6uMK0bYzvyObA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" It is pulled in by tests and used by our build system as well. Make an explicit dependency on threadlib. This can be later removed by using GLib GThread. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- bootstrap.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bootstrap.conf b/bootstrap.conf index 87c23c7d89..d7701ad578 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -58,6 +58,8 @@ gnulib_modules=3D"$gnulib_modules sigaction" gnulib_modules=3D"$gnulib_modules sigpipe" # -> open code conditional or use GIO GFileInfo gnulib_modules=3D"$gnulib_modules stat-time" +# -> GThread +gnulib_modules=3D"$gnulib_modules threadlib" # -> remove use or open-code it. possibly add to glib gnulib_modules=3D"$gnulib_modules strchrnul" # -> g_strsplit --=20 2.23.0 From nobody Mon Apr 29 13:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579273260; cv=none; d=zohomail.com; s=zohoarc; b=QGmEQ/RV1OBkbZtWA4XLqkYxs+47sFXpCXG/9AECJ01qH3vnZMlgYYDao3XmQ6H+eX/JYf6epMYsiijU414dfwnJK8wruMZNpsMfYYxi2b2y6fwo4F4jnzsvHQCVa86I8Qx8At2LzLMlp2Uu5z0OEdcK6/NsAq7rgEONJqPmEvc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579273260; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qFNXdqaMmpZo6AsAA/QvH4T1zTZ1GkFlM2PlQCRUPd4=; b=hggBoyBgT680fbpzZtgeFfNfXfCu98GQtAB1FoeA4QZq/00ZaQg+cXOsOYwpoxPCDpe10NIr9tS+3zm/4D6mo5H2sY39CJa9Ilcvgu3c/qDj8VsdmCFS95+HFfETOL61azUO1kuUGWf+P9snfinS+ouynIeZnIQtVoosIpW2xao= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1579273260232910.9491471138698; Fri, 17 Jan 2020 07:01:00 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-mtAB7598Od-UHhgp5bc3gA-1; Fri, 17 Jan 2020 10:00:56 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B40EA1005514; Fri, 17 Jan 2020 15:00:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8130960FC6; Fri, 17 Jan 2020 15:00:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 267E418089D5; Fri, 17 Jan 2020 15:00:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00HF0RRR013761 for ; Fri, 17 Jan 2020 10:00:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id ECDBE101F942; Fri, 17 Jan 2020 15:00:27 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5ACEE10027A9 for ; Fri, 17 Jan 2020 15:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579273259; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qFNXdqaMmpZo6AsAA/QvH4T1zTZ1GkFlM2PlQCRUPd4=; b=aQatoZcVv7inB8ATe1M0LJCva3IQpJ/FEdgidKGCryBdWMVQ0A1/0cAf8OAqcx/Q150pxA jRK3mIrtfwIniC+hRUzs9+DcwuW/DsJd/Hh1ZgD2AnJh4VUFO6YTdXsyBM5x5RuFpgWsqh mvm7HP9F05u5foEL0CtpLg9mWPijo3E= From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 04/10] bootstrap.conf: drop gnulib tests from libvirt Date: Fri, 17 Jan 2020 16:00:11 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: mtAB7598Od-UHhgp5bc3gA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We are in process of removing gnulib and adopting meson as our build system. In order to help with the transition let's drop gnulib tests. This will also help with the fact that before we will be able to drop gnulib completely we will store output of bootstrap in git. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- .gitignore | 2 -- Makefile.am | 2 +- bootstrap.conf | 13 ------------- configure.ac | 1 - gnulib/tests/Makefile.am | 32 -------------------------------- 5 files changed, 1 insertion(+), 49 deletions(-) delete mode 100644 gnulib/tests/Makefile.am diff --git a/.gitignore b/.gitignore index 2d6e3e3194..2139d176da 100644 --- a/.gitignore +++ b/.gitignore @@ -27,12 +27,10 @@ Makefile.in =20 # gnulib related ignores !/gnulib/lib/Makefile.am -!/gnulib/tests/Makefile.am *.rej *~ /gnulib/lib/* /gnulib/m4/* -/gnulib/tests/* =20 # git related ignores *.orig diff --git a/Makefile.am b/Makefile.am index 0d7ccc74db..8a8eecb697 100644 --- a/Makefile.am +++ b/Makefile.am @@ -23,7 +23,7 @@ GENHTML =3D genhtml # so force it explicitly DISTCHECK_CONFIGURE_FLAGS =3D --enable-werror =20 -SUBDIRS =3D . gnulib/lib include/libvirt src tools docs gnulib/tests \ +SUBDIRS =3D . gnulib/lib include/libvirt src tools docs \ tests po examples =20 XZ_OPT ?=3D -v -T0 diff --git a/bootstrap.conf b/bootstrap.conf index d7701ad578..58d1b8e676 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -93,13 +93,10 @@ fi gnulib_name=3Dlibgnu m4_base=3Dm4 source_base=3Dgnulib/lib -tests_base=3Dgnulib/tests gnulib_tool_option_extras=3D"\ --lgpl=3D2\ - --with-tests\ --makefile-name=3Dgnulib.mk\ --avoid=3Dpt_chown\ - --avoid=3Dlock-tests\ " local_gl_dir=3Dgnulib/local =20 @@ -134,16 +131,6 @@ gnulib_extra_files=3D" doc/INSTALL " =20 - -bootstrap_post_import_hook() -{ - # Change paths in gnulib/tests/gnulib.mk from "../../.." to "../..", - # and make tests conditional by changing "TESTS" to "GNULIB_TESTS". - m=3Dgnulib/tests/gnulib.mk - sed 's,\.\./\.\./\.\.,../..,g; s/^TESTS /GNULIB_TESTS /' $m > $m-t - mv -f $m-t $m -} - bootstrap_epilogue() { echo "$0: done. Now you can run 'mkdir build && cd build && ../config= ure'." diff --git a/configure.ac b/configure.ac index 58c4454707..4bdf38ec15 100644 --- a/configure.ac +++ b/configure.ac @@ -925,7 +925,6 @@ AC_CONFIG_FILES([run], AC_CONFIG_FILES([\ Makefile src/Makefile include/libvirt/Makefile docs/Makefile \ gnulib/lib/Makefile \ - gnulib/tests/Makefile \ .color_coded \ .ycm_extra_conf.py \ libvirt.pc \ diff --git a/gnulib/tests/Makefile.am b/gnulib/tests/Makefile.am deleted file mode 100644 index 7062cbaf87..0000000000 --- a/gnulib/tests/Makefile.am +++ /dev/null @@ -1,32 +0,0 @@ -## Makefile for gnulib/lib - -## Copyright (C) 2011, 2013 Red Hat, Inc. -## -## This library is free software; you can redistribute it and/or -## modify it under the terms of the GNU Lesser General Public -## License as published by the Free Software Foundation; either -## version 2.1 of the License, or (at your option) any later version. -## -## This library is distributed in the hope that it will be useful, -## but WITHOUT ANY WARRANTY; without even the implied warranty of -## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -## Lesser General Public License for more details. -## -## You should have received a copy of the GNU Lesser General Public -## License along with this library. If not, see -## . - -include gnulib.mk - -GNULIB_TESTS0 =3D -GNULIB_TESTS1 =3D $(GNULIB_TESTS) -if WITH_EXPENSIVE_TESTS -## Automake requires that at least one conditional call out all tests to -## be run, for those tests to be shipped in the tarball -TESTS =3D $(GNULIB_TESTS) -endif WITH_EXPENSIVE_TESTS -## However, we want to change the set of tests based on the make environme= nt, -## where the default was set at configure time. Use GNU make constructs to -## hide our actions from Automake, so we don't get it too confused. -VIR_TEST_EXPENSIVE ?=3D $(VIR_TEST_EXPENSIVE_DEFAULT) -$(eval TESTS=3D$(GNULIB_TESTS$(VIR_TEST_EXPENSIVE))) --=20 2.23.0 From nobody Mon Apr 29 13:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579273257; cv=none; d=zohomail.com; s=zohoarc; b=KCvzyHaUkPpP0M570RN3uY287Ox1ycWrM8V/iO0Sr772I3PewnjS4jr1D7+oFCqX8T4uBQ8NlcINOijv/ZrzCgqznCAqR2Q8w3yuSZiC/rKrf9UCd9PAFUrmSXkpOok56/fSdEXl5JUoGHIouHzSd2xWbUF7+5/0lLRDoAjPvZc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579273257; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TNDMByY/CWPQVhgVY6T4Xj5xw7dcmbuHZ7OYmQoFSDw=; b=BayH3MAfzcf+/MUJ38wO5kBRMFUUYflKdkMHuopt/4qZc+pnnGCOVZQBFkXVE+uC7q88BmldkoDe5FVxaBv6AsN73H17bLQzE58ukacRJwuPRUD0N5BQfXdI2gygwF4wSN5r3N1s/9Du2PVK6cZO3+ojBwG+r375qzPPJAig3VU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1579273257621223.3939737147433; Fri, 17 Jan 2020 07:00:57 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-384-25q0QCLhNSSdGxyff2avhg-1; Fri, 17 Jan 2020 10:00:54 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 404FC18AAFA2; Fri, 17 Jan 2020 15:00:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D8FA19C7F; Fri, 17 Jan 2020 15:00:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A176587090; Fri, 17 Jan 2020 15:00:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00HF0V9k013781 for ; Fri, 17 Jan 2020 10:00:31 -0500 Received: by smtp.corp.redhat.com (Postfix) id 35F5610027A9; Fri, 17 Jan 2020 15:00:31 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C56A1081333 for ; Fri, 17 Jan 2020 15:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579273256; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TNDMByY/CWPQVhgVY6T4Xj5xw7dcmbuHZ7OYmQoFSDw=; b=D/lHYNTMhfFVP5nXGOZlH3y5uucJuB1ZaocCILlmk3bsT0ZrWThWoGm9djYegO5qD7H7TI Zzcs1JwwaNgcA4noB0ZcwScBwYeJTqdBn4Mi4osxQCFoQeOAUu2FiOX7R+GVWbfzR5BA2R KOGR+91ROBzYSi1t0dHtHaOxpnnHCzE= From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 05/10] bootstrap.conf: always copy files Date: Fri, 17 Jan 2020 16:00:12 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: 25q0QCLhNSSdGxyff2avhg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Preparation for having bootstrap result in git. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- bootstrap.conf | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/bootstrap.conf b/bootstrap.conf index 58d1b8e676..b4020ab8ad 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -77,11 +77,7 @@ gnulib_modules=3D"$gnulib_modules wcwidth" =20 SKIP_PO=3Dtrue =20 -# Enable copy-mode for MSYS/MinGW. MSYS' ln doesn't work well in the way -# bootstrap uses it with relative paths. -if test -n "$MSYSTEM"; then - copy=3Dtrue -fi +copy=3Dtrue =20 =20 # Tell gnulib to: --=20 2.23.0 From nobody Mon Apr 29 13:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579273266; cv=none; d=zohomail.com; s=zohoarc; b=Xlo/BdpL0PswCyYlf6LmcuFM5um0sa1T1ybVXaJZqbm2GfMmkJCuhNid06vUuau1CKoTplA6hkBvCzTZNkctHKqWxLwQ/fBa7S2X9MIhC6RrqLgB3yWfCua7GfkTNTq+WYRTYxSpa0NUwq/0QRQ5L0JisgWvhgn9NV45aXfi1HA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579273266; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZMZ7Sx+oiWMcFn9kskgNc0pSNguWMc6Ygj3QXFQobuI=; b=B/qSBZ+/dwtMsobsJNlemNI6iS/XUgYWKQtp/2BqfXhaee8lMDS06VirpTwIrKO2dJXKVy/b+/Yi3IQ5mKxgBj3ZZAMNzrnkT44JP80dY2V76r+u9VgJwSiRkx43lN7F4GWy4ecmY0NgmBriRH5XXZ17e81FW0O2Efpi/g7lT20= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 157927326675048.17671102751342; Fri, 17 Jan 2020 07:01:06 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-120-Ngvljj_2NgyI0aX0w-S7qA-1; Fri, 17 Jan 2020 10:01:02 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9246801F74; Fri, 17 Jan 2020 15:00:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F00A1084194; Fri, 17 Jan 2020 15:00:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2375A87091; Fri, 17 Jan 2020 15:00:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00HF0XoE013794 for ; Fri, 17 Jan 2020 10:00:33 -0500 Received: by smtp.corp.redhat.com (Postfix) id B230E1081333; Fri, 17 Jan 2020 15:00:33 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id E52AE10027A9 for ; Fri, 17 Jan 2020 15:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579273265; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZMZ7Sx+oiWMcFn9kskgNc0pSNguWMc6Ygj3QXFQobuI=; b=APBZgX0PnpJ26PCJPuPzwfOfuK2Vn21dTvVGavT9mBUkRrzpib17Gbal80bu83zApx94G+ bHRFKB5wanxKujrdp9sKffMiTT1H3rXiDYdYfH0cMZ20GaFnbJRvToldZJNrnu95IhslRQ HuHJimC1Mpx5QTJgSvBYUwEn6c3bclU= From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 06/10] bootstrap.conf: declare bootstrap sync in configuration file Date: Fri, 17 Jan 2020 16:00:13 +0100 Message-Id: <5ac332549c6d74c43ea38d21d97ddb3dc878820a.1579272954.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: Ngvljj_2NgyI0aX0w-S7qA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- autogen.sh | 2 +- bootstrap.conf | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index 9afad8f9d5..a119b099cb 100755 --- a/autogen.sh +++ b/autogen.sh @@ -147,7 +147,7 @@ if test -d .git || test -f .git; then dry_run=3D2 else echo "Running bootstrap..." - ./bootstrap$no_git --bootstrap-sync || { + ./bootstrap$no_git || { die "bootstrap failed" } gnulib_hash >"$state_file" diff --git a/bootstrap.conf b/bootstrap.conf index b4020ab8ad..13dd239fd1 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -79,6 +79,8 @@ SKIP_PO=3Dtrue =20 copy=3Dtrue =20 +bootstrap_sync=3Dtrue + =20 # Tell gnulib to: # require LGPLv2+ --=20 2.23.0 From nobody Mon Apr 29 13:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579273314; cv=none; d=zohomail.com; s=zohoarc; b=NrjiaNIM/mTOqsy9Msx7AUv8FMfGp9mCteXWlRvVAM00s6YOY2NnoKOj7Gtee23Zmz0P0lD1eZAC+3ni9j2kOKMHHYz1g6jw0Toa1OuwUAHeDYPbFL6lchbO3faw4DQ4Pv+XYU7QA8bnUHjD5sy6shzQE7zFhY47cStTwMjyacs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579273314; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0m8OKwMvxDpYKhH24UyeWxyG2TmXYlT6wOddcrWNcQQ=; b=jX+G5zfg0HKNDwi0Ryfnjabj85YBeYjvHMbwseLKD2aF5I6P1i0byM3BY/y6ZzsneXhiaS5tIYbR7CavsjGc2LYqFy5/JeVg1tjOBI2Gxx5w29Or1P6ghjDu+PSCUXKh7VsoaaM06fxamA/WMfWIhRHoKQuXsfttPO46RAEHxrI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1579273314327794.3003018453339; Fri, 17 Jan 2020 07:01:54 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-424-YhNjhY_AMC6_-1q2Dfv0tA-1; Fri, 17 Jan 2020 10:01:49 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 22754800D5A; Fri, 17 Jan 2020 15:01:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2748952EA; Fri, 17 Jan 2020 15:01:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7840587093; Fri, 17 Jan 2020 15:01:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00HF0ZhV013806 for ; Fri, 17 Jan 2020 10:00:35 -0500 Received: by smtp.corp.redhat.com (Postfix) id D4E501081333; Fri, 17 Jan 2020 15:00:35 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 445F710027A9 for ; Fri, 17 Jan 2020 15:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579273313; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0m8OKwMvxDpYKhH24UyeWxyG2TmXYlT6wOddcrWNcQQ=; b=gwsqMFgD/bSOvNEWxuuOWrEbMMYZOeApoJuUzpQclY4PQ6Ch80wGnsnUtydwQJ5oxWjWlG bAFLIjNkTF+R+4pm67AN4ScczYwb3sfo/qCPb+RmCvbeEHxVHB9XN9uVZh2hYebN8MJ7H2 aHjdvcFGBcM6I4t1+YlMrFn7QdurDNQ= From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 07/10] bootstrap.conf: disable VC ignore files Date: Fri, 17 Jan 2020 16:00:14 +0100 Message-Id: <23fc25b2ab686eaf780a04a71a93eb6da47b184e.1579272954.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: YhNjhY_AMC6_-1q2Dfv0tA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We already ignore most of these files and the .gitignore files as well. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- .gitignore | 5 ++++- bootstrap.conf | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 2139d176da..949bd3bc5a 100644 --- a/.gitignore +++ b/.gitignore @@ -14,9 +14,12 @@ /INSTALL /aclocal.m4 /autom4te.cache -/build-aux/.gitignore /build-aux/compile +/build-aux/config.guess +/build-aux/config.sub /build-aux/depcomp +/build-aux/install-sh +/build-aux/ltmain.sh /build-aux/missing /build-aux/test-driver /config.h.in diff --git a/bootstrap.conf b/bootstrap.conf index 13dd239fd1..5ff3374ded 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -81,6 +81,8 @@ copy=3Dtrue =20 bootstrap_sync=3Dtrue =20 +vc_ignore=3D + =20 # Tell gnulib to: # require LGPLv2+ @@ -95,6 +97,7 @@ gnulib_tool_option_extras=3D"\ --lgpl=3D2\ --makefile-name=3Dgnulib.mk\ --avoid=3Dpt_chown\ + --no-vc-files\ " local_gl_dir=3Dgnulib/local =20 --=20 2.23.0 From nobody Mon Apr 29 13:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579273318; cv=none; d=zohomail.com; s=zohoarc; b=j5VScWcKBfc8u5vcOIGzQ7Ul9Gv8HG/rEjjdLt5l49Xv+am2hmyLkGeDpTPvvzD439d1vFXSUxoxPIwJdwmj417ixif9spyJnJ4ueBOLRmo7iuyHhuBVolf+kpLAv2C9KHJ5sow/hPuE3oIjRbdtoi3r8DHfJ0XGoqrziRg1+Kg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579273318; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9HAyeD1l+s1KjDfNGbYpRcR864VJQ4BQfI2XM4bbyTE=; b=iYdrUzz2LlueEjWpFOYSbW123o0LrQH9N4lO15hIn5U+4eY1Z21q4cv6Zq3u0hf32uklhFhKqrAZxDLAOi2ZrjaC9PQh7DfmbMLpitdp5OXpJOi3cpbWUw1mj4nqW/nukxKjjlv1eQarP2ZbTHRcjYccXF4ZZBYHo91x8fyRnNE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1579273318855781.0529215667284; Fri, 17 Jan 2020 07:01:58 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-usLlQw1BO967ZGUgGahMyg-1; Fri, 17 Jan 2020 10:01:55 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30535100550E; Fri, 17 Jan 2020 15:01:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01617675AF; Fri, 17 Jan 2020 15:01:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9F6E887096; Fri, 17 Jan 2020 15:01:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00HF0esd013823 for ; Fri, 17 Jan 2020 10:00:40 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9266E1084194; Fri, 17 Jan 2020 15:00:40 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id EAF7D1081333 for ; Fri, 17 Jan 2020 15:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579273317; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9HAyeD1l+s1KjDfNGbYpRcR864VJQ4BQfI2XM4bbyTE=; b=N/N/rUIqfPuBXKecAvziFi1JK+4HPM/dJCBJjn2KBB2uWvUUq6jJb5Y3S9W27PDLNAXdZV S+4+oaqCrVPVvbxX+kSHLQ0pLo6q+N+6kHgDYBdl7E7qWXvygo/Oqecx3Qei3js4OzH0x0 bqB7FM8kIuqac7N7VzLGwqAr9D8+TTU= From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 08/10] bootstrap.conf: stop creating AUTHORS file Date: Fri, 17 Jan 2020 16:00:15 +0100 Message-Id: <5bde956f47f3dc03537083d33f9a5fd542241fff.1579272954.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: usLlQw1BO967ZGUgGahMyg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The existence of AUTHORS file is required for GNU projects but since commit <8bfb36db40f38e92823b657b5a342652064b5adc> we do not require these files to exist. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- autogen.sh | 2 +- bootstrap.conf | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/autogen.sh b/autogen.sh index a119b099cb..a1f1943adb 100755 --- a/autogen.sh +++ b/autogen.sh @@ -127,7 +127,7 @@ if test -d .git || test -f .git; then expected_hash=3D$(cat "$state_file" 2>/dev/null) actual_hash=3D$(gnulib_hash "$no_git") =20 - if test "$actual_hash" =3D "$expected_hash" && test -f AUTHORS; then + if test "$actual_hash" =3D "$expected_hash"; then # The gnulib hash matches our expectations, and all the files # that can only be generated through bootstrap are present: # we just need to run autoreconf. Unless we're performing a diff --git a/bootstrap.conf b/bootstrap.conf index 5ff3374ded..4159199d08 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -120,9 +120,6 @@ xmllint - xsltproc - " =20 -# Automake requires that AUTHORS exist. -touch AUTHORS || exit 1 - # Override bootstrap's list - we don't use mdate-sh or texinfo.tex. gnulib_extra_files=3D" build-aux/install-sh --=20 2.23.0 From nobody Mon Apr 29 13:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579273270; cv=none; d=zohomail.com; s=zohoarc; b=BJHHIsAC31uPaRgvuHkKFsZIlFWOhLxWj4OE305wQnMEunu6tv3uSsyQJrO/XTvUSgSdkPZ+4Hu8vVnbwY8CVXpdAptiZEsadkj7jpbARYQlVf0xc1QIBAXadPXtAbWn2cg5BKsUVYAv1twcMoPNZjCD2J4+59LhG3GuC58F+xc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579273270; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SL/D0tTYjvdD8r0he1aZqtEoC1P8QVaNRhOyewfiiOg=; b=UHC7XiWlm8CJaxE23LQ5oMFR6v+Y07znYENcYbfHZ1FfMx9yEfGUpvqphLQjqIbwdpovV71E43XL36M4kUkUpPXVQML4jDXhWABesi9AeIk0eEQT8VqrUWfGHyWiK+gBZIz5ut1YGBYJVzswhzOx75y2SzWUaupe6tt7sLq079s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1579273270169850.9932203874766; Fri, 17 Jan 2020 07:01:10 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-dW3N9sQXPv2sV7QohYdp2A-1; Fri, 17 Jan 2020 10:01:06 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 65169A0CD0; Fri, 17 Jan 2020 15:01:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A55D5DA7D; Fri, 17 Jan 2020 15:01:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C50D718089D8; Fri, 17 Jan 2020 15:00:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00HF0g5w013835 for ; Fri, 17 Jan 2020 10:00:43 -0500 Received: by smtp.corp.redhat.com (Postfix) id E98B7101F942; Fri, 17 Jan 2020 15:00:42 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 589E31084194 for ; Fri, 17 Jan 2020 15:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579273269; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=SL/D0tTYjvdD8r0he1aZqtEoC1P8QVaNRhOyewfiiOg=; b=VhMI5om02ePtx/8qC+Me0Xeqgb645/f7zE3MgMSMsVRsRJ+bN7wf+PknLn5O40kABxdAAr LMtj8CSURbR7BE05IODw6uVsES+PCk/RHo6cyUh3zJ10uDV60p0cmJr32Wcxvct9apkNN4 3Vh1XIhatgsogbY5Ef7cw+VGHSxZdDs= From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 09/10] syntax-check: remove deleted daemon directory from space_indent_check Date: Fri, 17 Jan 2020 16:00:16 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: dW3N9sQXPv2sV7QohYdp2A-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index b0a977201e..e5623606dd 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -569,7 +569,7 @@ sc_size_of_brackets: # Ensure that no C source file, docs, or rng schema uses TABs for # indentation. Also match *.h.in files, to get libvirt.h.in. Exclude # files in gnulib, since they're imported. -space_indent_files=3D(\.(aug(\.in)?|rng|s?[ch](\.in)?|html.in|py|pl|syms)|= (daemon|tools)/.*\.in) +space_indent_files=3D(\.(aug(\.in)?|rng|s?[ch](\.in)?|html.in|py|pl|syms)|= tools/.*\.in) sc_TAB_in_indentation: @prohibit=3D'^ * ' \ in_vc_files=3D'$(space_indent_files)$$' \ --=20 2.23.0 From nobody Mon Apr 29 13:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579273324; cv=none; d=zohomail.com; s=zohoarc; b=fsWpq9U7jVF7YiEZ3aOg5Tlvh3JMRn9vuZmFA5Ju/y+NXuYxvFbK8KCrbeFeHpqOVseqZjQjKk6iNZF4z+nK33uKjiDo8DMSvbf9BlmB32MBD9uPaFd6sK3lGEkH0w/HBoK9C3+AC/d4fdA3I2llkbtnkyE0yeheMs7STw08ZKk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579273324; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7Jq9XtAYatPiungWqVtOCFzBSPnQdOf5HravG5d16Ak=; b=YmL8CuU6k7oX9n4khZfPRc1oRi5LCshBSFiE1u0YWcqGrxIuImiCruUTLVYcuL+xZlBBmSETSyDwd4If1CwCJGQrypxf+jzKTVNkEKYz8o9m0S7AgM21dh/PrhN5NXjiVIz/MyNAj602Jm785BS8wl6nF3ve4772cWlkZaWt8AI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1579273324243796.1669786324817; Fri, 17 Jan 2020 07:02:04 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-184-0OUQEVupN4-gw-i8c4uRmw-1; Fri, 17 Jan 2020 10:02:00 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B97518AAFA1; Fri, 17 Jan 2020 15:01:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EED4484BBE; Fri, 17 Jan 2020 15:01:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8CF55180880C; Fri, 17 Jan 2020 15:01:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00HF0iGN013845 for ; Fri, 17 Jan 2020 10:00:44 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7416210841AB; Fri, 17 Jan 2020 15:00:44 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A391101F942 for ; Fri, 17 Jan 2020 15:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579273322; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7Jq9XtAYatPiungWqVtOCFzBSPnQdOf5HravG5d16Ak=; b=bXM+UxpCLlJeb6ngGsDNYPCqt90vzoc6HMcw+DB93d6PziW8EycuBOsLmbqV3c6pGZolVp ysC3FY0BpJFhL8jVLYyJpR20ZoD1gK5aYOxDojyGmikEyAnmPnu+R8BjVRVq3BNa6XRJV6 xrK+wmlqtX8M95BVgnyjHQPip7r8fXI= From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 10/10] autogen.sh: fix autoreconf step Date: Fri, 17 Jan 2020 16:00:17 +0100 Message-Id: <1afee1b042cbde09de8bb489cdd5da1d8ebf418c.1579272954.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 0OUQEVupN4-gw-i8c4uRmw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Running bootstrap and autoreconf from autogen.sh produced different files in build-aux directory. The reason is that gnulib usually have newer version of these files and overwrites them after the autoreconf step. In order to fix it remove the --install and --force options, in addition introduce --verbose option in order to reflect what bootstrap is doing. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index a1f1943adb..47446dc785 100755 --- a/autogen.sh +++ b/autogen.sh @@ -134,7 +134,7 @@ if test -d .git || test -f .git; then # dry run, of course... if test -z "$dry_run"; then echo "Running autoreconf..." - autoreconf -if || { + autoreconf -v || { die "autoreconf failed" } fi --=20 2.23.0