From nobody Mon Apr 29 06:38:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578320719; cv=none; d=zohomail.com; s=zohoarc; b=jTeQ/vXHwrcCjOUicuuiLtxM1kHhzwr0YrWxbxrdhRjOeqjP1e4gw75o99Lu8H5VDIu2dt7+l8iVh0TuVclatpCdyl/l7ghQ+j1zXZ5e02uc4TORvojlR5lK9Ua2HX4VIOH7KSHuoI3fHwvpfUaSiDd+4MEIHF/Y4aADQYOrqiM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578320719; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=i1/ITo8//LtVmdK41+lvG+T4Mye/KoNGWvpZvVtHFDE=; b=XQa9a/M6mfLvM/ViL8f5Eif31ILREo4ngKVorEzJ3RX02Vbp35tPNdu6B8E0SqGeOb0mr2wE0d3P7bjZuCxPO/AyITxJKaCYXRbsTZncyFDFjPZglDypc5siD4/nwTuPw7AEnuFCfmdGG97OwOsmejmZuNhgxQGUmaPBtERYdwg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1578320719764939.4918303394516; Mon, 6 Jan 2020 06:25:19 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-PR2PHJodM62XOPqGoNNLVw-1; Mon, 06 Jan 2020 09:25:15 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1E642100551C; Mon, 6 Jan 2020 14:25:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2D907DB3E; Mon, 6 Jan 2020 14:25:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 930F11803C42; Mon, 6 Jan 2020 14:25:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 006EP3Fl009716 for ; Mon, 6 Jan 2020 09:25:03 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8510E7C00E; Mon, 6 Jan 2020 14:25:03 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C3D77C00D for ; Mon, 6 Jan 2020 14:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578320718; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=i1/ITo8//LtVmdK41+lvG+T4Mye/KoNGWvpZvVtHFDE=; b=Skr0lggJl2VOPDxJ+LqvnZiC8fkmeQFxGJ6rZr8vpzY/1QAKZs7u8Dub3YAFvaCCaPk54n zYapo6Pzc6k0sIGvEUZysftu8SBoA3pGI9CgY9xdlWwsRDhf4CtigALqaYcFr+JnHt2tyr zW0tYALaxilAg6cyHkVw7CxpaW+SGqA= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 6 Jan 2020 15:25:57 +0100 Message-Id: <92a61f86d2347f75982efc11a4e6a4dd7a0e5237.1578320661.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/9] build: error out when check-augeas fails X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: PR2PHJodM62XOPqGoNNLVw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Fixes: 2ffbdabb859594256d45c1b48521dd6501629852 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index f3d4c28c6d..c9b5eeba47 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -342,7 +342,7 @@ check-augeas: $(augeas_DATA) $(augeastest_DATA) FILE=3D$$(basename "$$f"); \ "$(AUGPARSE)" \ -I "$(srcdir)/$$DIR" -I "$(builddir)/$$DIR" \ - "$$DIR/$$FILE"; \ + "$$DIR/$$FILE" || exit 1; \ done; \ fi .PHONY: check-augeas --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 06:38:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578320714; cv=none; d=zohomail.com; s=zohoarc; b=AqGreUpaRsZyfqHbtI4jvxd5mYANRYooqTvFoD1ESDe5ltRYRJd0L5v4ClYbU4TMjy9ZQM6q962ZUdPMuUzQl4l98lIPHbqTjZ80bTT4GvDRXoWVDytMXr5cLcN3yznpiovrFAphnmPWaSwqZMbRa4K2ZbSxMPhLicLf/b7PuPw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578320714; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ftPk3TK7/XPlaDQ9cDhm4OLDVsnyPigelJ33jFqbIdU=; b=AypG1ixRNBqTMJ3excRUTQHU03PYviQkKIr7xCGKFGkxx0NP8vRurJgUlRLysSNj/5QQjlbFdKcjzUx9IhtSmneoELnk3G3mMGxcWp4smwQTl9peR9yEcQ35MA+vjE2dEkX0BbA8oGj9jcF3f+1gzYaHDXCJUT+JYbUJuZc6LZ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1578320714947955.8717725496437; Mon, 6 Jan 2020 06:25:14 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-0m7A378BMIKSsqYHOFas0Q-1; Mon, 06 Jan 2020 09:25:11 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 70D64801E72; Mon, 6 Jan 2020 14:25:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3797B5D9CA; Mon, 6 Jan 2020 14:25:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CC96681C73; Mon, 6 Jan 2020 14:25:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 006EP4GJ009727 for ; Mon, 6 Jan 2020 09:25:04 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5A0781BC6D; Mon, 6 Jan 2020 14:25:04 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id D462C7C00D for ; Mon, 6 Jan 2020 14:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578320713; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ftPk3TK7/XPlaDQ9cDhm4OLDVsnyPigelJ33jFqbIdU=; b=cunKglaQoisWyk8dNMa6xOQYDakVRN1fUGLawhWk1RI6itE1d8TaT0GY0SKuIwhu5nrsna BkqhjiPVI/DTh3Np9g15h0nRN38zIAUGL1HVkpO1hK+T1jSrXxzN/8Ma5ThTQQ2cI3TX6A AJVsVD6US8G2hpDQq5E5QHduGsokjVI= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 6 Jan 2020 15:25:58 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/9] qemu: rename gluster_debug_entry X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 0m7A378BMIKSsqYHOFas0Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Remove the 'gluster' part and decouple the return from the gluster_debug_level parsing to allow adding more options to this section. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/libvirtd_qemu.aug | 4 ++-- src/qemu/qemu_conf.c | 11 +++++++---- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index 86bea2a32a..557b6f38f8 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -115,7 +115,7 @@ module Libvirtd_qemu =3D =20 let nvram_entry =3D str_array_entry "nvram" =20 - let gluster_debug_level_entry =3D int_entry "gluster_debug_level" + let debug_level_entry =3D int_entry "gluster_debug_level" =20 let memory_entry =3D str_entry "memory_backing_dir" =20 @@ -152,7 +152,7 @@ module Libvirtd_qemu =3D | network_entry | log_entry | nvram_entry - | gluster_debug_level_entry + | debug_level_entry | memory_entry | vxhs_entry | nbd_entry diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index c07a844dfc..b62dd1df52 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -796,10 +796,13 @@ virQEMUDriverConfigLoadNVRAMEntry(virQEMUDriverConfig= Ptr cfg, =20 =20 static int -virQEMUDriverConfigLoadGlusterDebugEntry(virQEMUDriverConfigPtr cfg, - virConfPtr conf) +virQEMUDriverConfigLoadDebugEntry(virQEMUDriverConfigPtr cfg, + virConfPtr conf) { - return virConfGetValueUInt(conf, "gluster_debug_level", &cfg->glusterD= ebugLevel); + if (virConfGetValueUInt(conf, "gluster_debug_level", &cfg->glusterDebu= gLevel) < 0) + return -1; + + return 0; } =20 =20 @@ -1014,7 +1017,7 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfigPt= r cfg, if (virQEMUDriverConfigLoadNVRAMEntry(cfg, conf, privileged) < 0) return -1; =20 - if (virQEMUDriverConfigLoadGlusterDebugEntry(cfg, conf) < 0) + if (virQEMUDriverConfigLoadDebugEntry(cfg, conf) < 0) return -1; =20 if (virQEMUDriverConfigLoadSecurityEntry(cfg, conf, privileged) < 0) --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 06:38:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578320764; cv=none; d=zohomail.com; s=zohoarc; b=JGy449wowJS6XVc8Ei+nHHbDrHQ7LCKzfENhPpuJmvhE4vhDrypoKZnI8O53O5j5d/bpZeBDCuSFrMMenqpKIYJ1eZfo+digxSEOmVnk/d6pB9tGldZBODyGW0QVwJyoOhiUElpRuAoFEhRld0ZLMmWbu/DDMtphXlzN90Big0E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578320764; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x5O7CcDh7oyvxK0CWGIZfHKMQyq08Qai4+nmAlqnCRw=; b=SPlCfCiUlG5WeAUtyYGDTim23rBUEY5s6E1jmXUhVzCOjTp470lBqku+j2p0/tDX59vRdk9u8no7Ma0yQ8E8CI0w5bhLIrbC4A3y4XeIVzSiuaT2uwTA2qmVoVBw66hUheVAOMlBMSYE10oIjhzxmHch2yGBRbaaAfTPT+fwleI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1578320764120721.889950010062; Mon, 6 Jan 2020 06:26:04 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-Ne5ctSsjPLyUvt4xjWG2sg-1; Mon, 06 Jan 2020 09:25:18 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37879801E77; Mon, 6 Jan 2020 14:25:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C43510840FF; Mon, 6 Jan 2020 14:25:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A7A5A81C76; Mon, 6 Jan 2020 14:25:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 006EP5Zr009739 for ; Mon, 6 Jan 2020 09:25:05 -0500 Received: by smtp.corp.redhat.com (Postfix) id 2B2DF7BA50; Mon, 6 Jan 2020 14:25:05 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id A663C1BC6D for ; Mon, 6 Jan 2020 14:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578320762; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=x5O7CcDh7oyvxK0CWGIZfHKMQyq08Qai4+nmAlqnCRw=; b=W+EuqAAEAbNE6pSWt/1xGXDgy0fkA0Ls05keg1+/emD9qdcT9RZNw62XY/5RormFSnvTDp T+Ei4lWABoBO1OF5JzHoEHE4PuFjVxOmCEbpqzrWBVNbBFOmE+/94CwQqu52GDS1aOVd9Z D0X2+mtjCIamb+Z+5z8iklHwhG2mc1Q= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 6 Jan 2020 15:25:59 +0100 Message-Id: <86bce6746b6e6c008c13752dcded0a6532a7a3d0.1578320661.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/9] conf: add xmlopt to virDomainFSDefNew X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: Ne5ctSsjPLyUvt4xjWG2sg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) This will be needed in the future for allocating private data. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- src/conf/domain_conf.c | 4 ++-- src/conf/domain_conf.h | 2 +- src/lxc/lxc_native.c | 2 +- src/lxc/lxc_process.c | 2 +- src/openvz/openvz_conf.c | 2 +- src/vmx/vmx.c | 2 +- src/vz/vz_sdk.c | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ee33b7caf0..400467f9c0 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2279,7 +2279,7 @@ virDomainControllerIsPSeriesPHB(const virDomainContro= llerDef *cont) =20 =20 virDomainFSDefPtr -virDomainFSDefNew(void) +virDomainFSDefNew(virDomainXMLOptionPtr xmlopt G_GNUC_UNUSED) { virDomainFSDefPtr ret; =20 @@ -11127,7 +11127,7 @@ virDomainFSDefParseXML(virDomainXMLOptionPtr xmlopt, =20 ctxt->node =3D node; =20 - if (!(def =3D virDomainFSDefNew())) + if (!(def =3D virDomainFSDefNew(xmlopt))) return NULL; =20 type =3D virXMLPropString(node, "type"); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index e012975fca..8f97b53b69 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2866,7 +2866,7 @@ virDomainControllerDefPtr virDomainControllerDefNew(v= irDomainControllerType type void virDomainControllerDefFree(virDomainControllerDefPtr def); bool virDomainControllerIsPSeriesPHB(const virDomainControllerDef *cont); =20 -virDomainFSDefPtr virDomainFSDefNew(void); +virDomainFSDefPtr virDomainFSDefNew(virDomainXMLOptionPtr xmlopt); void virDomainFSDefFree(virDomainFSDefPtr def); void virDomainActualNetDefFree(virDomainActualNetDefPtr def); virDomainVsockDefPtr virDomainVsockDefNew(virDomainXMLOptionPtr xmlopt); diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index e9b83653b5..dd2345c324 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -59,7 +59,7 @@ lxcCreateFSDef(int type, { virDomainFSDefPtr def; =20 - if (!(def =3D virDomainFSDefNew())) + if (!(def =3D virDomainFSDefNew(NULL))) return NULL; =20 def->type =3D type; diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 487a085b7e..0a9ccdf9ec 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -1138,7 +1138,7 @@ virLXCProcessEnsureRootFS(virDomainObjPtr vm) if (root) return 0; =20 - if (!(root =3D virDomainFSDefNew())) + if (!(root =3D virDomainFSDefNew(NULL))) goto error; =20 root->type =3D VIR_DOMAIN_FS_TYPE_MOUNT; diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index c4c6dec2f7..32696c675e 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -340,7 +340,7 @@ openvzReadFSConf(virDomainDefPtr def, veid); goto error; } else if (ret > 0) { - if (!(fs =3D virDomainFSDefNew())) + if (!(fs =3D virDomainFSDefNew(NULL))) goto error; =20 fs->type =3D VIR_DOMAIN_FS_TYPE_TEMPLATE; diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 2afb0b2823..aa88dfcb5d 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2465,7 +2465,7 @@ int virVMXParseFileSystem(virConfPtr conf, int number= , virDomainFSDefPtr *def) if (!(present && enabled)) return 0; =20 - if (!(*def =3D virDomainFSDefNew())) + if (!(*def =3D virDomainFSDefNew(NULL))) return -1; =20 (*def)->type =3D VIR_DOMAIN_FS_TYPE_MOUNT; diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index c98542c244..f13f8a81b3 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -825,7 +825,7 @@ prlsdkAddDomainHardDisksInfo(vzDriverPtr driver, PRL_HA= NDLE sdkdom, virDomainDef if (IS_CT(def) && prlsdkInBootList(sdkdom, hdd)) { =20 - if (!(fs =3D virDomainFSDefNew())) + if (!(fs =3D virDomainFSDefNew(NULL))) goto error; =20 if (prlsdkGetFSInfo(hdd, fs) < 0) --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 06:38:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578320717; cv=none; d=zohomail.com; s=zohoarc; b=l6k1OxM5W9CZGfC1oPIweJUgMJvzRLVLZdzKLGg7Nv5GNVBz+VgfoinOuixYOV3o+Dc3qiJYBi/4dqDaHHqwrgZdggKMXMbwbJGYIaibJ+/EHQkig7wP6ewIHBJpTmMFmQ2qPDsTvtMTtfnmxGBSmsYDkF91TlsoVix3kjkKpa8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578320717; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JFiWq8AriDM3aXqhHBIv2nlR03rt+/ki4sKjsQKMAY0=; b=Or/gP/dNPeWHxaA0uXFiTAxBQMyZ2nb79YX9Vpsc7M4xXK/JilsZrZdGA02Pa9dUqUD54B6W/k6Xhkct4ZJIQEh7stZqqnidDbnTzy3Wufg0jCgqLMe4Yq7SYQYzgYyzOJWNSd49Jc1aYqUhNg7H2j4wOCP60dx4zEdqkR1kvoo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1578320717232995.9227751112614; Mon, 6 Jan 2020 06:25:17 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-4i0yHcVSPF6v7HMB6Km9uA-1; Mon, 06 Jan 2020 09:25:13 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 973DEDC2C; Mon, 6 Jan 2020 14:25:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D5AB7C00A; Mon, 6 Jan 2020 14:25:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0BA2D1803C38; Mon, 6 Jan 2020 14:25:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 006EP51x009747 for ; Mon, 6 Jan 2020 09:25:06 -0500 Received: by smtp.corp.redhat.com (Postfix) id F10E777FFD; Mon, 6 Jan 2020 14:25:05 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7890B7C00A for ; Mon, 6 Jan 2020 14:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578320716; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JFiWq8AriDM3aXqhHBIv2nlR03rt+/ki4sKjsQKMAY0=; b=Hajc7Ljo5kSFTgmAV2U2/WYaF98kBDvaE3+BXezgkM4UGzia9atBlYfYzTfvOBIaTLxdQt EqR69bY+yxA4f2OPKR7XezBU0iWLsH4u+sBzR0tG/F8U3A6y4QsOwru7nxqUAW5GswzIsZ JZ3MEjuQnf0kZxkodvNhQ/bpmJUQTwM= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 6 Jan 2020 15:26:00 +0100 Message-Id: <999d9f5c0876c583c4ef369cd91036aed9cb224b.1578320661.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/9] conf: add private data to virDomainFSDef X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 4i0yHcVSPF6v7HMB6Km9uA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Add an object to hold the private data and call the allocation function if it's present in xmlopt. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- src/conf/domain_conf.c | 7 ++++++- src/conf/domain_conf.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 400467f9c0..7d1dd717c2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2279,7 +2279,7 @@ virDomainControllerIsPSeriesPHB(const virDomainContro= llerDef *cont) =20 =20 virDomainFSDefPtr -virDomainFSDefNew(virDomainXMLOptionPtr xmlopt G_GNUC_UNUSED) +virDomainFSDefNew(virDomainXMLOptionPtr xmlopt) { virDomainFSDefPtr ret; =20 @@ -2289,6 +2289,11 @@ virDomainFSDefNew(virDomainXMLOptionPtr xmlopt G_GNU= C_UNUSED) if (!(ret->src =3D virStorageSourceNew())) goto cleanup; =20 + if (xmlopt && + xmlopt->privateData.fsNew && + !(ret->privateData =3D xmlopt->privateData.fsNew())) + goto cleanup; + return ret; =20 cleanup: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 8f97b53b69..c177623c47 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -817,6 +817,7 @@ struct _virDomainFSDef { unsigned long long space_soft_limit; /* in bytes */ bool symlinksResolved; virDomainVirtioOptionsPtr virtio; + virObjectPtr privateData; }; =20 =20 @@ -2740,6 +2741,7 @@ struct _virDomainXMLPrivateDataCallbacks { virDomainXMLPrivateDataNewFunc graphicsNew; virDomainXMLPrivateDataNewFunc networkNew; virDomainXMLPrivateDataNewFunc videoNew; + virDomainXMLPrivateDataNewFunc fsNew; virDomainXMLPrivateDataFormatFunc format; virDomainXMLPrivateDataParseFunc parse; /* following function shall return a pointer which will be used as the --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 06:38:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578320766; cv=none; d=zohomail.com; s=zohoarc; b=ffBkuHg6FCeVF7WrDv3pdeVxivPEwxWu2LEWWIXmXOqn+6Xa4m2nbPG/ag9+i48UMN32xt8QZrHO36Q3sa5fTgLdSOUweAIiPClhI/7laN0aMLjLLJE4p4g320seF3JjSJtkJF4D6K9ZZ0job1hterR6b6haPQl6nDLRmylaYP8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578320766; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pleLvTWv9i25oRGRScNWOILNKFah0wgVmUieuRO+SIg=; b=WUJOInjMXAZWt/7+r5kGpheaXk8yRxhOjxvC/ApsVbP9zMH2xhc4nLHRY7RHtZtbaJXVhvOjfT0Knv9YOSo4UAagKMV0QETy+yxueZD3LlC/xM73lfBzidSsctrCqqjxBQC2hfH9tZThzecsmXkDNPwFCsX6ykxXlm+LFkJNR5Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1578320766298790.2854186036144; Mon, 6 Jan 2020 06:26:06 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271-gbtxLRDPO8-E5FFpxMXQjw-1; Mon, 06 Jan 2020 09:25:23 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BBF9DC22; Mon, 6 Jan 2020 14:25:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47F547DB5C; Mon, 6 Jan 2020 14:25:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 03E4C1803C43; Mon, 6 Jan 2020 14:25:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 006EP6iI009754 for ; Mon, 6 Jan 2020 09:25:06 -0500 Received: by smtp.corp.redhat.com (Postfix) id C25F077FFD; Mon, 6 Jan 2020 14:25:06 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B2031BC6D for ; Mon, 6 Jan 2020 14:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578320765; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=pleLvTWv9i25oRGRScNWOILNKFah0wgVmUieuRO+SIg=; b=D9cmSFTyWcqDZvdZVpXKR1jGnRt3ILuJ8l7nQnO4qAqicoKKNq5fWzTaIP3rgLzhGsEcXN 9BGake9o+0KPWheUx+mJ8b0UCMamgaWFds+blgd9+ETCFaorczZ8kHkjELnoEPvy87p0Gv UYe/WCVDiV+r22u1Jg4/Tz0pHD4L0t4= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 6 Jan 2020 15:26:01 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 5/9] qemu: add private data to virDomainFSDef X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: gbtxLRDPO8-E5FFpxMXQjw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Wire up the allocation and disposal of private data. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_domain.c | 38 ++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_domain.h | 12 ++++++++++++ 2 files changed, 50 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 065c9e97a9..87741659ad 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1407,6 +1407,43 @@ qemuDomainNetworkPrivateDispose(void *obj G_GNUC_UNU= SED) } =20 =20 +static virClassPtr qemuDomainFSPrivateClass; +static void qemuDomainFSPrivateDispose(void *obj); + + +static int +qemuDomainFSPrivateOnceInit(void) +{ + if (!VIR_CLASS_NEW(qemuDomainFSPrivate, virClassForObject())) + return -1; + + return 0; +} + + +VIR_ONCE_GLOBAL_INIT(qemuDomainFSPrivate); + + +static virObjectPtr +qemuDomainFSPrivateNew(void) +{ + qemuDomainFSPrivatePtr priv; + + if (qemuDomainFSPrivateInitialize() < 0) + return NULL; + + if (!(priv =3D virObjectNew(qemuDomainFSPrivateClass))) + return NULL; + + return (virObjectPtr) priv; +} + + +static void +qemuDomainFSPrivateDispose(void *obj G_GNUC_UNUSED) +{ +} + static virClassPtr qemuDomainVideoPrivateClass; static void qemuDomainVideoPrivateDispose(void *obj); =20 @@ -3865,6 +3902,7 @@ virDomainXMLPrivateDataCallbacks virQEMUDriverPrivate= DataCallbacks =3D { .graphicsNew =3D qemuDomainGraphicsPrivateNew, .networkNew =3D qemuDomainNetworkPrivateNew, .videoNew =3D qemuDomainVideoPrivateNew, + .fsNew =3D qemuDomainFSPrivateNew, .parse =3D qemuDomainObjPrivateXMLParse, .format =3D qemuDomainObjPrivateXMLFormat, .getParseOpaque =3D qemuDomainObjPrivateXMLGetParseOpaque, diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index c93bdf4099..c6afc484f6 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -560,6 +560,18 @@ struct _qemuDomainNetworkPrivate { }; =20 =20 +#define QEMU_DOMAIN_FS_PRIVATE(dev) \ + ((qemuDomainFSPrivatePtr) (dev)->privateData) + +typedef struct _qemuDomainFSPrivate qemuDomainFSPrivate; +typedef qemuDomainFSPrivate *qemuDomainFSPrivatePtr; +struct _qemuDomainFSPrivate { + virObject parent; + + int dummy; +}; + + typedef enum { QEMU_PROCESS_EVENT_WATCHDOG =3D 0, QEMU_PROCESS_EVENT_GUESTPANIC, --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 06:38:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578320731; cv=none; d=zohomail.com; s=zohoarc; b=eE1oieSdjKaHB+SR/lTabsSOuvPhq7k/gTeyuqVt07BpOWQVGcvKFCg1M9NMBDbbMuAge1jPvUFsQPw8n6TYW7WoGNirV1reXD6xuP8QEuP5tjIQvkzjgJsgLi2usiIyvXZAOokNJFCHX6LLgV47mTJYHSDqQuGPnjXyyXSOSHM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578320731; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3PPCJPeSnw6X1oAA17R/2ncb4I+/8S5rTJ+aFOPh85s=; b=YFMrIwIvTvj0JQL0QHRthLVOUiAlJUtTIAiWAIy73+lAbfKJKwmsMeHeedOgDvybaRvfH0YiJ6eJb8a2d5IO62Es5DJ4bc++rQHTZej8yBmIAZc2gwKc4PZL0t2u+1SPtHxwd0eBBfXcRNdmWsVDFdie00eF8EQFWMOkFdUgu7k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1578320731512398.31832415947315; Mon, 6 Jan 2020 06:25:31 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-13-KWPTZf3VN5ag5--HSA_5qw-1; Mon, 06 Jan 2020 09:25:29 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DD550DC24; Mon, 6 Jan 2020 14:25:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4F0B7C012; Mon, 6 Jan 2020 14:25:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6F6AB18034E9; Mon, 6 Jan 2020 14:25:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 006EP73X009759 for ; Mon, 6 Jan 2020 09:25:07 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9400A7C00D; Mon, 6 Jan 2020 14:25:07 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C8DF77FFD for ; Mon, 6 Jan 2020 14:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578320730; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3PPCJPeSnw6X1oAA17R/2ncb4I+/8S5rTJ+aFOPh85s=; b=LudScFZxggIOxioO0U2QJorzUoLSGOy0hB50MzBuJPiUxbLFoMJ/3/WOw3CmPeFbdCfLqV oBq+sin4oXtXGli5ANfJcZxIofweqwkuMW+ajqv0CWLIRxSqJeiOmQ8Ebr0Uxo6DHf7zvt PB18lnLeZ+Xfd1VoRCXi9pebbeaLkg8= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 6 Jan 2020 15:26:02 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 6/9] qemu: pass private data to qemuBuildFilesystemCommandLine X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: KWPTZf3VN5ag5--HSA_5qw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) This will be used by a future patch. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_command.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 11d3c29297..3b18282de4 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2678,7 +2678,8 @@ qemuBuildFSDevCommandLine(virCommandPtr cmd, static int qemuBuildFilesystemCommandLine(virCommandPtr cmd, const virDomainDef *def, - virQEMUCapsPtr qemuCaps) + virQEMUCapsPtr qemuCaps, + qemuDomainObjPrivatePtr priv G_GNUC_UNUSED) { size_t i; =20 @@ -9869,7 +9870,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver, if (qemuBuildDisksCommandLine(cmd, def, qemuCaps) < 0) return NULL; =20 - if (qemuBuildFilesystemCommandLine(cmd, def, qemuCaps) < 0) + if (qemuBuildFilesystemCommandLine(cmd, def, qemuCaps, priv) < 0) return NULL; =20 if (qemuBuildNetCommandLine(driver, vm, logManager, secManager, cmd, --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 06:38:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578320828; cv=none; d=zohomail.com; s=zohoarc; b=mZRT0pUdWsxWzC8WfdIxV1KJO4MRkdms+Y1m1GhPaHMEhIqHbnV8wabQnPFrImz0yOB0gyWjWjjjRjTMTe51P6vbQajrZSysWvjFuu4sELU9PqcGPW1PQFVr0T57a8GSTIhD0M0jqK8Q3rIB94SaNiFsR1RZpICrTfVmR6u6Y18= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578320828; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DML18E2gBsnngLeAu3VvcjmUtXLIUht81d7dkpmQUgg=; b=ah3+86r/KgKTNlwJTJbg+lQZZAoder2aQZRFVVxGKjDu+0NSQhGpYfrv64YXaSyc3z3sVU1PDQ9XpsKX93Dwqfcf30EUny7fosYhDIDVYYEjhTMzfufW56i9DJmMQtjfilChlIoywhlFR8UyPT0dfDS/szUuxRFpEYWN8T/MU+w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1578320828811579.993526179628; Mon, 6 Jan 2020 06:27:08 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-2bxGj-daOG2ZmNGQQrJsbQ-1; Mon, 06 Jan 2020 09:25:28 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2ADFF800D53; Mon, 6 Jan 2020 14:25:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E234D60F82; Mon, 6 Jan 2020 14:25:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9934D18034EE; Mon, 6 Jan 2020 14:25:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 006EP8hH009770 for ; Mon, 6 Jan 2020 09:25:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id 65FEB7C00D; Mon, 6 Jan 2020 14:25:08 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0E071BC6D for ; Mon, 6 Jan 2020 14:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578320827; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DML18E2gBsnngLeAu3VvcjmUtXLIUht81d7dkpmQUgg=; b=eEJH2BcId+Bj7fciyVlS36nFm+D3P/JlO3gq3+w81qsRg5IYbCIKkoSldMaI4uXpbhtCos A5FOUHm8v7NWxZzgEQ/fEk6mTUl1jaEASb1EUSxw/pCD0WmplxD5GiSXsRGZ69TaasUytU eDhp25yEw2uUwwGh+O1wsCCD/ORwFCc= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 6 Jan 2020 15:26:03 +0100 Message-Id: <5ee658e099010db142ae4f5f41ad21d2ecdd4d5a.1578320661.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 7/9] qemu: address: take fsdriver type into account X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 2bxGj-daOG2ZmNGQQrJsbQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Split the switch by fsdriver type to allow adding a new one. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_domain_address.c | 34 +++++++++++++++++++++++----------- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index b077240899..de91c07e0a 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -672,18 +672,30 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDev= iceDefPtr dev, break; =20 case VIR_DOMAIN_DEVICE_FS: - /* the only type of filesystem so far is virtio-9p-pci */ - switch ((virDomainFSModel) dev->data.fs->model) { - case VIR_DOMAIN_FS_MODEL_VIRTIO_TRANSITIONAL: - /* Transitional devices only work in conventional PCI slots */ - return pciFlags; - case VIR_DOMAIN_FS_MODEL_VIRTIO: - case VIR_DOMAIN_FS_MODEL_VIRTIO_NON_TRANSITIONAL: - case VIR_DOMAIN_FS_MODEL_DEFAULT: - return virtioFlags; - case VIR_DOMAIN_FS_MODEL_LAST: - break; + switch ((virDomainFSDriverType) dev->data.fs->fsdriver) { + case VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT: + case VIR_DOMAIN_FS_DRIVER_TYPE_PATH: + case VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE: + /* these drivers are handled by virtio-9p-pci */ + switch ((virDomainFSModel) dev->data.fs->model) { + case VIR_DOMAIN_FS_MODEL_VIRTIO_TRANSITIONAL: + /* Transitional devices only work in conventional PCI slot= s */ + return pciFlags; + case VIR_DOMAIN_FS_MODEL_VIRTIO: + case VIR_DOMAIN_FS_MODEL_VIRTIO_NON_TRANSITIONAL: + case VIR_DOMAIN_FS_MODEL_DEFAULT: + return virtioFlags; + case VIR_DOMAIN_FS_MODEL_LAST: + break; + } + + case VIR_DOMAIN_FS_DRIVER_TYPE_LOOP: + case VIR_DOMAIN_FS_DRIVER_TYPE_NBD: + case VIR_DOMAIN_FS_DRIVER_TYPE_PLOOP: + case VIR_DOMAIN_FS_DRIVER_TYPE_LAST: + return 0; } + return 0; =20 case VIR_DOMAIN_DEVICE_NET: { --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 06:38:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578320731; cv=none; d=zohomail.com; s=zohoarc; b=iISKuNAMqwhLnZBUhsCdcq2SIFrvssvptj0mrfpzWO7WIsHxsy3ABOLOlkIjugOjRb82LaRuStiY+U8YC5/NcDoXd18HsLHXKlmgSEPA9Y7PgJSJa7vQXnt3qNOLF+k/Qb5h/vtDA6OwoTrrkU4de+jB5k+1vQ3T+M0lGDI09m8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578320731; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CALrOgTTY1DMjqzLzhCg2AFGXKyDTgPBL1DGovcAdQk=; b=bbHO5LGdm9EgFUvv8HDuHvHPNRPQllc00pYeul2cdbOGTPhA/qT02SVrztKaCID/Jm/CfR0jC4z5WdbAemkLoX/FShT3B8bnV62nUs5ceKOxFYRP9th+GqdV5MMu+Tle2hVxVd/brxC2zcoi1GaDOX1rsjhUu1SHPg1gzp6cnaA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1578320731675647.9858537841814; Mon, 6 Jan 2020 06:25:31 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-HEf4UOUPPiq4y0MsygseEA-1; Mon, 06 Jan 2020 09:25:25 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7AB6B800D4C; Mon, 6 Jan 2020 14:25:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5837C5DA70; Mon, 6 Jan 2020 14:25:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1785581C7A; Mon, 6 Jan 2020 14:25:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 006EP9bt009790 for ; Mon, 6 Jan 2020 09:25:09 -0500 Received: by smtp.corp.redhat.com (Postfix) id 364267BA50; Mon, 6 Jan 2020 14:25:09 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id B314E1BC6D for ; Mon, 6 Jan 2020 14:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578320730; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=CALrOgTTY1DMjqzLzhCg2AFGXKyDTgPBL1DGovcAdQk=; b=R4cSjlt+IcpmCnQUJc+vAQyH3zBKPF3QE15nwPyG3+tygP4f+EoBMkZ3WYKmN6/C+UwAQH cx4FJVXMPhmKjZnztiNIBHZ3wXNrt/1dtLOOKGeq3Q4yurKRhOeY2VQXn2GX+riTAitx0S zYGkpFbGf7zoKNde13UnoJoVpg5pXD4= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 6 Jan 2020 15:26:04 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 8/9] qemu: command: take fsdriver type into account X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: HEf4UOUPPiq4y0MsygseEA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Split the formatting by fsdriver type to allow adding a new type. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_command.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 3b18282de4..90236620a1 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2684,8 +2684,21 @@ qemuBuildFilesystemCommandLine(virCommandPtr cmd, size_t i; =20 for (i =3D 0; i < def->nfss; i++) { - if (qemuBuildFSDevCommandLine(cmd, def->fss[i], def, qemuCaps) < 0) - return -1; + switch ((virDomainFSDriverType) def->fss[i]->fsdriver) { + case VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT: + case VIR_DOMAIN_FS_DRIVER_TYPE_PATH: + case VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE: + /* these drivers are handled by virtio-9p-pci */ + if (qemuBuildFSDevCommandLine(cmd, def->fss[i], def, qemuCaps)= < 0) + return -1; + break; + + case VIR_DOMAIN_FS_DRIVER_TYPE_LOOP: + case VIR_DOMAIN_FS_DRIVER_TYPE_NBD: + case VIR_DOMAIN_FS_DRIVER_TYPE_PLOOP: + case VIR_DOMAIN_FS_DRIVER_TYPE_LAST: + break; + } } =20 return 0; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 06:38:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578320723; cv=none; d=zohomail.com; s=zohoarc; b=GKJavAseUrf4bZqAOKyW6MrQEK12ZYZLF/qQ7RNDnwPJPA7Ku1BPg9crXtZ87u4nwZBbs3AglByaNmRkOhqZKxQqHOtc1y69GTp3JOC7bWYHUrm9flnYu79JbBPcLguyt/iGAf3ULL+0ponwNCg/7oGn50/B+jQ6VfcCqCvlkJg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578320723; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Bkzbmae+laK2OGHSPlM2NEDCap5SG8+NZu4KKOPN5E4=; b=Olqtssje5r/ck874LnRdXWE2VpZ7XhL7LSwfLotr+R+Ln37zsK8J6K0i7sRqRGiTUxG/nmhhttUl27jaJb3VJdmulb1AZGaYXlcf3nILh0wfv9cATTtdED7EcKaIAuJ1IaZUlHq4fcWP5k/7mC8DEm/+JiOj42AZZZwzAWH1RUI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1578320723118568.3234866057795; Mon, 6 Jan 2020 06:25:23 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-r3uqG2jePxW942ykxRS8Ig-1; Mon, 06 Jan 2020 09:25:19 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E27A5800D5B; Mon, 6 Jan 2020 14:25:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB0F31D3; Mon, 6 Jan 2020 14:25:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6EC8781C77; Mon, 6 Jan 2020 14:25:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 006EPAJr009797 for ; Mon, 6 Jan 2020 09:25:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id 078501BC6D; Mon, 6 Jan 2020 14:25:10 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 844B17C007 for ; Mon, 6 Jan 2020 14:25:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578320722; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Bkzbmae+laK2OGHSPlM2NEDCap5SG8+NZu4KKOPN5E4=; b=IisV3WL7wJwWhj0ERpP+S+V4uqIM4Qd3DikEhkNHl4ufBGDncCcPz1J1ns0B9Tk20bbJ6h UqULFoE37uxUK5VwQmN6xknw1wURGktH3i59I9qlYeewBt9WvLbWr2Hp7wFnTgIABQJqtU jdF91Ro8mXlKUBs39M6mxodyTTvTiZs= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 6 Jan 2020 15:26:05 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 9/9] docs: formatdomain: use 'element' instead of 'block' X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: r3uqG2jePxW942ykxRS8Ig-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index dd04a05f09..b7910e3742 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3979,7 +3979,7 @@ (since 0.9.13) =20 - The filesystem block has an optional attribute accessmode + The filesystem element has an optional attribute accessmode which specifies the security mode for accessing the source (since 0.8.5). Currently this only works with type=3D'mount' for the QEMU/KVM driver. The possib= le --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list