[libvirt] [PATCH 0/2] tests: VIR_TEST_REGENERATE_OUTPUT fixes

Cole Robinson posted 2 patches 4 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1575901647.git.crobinso@redhat.com
configure.ac      |  1 +
tests/testutils.c | 14 ++------------
2 files changed, 3 insertions(+), 12 deletions(-)
[libvirt] [PATCH 0/2] tests: VIR_TEST_REGENERATE_OUTPUT fixes
Posted by Cole Robinson 4 years, 3 months ago
First fix is straightforward, the test-wrap-argv.py path needs to
be adjusted.

Second bit fixes an issue I hit with:

  VIR_TEST_REGENERATE_OUTPUT=1 ./build/tests/qemuxml2argvtest

Where it reported not finding a python binary. I assume this is due
to some preload PATH alteration, like the comment suggests, but I
didn't investigate it. The patch sidesteps the issue and seems
worth doing anyways

Cole Robinson (2):
  tests: fix REGENERATE test-wrap-argv.py usage
  tests: use PYTHON detected from configure

 configure.ac      |  1 +
 tests/testutils.c | 14 ++------------
 2 files changed, 3 insertions(+), 12 deletions(-)

-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] tests: VIR_TEST_REGENERATE_OUTPUT fixes
Posted by Ján Tomko 4 years, 3 months ago
On Mon, Dec 09, 2019 at 09:30:08AM -0500, Cole Robinson wrote:
>First fix is straightforward, the test-wrap-argv.py path needs to
>be adjusted.
>
>Second bit fixes an issue I hit with:
>
>  VIR_TEST_REGENERATE_OUTPUT=1 ./build/tests/qemuxml2argvtest
>
>Where it reported not finding a python binary. I assume this is due
>to some preload PATH alteration, like the comment suggests, but I
>didn't investigate it.

The real reason is "python" being a symlink - virFindFileInPath
calls virFileIsExecutable which contains a check for S_ISREG.

>The patch sidesteps the issue and seems
>worth doing anyways
>
>Cole Robinson (2):
>  tests: fix REGENERATE test-wrap-argv.py usage
>  tests: use PYTHON detected from configure
>
> configure.ac      |  1 +
> tests/testutils.c | 14 ++------------
> 2 files changed, 3 insertions(+), 12 deletions(-)
>

Yay, less lines!

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list