[libvirt] [PATCH 1/3] lib: Fix documentation for the count field of VIR_DOMAIN_STATS_IOTHREAD

Peter Krempa posted 3 patches 12 weeks ago

[libvirt] [PATCH 1/3] lib: Fix documentation for the count field of VIR_DOMAIN_STATS_IOTHREAD

Posted by Peter Krempa 12 weeks ago
The original implementation used QEMU_ADD_COUNT_PARAM which added the
'count' suffix, but 'cnt' was documented. Fix the documentation to
conform with the original implementation.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/libvirt-domain.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 51fb79cddd..87110036ca 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -11615,11 +11615,11 @@ virConnectGetDomainCapabilities(virConnectPtr conn,
  *
  *     The typed parameter keys are in this format:
  *
- *     "iothread.cnt" - maximum number of IOThreads in the subsequent list
- *                      as unsigned int. Each IOThread in the list will
- *                      will use it's iothread_id value as the <id>. There
- *                      may be fewer <id> entries than the iothread.cnt
- *                      value if the polling values are not supported.
+ *     "iothread.count" - maximum number of IOThreads in the subsequent list
+ *                        as unsigned int. Each IOThread in the list will
+ *                        will use it's iothread_id value as the <id>. There
+ *                        may be fewer <id> entries than the iothread.count
+ *                        value if the polling values are not supported.
  *     "iothread.<id>.poll-max-ns" - maximum polling time in ns as an unsigned
  *                                   long long. A 0 (zero) means polling is
  *                                   disabled.
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/3] lib: Fix documentation for the count field of VIR_DOMAIN_STATS_IOTHREAD

Posted by Ján Tomko 12 weeks ago
On Fri, Nov 29, 2019 at 09:59:26AM +0100, Peter Krempa wrote:
>The original implementation used QEMU_ADD_COUNT_PARAM which added the
>'count' suffix, but 'cnt' was documented. Fix the documentation to
>conform with the original implementation.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/libvirt-domain.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list