From nobody Thu Apr 25 01:47:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574685512; cv=none; d=zohomail.com; s=zohoarc; b=amX/5W1PrQLD1q7o5BETrYnWfp3c+iQjscVMO1DWM51ggmr8fQRBwX5KD8VHyJA4nnI3foPZIJsphadLzyTlPxthZEQfdl/Bt0wA6volt2Fb5CHRi9XoA6t7G3K9mp3d8qIq/6mjkrpZKjuGZPaaMjGIZab3o3BkUHibsGS0H+k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574685512; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x5V6mJvN5YVDXFn2u3Mcdh6oLn/qj8tP/Ko/JOJaxlc=; b=PiuM8lWTMAKEa9ZHl4PRsWreY+7tRXi1SU+hrloSS2oDL4GfB6Fi0T1TqmY5T/B/pPmXP6xHigZhJIfIx4YQAcTy6axX8s8zisR0n2I93CBZZxyaRIXvPmdSZGHvBjvgCTa6Km3okL9vkF5dSajdr6H/NPc/zVmc8S/KJoPmTJA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1574685512895603.562180782793; Mon, 25 Nov 2019 04:38:32 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-oQEHMwygOaWaqirgt0Wcpw-1; Mon, 25 Nov 2019 07:38:26 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C337593A0; Mon, 25 Nov 2019 12:38:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 073AB608A5; Mon, 25 Nov 2019 12:38:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 161174BB65; Mon, 25 Nov 2019 12:38:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAPCcIUm015887 for ; Mon, 25 Nov 2019 07:38:18 -0500 Received: by smtp.corp.redhat.com (Postfix) id ACE705C21B; Mon, 25 Nov 2019 12:38:18 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id AE5215C1D4; Mon, 25 Nov 2019 12:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574685511; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=x5V6mJvN5YVDXFn2u3Mcdh6oLn/qj8tP/Ko/JOJaxlc=; b=E8r3FZZ3egABB9Hq49o+LbqTATLh25+pSV4aut2L8CqXi2ofhIkbCp599+BRFblM0xgOxq VFB+etSOzQWqGTjGQUTLtg7TnvHBjPWT21jOP5c4CeAatlDSbRKgAuBXT/yXSlLP3ikaL0 gz4NmkCZ/je3gNB+XMzv8r7XGCA3jrw= From: Erik Skultety To: libvir-list@redhat.com Date: Mon, 25 Nov 2019 13:38:12 +0100 Message-Id: <6da69fa345b356fec732420a3a07e33b111fef2e.1574685489.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Erik Skultety Subject: [libvirt] [tck PATCH 1/2] scripts: qemu: Fix the disk encryption test description X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: oQEHMwygOaWaqirgt0Wcpw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The original text was a copy-paste from a different test case. Signed-off-by: Erik Skultety Reviewed-by: Daniel P. Berrang=C3=A9 --- scripts/qemu/100-disk-encryption.t | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/scripts/qemu/100-disk-encryption.t b/scripts/qemu/100-disk-enc= ryption.t index 12386ae..2c988ec 100644 --- a/scripts/qemu/100-disk-encryption.t +++ b/scripts/qemu/100-disk-encryption.t @@ -16,13 +16,12 @@ =20 =3Dhead1 NAME =20 -domain/060-persistent-lifecycle.t - Persistent domain lifecycle +domain/100-disk-encryption.t - LUKS disk encryption =20 =3Dhead1 DESCRIPTION =20 -The test case validates the core lifecycle operations on -persistent domains. A persistent domain is one with a -configuration enabling it to be tracked when inactive. +The test case verifies that libvirt is able to both create LUKS encrypted +storage volumes as well as start a domain with such disks assigned. =20 =3Dcut =20 --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 01:47:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574685511; cv=none; d=zohomail.com; s=zohoarc; b=QjWeKflVKGiEQ1yBNchYoHUDRhqKL+52PFRd87ap1LQq/7xRr4aQ0qk1pAbBqGNVnSN+Uz7UrjC4hl62kFTA3lrywsQ+EDAyo4VYNjmZTBihpZwABDqFEWvkD2JzbZx9V2TTSp7wJwUD3tFbNwhsHV9KsAXoEa5Rg5KgZ61MDwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574685511; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=j85BwAS4wXYN8+6eNhuqRnmcn4PXhxXf30axk3Rd+hI=; b=ExOfDsnQ0/MP2K/khdtZjX0MIf0bgzjymZcNzhnD5PTHGnHocxIpRUSbwRGPia5yryIMNQC6r/iun6vKO6ciy/7u2ofeKoThYDTShXLg9Nlbt97ScyI59vq0B5xyA3v7HI5MIN6MOf8ZBPa6l/Qf4MZPjAN3iWs25o/gdX+aUig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 157468551116677.23204526482664; Mon, 25 Nov 2019 04:38:31 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-183-g6qXjHrKMa6T7T4qVA5J6Q-1; Mon, 25 Nov 2019 07:38:27 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 302D5107ACE4; Mon, 25 Nov 2019 12:38:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EEF8460C18; Mon, 25 Nov 2019 12:38:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7FAA34BB78; Mon, 25 Nov 2019 12:38:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAPCcJU8015896 for ; Mon, 25 Nov 2019 07:38:19 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5521E5C1D4; Mon, 25 Nov 2019 12:38:19 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id A75B75C219; Mon, 25 Nov 2019 12:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574685510; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=j85BwAS4wXYN8+6eNhuqRnmcn4PXhxXf30axk3Rd+hI=; b=CqKHRJ/eMZPk2oi6EofCnqOjnD/lFfkW1Gx9+WnVyuXV1b0qvIBwUEJ9mh5RfD7Uvle3Y1 tV9T9c7sZsR/3FG0LXfXcX3S2rbOhvBDgcoj67QeysDZm2IeqhQdBt85jv/dEOWmoARnWD wo7Gb+myF+uVUu8EI1b15YadY1am1lA= From: Erik Skultety To: libvir-list@redhat.com Date: Mon, 25 Nov 2019 13:38:13 +0100 Message-Id: <29eb66ff689266e5fd24ef768b62a5783315aca0.1574685489.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Erik Skultety Subject: [libvirt] [tck PATCH 2/2] scripts: qemu: Enable disk encryption test X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: g6qXjHrKMa6T7T4qVA5J6Q-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" At the time the test was added, volume encryption wasn't fully supported in libvirt. For disks of type 'raw', this is not the case anymore, so let's adjust the test according to that fact and enable it. Signed-off-by: Erik Skultety Reviewed-by: Daniel P. Berrang=C3=A9 --- scripts/qemu/100-disk-encryption.t | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/qemu/100-disk-encryption.t b/scripts/qemu/100-disk-enc= ryption.t index 2c988ec..b44dbc8 100644 --- a/scripts/qemu/100-disk-encryption.t +++ b/scripts/qemu/100-disk-encryption.t @@ -41,10 +41,9 @@ END { $tck->cleanup if $tck; } =20 SKIP: { skip "Only relevant to QEMU driver", 8 unless $conn->get_type() eq "QE= MU"; - skip "Libvirt LUKS support isn't ready", 8; =20 my $dir =3D $tck->bucket_dir("300-disk-encryption"); -my $disk =3D catfile($dir, "demo.qcow2"); +my $disk =3D catfile($dir, "demo.img"); =20 =20 my $secretXML =3D <create_storage_pool($poolXML) }, "pool cre= ated"); =20 =20 -my $volXML =3D Sys::Virt::TCK::StorageVolBuilder->new(name =3D> "demo.qcow= 2") +my $volXML =3D Sys::Virt::TCK::StorageVolBuilder->new(name =3D> "demo.img") ->capacity(1024*1024*1024) - ->format("qcow2") + ->format("raw") ->encryption_format("luks") ->secret($secretUUID) ->as_xml(); @@ -86,7 +85,7 @@ diag "Creating volume $volXML"; lives_ok(sub { $vol =3D $pool->create_volume($volXML) }, "volume created"); =20 my $xml =3D $tck->generic_domain(name =3D> "tck") - ->disk(format =3D> { name =3D> "qemu", type =3D> "qcow2" }, + ->disk(format =3D> { name =3D> "qemu", type =3D> "raw" }, encryption_format =3D> "luks", secret =3D> $secretUUID, type =3D> "file", --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list