[libvirt] [PATCH 00/16] docs: hacking: various modernizations (glib chronicles)

Ján Tomko posted 16 patches 4 years, 5 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1571438015.git.jtomko@redhat.com
docs/hacking.html.in | 169 +++++++++++++++++++++++++++++--------------
1 file changed, 114 insertions(+), 55 deletions(-)
[libvirt] [PATCH 00/16] docs: hacking: various modernizations (glib chronicles)
Posted by Ján Tomko 4 years, 5 months ago
Contemporize the file.

Ján Tomko (16):
  docs: hacking: remove note about rename detection
  docs: hacking: mention git-publish prominently
  docs: hacking: emphasize some sections
  docs: hacking: remove notes about -Werror
  docs: hacking: demonstrate the powers of VIR_TEST_RANGE
  docs: hacking: extend the table of removed libvirt macros
  docs: hacking: mention compiler annotations
  docs: hacking: mention GLib alternatives of libvirt allocation macros
  docs: hacking: mention GLib alternatives of libvirt string allocation
    macros
  docs: hacking: document preferred strdup alternatives
  docs: hacking: document string concatenations
  docs: hacking: remove reference to ATTRIBUTE_FORMAT
  docs: hacking: extend goto documentation
  docs: hacking: amend label indenting rules
  docs: hacking: amend push-without-review rules
  docs: hacking: fix typo

 docs/hacking.html.in | 169 +++++++++++++++++++++++++++++--------------
 1 file changed, 114 insertions(+), 55 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 00/16] docs: hacking: various modernizations (glib chronicles)
Posted by Ján Tomko 4 years, 5 months ago
On Sat, Oct 19, 2019 at 12:36:34AM +0200, Ján Tomko wrote:
>Contemporize the file.
>
>Ján Tomko (16):
>  docs: hacking: remove note about rename detection
>  docs: hacking: mention git-publish prominently
>  docs: hacking: emphasize some sections
>  docs: hacking: remove notes about -Werror
>  docs: hacking: demonstrate the powers of VIR_TEST_RANGE
>  docs: hacking: extend the table of removed libvirt macros
>  docs: hacking: mention compiler annotations
>  docs: hacking: mention GLib alternatives of libvirt allocation macros
>  docs: hacking: mention GLib alternatives of libvirt string allocation
>    macros
>  docs: hacking: document preferred strdup alternatives
>  docs: hacking: document string concatenations
>  docs: hacking: remove reference to ATTRIBUTE_FORMAT
>  docs: hacking: extend goto documentation
>  docs: hacking: amend label indenting rules
>  docs: hacking: amend push-without-review rules
>  docs: hacking: fix typo
>
> docs/hacking.html.in | 169 +++++++++++++++++++++++++++++--------------
> 1 file changed, 114 insertions(+), 55 deletions(-)

Thanks for all the reviews, I dropped the incorrect cc: tag (I had
supresscc enabled), changed the incorrect mentions of g_strcpy to
g_strdup and pushed all the patches except:

  docs: hacking: amend label indenting rules

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 00/16] docs: hacking: various modernizations (glib chronicles)
Posted by Andrea Bolognani 4 years, 5 months ago
On Sat, 2019-10-19 at 00:36 +0200, Ján Tomko wrote:
> Contemporize the file.
> 
> Ján Tomko (16):
>   docs: hacking: remove note about rename detection
>   docs: hacking: mention git-publish prominently
>   docs: hacking: emphasize some sections
>   docs: hacking: remove notes about -Werror
>   docs: hacking: demonstrate the powers of VIR_TEST_RANGE
>   docs: hacking: extend the table of removed libvirt macros
>   docs: hacking: mention compiler annotations
>   docs: hacking: mention GLib alternatives of libvirt allocation macros
>   docs: hacking: mention GLib alternatives of libvirt string allocation
>     macros
>   docs: hacking: document preferred strdup alternatives
>   docs: hacking: document string concatenations
>   docs: hacking: remove reference to ATTRIBUTE_FORMAT
>   docs: hacking: extend goto documentation
>   docs: hacking: amend label indenting rules
>   docs: hacking: amend push-without-review rules
>   docs: hacking: fix typo
> 
>  docs/hacking.html.in | 169 +++++++++++++++++++++++++++++--------------
>  1 file changed, 114 insertions(+), 55 deletions(-)

Aside from the couple of nits pointed out separately, I like how
you thoroughly delegacyzed the file!

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list