From nobody Tue May 7 03:29:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567436904; cv=none; d=zoho.com; s=zohoarc; b=B5Qkfap56OPhtcHLopCqfWkUTTKYPFErAUJ5JuiWpTPuxuYWgE7Vwc22EFUGtNAjxJveWtaMkUmzc7xOeWydE3ECxgCxjsxWZb81t4fA8t+NPuyZrbwCKGR9pPYj41TedsxfCsYLHP5ShKwGPlkbXPvIvQ6DwpirGArYJJxOftg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567436904; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=CAN6BGHmAF1nyRWPa4RbbLbEIhm8vhjD5s986L2ixnQ=; b=YbdOPI9bc3kMS8tFBJvH5V5dyKAax3qHVjE0O/x+xMlv+Gaz5IyrYhElEgb1AU6xFOXa682oPTb/+1ifFSG13GqsJod9SCfVWhG9GEG5ZkPpgA2utOEnL78laxz4rQTtFjr0psRhatIR3xe8f2MKd2Siq0WsXD2p597LW4KsYnw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1567436904685646.8822794623262; Mon, 2 Sep 2019 08:08:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C1C263084212; Mon, 2 Sep 2019 15:08:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D8B81001284; Mon, 2 Sep 2019 15:08:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4CF8C2551C; Mon, 2 Sep 2019 15:08:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x82F8Kob002437 for ; Mon, 2 Sep 2019 11:08:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id A30B75C54A; Mon, 2 Sep 2019 15:08:20 +0000 (UTC) Received: from orkuz.int.mamuti.net (unknown [10.40.205.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 742845C3FA for ; Mon, 2 Sep 2019 15:08:18 +0000 (UTC) Received: by orkuz.int.mamuti.net (Postfix, from userid 500) id 5B61D2A02AE; Mon, 2 Sep 2019 17:08:16 +0200 (CEST) From: Jiri Denemark To: libvir-list@redhat.com Date: Mon, 2 Sep 2019 17:08:13 +0200 Message-Id: <5273319b7e20d417e7c0c9c70b78a4a644d21ab6.1567436624.git.jdenemar@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] virsh: Rename --precopy-bandwidth migration option X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 02 Sep 2019 15:08:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The (pre-copy) bandwidth was historically the only bandwidth we supported and thus it is called just "bandwidth" in all other places. E.g., virsh migrate-setspeed or in the migration typed parameter name. Let's make the new option for virsh migrate consistent. Signed-off-by: Jiri Denemark Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Jim Fehlig --- tools/virsh-domain.c | 6 +++--- tools/virsh.pod | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 201fc176c7..3d26e81b22 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10587,9 +10587,9 @@ static const vshCmdOptDef opts_migrate[] =3D { .type =3D VSH_OT_INT, .help =3D N_("number of connections for parallel migration") }, - {.name =3D "precopy-bandwidth", + {.name =3D "bandwidth", .type =3D VSH_OT_INT, - .help =3D N_("pre-copy migration bandwidth limit in MiB/s") + .help =3D N_("migration bandwidth limit in MiB/s") }, {.name =3D NULL} }; @@ -10805,7 +10805,7 @@ doMigrate(void *opaque) goto save_error; } =20 - if ((rv =3D vshCommandOptULongLong(ctl, cmd, "precopy-bandwidth", &ull= Opt)) < 0) { + if ((rv =3D vshCommandOptULongLong(ctl, cmd, "bandwidth", &ullOpt)) < = 0) { goto out; } else if (rv > 0) { if (virTypedParamsAddULLong(¶ms, &nparams, &maxparams, diff --git a/tools/virsh.pod b/tools/virsh.pod index 0dc3216bc2..59fb4bfc2e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2153,7 +2153,7 @@ I I [I] [I]= [I] [I] [I<--persistent-xml> B] [I<--tls>] [I<--postcopy-bandwidth> B] [I<--parallel> [I<--parallel-connections> B]] -[I<--precopy-bandwidth> B] +[I<--bandwidth> B] =20 Migrate domain to another host. Add I<--live> for live migration; <--p2p> for peer-2-peer migration; I<--direct> for direct migration; or I<--tunnel= led> @@ -2186,7 +2186,7 @@ I<--postcopy-after-precopy> along with I<--postcopy> = to let libvirt automatically switch to post-copy after the first pass of pre-copy is fini= shed. The maximum bandwidth consumed during the post-copy phase may be limited u= sing I<--postcopy-bandwidth>. The maximum bandwidth consumed during the pre-cop= y phase -may be limited using I<--precopy-bandwidth>. +may be limited using I<--bandwidth>. =20 I<--auto-converge> forces convergence during live migration. The initial guest CPU throttling rate can be set with I. If the --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Tue May 7 03:29:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567436912; cv=none; d=zoho.com; s=zohoarc; b=is5pFp5Laenc4WVGIfM29ZFEz4ddNtJNGFxWgAfesymXJxEwv95/RHmWs1y8VKLxx6y7+XwBfM+AA0OCQXDxHkNEqzEFUDKGvoe0PNfyRwyxcyHT7dRaKiBsN6Ip3/L+QZxC0Z/OvokljFMNeH7qbrYpQLtwI7FZeneBNG4FCek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567436912; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=+lXK5ND9rYcvVc84NENBDW5221359Nm4HqmVEna8PUw=; b=oX9JRfBSJNXzZRD/RO/27H14cveOcJPDaoksvJJ1lH1ycWXsOzPUM4FIsXB/cDTx40FmHKCsycK3Ib4CiroTKPJ77C5TVOWnomGNn7C0PNy7CRMPCOeeUDXwjDhXIHE6Y5k3BxCnS+Zvt9Dn47tBzc4ERevcmj48wUk+ZLlCYkE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1567436912140876.1713443284161; Mon, 2 Sep 2019 08:08:32 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2EF38CF1A3; Mon, 2 Sep 2019 15:08:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 790311000337; Mon, 2 Sep 2019 15:08:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 33022180B536; Mon, 2 Sep 2019 15:08:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x82F8Ki2002447 for ; Mon, 2 Sep 2019 11:08:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id EE69C1001947; Mon, 2 Sep 2019 15:08:20 +0000 (UTC) Received: from orkuz.int.mamuti.net (unknown [10.40.205.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C12731000337 for ; Mon, 2 Sep 2019 15:08:18 +0000 (UTC) Received: by orkuz.int.mamuti.net (Postfix, from userid 500) id 612262A090B; Mon, 2 Sep 2019 17:08:16 +0200 (CEST) From: Jiri Denemark To: libvir-list@redhat.com Date: Mon, 2 Sep 2019 17:08:14 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] news: Rename --precopy-bandwidth migration option X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Mon, 02 Sep 2019 15:08:31 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The (pre-copy) bandwidth was historically the only bandwidth we supported and thus it is called just "bandwidth" in all other places. E.g., virsh migrate-setspeed or in the migration typed parameter name. Let's make the new option for virsh migrate consistent. Signed-off-by: Jiri Denemark Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Jim Fehlig --- docs/news.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 92d566c2fe..0c79765fd0 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -67,12 +67,12 @@
- virsh: Support setting precopy bandwidth in migrate subcommand + virsh: Support setting bandwidth in migrate subcommand In addition to postcopy bandwidth, the virsh migrate subcommand now supports specifying precopy bandwidth with the - --precopy-bandwidth parameter. + --bandwidth parameter.
--=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list