From nobody Sun May 5 09:46:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564056564; cv=none; d=zoho.com; s=zohoarc; b=VMlu+AJ0s7XCz/NARsvsHVIe2m9ertUbt1DniGXtl+mQXkkkjSBpha29AxS7gDvNmn/cCLnv/VJsOpNWJvw3uh1Eo1zM90aZJR4IwUMFCQ7vbjmrio3iAebY5B3rYqVbMetKdWZmlSf7YtbdXBYcobiIjDteWzL6mB/IZstvP5M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564056564; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=lFNhuYIZyg/0z0uBCsUzdCharE3kj9tVRhz3H7PRz6Q=; b=B8MotkpUXi0xgX1TTIp3loMw1j14caFbAMvCLbbUFbEM4yI0MdSiyntR+5+KMVsWxZ0lrbQnQJ3q06dAPeylCfhkoB5NOx442alBKigVv0VAVBiWt6BmKL98bBK10VGt96VY+BlYCJOMQVEUYTV/KLP89AqihHH3yBRuM/je3kc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564056564055169.10092924506034; Thu, 25 Jul 2019 05:09:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B2EEC300CB03; Thu, 25 Jul 2019 12:09:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90DBD5C2E1; Thu, 25 Jul 2019 12:09:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 509E219733; Thu, 25 Jul 2019 12:09:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6PC9IbR017699 for ; Thu, 25 Jul 2019 08:09:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id F23B95DE61; Thu, 25 Jul 2019 12:09:17 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E20F5DD93 for ; Thu, 25 Jul 2019 12:09:17 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Thu, 25 Jul 2019 14:09:10 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/3] virsh: clean up includes X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 25 Jul 2019 12:09:23 +0000 (UTC) We don't need domain_conf or libvirt-{qemu,lxc} in these generic files. Signed-off-by: J=C3=A1n Tomko --- tools/virsh.c | 3 --- tools/vsh.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index b41304a888..c758e38cbd 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -40,12 +40,9 @@ #include "virerror.h" #include "virbuffer.h" #include "viralloc.h" -#include -#include #include "virfile.h" #include "virthread.h" #include "vircommand.h" -#include "conf/domain_conf.h" #include "virtypedparam.h" #include "virstring.h" #include "virgettext.h" diff --git a/tools/vsh.c b/tools/vsh.c index f2486498c9..5de082cb34 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -41,12 +41,9 @@ #include "virerror.h" #include "virbuffer.h" #include "viralloc.h" -#include -#include #include "virfile.h" #include "virthread.h" #include "vircommand.h" -#include "conf/domain_conf.h" #include "virtypedparam.h" #include "virstring.h" =20 --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 09:46:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564056567; cv=none; d=zoho.com; s=zohoarc; b=h4ARmc/VIwIzSyUq6fKSWQfmEeU07UZ26mytXWGxv3B8dxpFhsT69cRJieqpwIH4SacZA4M4ACNuKe3+bIn2l6Ycqwi5sjBGXWQ8pCsXAQZOOE2vlXD0Dugynl2AhyVYUe0HSucLFS6NCn+D6E7m6mPW5SiWD5uNcJiSeMCpWkc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564056567; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=RkJ6V0N1IlHori6deiH0U/yisinTegiJy/N805tOOks=; b=bhsgv19omxIpAK5xPIpQQ46lNNsyc1Ajdq8q3ed9vb9UOE4NT2N7eS46MLw2QnuWI5MGWCu/wBTKtIfxIkUShh6P02RMEYb9ZpVUJs60l+3fawKZwOXO77Nzsg23VUKmkUpZZoB+CMG52gPQcHHIpIvIgc6PjhApTzss1XmYYn4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156405656770619.653320789287477; Thu, 25 Jul 2019 05:09:27 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5F2FC308427D; Thu, 25 Jul 2019 12:09:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30DCF19723; Thu, 25 Jul 2019 12:09:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DFC6F19735; Thu, 25 Jul 2019 12:09:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6PC9IN6017707 for ; Thu, 25 Jul 2019 08:09:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id C32945DE61; Thu, 25 Jul 2019 12:09:18 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E9BA5DD93 for ; Thu, 25 Jul 2019 12:09:18 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Thu, 25 Jul 2019 14:09:11 +0200 Message-Id: <9194640d0a394083cb76ce22ef37ae2a7b409baf.1564056508.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/3] conf: remove outdated comment X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 25 Jul 2019 12:09:26 +0000 (UTC) When using the ENUM macros, the compiler guards that the declaration and implementation are in sync. Signed-off-by: J=C3=A1n Tomko --- src/conf/domain_conf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 48b0af4b04..00ff734ff0 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -119,7 +119,6 @@ struct _virDomainDeviceDef { }; =20 /* Different types of hypervisor */ -/* NB: Keep in sync with virDomainVirtTypeToString impl */ typedef enum { VIR_DOMAIN_VIRT_NONE =3D 0, VIR_DOMAIN_VIRT_QEMU, --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 09:46:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564056571; cv=none; d=zoho.com; s=zohoarc; b=MHh+GZ/bw2FSoiAxwimF4TY9Pxws3TOyta5bJk8V8RSzKCC1FCDoVQB1t1dUYq1LZvp+7YCJw6DL4AlGUDp2KGfm5Y/sxPlEw+c57Wm3+P0aNeiu7zagvgCZXqIJnofkqy0yD7RUjyy+L5+pl3DMBq4asY/Bvv80ZdlFQopATOo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564056571; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=p0UCt2nWsFfiM2rRk0wpa8qJjXTnDpIxv/KqnyYhwRk=; b=mOxTVoROaMvJThyPl4vZXktIqDuL7b2aQBoCK1gAQdgS3D469fCLoY9G+PdCy2Q6pdtFHS6hcOocQaPk36bbzPDTAbnBiAS1UO6UPLm5oivrkoiNiOwQYdTrgco3u8yHHvIjAKpHbRD0zFVV8GvQwJU17hATWjy7jL11eQgPxtk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564056571163557.4993058245743; Thu, 25 Jul 2019 05:09:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C364130A7C69; Thu, 25 Jul 2019 12:09:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9DCE85F9D7; Thu, 25 Jul 2019 12:09:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6582F1800209; Thu, 25 Jul 2019 12:09:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6PC9MdS017729 for ; Thu, 25 Jul 2019 08:09:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0D8F65DC1A; Thu, 25 Jul 2019 12:09:22 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B4E85DE68 for ; Thu, 25 Jul 2019 12:09:18 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Thu, 25 Jul 2019 14:09:12 +0200 Message-Id: <12934e708424f5a8f32621ed645c84e5dec14cb4.1564056508.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/3] conf: remove reference to VIR_DOMAIN_RNG_BACKEND_POOL X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 25 Jul 2019 12:09:30 +0000 (UTC) Sadly, this brilliant idea never got implemented: https://www.fit.vutbr.cz/study/DP/DP.php.en?id=3D14418 Signed-off-by: J=C3=A1n Tomko --- src/conf/domain_conf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 00ff734ff0..822f9af265 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2075,7 +2075,6 @@ typedef enum { typedef enum { VIR_DOMAIN_RNG_BACKEND_RANDOM, VIR_DOMAIN_RNG_BACKEND_EGD, - /* VIR_DOMAIN_RNG_BACKEND_POOL, */ =20 VIR_DOMAIN_RNG_BACKEND_LAST } virDomainRNGBackend; --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list