[libvirt] [PATCH 0/2] util: Fix memleak after (legacy) blockjob (blockdev-add saga spin-off)

Peter Krempa posted 2 patches 4 years, 8 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1563460852.git.pkrempa@redhat.com
src/util/virstoragefile.c | 36 +++++++++++++++++++-----------------
1 file changed, 19 insertions(+), 17 deletions(-)
[libvirt] [PATCH 0/2] util: Fix memleak after (legacy) blockjob (blockdev-add saga spin-off)
Posted by Peter Krempa 4 years, 8 months ago
While verifying that legacy block jobs are not broken I've found a
memleak.

Peter Krempa (2):
  util: storage: Clean up label use in virStorageFileGetMetadataInternal
  util: storage: Don't leak metadata on repeated calls of
    virStorageFileGetMetadata

 src/util/virstoragefile.c | 36 +++++++++++++++++++-----------------
 1 file changed, 19 insertions(+), 17 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] util: Fix memleak after (legacy) blockjob (blockdev-add saga spin-off)
Posted by Ján Tomko 4 years, 8 months ago
On Thu, Jul 18, 2019 at 04:42:00PM +0200, Peter Krempa wrote:
>While verifying that legacy block jobs are not broken I've found a
>memleak.
>
>Peter Krempa (2):
>  util: storage: Clean up label use in virStorageFileGetMetadataInternal
>  util: storage: Don't leak metadata on repeated calls of
>    virStorageFileGetMetadata
>
> src/util/virstoragefile.c | 36 +++++++++++++++++++-----------------
> 1 file changed, 19 insertions(+), 17 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] util: Fix memleak after (legacy) blockjob (blockdev-add saga spin-off)
Posted by Michal Privoznik 4 years, 8 months ago
On 7/18/19 4:42 PM, Peter Krempa wrote:
> While verifying that legacy block jobs are not broken I've found a
> memleak.
> 
> Peter Krempa (2):
>    util: storage: Clean up label use in virStorageFileGetMetadataInternal
>    util: storage: Don't leak metadata on repeated calls of
>      virStorageFileGetMetadata
> 
>   src/util/virstoragefile.c | 36 +++++++++++++++++++-----------------
>   1 file changed, 19 insertions(+), 17 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list