[libvirt] [PATCH v2 0/3] Ditch external JavaScript libraries

Martin Kletzander posted 3 patches 4 years, 9 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
docs/Makefile.am            |   5 +-
docs/index.html.in          |  15 +-----
docs/js/jquery-3.1.1.min.js |   4 --
docs/js/jquery.rss.min.js   |  11 ----
docs/js/main.js             | 102 +++++++++++++++++++++++++++---------
docs/js/moment.min.js       |   7 ---
6 files changed, 81 insertions(+), 63 deletions(-)
delete mode 100644 docs/js/jquery-3.1.1.min.js
delete mode 100644 docs/js/jquery.rss.min.js
delete mode 100644 docs/js/moment.min.js
[libvirt] [PATCH v2 0/3] Ditch external JavaScript libraries
Posted by Martin Kletzander 4 years, 9 months ago
This is a response to all the discussions (mainly) other people had about all
the JS code we're currently using, bundling, etc.

Ideally, we'll set up CORS [1] on planet.virt-tools.org, but for now this is
already a nice clean-up by itself.

[1] https://en.wikipedia.org/wiki/Cross-origin_resource_sharing

Martin Kletzander (3):
  docs: Some JavaScript clean-up
  docs: Use our own implementation for fetching the RSS data
  docs: Remove unused JS libraries

 docs/Makefile.am            |   5 +-
 docs/index.html.in          |  15 +-----
 docs/js/jquery-3.1.1.min.js |   4 --
 docs/js/jquery.rss.min.js   |  11 ----
 docs/js/main.js             | 102 +++++++++++++++++++++++++++---------
 docs/js/moment.min.js       |   7 ---
 6 files changed, 81 insertions(+), 63 deletions(-)
 delete mode 100644 docs/js/jquery-3.1.1.min.js
 delete mode 100644 docs/js/jquery.rss.min.js
 delete mode 100644 docs/js/moment.min.js

-- 
2.22.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/3] Ditch external JavaScript libraries
Posted by Andrea Bolognani 4 years, 9 months ago
On Thu, 2019-06-20 at 11:43 +0200, Martin Kletzander wrote:
> This is a response to all the discussions (mainly) other people had about all
> the JS code we're currently using, bundling, etc.
> 
> Ideally, we'll set up CORS [1] on planet.virt-tools.org, but for now this is
> already a nice clean-up by itself.
> 
> [1] https://en.wikipedia.org/wiki/Cross-origin_resource_sharing
> 
> Martin Kletzander (3):
>   docs: Some JavaScript clean-up
>   docs: Use our own implementation for fetching the RSS data
>   docs: Remove unused JS libraries

With the nits mentioned separately addressed,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

Thanks a ton for working on this!

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list