From nobody Wed May 1 20:57:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1558014109; cv=none; d=zoho.com; s=zohoarc; b=Oo0f4gYdXMkOVxznIHZpoK1/l56s9Vo8/uBSLCAcDc3Co/EoLPWCU5EKX/TjXBPfwkgcCYGp5KmBmlMeRNKeNJcUzWOWOwjpVpRB0ozjE2mNcUFYm79D9fHVJ6ceZfOXFykS/Pk2BXQJHhh+c99dKUH3nqTq5JRA2VcYRKneBcI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558014109; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=qfWjJNTA0TDlR1cI+udMcLj8pzwgmzkeg5UYg4h54ZI=; b=jPvN503QZdPpFle0kF/FFBXv0O/9BugI7TrpgxAIBLEAo4SX6S6JkzBSykc8Hr6jSu5HgxrnEKzF/heMY476POOmYfoMnLWh5OGpaHp3w/FDrgc9c3jks2du0Snoidl2FIyQDi2GijB3DBBlGtRqhqzhvXH6JHDnyvzDSZMkZ2I= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1558014109743187.50577268098186; Thu, 16 May 2019 06:41:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D9AA13083045; Thu, 16 May 2019 13:41:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CA4919733; Thu, 16 May 2019 13:41:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 47C9A1806B11; Thu, 16 May 2019 13:41:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4GDfVrY011393 for ; Thu, 16 May 2019 09:41:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 466101A8F7; Thu, 16 May 2019 13:41:31 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C466D2E19D for ; Thu, 16 May 2019 13:41:28 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Thu, 16 May 2019 15:41:16 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] build: bump minimum udev version to 219 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 16 May 2019 13:41:48 +0000 (UTC) This is the version of systemd RHEL/CentOS 7 uses: https://repology.org/project/systemd/versions Oldest tracked openSUSE distros have 228, Ubuntu 16.04 has 229 and Gentoo's alternative eudev has bumped the version to 219 back in 2015. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Pavel Hrdina --- m4/virt-udev.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/virt-udev.m4 b/m4/virt-udev.m4 index cf977c650b..5bb9cd5c5f 100644 --- a/m4/virt-udev.m4 +++ b/m4/virt-udev.m4 @@ -18,12 +18,12 @@ dnl . dnl =20 AC_DEFUN([LIBVIRT_ARG_UDEV],[ - LIBVIRT_ARG_WITH_FEATURE([UDEV], [libudev], [check], [145]) + LIBVIRT_ARG_WITH_FEATURE([UDEV], [libudev], [check], [219]) ]) =20 AC_DEFUN([LIBVIRT_CHECK_UDEV],[ AC_REQUIRE([LIBVIRT_CHECK_PCIACCESS]) - LIBVIRT_CHECK_PKG([UDEV], [libudev], [145]) + LIBVIRT_CHECK_PKG([UDEV], [libudev], [219]) =20 if test "$with_udev" =3D "yes" && test "$with_pciaccess" !=3D "yes" ; th= en AC_MSG_ERROR([You must install the pciaccess module to build with udev= ]) --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Wed May 1 20:57:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1558014113; cv=none; d=zoho.com; s=zohoarc; b=dMjkh/+kZxLSOYm6VdH5RsyYiLzdCzhgfTvbY2g4bSAwfZF6cscdyBex9WBRzmfTdFDxhw4LxXXSQw6PFuFoI/er+gbO6kYKYnPZrk6qkNLzUUhPbwCUIirNUDNUKGEyBnOicD4TzL6BYrnJ2CoXlrWx/BEeEvHgRAjwQ4QKlC0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558014113; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=6d0ZOrX6g72QZR42PZsUUDAxrQPyGrw68vY28hQTfOI=; b=lt3asPfXJCCPe0qQJhpS2cJxETObkD1LvnRlqsFyIscl/hzysX0mbfa5qwF/NtRqbDfAVOG+nu/jff5zGqsvdDRfmlHgZ/GmF1CVSf9EU/xPlvvPrR9nwi140+CS6ux5wUnxumEugkIVCLmoyoS95I9rJ/rco48MvHWWwPa9sMQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1558014113853532.0133473239842; Thu, 16 May 2019 06:41:53 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CCD0164122; Thu, 16 May 2019 13:41:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A85272E199; Thu, 16 May 2019 13:41:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 699251806B15; Thu, 16 May 2019 13:41:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4GDfYD7011403 for ; Thu, 16 May 2019 09:41:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4D0AF19733; Thu, 16 May 2019 13:41:34 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C83E32E19A for ; Thu, 16 May 2019 13:41:31 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Thu, 16 May 2019 15:41:17 +0200 Message-Id: <791e4d26cd132787384703323eb4a841be2503a2.1558013999.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] build: drop check for udev_monitor_set_receive_buffer_size X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 16 May 2019 13:41:52 +0000 (UTC) It has been exported by systemd commit commit a571c23e954cb88cdd5faa28593b19bd7c340130 libudev: export udev_monitor_set_receive_buffer_size() released in v183. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Pavel Hrdina --- m4/virt-udev.m4 | 10 ---------- src/node_device/node_device_udev.c | 2 -- 2 files changed, 12 deletions(-) diff --git a/m4/virt-udev.m4 b/m4/virt-udev.m4 index 5bb9cd5c5f..2e0f993e33 100644 --- a/m4/virt-udev.m4 +++ b/m4/virt-udev.m4 @@ -28,16 +28,6 @@ AC_DEFUN([LIBVIRT_CHECK_UDEV],[ if test "$with_udev" =3D "yes" && test "$with_pciaccess" !=3D "yes" ; th= en AC_MSG_ERROR([You must install the pciaccess module to build with udev= ]) fi - - if test "$with_udev" =3D "yes" ; then - old_CFLAGS=3D"$CFLAGS" - old_LIBS=3D"$LIBS" - CFLAGS=3D"$CFLAGS $UDEV_CFLAGS" - LIBS=3D"$CFLAGS $UDEV_LIBS" - AC_CHECK_FUNCS([udev_monitor_set_receive_buffer_size]) - CFLAGS=3D"$old_CFLAGS" - LIBS=3D"$old_LIBS" - fi ]) =20 AC_DEFUN([LIBVIRT_RESULT_UDEV],[ diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_devi= ce_udev.c index 5df2fd72f3..276bf3dd99 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -1847,14 +1847,12 @@ nodeStateInitialize(bool privileged, =20 udev_monitor_enable_receiving(priv->udev_monitor); =20 -#if HAVE_UDEV_MONITOR_SET_RECEIVE_BUFFER_SIZE /* mimic udevd's behaviour and override the systems rmem_max limit in = case * there's a significant number of device 'add' events */ if (geteuid() =3D=3D 0) udev_monitor_set_receive_buffer_size(priv->udev_monitor, 128 * 1024 * 1024); -#endif =20 if (virThreadCreate(&priv->th, true, udevEventHandleThread, NULL) < 0)= { virReportSystemError(errno, "%s", --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list