From nobody Fri Apr 26 03:35:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557825870; cv=none; d=zoho.com; s=zohoarc; b=eCMKsHOlFPMWIs2wvQn4GO4Aa4s7Sm+8GdCgdbIksCbVTXR1AbXyUB3xZ1Hpqz9wl2deMLghVnQRkCjPfIS3Ytpx8vr2TLeblxB4osAixM5JBkFKqfsQQtPapCi1KUZMBCNGB3a/iK4MKv6lnoAMOx00wJI9slb4kDOz51354J4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557825870; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=rCKyqCTXKoL2vE33RKAvjBPZdddr+zKkmmT0Iw4mof0=; b=f8Vn6d8VM6LOH6XdKiol4Q9puzG8d+4LswW6dkR2dmioZgUMs30KuzRoZFV+3sG8NR03HUOBL8BuMXMBFTPA93VVAL5IsUQB6S/INr/SB82rmUYCoicZVV1W1xnZeEREKbD9/pfk/R1o4siQe9ejNaycX9YBnpPz+t2SsgmP1Lk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1557825870038273.3161183568732; Tue, 14 May 2019 02:24:30 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 36CCF19DCB; Tue, 14 May 2019 09:24:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C48D19C7F; Tue, 14 May 2019 09:24:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C2A4F41F5C; Tue, 14 May 2019 09:24:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4E9OI9S013122 for ; Tue, 14 May 2019 05:24:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7BDFD5D706; Tue, 14 May 2019 09:24:18 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 059BC5D6A6 for ; Tue, 14 May 2019 09:24:17 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 14 May 2019 11:24:09 +0200 Message-Id: <42211e65dfe958b3d433dd66337e3daa9bb5cdb0.1557825733.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/4] virstorageobj: Don't clear vols if they weren't initialized X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 14 May 2019 09:24:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" If virStoragePoolObjNew() fails to create new volume object list then virObjectUnref() is called and since refcounter is 1 then virStoragePoolObjDispose() is called which in turn calls virStoragePoolObjClearVols() which in turn dereferences obj->volumes. Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- src/conf/virstorageobj.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 1d6c9d1937..1d5c88f50b 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -365,8 +365,10 @@ virStoragePoolObjDispose(void *opaque) if (!obj) return; =20 - virStoragePoolObjClearVols(obj); - virObjectUnref(obj->volumes); + if (obj->volumes) { + virStoragePoolObjClearVols(obj); + virObjectUnref(obj->volumes); + } =20 virStoragePoolDefFree(obj->def); virStoragePoolDefFree(obj->newDef); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 26 03:35:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557825863; cv=none; d=zoho.com; s=zohoarc; b=jRYyLNtZ8+6QpHPphrdsF6Q4A470QuLgUijFJPMPqHqN2S9W1eF3UkH6NLGObd0mZ5RS5r+tJKgX351zZDKDAtr4A8is4y6/nVazNCOr5WrxSP63kEBAToKoQNGF8ULV52IcFrca2V570+D1McxcYNXbK7KIvCTwNmx+fai+T7I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557825863; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Je2N/ccgi+zP6AJQl80zKyIfQKbJULfY3O2vHoBq2hs=; b=gw6UAEaQGZaOOyGtRXQI4Ng1DNB4BonsKXCycpBhWAMnScP8p4mtI278J2qLrqTkiQLJ5Wkf/2X6GAcu5h07APkYFhr5AAyyYETXoIMuX9dcGYxervJSIKk3tsHNWqJiraW360KvM7qF9SLaZ/YT0W2JRzMHHICyt5ZP4imXT1g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1557825863894859.6826822844255; Tue, 14 May 2019 02:24:23 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 354AA330247; Tue, 14 May 2019 09:24:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F2159619BC; Tue, 14 May 2019 09:24:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9FB6141F58; Tue, 14 May 2019 09:24:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4E9OJBF013127 for ; Tue, 14 May 2019 05:24:19 -0400 Received: by smtp.corp.redhat.com (Postfix) id 494785D706; Tue, 14 May 2019 09:24:19 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7DFE5D6A6 for ; Tue, 14 May 2019 09:24:18 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 14 May 2019 11:24:10 +0200 Message-Id: <279dc8f74c28f93b957457acaa171b2f6d7ecb79.1557825733.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/4] virNetServerPreExecRestart: Check for retval of virJSONValueNewArray() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 14 May 2019 09:24:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- src/rpc/virnetserver.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index 83b871764f..4934dba967 100644 --- a/src/rpc/virnetserver.c +++ b/src/rpc/virnetserver.c @@ -629,7 +629,9 @@ virJSONValuePtr virNetServerPreExecRestart(virNetServer= Ptr srv) goto error; } =20 - services =3D virJSONValueNewArray(); + if (!(services =3D virJSONValueNewArray())) + goto error; + if (virJSONValueObjectAppend(object, "services", services) < 0) { virJSONValueFree(services); goto error; @@ -646,7 +648,9 @@ virJSONValuePtr virNetServerPreExecRestart(virNetServer= Ptr srv) } } =20 - clients =3D virJSONValueNewArray(); + if (!(clients =3D virJSONValueNewArray())) + goto error; + if (virJSONValueObjectAppend(object, "clients", clients) < 0) { virJSONValueFree(clients); goto error; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 26 03:35:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557825875; cv=none; d=zoho.com; s=zohoarc; b=ciFuDA5NCLXKqq+kxRwMjxjxO3tdhIAIzCrPjANqTAlmtvSIx6NI3TaNL5OZ73Y9NKysW8wljb/USCrJz/RBfIUsoRLc3dqnR5eSh2TSLVwlHVZ4NY4rxE/j8jJqygQ3/b/wYLc8GRxVsnU20EKg1mT05SrWuCo66w9ri+nhZpQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557825875; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=7fbTTm2y5tpp+onongU8WS54eQ22Hxgqc1yM4/EKJpE=; b=NZxXhOmMebeHVgx2VdB33gP8bTXBQyRkp4Ko+Z39BFhoGzOmcBuF3fag2eovYbLX8XHTPdqI+5Q6AEIWzG71kGF12Ulj5ZOYHIZFH4kSqb2UlEVL36xnQX/d3fo5YD/jHoCGaHiXIbQ33yb4pKdnqVvAkNTJPpJKRxqlYTCu3Ws= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1557825875299686.6180008249848; Tue, 14 May 2019 02:24:35 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A28373082B40; Tue, 14 May 2019 09:24:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78CB319C7F; Tue, 14 May 2019 09:24:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4223718089D1; Tue, 14 May 2019 09:24:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4E9OKbE013140 for ; Tue, 14 May 2019 05:24:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 173F45D706; Tue, 14 May 2019 09:24:20 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95A425D6A6 for ; Tue, 14 May 2019 09:24:19 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 14 May 2019 11:24:11 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/4] virCommand: Make virCommandPassFDGetFDIndex fail if passed command is in error state X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 14 May 2019 09:24:34 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The idea of virCommand* APIs is that a possible error that occurred while constructing cmd line is kept in virCommand struct. If that's the case all subsequent calls to virCommand*() are NO-OPs or they return an error. Well, virCommandPassFDGetFDIndex() is not honoring that. Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- src/util/vircommand.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 9e99697c55..8695c98d1b 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -1034,6 +1034,9 @@ virCommandPassFDGetFDIndex(virCommandPtr cmd, int fd) { size_t i =3D 0; =20 + if (!cmd || cmd->has_error) + return -1; + while (i < cmd->npassfd) { if (cmd->passfd[i].fd =3D=3D fd) return i; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 26 03:35:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557825878; cv=none; d=zoho.com; s=zohoarc; b=OvMhIz3Nhaks2X9kp8ha0RHMA44Dyxz4OkfOZDg8gYWc8Zwnmi5nGE3aw41pjYuIWGLIe+tRUnSYXum9Ppg/bT6VsEDI/BzqVMlhQKOqSSK+ZwDKGkoKpkFaOytt35qAR1cW41lXvzWbCt4yTnGcC8tuAw+d18EUMtao492ACPI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557825878; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=sVncIHfb/phfn0wstXxs1aJ7X0zviF4exai2oMEkY+U=; b=lGVH1wU26TN3cAxA53fJdnorPCEdO8QTg87TImJ0EsK+6Hf729DTUtq2EH3TQye9XRWLP7oPEgmX+zp89qF2Ez7mh1WwjfnqJjqUwh+6rVWBLUQhkIzTD7dOpHx6yBCY9gAhfF6qi+8loBxI3nOAYfaDtBPs9l4eTbRYJITqJYY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1557825878750152.69113798437297; Tue, 14 May 2019 02:24:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1D74381DFE; Tue, 14 May 2019 09:24:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB95D5C26B; Tue, 14 May 2019 09:24:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B1F8918089D4; Tue, 14 May 2019 09:24:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4E9OKfA013147 for ; Tue, 14 May 2019 05:24:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id D8C165D706; Tue, 14 May 2019 09:24:20 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 637505D6A6 for ; Tue, 14 May 2019 09:24:20 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 14 May 2019 11:24:12 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/4] storagepoolxml2argvtest: Avoid double free X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 14 May 2019 09:24:37 +0000 (UTC) Content-Type: text/plain; charset="utf-8" A double free may occur in testCompareXMLToArgvFiles() when @def is freed right after virStoragePoolObjNew() failed and the second time at cleanup label. Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- tests/storagepoolxml2argvtest.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/storagepoolxml2argvtest.c b/tests/storagepoolxml2argvtes= t.c index b7e32064af..0c01931946 100644 --- a/tests/storagepoolxml2argvtest.c +++ b/tests/storagepoolxml2argvtest.c @@ -39,7 +39,6 @@ testCompareXMLToArgvFiles(bool shouldFail, case VIR_STORAGE_POOL_NETFS: if (!(pool =3D virStoragePoolObjNew())) { VIR_TEST_DEBUG("pool type '%s' alloc pool obj fails\n", defTyp= eStr); - virStoragePoolDefFree(def); goto cleanup; } virStoragePoolObjSetDef(pool, def); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list