From nobody Thu Apr 25 21:38:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557153334; cv=none; d=zoho.com; s=zohoarc; b=bANsJNLWw9MgsUQSUu+2el538JYOB0UF2fq3cJMIIKFdqtBODQKslnlt9RHwVa7RGfrF+8DcDvJjFVvdirfcq32yKytbHu9Pz1GsyVdsn16AFKdkb9cf5fRfKT7paPjADahvQaPUTDglQaWbAzyh7UhKQJl7t1EGpGAfbULCVHo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557153334; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=lC/BTZqb4HDarpdmXpR9KjrdNnZBwOqw6vUTvmr7qN0=; b=AMptw7TLucIn7ZzKCGrXIRbUjOWxOfLZTsOyK/BZr2NZ4t6jjPzg39WNexBjYejxTSij7pY4ujdEVDOscYEJZ4+r9HkN5mHhBPnzkdq6hutbX0S54T3a1WTJCzlWTC7AJyuGVdnSvmnFcHgkxf2Yd5a8Viz+EjEVclPKRYNuTrY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 155715333482410.13776647353609; Mon, 6 May 2019 07:35:34 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B0E62356E4; Mon, 6 May 2019 14:35:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD0BB272AD; Mon, 6 May 2019 14:35:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4F7E518089CC; Mon, 6 May 2019 14:35:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x46EYGse027936 for ; Mon, 6 May 2019 10:34:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 262E96146F; Mon, 6 May 2019 14:34:16 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2CF95FC36 for ; Mon, 6 May 2019 14:34:13 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 6 May 2019 16:34:06 +0200 Message-Id: <47188b944c5a6e5dcdc121569de4736ba398761f.1557153152.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/3] virfilemock: Init symbols in canonicalize_file_name() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 06 May 2019 14:35:33 +0000 (UTC) Content-Type: text/plain; charset="utf-8" If a program that is using this mock calls canonicalize_file_name() as the very first function then it will face SIGSEGV because real_canonicalize_file_name is uninitialized. Signed-off-by: Michal Privoznik --- tests/virfilemock.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/virfilemock.c b/tests/virfilemock.c index 89e14c5b67..106032f857 100644 --- a/tests/virfilemock.c +++ b/tests/virfilemock.c @@ -177,6 +177,9 @@ statfs(const char *path, struct statfs *buf) char * canonicalize_file_name(const char *path) { + + init_syms(); + if (getenv("LIBVIRT_MTAB")) { const char *p; char *ret; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 21:38:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557153382; cv=none; d=zoho.com; s=zohoarc; b=cHpdvxBY721IOEa1LPiM/wj7WZabqQEYsxKqhnGC5YKyADuL3d4gaQZdyiKL8E6C6N+rCnfUPsTThPhrNUOrXERO5DjjDFDHKQNSNJ60qYceO8c84b/qrZzSORbSW7QxkPtpdxsAyfASzv4iH5G/opopkLfi70yodZ0dtJ2mr/A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557153382; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=r42D1xGltx+HqPnCDLSgZOZgrsLVkc4PFaucWC5aNsw=; b=NowzcNSVSYKhRWGglY9mEHMfUXRQL1QD2YRN1IY2SE5UiJJTCI2b5OJwaVL8S/VUoE9C2MxVOvBWEHjyUlYDMpw+NFaD/N1i4VbmL2aEeYHcuzEsE/f/R5A5FHeDtEzA3erhBS29Md1l3YLZWvoQg9SUxnQHqWGQyD6OyUSnPLk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 155715338282932.270321550355106; Mon, 6 May 2019 07:36:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9A9D33079B62; Mon, 6 May 2019 14:36:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 706F92D1D4; Mon, 6 May 2019 14:36:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 18EA24EA78; Mon, 6 May 2019 14:36:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x46EYG01027941 for ; Mon, 6 May 2019 10:34:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id EBD9A4AB; Mon, 6 May 2019 14:34:16 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 73E3F61781 for ; Mon, 6 May 2019 14:34:16 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 6 May 2019 16:34:07 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/3] virtestmock: Initialize symbols from stat() and its friends X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 06 May 2019 14:36:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Introduced by ff376c6283c97. Previously, init_syms() was called from stat() mock and its friends. This is crucial because checkPath() might call printFile() which in turn calls real_fopen(). But if stat() or one of its friends is the first function called then because of lacking init_syms() call no real_* is initialized. The other thing is that we really want the recorded action to be "stat" instead of __FUNCTION__ because there's no good in recording that it was __xstat64 who touched some file. Signed-off-by: Michal Privoznik --- tests/virtestmock.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/virtestmock.c b/tests/virtestmock.c index bc62312444..ad6958ac87 100644 --- a/tests/virtestmock.c +++ b/tests/virtestmock.c @@ -190,7 +190,9 @@ int access(const char *path, int mode) } =20 =20 -#define VIR_MOCK_STAT_HOOK CHECK_PATH(path) +#define VIR_MOCK_STAT_HOOK \ + init_syms(); \ + checkPath(path, "stat") =20 #include "virmockstathelpers.c" =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 21:38:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557153374; cv=none; d=zoho.com; s=zohoarc; b=gqEH1uBgEot5tt6qGe+Gg0upPP+gvONVDjGNTver4suuVmXNSpV1hb2ie/mhTdo4AaptmPrvBUO6ci4f1m13Z1UxrOOfGe4pYd6f2jXlY2WTgQr/TDGBJW5RPnHYi2ZSXhkk9SJAzhqLalztLWYSGdWoKGi+P3OwruX+iroOeTI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557153374; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=RXG10Abch5o+Olnf7wwmg92OOF4yztTg8sy9GH8D9Es=; b=UXc5tWH6bJp5F4+1w2BK91aMz0Pr5ACf22gweXvQ83YI/njelOrXuqbezLk3uVRrFc2TLfFwxroEf0xQ1JPKIdCMkOrNxvSPfXw3suybxLiFZ5tD1ddwY+3qh2ejf4MLE8J2xiN3v0//bwkDmzJc+QmepjnF9TaSWUdRPvluVnc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1557153374279790.8724127446587; Mon, 6 May 2019 07:36:14 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 90D66CA37E; Mon, 6 May 2019 14:36:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 61A7D60C47; Mon, 6 May 2019 14:36:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CE7614EA76; Mon, 6 May 2019 14:36:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x46EYHUa027949 for ; Mon, 6 May 2019 10:34:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id BE8D75FC36; Mon, 6 May 2019 14:34:17 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 466F14AB for ; Mon, 6 May 2019 14:34:17 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 6 May 2019 16:34:08 +0200 Message-Id: <94a391c52548dd2dfa8cf94142cef3cd6cd054b0.1557153152.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/3] lib: Build sources before running 'check-access' X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 06 May 2019 14:36:13 +0000 (UTC) Content-Type: text/plain; charset="utf-8" If the source tree was freshly configured and no objects are built yet then 'make check-access' has no test to run. Build the sources beforehand. Signed-off-by: Michal Privoznik --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index eba5916352..0d8bb733e6 100644 --- a/Makefile.am +++ b/Makefile.am @@ -83,7 +83,7 @@ srpm: clean =20 check-local: all tests =20 -check-access: +check-access: all @($(MAKE) $(AM_MAKEFLAGS) -C tests check-access) =20 MAINTAINERCLEANFILES =3D .git-module-status --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list