[libvirt] [PATCH 0/5] util: Clean up header inclusion

Peter Krempa posted 5 patches 4 years, 11 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1554296696.git.pkrempa@redhat.com
src/Makefile.am                           |  5 ++
src/access/viraccessperm.h                |  1 +
src/conf/capabilities.c                   |  1 +
src/conf/cpu_conf.h                       |  1 +
src/conf/device_conf.h                    |  1 +
src/conf/domain_capabilities.h            |  2 +-
src/conf/domain_conf.h                    |  1 +
src/conf/interface_conf.h                 |  1 +
src/conf/network_conf.h                   |  1 +
src/conf/node_device_conf.h               |  1 +
src/conf/node_device_util.c               |  1 +
src/conf/numa_conf.h                      |  1 +
src/conf/nwfilter_conf.h                  |  1 +
src/conf/storage_adapter_conf.h           |  1 +
src/conf/storage_conf.h                   |  1 +
src/conf/virdomainmomentobjlist.c         |  1 +
src/conf/virdomainsnapshotobjlist.c       |  1 +
src/conf/virnwfilterbindingobj.c          |  2 +
src/libvirt_private.syms                  | 19 +++--
src/libxl/libxl_domain.c                  |  1 +
src/locking/lock_daemon_config.c          |  2 +
src/locking/lock_driver_lockd.c           |  2 +
src/logging/log_daemon_config.c           |  2 +
src/lxc/lxc_conf.c                        |  2 +
src/lxc/lxc_fuse.c                        |  2 +
src/lxc/lxc_fuse.h                        |  1 -
src/network/leaseshelper.c                |  1 +
src/nwfilter/nwfilter_ebiptables_driver.c |  1 +
src/qemu/qemu_firmware.c                  |  1 +
src/qemu/qemu_firmware.h                  |  1 -
src/remote/remote_daemon_config.c         |  2 +
src/security/security_dac.c               |  1 +
src/security/security_manager.c           |  1 +
src/storage/storage_file_fs.c             |  1 +
src/util/Makefile.inc.am                  |  3 +
src/util/viralloc.h                       | 77 -------------------
src/util/virauth.c                        |  1 +
src/util/virauthconfig.c                  |  1 +
src/util/virauthconfig.h                  |  2 +-
src/util/virautoclean.h                   | 90 +++++++++++++++++++++++
src/util/virbitmap.c                      |  1 +
src/util/virbitmap.h                      |  2 +-
src/util/virbuffer.c                      |  1 +
src/util/virbuffer.h                      |  2 +-
src/util/vircgroup.h                      |  1 +
src/util/vircgroupv1.c                    |  2 +
src/util/vircgroupv2.c                    |  2 +
src/util/vircommand.c                     |  1 +
src/util/vircommand.h                     |  1 -
src/util/virconf.h                        |  1 +
src/util/virenum.c                        | 84 +++++++++++++++++++++
src/util/virenum.h                        | 80 ++++++++++++++++++++
src/util/virerror.c                       |  1 +
src/util/virerror.h                       |  2 +-
src/util/virfile.c                        |  1 +
src/util/virfile.h                        |  1 -
src/util/virfirewall.c                    |  1 +
src/util/virfirewall.h                    |  2 +-
src/util/virfirewalld.c                   |  2 +
src/util/virgic.h                         |  1 +
src/util/virhash.c                        |  1 +
src/util/virhash.h                        |  2 +-
src/util/virjson.c                        |  2 +
src/util/virjson.h                        |  1 -
src/util/virkeycode.h                     |  1 +
src/util/virmacaddr.c                     |  1 +
src/util/virmacaddr.h                     |  2 +-
src/util/virmdev.c                        |  1 +
src/util/virmdev.h                        |  2 +-
src/util/virnetdev.c                      |  2 +
src/util/virnetdev.h                      |  2 +-
src/util/virnetdevip.c                    |  2 +
src/util/virnetdevmacvlan.c               |  2 +
src/util/virnetdevmacvlan.h               |  1 +
src/util/virnetdevvlan.c                  |  1 +
src/util/virnetdevvlan.h                  |  3 +-
src/util/virnetdevvportprofile.c          |  2 +
src/util/virnetdevvportprofile.h          |  1 +
src/util/virnetlink.c                     |  1 +
src/util/virnetlink.h                     |  1 -
src/util/virobject.h                      | 10 +++
src/util/virpci.c                         |  1 +
src/util/virpci.h                         |  2 +-
src/util/virperf.c                        |  2 +
src/util/virperf.h                        |  3 +-
src/util/virpidfile.c                     |  1 +
src/util/virpolkit.c                      |  1 +
src/util/virprocess.h                     |  1 +
src/util/virresctrl.c                     |  1 +
src/util/virresctrl.h                     |  2 +-
src/util/virscsi.c                        |  1 +
src/util/virscsi.h                        |  1 -
src/util/virscsivhost.c                   |  1 +
src/util/virscsivhost.h                   |  1 -
src/util/virsecret.h                      |  1 +
src/util/virsocketaddr.c                  |  1 +
src/util/virsocketaddr.h                  |  2 +-
src/util/virstorageencryption.h           |  1 +
src/util/virstoragefile.h                 |  1 +
src/util/virstring.h                      |  1 -
src/util/virsysinfo.h                     |  1 +
src/util/virtypedparam.h                  |  1 +
src/util/virusb.c                         |  1 +
src/util/virusb.h                         |  1 -
src/util/virutil.c                        | 58 ---------------
src/util/virutil.h                        | 55 --------------
tests/eventtest.c                         |  1 +
tests/objecteventtest.c                   |  2 +
tests/qemusecuritymock.c                  |  1 +
tests/scsihosttest.c                      |  1 +
tests/vboxsnapshotxmltest.c               |  1 +
tests/vircgroupmock.c                     |  1 +
tests/virfiletest.c                       |  1 +
tests/virfilewrapper.c                    |  1 +
tests/virlockspacetest.c                  |  1 +
tests/virnetdaemontest.c                  |  2 +
tests/virnetsockettest.c                  |  1 +
tests/virnettlscontexttest.c              |  1 +
tests/virnettlshelpers.c                  |  1 +
tests/virnettlssessiontest.c              |  1 +
tests/virscsitest.c                       |  1 +
tests/virstoragetest.c                    |  1 +
tools/virt-host-validate-common.h         |  1 +
123 files changed, 406 insertions(+), 223 deletions(-)
create mode 100644 src/util/virautoclean.h
create mode 100644 src/util/virenum.c
create mode 100644 src/util/virenum.h
[libvirt] [PATCH 0/5] util: Clean up header inclusion
Posted by Peter Krempa 4 years, 11 months ago
Peter Krempa (5):
  util: Move VIR_AUTOUNREF definition to virobject.h
  util: Move the VIR_AUTO(CLEAN|PTR) helper macros into a separate
    header
  util: Don't include 'viralloc.h' into other header files
  util: Move enum convertors into virenum.(c|h)
  Include unistd.h directly by files using it

 src/Makefile.am                           |  5 ++
 src/access/viraccessperm.h                |  1 +
 src/conf/capabilities.c                   |  1 +
 src/conf/cpu_conf.h                       |  1 +
 src/conf/device_conf.h                    |  1 +
 src/conf/domain_capabilities.h            |  2 +-
 src/conf/domain_conf.h                    |  1 +
 src/conf/interface_conf.h                 |  1 +
 src/conf/network_conf.h                   |  1 +
 src/conf/node_device_conf.h               |  1 +
 src/conf/node_device_util.c               |  1 +
 src/conf/numa_conf.h                      |  1 +
 src/conf/nwfilter_conf.h                  |  1 +
 src/conf/storage_adapter_conf.h           |  1 +
 src/conf/storage_conf.h                   |  1 +
 src/conf/virdomainmomentobjlist.c         |  1 +
 src/conf/virdomainsnapshotobjlist.c       |  1 +
 src/conf/virnwfilterbindingobj.c          |  2 +
 src/libvirt_private.syms                  | 19 +++--
 src/libxl/libxl_domain.c                  |  1 +
 src/locking/lock_daemon_config.c          |  2 +
 src/locking/lock_driver_lockd.c           |  2 +
 src/logging/log_daemon_config.c           |  2 +
 src/lxc/lxc_conf.c                        |  2 +
 src/lxc/lxc_fuse.c                        |  2 +
 src/lxc/lxc_fuse.h                        |  1 -
 src/network/leaseshelper.c                |  1 +
 src/nwfilter/nwfilter_ebiptables_driver.c |  1 +
 src/qemu/qemu_firmware.c                  |  1 +
 src/qemu/qemu_firmware.h                  |  1 -
 src/remote/remote_daemon_config.c         |  2 +
 src/security/security_dac.c               |  1 +
 src/security/security_manager.c           |  1 +
 src/storage/storage_file_fs.c             |  1 +
 src/util/Makefile.inc.am                  |  3 +
 src/util/viralloc.h                       | 77 -------------------
 src/util/virauth.c                        |  1 +
 src/util/virauthconfig.c                  |  1 +
 src/util/virauthconfig.h                  |  2 +-
 src/util/virautoclean.h                   | 90 +++++++++++++++++++++++
 src/util/virbitmap.c                      |  1 +
 src/util/virbitmap.h                      |  2 +-
 src/util/virbuffer.c                      |  1 +
 src/util/virbuffer.h                      |  2 +-
 src/util/vircgroup.h                      |  1 +
 src/util/vircgroupv1.c                    |  2 +
 src/util/vircgroupv2.c                    |  2 +
 src/util/vircommand.c                     |  1 +
 src/util/vircommand.h                     |  1 -
 src/util/virconf.h                        |  1 +
 src/util/virenum.c                        | 84 +++++++++++++++++++++
 src/util/virenum.h                        | 80 ++++++++++++++++++++
 src/util/virerror.c                       |  1 +
 src/util/virerror.h                       |  2 +-
 src/util/virfile.c                        |  1 +
 src/util/virfile.h                        |  1 -
 src/util/virfirewall.c                    |  1 +
 src/util/virfirewall.h                    |  2 +-
 src/util/virfirewalld.c                   |  2 +
 src/util/virgic.h                         |  1 +
 src/util/virhash.c                        |  1 +
 src/util/virhash.h                        |  2 +-
 src/util/virjson.c                        |  2 +
 src/util/virjson.h                        |  1 -
 src/util/virkeycode.h                     |  1 +
 src/util/virmacaddr.c                     |  1 +
 src/util/virmacaddr.h                     |  2 +-
 src/util/virmdev.c                        |  1 +
 src/util/virmdev.h                        |  2 +-
 src/util/virnetdev.c                      |  2 +
 src/util/virnetdev.h                      |  2 +-
 src/util/virnetdevip.c                    |  2 +
 src/util/virnetdevmacvlan.c               |  2 +
 src/util/virnetdevmacvlan.h               |  1 +
 src/util/virnetdevvlan.c                  |  1 +
 src/util/virnetdevvlan.h                  |  3 +-
 src/util/virnetdevvportprofile.c          |  2 +
 src/util/virnetdevvportprofile.h          |  1 +
 src/util/virnetlink.c                     |  1 +
 src/util/virnetlink.h                     |  1 -
 src/util/virobject.h                      | 10 +++
 src/util/virpci.c                         |  1 +
 src/util/virpci.h                         |  2 +-
 src/util/virperf.c                        |  2 +
 src/util/virperf.h                        |  3 +-
 src/util/virpidfile.c                     |  1 +
 src/util/virpolkit.c                      |  1 +
 src/util/virprocess.h                     |  1 +
 src/util/virresctrl.c                     |  1 +
 src/util/virresctrl.h                     |  2 +-
 src/util/virscsi.c                        |  1 +
 src/util/virscsi.h                        |  1 -
 src/util/virscsivhost.c                   |  1 +
 src/util/virscsivhost.h                   |  1 -
 src/util/virsecret.h                      |  1 +
 src/util/virsocketaddr.c                  |  1 +
 src/util/virsocketaddr.h                  |  2 +-
 src/util/virstorageencryption.h           |  1 +
 src/util/virstoragefile.h                 |  1 +
 src/util/virstring.h                      |  1 -
 src/util/virsysinfo.h                     |  1 +
 src/util/virtypedparam.h                  |  1 +
 src/util/virusb.c                         |  1 +
 src/util/virusb.h                         |  1 -
 src/util/virutil.c                        | 58 ---------------
 src/util/virutil.h                        | 55 --------------
 tests/eventtest.c                         |  1 +
 tests/objecteventtest.c                   |  2 +
 tests/qemusecuritymock.c                  |  1 +
 tests/scsihosttest.c                      |  1 +
 tests/vboxsnapshotxmltest.c               |  1 +
 tests/vircgroupmock.c                     |  1 +
 tests/virfiletest.c                       |  1 +
 tests/virfilewrapper.c                    |  1 +
 tests/virlockspacetest.c                  |  1 +
 tests/virnetdaemontest.c                  |  2 +
 tests/virnetsockettest.c                  |  1 +
 tests/virnettlscontexttest.c              |  1 +
 tests/virnettlshelpers.c                  |  1 +
 tests/virnettlssessiontest.c              |  1 +
 tests/virscsitest.c                       |  1 +
 tests/virstoragetest.c                    |  1 +
 tools/virt-host-validate-common.h         |  1 +
 123 files changed, 406 insertions(+), 223 deletions(-)
 create mode 100644 src/util/virautoclean.h
 create mode 100644 src/util/virenum.c
 create mode 100644 src/util/virenum.h

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list