[libvirt] [PATCH 0/7] Introduce automatic clearing for virBuffer

Peter Krempa posted 7 patches 5 years, 1 month ago
Failed in applying to current master (apply log)
src/libvirt_private.syms |   1 -
src/qemu/qemu_domain.c   |  27 +++-------
src/util/viralloc.h      |  32 +++++++++++-
src/util/virbuffer.c     | 107 ---------------------------------------
src/util/virbuffer.h     |   7 ++-
tests/virbuftest.c       |  57 +++++----------------
6 files changed, 56 insertions(+), 175 deletions(-)
[libvirt] [PATCH 0/7] Introduce automatic clearing for virBuffer
Posted by Peter Krempa 5 years, 1 month ago
First 4 patches clean up existing mess.

Note that this series both fixes and then deletes virBufferEscapeN.
The split is deliberate, so that if somebody needs virBufferEscapeN
in the future they can revert the removal and get a working version.

Peter Krempa (7):
  util: buffer: Remove misleading AUTOPTR func for 'virBuffer'
  util: buf: Fix memory leak in virBufferEscapeN
  tests: buf: Fix debug messages in 'testBufEscapeRegex'
  util: buf: Remove virBufferEscapeN
  util: alloc: Introduce 'VIR_AUTOCLEAN' macros for clearing stack'd
    structs
  util: buffer: Introduce VIR_AUTOCLEAN function for virBuffer
  qemu: domain: Use VIR_AUTOCLEAN for virBuffer

 src/libvirt_private.syms |   1 -
 src/qemu/qemu_domain.c   |  27 +++-------
 src/util/viralloc.h      |  32 +++++++++++-
 src/util/virbuffer.c     | 107 ---------------------------------------
 src/util/virbuffer.h     |   7 ++-
 tests/virbuftest.c       |  57 +++++----------------
 6 files changed, 56 insertions(+), 175 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/7] Introduce automatic clearing for virBuffer
Posted by Eric Blake 5 years, 1 month ago
On 2/21/19 9:50 AM, Peter Krempa wrote:
> First 4 patches clean up existing mess.
> 
> Note that this series both fixes and then deletes virBufferEscapeN.
> The split is deliberate, so that if somebody needs virBufferEscapeN
> in the future they can revert the removal and get a working version.
> 
> Peter Krempa (7):
>   util: buffer: Remove misleading AUTOPTR func for 'virBuffer'
>   util: buf: Fix memory leak in virBufferEscapeN
>   tests: buf: Fix debug messages in 'testBufEscapeRegex'
>   util: buf: Remove virBufferEscapeN
>   util: alloc: Introduce 'VIR_AUTOCLEAN' macros for clearing stack'd
>     structs
>   util: buffer: Introduce VIR_AUTOCLEAN function for virBuffer
>   qemu: domain: Use VIR_AUTOCLEAN for virBuffer

Mail delays prevent me from replying directly to the messages that have
not hit my inbox yet. I had some minor comments on 5, but trust you can
address those.

Series:
Reviewed-by: Eric Blake <eblake@redhat.com>

(And the longer I take to get my incremental backup stuff in, the more I
have to rebase it to start using more of these cool macros...)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list