[libvirt] [PATCH 0/5] Block job handling related fixes (blockdev-add saga)

Peter Krempa posted 5 patches 5 years, 2 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1548323820.git.pkrempa@redhat.com
include/libvirt/libvirt-domain.h |  3 ++-
src/qemu/qemu_blockjob.c         |  7 ++++++-
src/qemu/qemu_driver.c           | 34 ++++++++++++++------------------
3 files changed, 23 insertions(+), 21 deletions(-)
[libvirt] [PATCH 0/5] Block job handling related fixes (blockdev-add saga)
Posted by Peter Krempa 5 years, 2 months ago
Fix the generated documentation and clean up a few corner cases in
qemu's block job handling.

Peter Krempa (5):
  lib: Fix docs generated for enum virDomainBlockJobType
  qemu: blockjob: Make sure that internal states are not reported as
    event
  qemu: blockjob: Mark job as started only when it's new
  qemu: Clear block copy mirror state explicitly
  qemu: Don't double-free disk->mirror if block commit initialization
    fails

 include/libvirt/libvirt-domain.h |  3 ++-
 src/qemu/qemu_blockjob.c         |  7 ++++++-
 src/qemu/qemu_driver.c           | 34 ++++++++++++++------------------
 3 files changed, 23 insertions(+), 21 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/5] Block job handling related fixes (blockdev-add saga)
Posted by John Ferlan 5 years, 1 month ago

On 1/24/19 4:58 AM, Peter Krempa wrote:
> Fix the generated documentation and clean up a few corner cases in
> qemu's block job handling.
> 
> Peter Krempa (5):
>   lib: Fix docs generated for enum virDomainBlockJobType
>   qemu: blockjob: Make sure that internal states are not reported as
>     event
>   qemu: blockjob: Mark job as started only when it's new
>   qemu: Clear block copy mirror state explicitly
>   qemu: Don't double-free disk->mirror if block commit initialization
>     fails
> 
>  include/libvirt/libvirt-domain.h |  3 ++-
>  src/qemu/qemu_blockjob.c         |  7 ++++++-
>  src/qemu/qemu_driver.c           | 34 ++++++++++++++------------------
>  3 files changed, 23 insertions(+), 21 deletions(-)
> 

NIT, w/r/t patch2 - maybe a code comment regarding internal states would
help someone that trips across that code and wonders what the check is
for.  yes it's in the commit message, but not everyone goes back to the
commit that added the check to see why it was done that way.

Reviewed-by: John Ferlan <jferlan@redhat.com>
(series)

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list