[libvirt] [PATCH 00/11] qemu: format CCID controllers after USB hubs

Ján Tomko posted 11 patches 5 years, 2 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1547625223.git.jtomko@redhat.com
src/qemu/qemu_command.c                       | 222 +++++++++++-------
src/qemu/qemu_command.h                       |   3 +-
src/qemu/qemu_hotplug.c                       |   2 +-
tests/qemuxml2argvdata/chardev-reconnect.args |   2 +-
tests/qemuxml2argvdata/controller-order.args  |   2 +-
tests/qemuxml2argvdata/name-escape.args       |   2 +-
.../smartcard-controller.args                 |   2 +-
.../smartcard-host-certificates-database.args |   2 +-
.../smartcard-host-certificates.args          |   2 +-
tests/qemuxml2argvdata/smartcard-host.args    |   2 +-
.../smartcard-passthrough-spicevmc.args       |   2 +-
.../smartcard-passthrough-tcp.args            |   2 +-
tests/qemuxml2argvdata/user-aliases.args      |   2 +-
13 files changed, 150 insertions(+), 97 deletions(-)
[libvirt] [PATCH 00/11] qemu: format CCID controllers after USB hubs
Posted by Ján Tomko 5 years, 2 months ago
https://bugzilla.redhat.com/show_bug.cgi?id=1599971

Ján Tomko (11):
  qemu: move out legacy USB controller formatting
  qemu: exit early if USB_CONTROLLER_MODEL_NONE is present
  Add qemuBuildDomainForbidLegacyUSBController
  qemu: separate counting of legacy USB controllers
  qemu: separate counting of USB controllers
  qemuBuildControllerDevStr: remove nusbcontroller argument
  qemu: Introduce qemuBuildControllersByTypeCommandLine
  qemu: format CCID controllers after USB hubs
  qemuBuildControllersByTypeCommandLine: free devstr in the cleanup
    section
  rename qemuBuildControllerDevCommandLine
  qemuBuildControllersCommandLine: use i instead of j as the counter

 src/qemu/qemu_command.c                       | 222 +++++++++++-------
 src/qemu/qemu_command.h                       |   3 +-
 src/qemu/qemu_hotplug.c                       |   2 +-
 tests/qemuxml2argvdata/chardev-reconnect.args |   2 +-
 tests/qemuxml2argvdata/controller-order.args  |   2 +-
 tests/qemuxml2argvdata/name-escape.args       |   2 +-
 .../smartcard-controller.args                 |   2 +-
 .../smartcard-host-certificates-database.args |   2 +-
 .../smartcard-host-certificates.args          |   2 +-
 tests/qemuxml2argvdata/smartcard-host.args    |   2 +-
 .../smartcard-passthrough-spicevmc.args       |   2 +-
 .../smartcard-passthrough-tcp.args            |   2 +-
 tests/qemuxml2argvdata/user-aliases.args      |   2 +-
 13 files changed, 150 insertions(+), 97 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 00/11] qemu: format CCID controllers after USB hubs
Posted by Cole Robinson 5 years, 2 months ago
On 01/16/2019 02:56 AM, Ján Tomko wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1599971
> 
> Ján Tomko (11):
>   qemu: move out legacy USB controller formatting
>   qemu: exit early if USB_CONTROLLER_MODEL_NONE is present
>   Add qemuBuildDomainForbidLegacyUSBController
>   qemu: separate counting of legacy USB controllers
>   qemu: separate counting of USB controllers
>   qemuBuildControllerDevStr: remove nusbcontroller argument
>   qemu: Introduce qemuBuildControllersByTypeCommandLine
>   qemu: format CCID controllers after USB hubs
>   qemuBuildControllersByTypeCommandLine: free devstr in the cleanup
>     section
>   rename qemuBuildControllerDevCommandLine
>   qemuBuildControllersCommandLine: use i instead of j as the counter
> 
>  src/qemu/qemu_command.c                       | 222 +++++++++++-------
>  src/qemu/qemu_command.h                       |   3 +-
>  src/qemu/qemu_hotplug.c                       |   2 +-
>  tests/qemuxml2argvdata/chardev-reconnect.args |   2 +-
>  tests/qemuxml2argvdata/controller-order.args  |   2 +-
>  tests/qemuxml2argvdata/name-escape.args       |   2 +-
>  .../smartcard-controller.args                 |   2 +-
>  .../smartcard-host-certificates-database.args |   2 +-
>  .../smartcard-host-certificates.args          |   2 +-
>  tests/qemuxml2argvdata/smartcard-host.args    |   2 +-
>  .../smartcard-passthrough-spicevmc.args       |   2 +-
>  .../smartcard-passthrough-tcp.args            |   2 +-
>  tests/qemuxml2argvdata/user-aliases.args      |   2 +-
>  13 files changed, 150 insertions(+), 97 deletions(-)
> 

Reviewed-by: Cole Robinson <crobinso@redhat.com>

Nice cleanups. Would be nice to move that 'Multiple legacy' error to
Validate time, but that can come later

Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list