From nobody Fri Apr 26 14:39:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1546615390483225.60918226853346; Fri, 4 Jan 2019 07:23:10 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8A5EFC070146; Fri, 4 Jan 2019 15:23:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BC316063D; Fri, 4 Jan 2019 15:23:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9233E4108D; Fri, 4 Jan 2019 15:23:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x04FMjSX013996 for ; Fri, 4 Jan 2019 10:22:45 -0500 Received: by smtp.corp.redhat.com (Postfix) id 772275D9C6; Fri, 4 Jan 2019 15:22:45 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E41465D9C5 for ; Fri, 4 Jan 2019 15:22:44 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Fri, 4 Jan 2019 16:22:41 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] examples: add spaces after #include X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 04 Jan 2019 15:23:08 +0000 (UTC) Lead by example in examples/ Signed-off-by: J=C3=A1n Tomko Reviewed-by: Erik Skultety --- examples/admin/client_close.c | 8 ++++---- examples/admin/client_info.c | 10 +++++----- examples/admin/client_limits.c | 6 +++--- examples/admin/list_clients.c | 8 ++++---- examples/admin/list_servers.c | 6 +++--- examples/admin/logging.c | 12 ++++++------ examples/admin/threadpool_params.c | 6 +++--- 7 files changed, 28 insertions(+), 28 deletions(-) diff --git a/examples/admin/client_close.c b/examples/admin/client_close.c index a392707165..5c28ce7949 100644 --- a/examples/admin/client_close.c +++ b/examples/admin/client_close.c @@ -1,7 +1,7 @@ -#include -#include -#include -#include +#include +#include +#include +#include =20 int main(void) { diff --git a/examples/admin/client_info.c b/examples/admin/client_info.c index 57e9cd71ef..2c46ccf514 100644 --- a/examples/admin/client_info.c +++ b/examples/admin/client_info.c @@ -1,9 +1,9 @@ #define _GNU_SOURCE -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include =20 static const char * exampleTransportToString(int transport) diff --git a/examples/admin/client_limits.c b/examples/admin/client_limits.c index 2a1d6314ca..69b931682c 100644 --- a/examples/admin/client_limits.c +++ b/examples/admin/client_limits.c @@ -1,6 +1,6 @@ -#include -#include -#include +#include +#include +#include =20 int main(int argc, char **argv) { diff --git a/examples/admin/list_clients.c b/examples/admin/list_clients.c index 21ea4d818e..15205a7bd1 100644 --- a/examples/admin/list_clients.c +++ b/examples/admin/list_clients.c @@ -1,7 +1,7 @@ -#include -#include -#include -#include +#include +#include +#include +#include =20 static const char * exampleTransportToString(int transport) diff --git a/examples/admin/list_servers.c b/examples/admin/list_servers.c index 420fd5fb7b..e53cd3b48f 100644 --- a/examples/admin/list_servers.c +++ b/examples/admin/list_servers.c @@ -1,6 +1,6 @@ -#include -#include -#include +#include +#include +#include =20 int main(void) { diff --git a/examples/admin/logging.c b/examples/admin/logging.c index 648d7a6da9..dc1b23aab5 100644 --- a/examples/admin/logging.c +++ b/examples/admin/logging.c @@ -1,11 +1,11 @@ -#include -#include -#include +#include +#include +#include =20 #include "config.h" -#include -#include -#include +#include +#include +#include =20 static void printHelp(const char *argv0) { diff --git a/examples/admin/threadpool_params.c b/examples/admin/threadpool= _params.c index 43c71184a0..be833c2ea3 100644 --- a/examples/admin/threadpool_params.c +++ b/examples/admin/threadpool_params.c @@ -1,6 +1,6 @@ -#include -#include -#include +#include +#include +#include =20 int main(int argc, char **argv) { --=20 2.16.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 26 14:39:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1546615396069797.3063149796969; Fri, 4 Jan 2019 07:23:16 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D37D5C070473; Fri, 4 Jan 2019 15:23:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73501107A040; Fri, 4 Jan 2019 15:23:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AF5CE3F7D0; Fri, 4 Jan 2019 15:23:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x04FMkMY014001 for ; Fri, 4 Jan 2019 10:22:46 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4E15B5D9C6; Fri, 4 Jan 2019 15:22:46 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C52255D9C5 for ; Fri, 4 Jan 2019 15:22:45 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Fri, 4 Jan 2019 16:22:42 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] examples: include config.h X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 04 Jan 2019 15:23:14 +0000 (UTC) Since gnulib commit 6954995d unistd.h is included via stdlib.h on BSD systems, which requires config.h to be included first. Add config.h to the files that use it. Part of this commit reverts commit 6ee918de7462a20947241ec817c4571d6b84a716 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Erik Skultety --- examples/admin/client_close.c | 2 ++ examples/admin/client_info.c | 3 ++- examples/admin/client_limits.c | 2 ++ examples/admin/list_clients.c | 2 ++ examples/admin/list_servers.c | 2 ++ examples/admin/logging.c | 3 ++- examples/admin/threadpool_params.c | 2 ++ examples/dommigrate/dommigrate.c | 2 ++ examples/hellolibvirt/hellolibvirt.c | 2 ++ examples/openauth/openauth.c | 2 ++ examples/rename/rename.c | 2 ++ 11 files changed, 22 insertions(+), 2 deletions(-) diff --git a/examples/admin/client_close.c b/examples/admin/client_close.c index 5c28ce7949..9b7e1febb1 100644 --- a/examples/admin/client_close.c +++ b/examples/admin/client_close.c @@ -1,3 +1,5 @@ +#include + #include #include #include diff --git a/examples/admin/client_info.c b/examples/admin/client_info.c index 2c46ccf514..550a24824a 100644 --- a/examples/admin/client_info.c +++ b/examples/admin/client_info.c @@ -1,4 +1,5 @@ -#define _GNU_SOURCE +#include + #include #include #include diff --git a/examples/admin/client_limits.c b/examples/admin/client_limits.c index 69b931682c..a87cb52c82 100644 --- a/examples/admin/client_limits.c +++ b/examples/admin/client_limits.c @@ -1,3 +1,5 @@ +#include + #include #include #include diff --git a/examples/admin/list_clients.c b/examples/admin/list_clients.c index 15205a7bd1..1d961a1ec9 100644 --- a/examples/admin/list_clients.c +++ b/examples/admin/list_clients.c @@ -1,3 +1,5 @@ +#include + #include #include #include diff --git a/examples/admin/list_servers.c b/examples/admin/list_servers.c index e53cd3b48f..d48d87af6e 100644 --- a/examples/admin/list_servers.c +++ b/examples/admin/list_servers.c @@ -1,3 +1,5 @@ +#include + #include #include #include diff --git a/examples/admin/logging.c b/examples/admin/logging.c index dc1b23aab5..10952afa03 100644 --- a/examples/admin/logging.c +++ b/examples/admin/logging.c @@ -1,8 +1,9 @@ +#include + #include #include #include =20 -#include "config.h" #include #include #include diff --git a/examples/admin/threadpool_params.c b/examples/admin/threadpool= _params.c index be833c2ea3..9517dcb0f2 100644 --- a/examples/admin/threadpool_params.c +++ b/examples/admin/threadpool_params.c @@ -1,3 +1,5 @@ +#include + #include #include #include diff --git a/examples/dommigrate/dommigrate.c b/examples/dommigrate/dommigr= ate.c index 1b6072d138..71a0af4058 100644 --- a/examples/dommigrate/dommigrate.c +++ b/examples/dommigrate/dommigrate.c @@ -20,6 +20,8 @@ * . */ =20 +#include + #include #include #include diff --git a/examples/hellolibvirt/hellolibvirt.c b/examples/hellolibvirt/h= ellolibvirt.c index bfb12846e6..02c4401987 100644 --- a/examples/hellolibvirt/hellolibvirt.c +++ b/examples/hellolibvirt/hellolibvirt.c @@ -2,6 +2,8 @@ * hypervisor and gather a few bits of information about domains. * Similar API's exist for storage pools, networks, and interfaces. */ =20 +#include + #include #include #include diff --git a/examples/openauth/openauth.c b/examples/openauth/openauth.c index efd21c374f..eef46d5f52 100644 --- a/examples/openauth/openauth.c +++ b/examples/openauth/openauth.c @@ -1,6 +1,8 @@ /* This is a copy of the hellolibvirt example demonstaring how to use * virConnectOpenAuth with a custom auth callback */ =20 +#include + #include #include #include diff --git a/examples/rename/rename.c b/examples/rename/rename.c index 85f18e9df3..c64dd5baa3 100644 --- a/examples/rename/rename.c +++ b/examples/rename/rename.c @@ -16,6 +16,8 @@ * . */ =20 +#include + #include #include #include --=20 2.16.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list