[libvirt] [PATCH v2 0/9] util: error: Reformat error messages and add tests

Peter Krempa posted 9 patches 5 years, 3 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1544712448.git.pkrempa@redhat.com
include/libvirt/virterror.h |   5 +
src/libvirt_private.syms    |   2 +
src/util/Makefile.inc.am    |   1 +
src/util/virerror.c         | 738 +++++++-----------------------------
src/util/virerrorpriv.h     |  28 ++
tests/Makefile.am           |   6 +
tests/virerrormessages.txt  | 101 +++++
tests/virerrortest.c        | 126 ++++++
8 files changed, 405 insertions(+), 602 deletions(-)
create mode 100644 src/util/virerrorpriv.h
create mode 100644 tests/virerrormessages.txt
create mode 100644 tests/virerrortest.c
[libvirt] [PATCH v2 0/9] util: error: Reformat error messages and add tests
Posted by Peter Krempa 5 years, 3 months ago
V2 fixes gettext and simplifies some parts. Patch 4/9 is new and the
last two were dropped in comparison to v1.

Peter Krempa (9):
  include: error: Add enum sentinel for virErrorNumber enum
  util: error: Fix error message strings to play well with additional
    info
  util: error: Add error message versions with info for some error codes
  util: error: Reword some unused error messages
  util: error: Export virErrorMsg for use in testsuite
  tests: Add test for virErrorMsg message constraints
  util: error: Improve docs for virErrorMsg
  DO NOT PUSH: Make sure that error messages are not moved around
  util: error: Put error code messages into an array

 include/libvirt/virterror.h |   5 +
 src/libvirt_private.syms    |   2 +
 src/util/Makefile.inc.am    |   1 +
 src/util/virerror.c         | 738 +++++++-----------------------------
 src/util/virerrorpriv.h     |  28 ++
 tests/Makefile.am           |   6 +
 tests/virerrormessages.txt  | 101 +++++
 tests/virerrortest.c        | 126 ++++++
 8 files changed, 405 insertions(+), 602 deletions(-)
 create mode 100644 src/util/virerrorpriv.h
 create mode 100644 tests/virerrormessages.txt
 create mode 100644 tests/virerrortest.c

-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list