From nobody Wed May 8 19:34:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1536137753780661.6157759608673; Wed, 5 Sep 2018 01:55:53 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5200D30832D8; Wed, 5 Sep 2018 08:55:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 202C519498; Wed, 5 Sep 2018 08:55:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BA27F4A464; Wed, 5 Sep 2018 08:55:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w858tjN8032556 for ; Wed, 5 Sep 2018 04:55:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id 21B4B1010432; Wed, 5 Sep 2018 08:55:45 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id B733F101B733 for ; Wed, 5 Sep 2018 08:55:44 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 5 Sep 2018 10:55:38 +0200 Message-Id: <03feab486770cdf48ed82816cf36c5a870e58390.1536137658.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [libvirt-snmp][PATCH 1/3] Generate AUTHORS from git log X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 05 Sep 2018 08:55:52 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Adding new contributor to the list is something I keep forgetting about. Therefore switch to autogenerated list of contributors, just like every other libvirt project is doing so. Signed-off-by: Michal Privoznik Reviewed-by: J=EF=BF=BDn Tomko --- .gitignore | 4 ++-- AUTHORS =3D> AUTHORS.in | 12 +++++------- Makefile.am | 30 +++++++++++++++++++++--------- autogen.sh | 10 ++++++---- 4 files changed, 34 insertions(+), 22 deletions(-) rename AUTHORS =3D> AUTHORS.in (44%) diff --git a/.gitignore b/.gitignore index 2193ea2..aae9628 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,5 @@ -#*# -*.#*# +AUTHORS +ChangeLog *.a *.exe *.gcda diff --git a/AUTHORS b/AUTHORS.in similarity index 44% rename from AUTHORS rename to AUTHORS.in index 79dcc0e..d117ae4 100644 --- a/AUTHORS +++ b/AUTHORS.in @@ -1,5 +1,5 @@ - libvirt-snmp - =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + libvirt-snmp Authors + =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 =20 The main work done by: @@ -13,8 +13,6 @@ Autoconfiscated by: =20 Patches have also been contributed by: =20 - Daniel P. Berrange - Doug Goldstein - Laine Stump - Martin Kletzander - Jorge Boncompte +#authorslist# + + ... send patches to get your name added ... diff --git a/Makefile.am b/Makefile.am index ae1cd79..9ac6fc2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -3,18 +3,30 @@ SUBDIRS=3Dsrc/ docs/ EXTRA_DIST =3D \ libvirt-snmp.spec libvirt-snmp.spec.in \ autobuild.sh \ - autogen.sh + autogen.sh \ + AUTHORS.in \ + $(NULL) =20 rpm: clean @(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.gz) =20 +dist-hook: gen-ChangeLog gen-AUTHORS + +# Generate the ChangeLog file (with all entries since the switch to git) +# and insert it into the directory we're about to use to create a tarball. +.PHONY: gen-ChangeLog gen-AUTHORS gen-ChangeLog: - if [ -d .git ]; then \ - git log --oneline | sed 's/[0-9a-f]* \(.*\)/\1/' > $(distdir)/ChangeLog= ; \ - else \ - echo "Prevent non-empty ChangeLog" > $(distdir)/ChangeLog ;\ - fi + if test -d .git || test -d ../.git; then \ + $(top_srcdir)/build-aux/gitlog-to-changelog \ + > $(distdir)/cl-t; \ + rm -f $(distdir)/ChangeLog; \ + mv $(distdir)/cl-t $(distdir)/ChangeLog; \ + fi =20 -.PHONY: gen-ChangeLog - -dist-hook: gen-ChangeLog +gen-AUTHORS: + $(AM_V_GEN)if test -d $(srcdir)/.git; then \ + out=3D"`cd $(srcdir) && git log --pretty=3Dformat:'%aN <%aE>' | sort -u= `" && \ + perl -p -e "s/#authorslist#// and print '$$out'" \ + < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \ + mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS ; \ + fi diff --git a/autogen.sh b/autogen.sh index 5d00494..12d0dc0 100755 --- a/autogen.sh +++ b/autogen.sh @@ -15,11 +15,13 @@ if test -z "$*"; then fi =20 # Automake requires that ChangeLog exist. -if test ! -f ChangeLog; then - touch ChangeLog || exit 1 -fi +# Real ChangeLog/AUTHORS is auto-generated from GIT logs at +# make dist time, but automake requires that it +# exists at all times :-( +touch ChangeLog AUTHORS =20 -autoreconf -i -f +mkdir -p build-aux +autoreconf -if =20 cd $THEDIR =20 --=20 2.16.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Wed May 8 19:34:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1536137751777827.8535091721833; Wed, 5 Sep 2018 01:55:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 16E7F368E7; Wed, 5 Sep 2018 08:55:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C74EE173D9; Wed, 5 Sep 2018 08:55:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 71C0618005DF; Wed, 5 Sep 2018 08:55:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w858tl5h032578 for ; Wed, 5 Sep 2018 04:55:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id 103EC1010432; Wed, 5 Sep 2018 08:55:47 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id A54121040840 for ; Wed, 5 Sep 2018 08:55:45 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 5 Sep 2018 10:55:39 +0200 Message-Id: <097cc11f90c5c04b1b8289863bab758ab70a2080.1536137658.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [libvirt-snmp][PATCH 2/3] Makefile: Introduce srpm target X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 05 Sep 2018 08:55:50 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Just like we have 'rpm' we might have 'srpm'. Signed-off-by: Michal Privoznik --- Makefile.am | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9ac6fc2..6ce91ed 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,14 +1,18 @@ SUBDIRS=3Dsrc/ docs/ =20 EXTRA_DIST =3D \ - libvirt-snmp.spec libvirt-snmp.spec.in \ + $(PACKAGE).spec \ + $(PACKAGE).spec.in \ autobuild.sh \ autogen.sh \ AUTHORS.in \ $(NULL) =20 rpm: clean - @(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.gz) + @(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.xz) + +srpm: clean + @(unset CDPATH ; $(MAKE) dist && rpmbuild -ts $(distdir).tar.xz) =20 dist-hook: gen-ChangeLog gen-AUTHORS =20 --=20 2.16.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Wed May 8 19:34:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1536137758466846.2105415253656; Wed, 5 Sep 2018 01:55:58 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC961308A95E; Wed, 5 Sep 2018 08:55:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7343C60922; Wed, 5 Sep 2018 08:55:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 20A25181A12E; Wed, 5 Sep 2018 08:55:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w858tlbg032584 for ; Wed, 5 Sep 2018 04:55:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id AB9E110FD2BE; Wed, 5 Sep 2018 08:55:47 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D2051018CA8 for ; Wed, 5 Sep 2018 08:55:47 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 5 Sep 2018 10:55:40 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [libvirt-snmp][PATCH 3/3] configure: Prevent autoreconf from installing `compile' file X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 05 Sep 2018 08:55:57 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" When running autoreconf, it installs this `compile' file which triggers my OCD. It appears that our configure script can be modernized a bit which makes it stop. Signed-off-by: Michal Privoznik Reviewed-by: J=EF=BF=BDn Tomko --- configure.ac | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index f520927..c8df41d 100644 --- a/configure.ac +++ b/configure.ac @@ -1,8 +1,12 @@ AC_INIT([libvirt-snmp],[0.0.3],[libvir-list@redhat.com],[],[http://libvirt= .org]) -AM_INIT_AUTOMAKE([-Wall -Werror]) +AC_CONFIG_SRCDIR(src/libvirtSnmp.c) +AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) +AM_INIT_AUTOMAKE([-Wall -Werror]) =20 -AC_PREREQ([2.50]) +AC_CANONICAL_HOST + +AM_SILENT_RULES([yes]) =20 AC_PROG_CC AM_PROG_CC_C_O --=20 2.16.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list