From nobody Sat May 4 01:24:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1519050128952333.47107154243656; Mon, 19 Feb 2018 06:22:08 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 27AA43DE42; Mon, 19 Feb 2018 14:22:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF79B5D9C6; Mon, 19 Feb 2018 14:22:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6940841F67; Mon, 19 Feb 2018 14:22:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w1JEM4qq006339 for ; Mon, 19 Feb 2018 09:22:04 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9E79A1C73C; Mon, 19 Feb 2018 14:22:04 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46A7F1C72F for ; Mon, 19 Feb 2018 14:22:04 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Mon, 19 Feb 2018 15:21:58 +0100 Message-Id: <6be010b48e7a3bb0b15768f6b344f63f22e2beba.1519050033.git.phrdina@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [python PATCH 1/4] Use static variables to store virPyDictToTypedParams hints X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 19 Feb 2018 14:22:08 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" There is no need to have dynamic allocation every time the API is called. Rewrites commit <314b2346df>. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- libvirt-override.c | 149 ++++++++++++-------------------------------------= ---- libvirt-utils.h | 2 + 2 files changed, 34 insertions(+), 117 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index dba42d4..ab4232f 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -7739,6 +7739,25 @@ libvirt_virDomainMigrateGetMaxDowntime(PyObject *sel= f ATTRIBUTE_UNUSED, #endif /* LIBVIR_CHECK_VERSION(3, 7, 0) */ =20 #if LIBVIR_CHECK_VERSION(1, 1, 0) +static virPyTypedParamsHint virPyDomainMigrate3Params[] =3D { + { VIR_MIGRATE_PARAM_URI, VIR_TYPED_PARAM_STRING }, + { VIR_MIGRATE_PARAM_DEST_NAME, VIR_TYPED_PARAM_STRING }, + { VIR_MIGRATE_PARAM_DEST_XML, VIR_TYPED_PARAM_STRING }, + { VIR_MIGRATE_PARAM_GRAPHICS_URI, VIR_TYPED_PARAM_STRING }, + { VIR_MIGRATE_PARAM_BANDWIDTH, VIR_TYPED_PARAM_ULLONG }, + { VIR_MIGRATE_PARAM_LISTEN_ADDRESS, VIR_TYPED_PARAM_STRING }, + { VIR_MIGRATE_PARAM_DISKS_PORT, VIR_TYPED_PARAM_INT }, + { VIR_MIGRATE_PARAM_COMPRESSION, VIR_TYPED_PARAM_STRING }, + { VIR_MIGRATE_PARAM_COMPRESSION_MT_DTHREADS, VIR_TYPED_PARAM_INT }, + { VIR_MIGRATE_PARAM_COMPRESSION_MT_LEVEL, VIR_TYPED_PARAM_INT }, + { VIR_MIGRATE_PARAM_COMPRESSION_MT_THREADS, VIR_TYPED_PARAM_INT }, + { VIR_MIGRATE_PARAM_COMPRESSION_XBZRLE_CACHE, VIR_TYPED_PARAM_ULLONG }, + { VIR_MIGRATE_PARAM_PERSIST_XML, VIR_TYPED_PARAM_STRING }, + { VIR_MIGRATE_PARAM_AUTO_CONVERGE_INITIAL, VIR_TYPED_PARAM_INT }, + { VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT, VIR_TYPED_PARAM_INT }, +}; + + static PyObject * libvirt_virDomainMigrate3(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) @@ -7750,9 +7769,7 @@ libvirt_virDomainMigrate3(PyObject *self ATTRIBUTE_UN= USED, PyObject *dict; unsigned int flags; virTypedParameterPtr params; - virPyTypedParamsHintPtr hparams; int nparams =3D 0; - int nhparams =3D 15; virDomainPtr ddom =3D NULL; =20 if (!PyArg_ParseTuple(args, (char *) "OOOI:virDomainMigrate3", @@ -7762,55 +7779,9 @@ libvirt_virDomainMigrate3(PyObject *self ATTRIBUTE_U= NUSED, domain =3D (virDomainPtr) PyvirDomain_Get(pyobj_domain); dconn =3D (virConnectPtr) PyvirConnect_Get(pyobj_dconn); =20 - hparams =3D malloc(sizeof(virPyTypedParamsHint) * nhparams); - hparams[0].name =3D VIR_MIGRATE_PARAM_URI; - hparams[0].type =3D VIR_TYPED_PARAM_STRING; - - hparams[1].name =3D VIR_MIGRATE_PARAM_DEST_NAME; - hparams[1].type =3D VIR_TYPED_PARAM_STRING; - - hparams[2].name =3D VIR_MIGRATE_PARAM_DEST_XML; - hparams[2].type =3D VIR_TYPED_PARAM_STRING; - - hparams[3].name =3D VIR_MIGRATE_PARAM_GRAPHICS_URI; - hparams[3].type =3D VIR_TYPED_PARAM_STRING; - - hparams[4].name =3D VIR_MIGRATE_PARAM_BANDWIDTH; - hparams[4].type =3D VIR_TYPED_PARAM_ULLONG; - - hparams[5].name =3D VIR_MIGRATE_PARAM_LISTEN_ADDRESS; - hparams[5].type =3D VIR_TYPED_PARAM_STRING; - - hparams[6].name =3D VIR_MIGRATE_PARAM_DISKS_PORT; - hparams[6].type =3D VIR_TYPED_PARAM_INT; - - hparams[7].name =3D VIR_MIGRATE_PARAM_COMPRESSION; - hparams[7].type =3D VIR_TYPED_PARAM_STRING; - - hparams[8].name =3D VIR_MIGRATE_PARAM_COMPRESSION_MT_DTHREADS; - hparams[8].type =3D VIR_TYPED_PARAM_INT; - - hparams[9].name =3D VIR_MIGRATE_PARAM_COMPRESSION_MT_LEVEL; - hparams[9].type =3D VIR_TYPED_PARAM_INT; - - hparams[10].name =3D VIR_MIGRATE_PARAM_COMPRESSION_MT_THREADS; - hparams[10].type =3D VIR_TYPED_PARAM_INT; - - hparams[11].name =3D VIR_MIGRATE_PARAM_COMPRESSION_XBZRLE_CACHE; - hparams[11].type =3D VIR_TYPED_PARAM_ULLONG; - - hparams[12].name =3D VIR_MIGRATE_PARAM_PERSIST_XML; - hparams[12].type =3D VIR_TYPED_PARAM_STRING; - - hparams[13].name =3D VIR_MIGRATE_PARAM_AUTO_CONVERGE_INITIAL; - hparams[13].type =3D VIR_TYPED_PARAM_INT; - - hparams[14].name =3D VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT; - hparams[14].type =3D VIR_TYPED_PARAM_INT; - if (virPyDictToTypedParams(dict, ¶ms, &nparams, - hparams, nhparams) < 0) { - free(hparams); + virPyDomainMigrate3Params, + VIR_N_ELEMENTS(virPyDomainMigrate3Params)) = < 0) { return NULL; } =20 @@ -7819,7 +7790,6 @@ libvirt_virDomainMigrate3(PyObject *self ATTRIBUTE_UN= USED, LIBVIRT_END_ALLOW_THREADS; =20 virTypedParamsFree(params, nparams); - free(hparams); return libvirt_virDomainPtrWrap(ddom); } =20 @@ -7833,9 +7803,7 @@ libvirt_virDomainMigrateToURI3(PyObject *self ATTRIBU= TE_UNUSED, PyObject *dict; unsigned int flags; virTypedParameterPtr params; - virPyTypedParamsHintPtr hparams; int nparams; - int nhparams =3D 15; int ret =3D -1; =20 if (!PyArg_ParseTuple(args, (char *) "OzOI:virDomainMigrate3", @@ -7844,55 +7812,9 @@ libvirt_virDomainMigrateToURI3(PyObject *self ATTRIB= UTE_UNUSED, =20 domain =3D (virDomainPtr) PyvirDomain_Get(pyobj_domain); =20 - hparams =3D malloc(sizeof(virPyTypedParamsHint) * nhparams); - hparams[0].name =3D VIR_MIGRATE_PARAM_URI; - hparams[0].type =3D VIR_TYPED_PARAM_STRING; - - hparams[1].name =3D VIR_MIGRATE_PARAM_DEST_NAME; - hparams[1].type =3D VIR_TYPED_PARAM_STRING; - - hparams[2].name =3D VIR_MIGRATE_PARAM_DEST_XML; - hparams[2].type =3D VIR_TYPED_PARAM_STRING; - - hparams[3].name =3D VIR_MIGRATE_PARAM_GRAPHICS_URI; - hparams[3].type =3D VIR_TYPED_PARAM_STRING; - - hparams[4].name =3D VIR_MIGRATE_PARAM_BANDWIDTH; - hparams[4].type =3D VIR_TYPED_PARAM_ULLONG; - - hparams[5].name =3D VIR_MIGRATE_PARAM_LISTEN_ADDRESS; - hparams[5].type =3D VIR_TYPED_PARAM_STRING; - - hparams[6].name =3D VIR_MIGRATE_PARAM_DISKS_PORT; - hparams[6].type =3D VIR_TYPED_PARAM_INT; - - hparams[7].name =3D VIR_MIGRATE_PARAM_COMPRESSION; - hparams[7].type =3D VIR_TYPED_PARAM_STRING; - - hparams[8].name =3D VIR_MIGRATE_PARAM_COMPRESSION_MT_DTHREADS; - hparams[8].type =3D VIR_TYPED_PARAM_INT; - - hparams[9].name =3D VIR_MIGRATE_PARAM_COMPRESSION_MT_LEVEL; - hparams[9].type =3D VIR_TYPED_PARAM_INT; - - hparams[10].name =3D VIR_MIGRATE_PARAM_COMPRESSION_MT_THREADS; - hparams[10].type =3D VIR_TYPED_PARAM_INT; - - hparams[11].name =3D VIR_MIGRATE_PARAM_COMPRESSION_XBZRLE_CACHE; - hparams[11].type =3D VIR_TYPED_PARAM_ULLONG; - - hparams[12].name =3D VIR_MIGRATE_PARAM_PERSIST_XML; - hparams[12].type =3D VIR_TYPED_PARAM_STRING; - - hparams[13].name =3D VIR_MIGRATE_PARAM_AUTO_CONVERGE_INITIAL; - hparams[13].type =3D VIR_TYPED_PARAM_INT; - - hparams[14].name =3D VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT; - hparams[14].type =3D VIR_TYPED_PARAM_INT; - if (virPyDictToTypedParams(dict, ¶ms, &nparams, - hparams, nhparams) < 0) { - free(hparams); + virPyDomainMigrate3Params, + VIR_N_ELEMENTS(virPyDomainMigrate3Params)) = < 0) { return NULL; } =20 @@ -7901,7 +7823,6 @@ libvirt_virDomainMigrateToURI3(PyObject *self ATTRIBU= TE_UNUSED, LIBVIRT_END_ALLOW_THREADS; =20 virTypedParamsFree(params, nparams); - free(hparams); return libvirt_intWrap(ret); } #endif /* LIBVIR_CHECK_VERSION(1, 1, 0) */ @@ -8743,6 +8664,13 @@ libvirt_virDomainListGetStats(PyObject *self ATTRIBU= TE_UNUSED, } =20 =20 +static virPyTypedParamsHint virPyDomainBlockCopyParams[] =3D { + { VIR_DOMAIN_BLOCK_COPY_BANDWIDTH, VIR_TYPED_PARAM_ULLONG }, + { VIR_DOMAIN_BLOCK_COPY_GRANULARITY, VIR_TYPED_PARAM_UINT }, + { VIR_DOMAIN_BLOCK_COPY_BUF_SIZE, VIR_TYPED_PARAM_UINT }, +}; + + static PyObject * libvirt_virDomainBlockCopy(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) @@ -8754,9 +8682,7 @@ libvirt_virDomainBlockCopy(PyObject *self ATTRIBUTE_U= NUSED, char *disk =3D NULL; char *destxml =3D NULL; virTypedParameterPtr params =3D NULL; - virPyTypedParamsHintPtr hparams; int nparams =3D 0; - int nhparams =3D 3; unsigned int flags =3D 0; int c_retval; =20 @@ -8765,22 +8691,11 @@ libvirt_virDomainBlockCopy(PyObject *self ATTRIBUTE= _UNUSED, return NULL; =20 if (PyDict_Check(pyobj_dict)) { - hparams =3D malloc(sizeof(virPyTypedParamsHint) * nhparams); - hparams[0].name =3D VIR_DOMAIN_BLOCK_COPY_BANDWIDTH; - hparams[0].type =3D VIR_TYPED_PARAM_ULLONG; - - hparams[1].name =3D VIR_DOMAIN_BLOCK_COPY_GRANULARITY; - hparams[1].type =3D VIR_TYPED_PARAM_UINT; - - hparams[2].name =3D VIR_DOMAIN_BLOCK_COPY_BUF_SIZE; - hparams[2].type =3D VIR_TYPED_PARAM_UINT; - if (virPyDictToTypedParams(pyobj_dict, ¶ms, &nparams, - hparams, nhparams) < 0) { - free(hparams); + virPyDomainBlockCopyParams, + VIR_N_ELEMENTS(virPyDomainBlockCopyPara= ms)) < 0) { return NULL; } - free(hparams); } =20 dom =3D (virDomainPtr) PyvirDomain_Get(pyobj_dom); diff --git a/libvirt-utils.h b/libvirt-utils.h index 779fd56..0af1e62 100644 --- a/libvirt-utils.h +++ b/libvirt-utils.h @@ -146,6 +146,8 @@ void virFree(void *ptrptr) ATTRIBUTE_NONNULL(1); # endif =20 =20 +#define VIR_N_ELEMENTS(array) (sizeof(array) / sizeof(*(array))) + /* The two-statement sequence "Py_INCREF(Py_None); return Py_None;" is so common that we encapsulate it here. Now, each use is simply return VIR_PY_NONE; */ --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 01:24:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1519050136249934.752303571967; Mon, 19 Feb 2018 06:22:16 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 593D1780EC; Mon, 19 Feb 2018 14:22:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22FAF5C579; Mon, 19 Feb 2018 14:22:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D067441F6A; Mon, 19 Feb 2018 14:22:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w1JEM5cu006352 for ; Mon, 19 Feb 2018 09:22:05 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3CF6E23167; Mon, 19 Feb 2018 14:22:05 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id D66911C72F for ; Mon, 19 Feb 2018 14:22:04 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Mon, 19 Feb 2018 15:21:59 +0100 Message-Id: <1fed9d858651390db84c0ac4e230a24e3ae114b8.1519050033.git.phrdina@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [python PATCH 2/4] Fix order of virPyDictToTypedParams hints X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 19 Feb 2018 14:22:15 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This corresponds to the order in libvirt-domain.h header file. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- libvirt-override.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index ab4232f..4f546b4 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -7743,16 +7743,16 @@ static virPyTypedParamsHint virPyDomainMigrate3Para= ms[] =3D { { VIR_MIGRATE_PARAM_URI, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_DEST_NAME, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_DEST_XML, VIR_TYPED_PARAM_STRING }, - { VIR_MIGRATE_PARAM_GRAPHICS_URI, VIR_TYPED_PARAM_STRING }, + { VIR_MIGRATE_PARAM_PERSIST_XML, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_BANDWIDTH, VIR_TYPED_PARAM_ULLONG }, + { VIR_MIGRATE_PARAM_GRAPHICS_URI, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_LISTEN_ADDRESS, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_DISKS_PORT, VIR_TYPED_PARAM_INT }, { VIR_MIGRATE_PARAM_COMPRESSION, VIR_TYPED_PARAM_STRING }, - { VIR_MIGRATE_PARAM_COMPRESSION_MT_DTHREADS, VIR_TYPED_PARAM_INT }, { VIR_MIGRATE_PARAM_COMPRESSION_MT_LEVEL, VIR_TYPED_PARAM_INT }, { VIR_MIGRATE_PARAM_COMPRESSION_MT_THREADS, VIR_TYPED_PARAM_INT }, + { VIR_MIGRATE_PARAM_COMPRESSION_MT_DTHREADS, VIR_TYPED_PARAM_INT }, { VIR_MIGRATE_PARAM_COMPRESSION_XBZRLE_CACHE, VIR_TYPED_PARAM_ULLONG }, - { VIR_MIGRATE_PARAM_PERSIST_XML, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_AUTO_CONVERGE_INITIAL, VIR_TYPED_PARAM_INT }, { VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT, VIR_TYPED_PARAM_INT }, }; --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 01:24:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15190501369321009.4077379491649; Mon, 19 Feb 2018 06:22:16 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC86D5B2FD; Mon, 19 Feb 2018 14:22:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A8245D9CB; Mon, 19 Feb 2018 14:22:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5220818033E5; Mon, 19 Feb 2018 14:22:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w1JEM5Xa006364 for ; Mon, 19 Feb 2018 09:22:06 -0500 Received: by smtp.corp.redhat.com (Postfix) id CCAC11C73C; Mon, 19 Feb 2018 14:22:05 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 753211C72F for ; Mon, 19 Feb 2018 14:22:05 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Mon, 19 Feb 2018 15:22:00 +0100 Message-Id: <0a44f41d328de2884703ac92da08e60c94eb79a2.1519050033.git.phrdina@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [python PATCH 3/4] Add missing virPyDictToTypedParams hint for migration params X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 19 Feb 2018 14:22:15 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- libvirt-override.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt-override.c b/libvirt-override.c index 4f546b4..59c1e0c 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -7747,6 +7747,7 @@ static virPyTypedParamsHint virPyDomainMigrate3Params= [] =3D { { VIR_MIGRATE_PARAM_BANDWIDTH, VIR_TYPED_PARAM_ULLONG }, { VIR_MIGRATE_PARAM_GRAPHICS_URI, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_LISTEN_ADDRESS, VIR_TYPED_PARAM_STRING }, + { VIR_MIGRATE_PARAM_MIGRATE_DISKS, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_DISKS_PORT, VIR_TYPED_PARAM_INT }, { VIR_MIGRATE_PARAM_COMPRESSION, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_COMPRESSION_MT_LEVEL, VIR_TYPED_PARAM_INT }, --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 01:24:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1519050142130977.2734835264811; Mon, 19 Feb 2018 06:22:22 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D05D96AAE7; Mon, 19 Feb 2018 14:22:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A149F18215; Mon, 19 Feb 2018 14:22:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 68DA7181A881; Mon, 19 Feb 2018 14:22:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w1JEM6Hk006370 for ; Mon, 19 Feb 2018 09:22:06 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6862A1C72F; Mon, 19 Feb 2018 14:22:06 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10CB59C047 for ; Mon, 19 Feb 2018 14:22:05 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Mon, 19 Feb 2018 15:22:01 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [python PATCH 4/4] Fix virPyDictToTypedParams type hint for block copy params X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 19 Feb 2018 14:22:21 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- libvirt-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-override.c b/libvirt-override.c index 59c1e0c..580c259 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -8668,7 +8668,7 @@ libvirt_virDomainListGetStats(PyObject *self ATTRIBUT= E_UNUSED, static virPyTypedParamsHint virPyDomainBlockCopyParams[] =3D { { VIR_DOMAIN_BLOCK_COPY_BANDWIDTH, VIR_TYPED_PARAM_ULLONG }, { VIR_DOMAIN_BLOCK_COPY_GRANULARITY, VIR_TYPED_PARAM_UINT }, - { VIR_DOMAIN_BLOCK_COPY_BUF_SIZE, VIR_TYPED_PARAM_UINT }, + { VIR_DOMAIN_BLOCK_COPY_BUF_SIZE, VIR_TYPED_PARAM_ULLONG }, }; =20 =20 --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list