From nobody Sun Apr 28 18:10:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1511963926621370.84251542283585; Wed, 29 Nov 2017 05:58:46 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 895E8C001600; Wed, 29 Nov 2017 13:58:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B2C6600D5; Wed, 29 Nov 2017 13:58:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2F0441800BDA; Wed, 29 Nov 2017 13:58:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vATDwdRC005828 for ; Wed, 29 Nov 2017 08:58:39 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0580D60621; Wed, 29 Nov 2017 13:58:39 +0000 (UTC) Received: from mamuti.net (unknown [10.40.205.100]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CBEA76062D for ; Wed, 29 Nov 2017 13:58:36 +0000 (UTC) Received: by mamuti.net (Postfix, from userid 500) id 957B61003C2; Wed, 29 Nov 2017 14:58:34 +0100 (CET) From: Jiri Denemark To: libvir-list@redhat.com Date: Wed, 29 Nov 2017 14:58:32 +0100 Message-Id: <33f09cde9e0f8428311f42af138cdd23c048d36f.1511963877.git.jdenemar@redhat.com> In-Reply-To: References: In-Reply-To: References: Mail-Followup-To: libvir-list@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] spec: Turn on verbose build X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 29 Nov 2017 13:58:45 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" When building a package in a build system, such as koji or cbs, logs are the only thing which can be used to diagnose failures. Make them verbose since human friendly output of V=3D0 build doesn't really help when a build fails. Signed-off-by: Jiri Denemark Reviewed-by: Pino Toscano --- libvirt.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b00689cabf..b88a977966 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1366,7 +1366,7 @@ rm -f po/stamp-po %{?enable_werror} \ --enable-expensive-tests \ %{arg_init_script} -make %{?_smp_mflags} +make %{?_smp_mflags} V=3D1 gzip -9 ChangeLog =20 %install @@ -1375,9 +1375,9 @@ rm -fr %{buildroot} # Avoid using makeinstall macro as it changes prefixes rather than setting # DESTDIR. Newer make_install macro would be better but it's not available # on RHEL 5, thus we need to expand it here. -make %{?_smp_mflags} install DESTDIR=3D%{?buildroot} SYSTEMD_UNIT_DIR=3D%{= _unitdir} +make %{?_smp_mflags} install DESTDIR=3D%{?buildroot} SYSTEMD_UNIT_DIR=3D%{= _unitdir} V=3D1 =20 -make %{?_smp_mflags} -C examples distclean +make %{?_smp_mflags} -C examples distclean V=3D1 =20 rm -f $RPM_BUILD_ROOT%{_libdir}/*.la rm -f $RPM_BUILD_ROOT%{_libdir}/*.a --=20 2.15.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun Apr 28 18:10:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1511963926754438.35088472578855; Wed, 29 Nov 2017 05:58:46 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A33518046E; Wed, 29 Nov 2017 13:58:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6268C5C552; Wed, 29 Nov 2017 13:58:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AA1453D380; Wed, 29 Nov 2017 13:58:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vATDwePI005847 for ; Wed, 29 Nov 2017 08:58:40 -0500 Received: by smtp.corp.redhat.com (Postfix) id B14DB5D964; Wed, 29 Nov 2017 13:58:40 +0000 (UTC) Received: from mamuti.net (unknown [10.40.205.100]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 81AFD5D976 for ; Wed, 29 Nov 2017 13:58:36 +0000 (UTC) Received: by mamuti.net (Postfix, from userid 500) id 979D8100E0B; Wed, 29 Nov 2017 14:58:34 +0100 (CET) From: Jiri Denemark To: libvir-list@redhat.com Date: Wed, 29 Nov 2017 14:58:33 +0100 Message-Id: <2b4c029316435fa2c1d3c72319250adb079064d6.1511963877.git.jdenemar@redhat.com> In-Reply-To: References: In-Reply-To: References: Mail-Followup-To: libvir-list@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] spec: Make the build reproducible X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 29 Nov 2017 13:58:46 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" If the spec file applies a patch which touches any file in the API XMLs dependency tree, we need to regenerate the XMLs and consequently recreate hvsupport.html. The file will contain a time stamp in a comment which means it will be different every time the package is built. The commit a54c9622860 which added the time stamp also added support for SOURCE_DATE_EPOCH environment variable. Let's set it to the time stamp of the spec file itself to make the build reproducible. Signed-off-by: Jiri Denemark Reviewed-by: Pino Toscano --- libvirt.spec.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index b88a977966..7e1b6a27d3 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1300,6 +1300,8 @@ exit 1 =20 # place macros above and build commands below this comment =20 +export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_specdir}/%{name}.spec) + %if 0%{?enable_autotools} autoreconf -if %endif @@ -1372,6 +1374,8 @@ gzip -9 ChangeLog %install rm -fr %{buildroot} =20 +export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_specdir}/%{name}.spec) + # Avoid using makeinstall macro as it changes prefixes rather than setting # DESTDIR. Newer make_install macro would be better but it's not available # on RHEL 5, thus we need to expand it here. --=20 2.15.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list