[libvirt] [PATCH v2 0/9] qemu: command: Refactor handling of disk drive arguments (blockdev-add saga)

Peter Krempa posted 9 patches 6 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1511344783.git.pkrempa@redhat.com
src/qemu/qemu_command.c                            | 241 ++++++++++++---------
.../qemuxml2argvdata/qemuxml2argv-boot-cdrom.args  |   2 +-
.../qemuxml2argv-boot-complex-bootindex.args       |   2 +-
.../qemuxml2argv-boot-complex.args                 |   2 +-
...xml2argv-boot-menu-disable-drive-bootindex.args |   2 +-
.../qemuxml2argv-boot-menu-disable-drive.args      |   2 +-
.../qemuxml2argv-boot-menu-disable.args            |   2 +-
.../qemuxml2argv-boot-menu-enable-bootindex.args   |   2 +-
...qemuxml2argv-boot-menu-enable-with-timeout.args |   2 +-
.../qemuxml2argv-boot-menu-enable.args             |   2 +-
.../qemuxml2argvdata/qemuxml2argv-boot-multi.args  |   2 +-
.../qemuxml2argvdata/qemuxml2argv-boot-order.args  |   2 +-
.../qemuxml2argvdata/qemuxml2argv-boot-strict.args |   2 +-
.../qemuxml2argv-controller-order.args             |   2 +-
tests/qemuxml2argvdata/qemuxml2argv-disk-aio.args  |   4 +-
.../qemuxml2argv-disk-cdrom-empty.args             |   2 +-
.../qemuxml2argv-disk-cdrom-network-ftp.args       |   2 +-
.../qemuxml2argv-disk-cdrom-network-ftps.args      |   2 +-
.../qemuxml2argv-disk-cdrom-network-http.args      |   2 +-
.../qemuxml2argv-disk-cdrom-network-https.args     |   2 +-
.../qemuxml2argv-disk-cdrom-network-tftp.args      |   2 +-
...qemuxml2argv-disk-cdrom-tray-no-device-cap.args |   2 +-
.../qemuxml2argv-disk-cdrom-tray.args              |   4 +-
.../qemuxml2argvdata/qemuxml2argv-disk-cdrom.args  |   2 +-
.../qemuxml2argv-disk-copy_on_read.args            |   2 +-
.../qemuxml2argv-disk-drive-boot-cdrom.args        |   4 +-
.../qemuxml2argv-disk-drive-boot-disk.args         |   4 +-
.../qemuxml2argv-disk-drive-cache-directsync.args  |   4 +-
.../qemuxml2argv-disk-drive-cache-unsafe.args      |   4 +-
.../qemuxml2argv-disk-drive-cache-v2-none.args     |   4 +-
.../qemuxml2argv-disk-drive-cache-v2-wb.args       |   4 +-
.../qemuxml2argv-disk-drive-cache-v2-wt.args       |   4 +-
.../qemuxml2argv-disk-drive-detect-zeroes.args     |   2 +-
.../qemuxml2argv-disk-drive-discard.args           |   2 +-
...uxml2argv-disk-drive-error-policy-enospace.args |   6 +-
.../qemuxml2argv-disk-drive-error-policy-stop.args |   6 +-
...gv-disk-drive-error-policy-wreport-rignore.args |   6 +-
.../qemuxml2argv-disk-drive-fmt-qcow.args          |   4 +-
.../qemuxml2argv-disk-drive-no-boot.args           |   4 +-
.../qemuxml2argv-disk-drive-readonly-disk.args     |   2 +-
...qemuxml2argv-disk-drive-readonly-no-device.args |   2 +-
.../qemuxml2argv-disk-drive-shared.args            |   4 +-
.../qemuxml2argv-disk-ioeventfd.args               |   2 +-
.../qemuxml2argvdata/qemuxml2argv-disk-order.args  |   4 +-
.../qemuxml2argvdata/qemuxml2argv-disk-serial.args |   1 +
.../qemuxml2argvdata/qemuxml2argv-disk-serial.xml  |   5 +
.../qemuxml2argv-disk-snapshot.args                |   4 +-
.../qemuxml2argv-disk-source-pool-mode.args        |  12 +-
.../qemuxml2argv-disk-source-pool.args             |   4 +-
.../qemuxml2argvdata/qemuxml2argv-disk-virtio.args |   4 +-
tests/qemuxml2argvdata/qemuxml2argv-event_idx.args |   2 +-
.../qemuxml2argv-graphics-spice-timeout.args       |   2 +-
.../qemuxml2argv-hugepages-numa.args               |   2 +-
.../qemuxml2argv-pci-autoadd-addr.args             |   4 +-
.../qemuxml2argv-pci-autoadd-idx.args              |   4 +-
.../qemuxml2argv-pci-autofill-addr.args            |   4 +-
.../qemuxml2argvdata/qemuxml2argv-pci-bridge.args  |   4 +-
tests/qemuxml2argvdata/qemuxml2argv-pci-many.args  |   4 +-
.../qemuxml2argv-user-aliases.args                 |   2 +-
.../qemuxml2xmlout-disk-serial.xml                 |  47 ++++
tests/qemuxml2xmltest.c                            |   2 +
61 files changed, 280 insertions(+), 192 deletions(-)
create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-serial.xml
[libvirt] [PATCH v2 0/9] qemu: command: Refactor handling of disk drive arguments (blockdev-add saga)
Posted by Peter Krempa 6 years, 4 months ago
Version 2 only prepares for the move of the arguments to -device which
will be used together with -blockdev rather than switching right away.

This will prevent breaking old qemu support since individual parameters
were moved to -device in separate instances.

Peter Krempa (9):
  qemu: command: Split out geometry frontend attribute formatting from
    -drive
  tests: qemuxml2xml: Run the 'disk-serial' test
  tests: qemuxml2argv: Test SD card with serial number
  qemu: command: Move disk 'serial' into frontend parameter formatter
  qemu: command: Move around order of generating -drive arguments
  qemu: command: Refactor logic when formatting -drive
  qemu: command: Move disk trhottling argument building into a separate
    function
  qemu: command: Move formatting of disk io error policy from -drive
  qemu: command: Anotate formatting of the frontend attributes with
    -drive

 src/qemu/qemu_command.c                            | 241 ++++++++++++---------
 .../qemuxml2argvdata/qemuxml2argv-boot-cdrom.args  |   2 +-
 .../qemuxml2argv-boot-complex-bootindex.args       |   2 +-
 .../qemuxml2argv-boot-complex.args                 |   2 +-
 ...xml2argv-boot-menu-disable-drive-bootindex.args |   2 +-
 .../qemuxml2argv-boot-menu-disable-drive.args      |   2 +-
 .../qemuxml2argv-boot-menu-disable.args            |   2 +-
 .../qemuxml2argv-boot-menu-enable-bootindex.args   |   2 +-
 ...qemuxml2argv-boot-menu-enable-with-timeout.args |   2 +-
 .../qemuxml2argv-boot-menu-enable.args             |   2 +-
 .../qemuxml2argvdata/qemuxml2argv-boot-multi.args  |   2 +-
 .../qemuxml2argvdata/qemuxml2argv-boot-order.args  |   2 +-
 .../qemuxml2argvdata/qemuxml2argv-boot-strict.args |   2 +-
 .../qemuxml2argv-controller-order.args             |   2 +-
 tests/qemuxml2argvdata/qemuxml2argv-disk-aio.args  |   4 +-
 .../qemuxml2argv-disk-cdrom-empty.args             |   2 +-
 .../qemuxml2argv-disk-cdrom-network-ftp.args       |   2 +-
 .../qemuxml2argv-disk-cdrom-network-ftps.args      |   2 +-
 .../qemuxml2argv-disk-cdrom-network-http.args      |   2 +-
 .../qemuxml2argv-disk-cdrom-network-https.args     |   2 +-
 .../qemuxml2argv-disk-cdrom-network-tftp.args      |   2 +-
 ...qemuxml2argv-disk-cdrom-tray-no-device-cap.args |   2 +-
 .../qemuxml2argv-disk-cdrom-tray.args              |   4 +-
 .../qemuxml2argvdata/qemuxml2argv-disk-cdrom.args  |   2 +-
 .../qemuxml2argv-disk-copy_on_read.args            |   2 +-
 .../qemuxml2argv-disk-drive-boot-cdrom.args        |   4 +-
 .../qemuxml2argv-disk-drive-boot-disk.args         |   4 +-
 .../qemuxml2argv-disk-drive-cache-directsync.args  |   4 +-
 .../qemuxml2argv-disk-drive-cache-unsafe.args      |   4 +-
 .../qemuxml2argv-disk-drive-cache-v2-none.args     |   4 +-
 .../qemuxml2argv-disk-drive-cache-v2-wb.args       |   4 +-
 .../qemuxml2argv-disk-drive-cache-v2-wt.args       |   4 +-
 .../qemuxml2argv-disk-drive-detect-zeroes.args     |   2 +-
 .../qemuxml2argv-disk-drive-discard.args           |   2 +-
 ...uxml2argv-disk-drive-error-policy-enospace.args |   6 +-
 .../qemuxml2argv-disk-drive-error-policy-stop.args |   6 +-
 ...gv-disk-drive-error-policy-wreport-rignore.args |   6 +-
 .../qemuxml2argv-disk-drive-fmt-qcow.args          |   4 +-
 .../qemuxml2argv-disk-drive-no-boot.args           |   4 +-
 .../qemuxml2argv-disk-drive-readonly-disk.args     |   2 +-
 ...qemuxml2argv-disk-drive-readonly-no-device.args |   2 +-
 .../qemuxml2argv-disk-drive-shared.args            |   4 +-
 .../qemuxml2argv-disk-ioeventfd.args               |   2 +-
 .../qemuxml2argvdata/qemuxml2argv-disk-order.args  |   4 +-
 .../qemuxml2argvdata/qemuxml2argv-disk-serial.args |   1 +
 .../qemuxml2argvdata/qemuxml2argv-disk-serial.xml  |   5 +
 .../qemuxml2argv-disk-snapshot.args                |   4 +-
 .../qemuxml2argv-disk-source-pool-mode.args        |  12 +-
 .../qemuxml2argv-disk-source-pool.args             |   4 +-
 .../qemuxml2argvdata/qemuxml2argv-disk-virtio.args |   4 +-
 tests/qemuxml2argvdata/qemuxml2argv-event_idx.args |   2 +-
 .../qemuxml2argv-graphics-spice-timeout.args       |   2 +-
 .../qemuxml2argv-hugepages-numa.args               |   2 +-
 .../qemuxml2argv-pci-autoadd-addr.args             |   4 +-
 .../qemuxml2argv-pci-autoadd-idx.args              |   4 +-
 .../qemuxml2argv-pci-autofill-addr.args            |   4 +-
 .../qemuxml2argvdata/qemuxml2argv-pci-bridge.args  |   4 +-
 tests/qemuxml2argvdata/qemuxml2argv-pci-many.args  |   4 +-
 .../qemuxml2argv-user-aliases.args                 |   2 +-
 .../qemuxml2xmlout-disk-serial.xml                 |  47 ++++
 tests/qemuxml2xmltest.c                            |   2 +
 61 files changed, 280 insertions(+), 192 deletions(-)
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-serial.xml

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/9] qemu: command: Refactor handling of disk drive arguments (blockdev-add saga)
Posted by Ján Tomko 6 years, 4 months ago
On Wed, Nov 22, 2017 at 11:01:32AM +0100, Peter Krempa wrote:
>Version 2 only prepares for the move of the arguments to -device which
>will be used together with -blockdev rather than switching right away.
>
>This will prevent breaking old qemu support since individual parameters
>were moved to -device in separate instances.
>
>Peter Krempa (9):
>  qemu: command: Split out geometry frontend attribute formatting from
>    -drive
>  tests: qemuxml2xml: Run the 'disk-serial' test
>  tests: qemuxml2argv: Test SD card with serial number
>  qemu: command: Move disk 'serial' into frontend parameter formatter
>  qemu: command: Move around order of generating -drive arguments
>  qemu: command: Refactor logic when formatting -drive
>  qemu: command: Move disk trhottling argument building into a separate
>    function
>  qemu: command: Move formatting of disk io error policy from -drive
>  qemu: command: Anotate formatting of the frontend attributes with
>    -drive
>

ACK series

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list