[libvirt] [PATCH 00/17] chardev parsing cleanup and improvements

Pavel Hrdina posted 17 patches 6 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1503302799.git.phrdina@redhat.com
src/conf/domain_conf.c                             | 700 ++++++++++++---------
.../generic-chardev-tcp-missing-host.xml           |  25 +
.../generic-chardev-tcp-missing-service.xml        |  25 +
.../generic-chardev-tcp-multiple-source.xml        |  26 +
tests/genericxml2xmlindata/generic-chardev-tcp.xml |  32 +
...generic-chardev-udp-missing-connect-service.xml |  24 +
.../generic-chardev-udp-multiple-source.xml        |  26 +
tests/genericxml2xmlindata/generic-chardev-udp.xml |  47 ++
.../generic-chardev-unix-redirdev-missing-path.xml |  24 +
.../generic-chardev-unix-rng-missing-path.xml      |  25 +
...generic-chardev-unix-smartcard-missing-path.xml |  23 +
.../genericxml2xmlindata/generic-chardev-unix.xml  |  43 ++
.../genericxml2xmloutdata/generic-chardev-tcp.xml  |  35 ++
.../genericxml2xmloutdata/generic-chardev-udp.xml  |  47 ++
.../genericxml2xmloutdata/generic-chardev-unix.xml |  44 ++
tests/genericxml2xmltest.c                         |  20 +
16 files changed, 875 insertions(+), 291 deletions(-)
create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-missing-host.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-missing-service.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-multiple-source.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-udp-missing-connect-service.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-udp-multiple-source.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-udp.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix-redirdev-missing-path.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix-rng-missing-path.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix-smartcard-missing-path.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix.xml
create mode 100644 tests/genericxml2xmloutdata/generic-chardev-tcp.xml
create mode 100644 tests/genericxml2xmloutdata/generic-chardev-udp.xml
create mode 100644 tests/genericxml2xmloutdata/generic-chardev-unix.xml
[libvirt] [PATCH 00/17] chardev parsing cleanup and improvements
Posted by Pavel Hrdina 6 years, 7 months ago
Pavel Hrdina (17):
  tests: introduce genericxml test for TCP chardev
  tests: introduce genericxml test for UDP chardev
  tests: introduce genericxml test for UNIX chardev
  conf: switch from while to for loop for chardev parsing
  conf: error out for multiple source elements while parsing chardev
  conf: error out for multiple log elements while parsing chardev
  conf: error out for multiple protocol elements while parsing chardev
  conf: move chardev protocol parsing to separate function
  conf: move chardev log parsing to separate function
  conf: move mode parsing of chardev source to separate function
  conf: move TCP chardev source parsing to separate function
  conf: move UDP chardev source parsing to separate function
  conf: move UNIX chardev source parsing to separate function
  conf: assign parsed strings directly into chardev source definition
  conf: move FILE chardev source parsing to separate function
  conf: separate PTY chardev source parsing
  conf: move chardev validation into virDomainDeviceDefValidateInternal

 src/conf/domain_conf.c                             | 700 ++++++++++++---------
 .../generic-chardev-tcp-missing-host.xml           |  25 +
 .../generic-chardev-tcp-missing-service.xml        |  25 +
 .../generic-chardev-tcp-multiple-source.xml        |  26 +
 tests/genericxml2xmlindata/generic-chardev-tcp.xml |  32 +
 ...generic-chardev-udp-missing-connect-service.xml |  24 +
 .../generic-chardev-udp-multiple-source.xml        |  26 +
 tests/genericxml2xmlindata/generic-chardev-udp.xml |  47 ++
 .../generic-chardev-unix-redirdev-missing-path.xml |  24 +
 .../generic-chardev-unix-rng-missing-path.xml      |  25 +
 ...generic-chardev-unix-smartcard-missing-path.xml |  23 +
 .../genericxml2xmlindata/generic-chardev-unix.xml  |  43 ++
 .../genericxml2xmloutdata/generic-chardev-tcp.xml  |  35 ++
 .../genericxml2xmloutdata/generic-chardev-udp.xml  |  47 ++
 .../genericxml2xmloutdata/generic-chardev-unix.xml |  44 ++
 tests/genericxml2xmltest.c                         |  20 +
 16 files changed, 875 insertions(+), 291 deletions(-)
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-missing-host.xml
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-missing-service.xml
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-multiple-source.xml
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp.xml
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-udp-missing-connect-service.xml
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-udp-multiple-source.xml
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-udp.xml
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix-redirdev-missing-path.xml
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix-rng-missing-path.xml
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix-smartcard-missing-path.xml
 create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix.xml
 create mode 100644 tests/genericxml2xmloutdata/generic-chardev-tcp.xml
 create mode 100644 tests/genericxml2xmloutdata/generic-chardev-udp.xml
 create mode 100644 tests/genericxml2xmloutdata/generic-chardev-unix.xml

-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list