[libvirt] [PATCH 0/8] some parsing cleanup and improvements

Pavel Hrdina posted 8 patches 6 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1502713939.git.phrdina@redhat.com
src/conf/cpu_conf.c                  |   2 +-
src/conf/domain_conf.c               | 373 ++++++++++++++++-------------------
src/conf/interface_conf.c            |   2 +-
src/conf/netdev_bandwidth_conf.c     |   6 +-
src/conf/netdev_vport_profile_conf.c |   2 +-
src/conf/network_conf.c              |  12 +-
src/conf/node_device_conf.c          |   2 +-
src/conf/nwfilter_conf.c             |   6 +-
src/conf/nwfilter_params.c           |   2 +-
src/conf/secret_conf.c               |   2 +-
src/conf/snapshot_conf.c             |   2 +-
src/conf/storage_conf.c              |   4 +-
src/conf/virnetworkobj.c             |   2 +-
src/conf/virsavecookie.c             |   2 +-
src/esx/esx_vi_types.c               |   9 +-
src/libvirt_private.syms             |   1 +
src/security/virt-aa-helper.c        |   2 +-
src/test/test_driver.c               |   2 +-
src/util/virxml.c                    |  16 ++
src/util/virxml.h                    |   3 +
src/vz/vz_sdk.c                      |   2 +-
tools/virsh-domain.c                 |  18 +-
tools/virsh-interface.c              |  12 +-
23 files changed, 236 insertions(+), 248 deletions(-)
[libvirt] [PATCH 0/8] some parsing cleanup and improvements
Posted by Pavel Hrdina 6 years, 7 months ago
Pavel Hrdina (8):
  util: introduce virXMLNodeNameEqual
  use virXMLNodeNameEqual instead of xmlStrEqual
  conf: cleanup virDomainChrSourceDef parsing
  conf: use virXMLPropString for KeyWrapCipherDef parsing
  conf: use virXMLPropString for disk geometry parsing
  conf: use virXMLPropString for IOThread parsing
  conf: use virXMLPropString for IOThread pin parsing
  conf: use virXMLPropString for Domain def parsing

 src/conf/cpu_conf.c                  |   2 +-
 src/conf/domain_conf.c               | 373 ++++++++++++++++-------------------
 src/conf/interface_conf.c            |   2 +-
 src/conf/netdev_bandwidth_conf.c     |   6 +-
 src/conf/netdev_vport_profile_conf.c |   2 +-
 src/conf/network_conf.c              |  12 +-
 src/conf/node_device_conf.c          |   2 +-
 src/conf/nwfilter_conf.c             |   6 +-
 src/conf/nwfilter_params.c           |   2 +-
 src/conf/secret_conf.c               |   2 +-
 src/conf/snapshot_conf.c             |   2 +-
 src/conf/storage_conf.c              |   4 +-
 src/conf/virnetworkobj.c             |   2 +-
 src/conf/virsavecookie.c             |   2 +-
 src/esx/esx_vi_types.c               |   9 +-
 src/libvirt_private.syms             |   1 +
 src/security/virt-aa-helper.c        |   2 +-
 src/test/test_driver.c               |   2 +-
 src/util/virxml.c                    |  16 ++
 src/util/virxml.h                    |   3 +
 src/vz/vz_sdk.c                      |   2 +-
 tools/virsh-domain.c                 |  18 +-
 tools/virsh-interface.c              |  12 +-
 23 files changed, 236 insertions(+), 248 deletions(-)

-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/8] some parsing cleanup and improvements
Posted by Ján Tomko 6 years, 7 months ago
On Mon, Aug 14, 2017 at 02:32:39PM +0200, Pavel Hrdina wrote:
>Pavel Hrdina (8):
>  util: introduce virXMLNodeNameEqual
>  use virXMLNodeNameEqual instead of xmlStrEqual
>  conf: cleanup virDomainChrSourceDef parsing
>  conf: use virXMLPropString for KeyWrapCipherDef parsing

FYI there is a non-breaking space after conf:

>  conf: use virXMLPropString for disk geometry parsing
>  conf: use virXMLPropString for IOThread parsing
>  conf: use virXMLPropString for IOThread pin parsing
>  conf: use virXMLPropString for Domain def parsing
>

ACK series.

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/8] some parsing cleanup and improvements
Posted by Pavel Hrdina 6 years, 7 months ago
On Mon, Aug 14, 2017 at 05:10:00PM +0200, Ján Tomko wrote:
> On Mon, Aug 14, 2017 at 02:32:39PM +0200, Pavel Hrdina wrote:
> > Pavel Hrdina (8):
> >  util: introduce virXMLNodeNameEqual
> >  use virXMLNodeNameEqual instead of xmlStrEqual
> >  conf: cleanup virDomainChrSourceDef parsing
> >  conf: use virXMLPropString for KeyWrapCipherDef parsing
> 
> FYI there is a non-breaking space after conf:

And I was wondering why git was asking about encoding.

I've fixed it and pushed it, thanks.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list