From nobody Sat Dec 21 14:57:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1685028891; cv=none; d=zohomail.com; s=zohoarc; b=iVZEX8fKOTTWFYNzLV+bJh//X0TowFEGEatBUpnJDiT8IFxO/X342KaLIo2bnu/eJEWJ1q2bvf7KnNBJWkMoCzyKGrZYlF09ENbp6gqCP74XZBkcXJEBsN8yh5sLhuTojExvvNrcDpa/9biicUFJvFrwwuB2dHKPxSMRTVlKADE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685028891; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qt7aF0rQJuSr9iE/B76ikL1d5B+5Xm8pZBWCiPbhuCk=; b=kYpCvMD6FIgx/KRYFPAn2WT7HxQV5ygcFeNNbMF91evIDIVKwe/qGK9fkdCSgbkrDqAW5vkwFN1YEQhyKIP912I4JJsAGYd8T2HYHhdsly1lJuVd/6o+gn+9aFUK6H7i42tHsI34ttWP7P1B3guWHT7uiCezEeIGgPJGZVNqB48= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1685028891297268.6350282549257; Thu, 25 May 2023 08:34:51 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-519-cuL4RB8lOD6nMx64rcRuAg-1; Thu, 25 May 2023 11:34:42 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD199381D1FF; Thu, 25 May 2023 15:33:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98AA1407DEC3; Thu, 25 May 2023 15:33:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 501E519465A4; Thu, 25 May 2023 15:33:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 90CED19465A0 for ; Thu, 25 May 2023 15:14:02 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 63093401026; Thu, 25 May 2023 15:14:02 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB4FC41F2CC for ; Thu, 25 May 2023 15:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685028890; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qt7aF0rQJuSr9iE/B76ikL1d5B+5Xm8pZBWCiPbhuCk=; b=bCpMuFiNuAg0ztTrXy2ziy/IIGPRWJLKyywxlRru7aTtxirD+TQeAPwnfACagb4JwApBJD RwF1hSLtQBg7f5dHIlSubUMi53hdKd0Ox7IqZRiA0SGVWhLk/kWSIlIRN9CyCEEWq1m6CG 0vThHk/5V/AosCiZP5vMVn2BD6Eg2P8= X-MC-Unique: cuL4RB8lOD6nMx64rcRuAg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 18/18] testQEMUSchemaValidateObjectMember: validate QMP object member deprecation Date: Thu, 25 May 2023 17:13:45 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1685028893723100001 Content-Type: text/plain; charset="utf-8" The QMP schema validator wasn't adapted to consider features of 'object' members and thus we didn't catch the deprecation of 'device' in 'block_set_io_throttle'. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tests/testutilsqemuschema.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/testutilsqemuschema.c b/tests/testutilsqemuschema.c index d431e7b3fc..f7b2e122bd 100644 --- a/tests/testutilsqemuschema.c +++ b/tests/testutilsqemuschema.c @@ -187,6 +187,10 @@ testQEMUSchemaValidateObjectMember(const char *key, return -1; } + /* validate that the member is not deprecated */ + if ((rc =3D testQEMUSchemaValidateDeprecated(keymember, key, data->ctx= t)) < 0) + return rc; + /* lookup schema entry for keytype */ if (!(keytype =3D virJSONValueObjectGetString(keymember, "type")) || !(keyschema =3D virHashLookup(data->ctxt->schema, keytype))) { --=20 2.40.1