From nobody Sun Feb 8 20:35:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566305988; cv=none; d=zoho.com; s=zohoarc; b=XvOErWINi2oq9v0nBlVurBkSjqG4BJzoI4PaXjqUeaZlCFyVrGCD+ghnbJZ6zYsuDXVxgO23qpJSJ2uE0fbBlk0UuzRvbAWnziSfkl2i+oZfnyLmK6sRCDnHDHQHdOKHc4S2rTEOK2G+wBqgrV/tywudxTQL8DYSZ9cfoaupay0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566305988; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=qTlFb7lH8tjC53VVbkDUvz4AOrxDpZxwjpMK+md1Bwo=; b=G6O2sCXeGYQTZCD0HUUwdxh8f1/FX9V6cUtmL0mwXkFwSoJDz2DiPml47KPr5U6beMz0acL5NElG76ONgTilND5yQ59fZUJds9KCDAQgpew0wvX3PrILgVPL14VIWeOWLyZ7Z32qvd47y4UuOvX8PslFzvFMkXZLStDWgwx7WmE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1566305988051547.7985741770661; Tue, 20 Aug 2019 05:59:48 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F05AF106BB28; Tue, 20 Aug 2019 12:59:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE85D8CBED; Tue, 20 Aug 2019 12:59:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9538718005A0; Tue, 20 Aug 2019 12:59:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7KCxfq6023230 for ; Tue, 20 Aug 2019 08:59:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id 710E118F1B; Tue, 20 Aug 2019 12:59:41 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECBB94274 for ; Tue, 20 Aug 2019 12:59:36 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Tue, 20 Aug 2019 14:59:10 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 11/19] qemuBuildControllersByTypeCommandLine: use VIR_AUTOFREE X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Tue, 20 Aug 2019 12:59:47 +0000 (UTC) Reduce the scope of the variable to get it freed for every controller processed. Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index db8584243c..298a1c3fea 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3198,12 +3198,12 @@ qemuBuildControllersByTypeCommandLine(virCommandPtr= cmd, virQEMUCapsPtr qemuCaps, virDomainControllerType type) { - char *devstr =3D NULL; int ret =3D -1; size_t i; =20 for (i =3D 0; i < def->ncontrollers; i++) { virDomainControllerDefPtr cont =3D def->controllers[i]; + VIR_AUTOFREE(char *) devstr =3D NULL; =20 if (cont->type !=3D type) continue; @@ -3236,7 +3236,6 @@ qemuBuildControllersByTypeCommandLine(virCommandPtr c= md, continue; } =20 - VIR_FREE(devstr); if (qemuBuildControllerDevStr(def, cont, qemuCaps, &devstr) < 0) goto cleanup; =20 @@ -3251,7 +3250,6 @@ qemuBuildControllersByTypeCommandLine(virCommandPtr c= md, =20 ret =3D 0; cleanup: - VIR_FREE(devstr); return ret; } =20 --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list