From nobody Mon Feb 9 00:39:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571752900; cv=none; d=zoho.com; s=zohoarc; b=n1Wx5mG0C6s91fmgyN/LsMfcKMBtLF/q7q/wXf8lMh10tEGr2JHzMELz+PwEteGSJ7/fJTrtM1lPVqu9jMF4QoPRHeulVdeSy7fjgGq884l+yMj+cPi/WYFaheersrGxuqnCjZuB+Vv1jGH9pHL4ANXfnbZlRzKzEhvV58NcoHU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571752900; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YPkBmNBKjhW0iJvNVLqeyYuLvOITUALGzyxxnYTNy8o=; b=XdlRxiRePZmo2a//XbHm7/OQDHUC0OK9SWkApH6tQd5dTmFV5Nr7CRKrAkyFoyf5xW28hx2imHjoxSfJ+rHybhFHMlCQSuX5CIy8aBU7mrhv3rVFNgF60ga70mDBqrxhbmXeGO2Gd3goQKP/Y2YBGkrA8sw1mcb/U+sjCjfvN4Q= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1571752900019737.1098101819948; Tue, 22 Oct 2019 07:01:40 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-Y6yPfJvMMzGodop6p6vqqQ-1; Tue, 22 Oct 2019 10:01:36 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E1999107AD3E; Tue, 22 Oct 2019 14:01:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A524762A79; Tue, 22 Oct 2019 14:01:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3E3593FB45; Tue, 22 Oct 2019 14:01:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9ME16nu003020 for ; Tue, 22 Oct 2019 10:01:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id A5A726012E; Tue, 22 Oct 2019 14:01:06 +0000 (UTC) Received: from moe.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B34A6012D for ; Tue, 22 Oct 2019 14:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571752898; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=YPkBmNBKjhW0iJvNVLqeyYuLvOITUALGzyxxnYTNy8o=; b=hybt8E1B+bPCWffgvFl5esgEq7kjnhvUFStHcWumkptf80NVaZfIa/t8s/ovkDiE2nkdCj zAPGLXY1Voqflj17P41wkrxvvx1BN0oNV57A57F4vjn1NGbAG4brEnUe5fFdpRbPN6Jtua 5Hih6nL5CwZxCk9WVn6QxS3JA7jK3Tk= From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 22 Oct 2019 15:58:17 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 73/75] virstring: Make virVasprintf() return no value X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: Y6yPfJvMMzGodop6p6vqqQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Michal Privoznik --- src/util/virstring.c | 7 ++----- src/util/virstring.h | 5 ++--- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index f6495fdb72..c704ce38f0 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -722,15 +722,14 @@ virDoubleToStr(char **strp, double number) } =20 =20 -int +void virVasprintfInternal(char **strp, const char *fmt, va_list list) { char *str =3D NULL; - int ret; =20 - ret =3D g_vasprintf(&str, fmt, list); + g_vasprintf(&str, fmt, list); =20 /* GLib is supposed to abort() on OOM, but a mistake meant * it did not. Delete this once our min glib is at 2.64.0 @@ -742,8 +741,6 @@ virVasprintfInternal(char **strp, abort(); #endif *strp =3D str; - - return ret; } =20 /** diff --git a/src/util/virstring.h b/src/util/virstring.h index 6072af8f59..ea0774f2c7 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -133,9 +133,8 @@ int virStrdup(char **dest, const char *src) =20 int virStrndup(char **dest, const char *src, ssize_t n) G_GNUC_WARN_UNUSED_RESULT ATTRIBUTE_NONNULL(1); -int virVasprintfInternal(char **strp, const char *fmt, va_list list) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) G_GNUC_PRINTF(2, 0) - G_GNUC_WARN_UNUSED_RESULT; +void virVasprintfInternal(char **strp, const char *fmt, va_list list) + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) G_GNUC_PRINTF(2, 0); =20 /** * VIR_STRDUP: --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list