From nobody Tue Mar 24 00:57:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1773938656; cv=none; d=zohomail.com; s=zohoarc; b=LVW7kcNsvqAfcuMEqZBPycg+xltyzEJjepxUlU1fp4r87oBYBLbe8j1GwLaAtzONUJ2MLcosRnrsQYoWycBr80JQnXYlUGiVIJaZz8w93suCzRbzBLRo2EuNpqZwSokK9ouFgNfJeOBli/uE6/O8sYbFxvU54RxOPhy9SJKzCgw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773938656; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=pqQKmU2a9uPO/LL5cGvbS4iGyY4HVAULcePRHjCPhAQ=; b=nS9DunjAsxztm34feOGN3bcFOq3m//V86JCd1qgtusUfM5l70+Wh0KCDZwwMJ3lmxMoAqm1h2ZUUKNHvcpeGpZCc90+z4tOW2trwiHmUcNtiJU9bb6NpwQDFyz7L2xLeL9DpGiC6H32yfzja8F2J/srLiEBoNr13kXSvb50JOes= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1773938656235408.777322969788; Thu, 19 Mar 2026 09:44:16 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5153741937; Thu, 19 Mar 2026 12:44:15 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id B694141CFD; Thu, 19 Mar 2026 12:39:54 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0D3CA41819; Thu, 19 Mar 2026 12:39:51 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EBD7A41B96 for ; Thu, 19 Mar 2026 12:37:10 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-251-zjgSV-2yOheyUkhd5eKjTA-1; Thu, 19 Mar 2026 12:37:09 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 58C2D19560AA for ; Thu, 19 Mar 2026 16:37:08 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.44.33.53]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A76B030001A1 for ; Thu, 19 Mar 2026 16:37:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773938230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pqQKmU2a9uPO/LL5cGvbS4iGyY4HVAULcePRHjCPhAQ=; b=OU7APRKZje9NvQKgVBwmcnnUpceX4tBZQPy8eKQy8HI4geIp9pT34hbe/tz1KXNQe2vEWr x32dMNME+n4be8cx4HFLwkNzv5LZYSQJpx+rRlrAAl3If/VLYkX9a2Al3vWygtAL8xDB7V PAzUA71BWCcpXqs2CU8vn12Q6Q1rnog= X-MC-Unique: zjgSV-2yOheyUkhd5eKjTA-1 X-Mimecast-MFC-AGG-ID: zjgSV-2yOheyUkhd5eKjTA_1773938228 To: devel@lists.libvirt.org Subject: [libvirt PATCH 08/11] qemu: Implement iommufd Date: Thu, 19 Mar 2026 17:36:54 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bEAvbbaWkWhYfH4xxAZffnwvSZ3vjgO4q2Ip8CVinqI_1773938228 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XRSVZE6MNC4OSIE5IJWQ4NOH5IFCEBBL X-Message-ID-Hash: XRSVZE6MNC4OSIE5IJWQ4NOH5IFCEBBL X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pavel Hrdina via Devel Reply-To: Pavel Hrdina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1773938657393158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Pavel Hrdina Ideally this should be done in qemuDomainHostdevDefPostParse but that would require a lot of refactoring mainly due to how interface backed by hostdev works. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/qemu/qemu_domain.c | 12 +++++++++--- src/qemu/qemu_domain.h | 3 ++- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_process.c | 4 ++-- 4 files changed, 14 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 1d00ff2845..e667d74f1a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10110,10 +10110,12 @@ qemuDomainPrepareHostdevSCSI(virDomainHostdevDef = *hostdev, =20 =20 static int -qemuDomainPrepareHostdevPCI(virDomainHostdevDef *hostdev, +qemuDomainPrepareHostdevPCI(const virDomainDef *def, + virDomainHostdevDef *hostdev, virQEMUCaps *qemuCaps) { virDeviceHostdevPCIDriverName *driverName =3D &hostdev->source.subsys.= u.pci.driver.name; + virDomainHostdevSubsysPCI *pcisrc =3D &hostdev->source.subsys.u.pci; =20 /* assign defaults for hostdev passthrough */ switch (*driverName) { @@ -10150,12 +10152,16 @@ qemuDomainPrepareHostdevPCI(virDomainHostdevDef *= hostdev, return -1; } =20 + if (pcisrc->driver.iommufd =3D=3D VIR_TRISTATE_BOOL_ABSENT) + pcisrc->driver.iommufd =3D def->iommufd; + return 0; } =20 =20 int -qemuDomainPrepareHostdev(virDomainHostdevDef *hostdev, +qemuDomainPrepareHostdev(const virDomainDef *def, + virDomainHostdevDef *hostdev, qemuDomainObjPrivate *priv) { if (hostdev->mode !=3D VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) @@ -10165,7 +10171,7 @@ qemuDomainPrepareHostdev(virDomainHostdevDef *hostd= ev, case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI: return qemuDomainPrepareHostdevSCSI(hostdev, priv); case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: - return qemuDomainPrepareHostdevPCI(hostdev, priv->qemuCaps); + return qemuDomainPrepareHostdevPCI(def, hostdev, priv->qemuCaps); case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 5755d2adb0..f797542a87 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -1040,7 +1040,8 @@ qemuDomainDiskCachemodeFlags(virDomainDiskCache cache= mode, bool *noflush); =20 int -qemuDomainPrepareHostdev(virDomainHostdevDef *hostdev, +qemuDomainPrepareHostdev(const virDomainDef *def, + virDomainHostdevDef *hostdev, qemuDomainObjPrivate *priv); =20 char * qemuDomainGetManagedPRSocketPath(qemuDomainObjPrivate *priv); diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index d6be851e61..adae94f0a2 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2891,7 +2891,7 @@ qemuDomainAttachHostDevice(virQEMUDriver *driver, return -1; } =20 - if (qemuDomainPrepareHostdev(hostdev, vm->privateData) < 0) + if (qemuDomainPrepareHostdev(vm->def, hostdev, vm->privateData) < 0) return -1; =20 switch (hostdev->source.subsys.type) { diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ecd05b4bf6..fed6079ad2 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6087,7 +6087,7 @@ qemuProcessPrepareDomainNetwork(virDomainObj *vm) /* For hostdev present in qemuProcessPrepareDomain() phase= this was * done already, but this code runs after that, so we have= to call * it ourselves. */ - if (qemuDomainPrepareHostdev(hostdev, priv) < 0) + if (qemuDomainPrepareHostdev(def, hostdev, priv) < 0) return -1; =20 virDomainHostdevInsert(def, hostdev); @@ -6875,7 +6875,7 @@ qemuProcessPrepareDomainHostdevs(virDomainObj *vm, for (i =3D 0; i < vm->def->nhostdevs; i++) { virDomainHostdevDef *hostdev =3D vm->def->hostdevs[i]; =20 - if (qemuDomainPrepareHostdev(hostdev, priv) < 0) + if (qemuDomainPrepareHostdev(vm->def, hostdev, priv) < 0) return -1; } =20 --=20 2.53.0