From nobody Mon Sep 21 19:54:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1784735947; cv=none; d=zohomail.com; s=zohoarc; b=AYTWNv8/0KPfGobZuD3Qtx5wYipOtmRU0E4r+ghpK4MlKgjqC7F9T1lpHLatVLyTqxPCCKNCyQC66t4ss8Ac7CioNeIAqcXJvZ//HZoNzjoWEIPJEM4jh8MvBXmadeTyHQ4JaO6VUvZ0XOKUfWUuET1oLJiSroU9cCWsnOoYsW8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784735947; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=lrO9Nv2TscQB7vPYyrUFRXyEixubVxnki4HFkExwl0I=; b=elI2xiB6mUvB31Pu8/XMyHPfQDQZfFyJgEXl7xm3GeieZyulgUfoq2bub68fsUFTkjde24sZujt695pdAbtFtIfvRANINMGqPeV/G8lZ3n35bP1vySXqHWece6Wy7l7k4gfrCGQ1yg9b+IGJfn8dToZ2STzaxV5p8Zhtmfse+4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1784735947056200.41458942765087; Wed, 22 Jul 2026 08:59:07 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C25AC418E7; Wed, 22 Jul 2026 11:59:05 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 1878D4400F; Wed, 22 Jul 2026 11:40:32 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C9A2941B0B; Wed, 22 Jul 2026 11:40:20 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C3A7641B0B for ; Wed, 22 Jul 2026 11:38:37 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-520-NQms1cyEOFaQnU1Z2orrIA-1; Wed, 22 Jul 2026 11:38:34 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0AE581805F04 for ; Wed, 22 Jul 2026 15:38:34 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.24.17]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 56D27D70 for ; Wed, 22 Jul 2026 15:38:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784734717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lrO9Nv2TscQB7vPYyrUFRXyEixubVxnki4HFkExwl0I=; b=NeWnaCYHxDuVsDnX0JuFwQ1XXufltybCRAh/WeZ3YmvrIoL+OC1JVBrDJf2GHS4GzoCafy qvsE9cxLc1U+LNEWYyj36EhAYgrRUqtXMuya5HThrAaHucBmZh7YQuXauX9g/bykuWpApk jswM/H2F0naY7DLJq/3HG9Qda0q6dIo= X-MC-Unique: NQms1cyEOFaQnU1Z2orrIA-1 X-Mimecast-MFC-AGG-ID: NQms1cyEOFaQnU1Z2orrIA_1784734714 To: devel@lists.libvirt.org Subject: [PATCH 11/13] qemuProcessGuestPanicEventInfo: Fold into only caller Date: Wed, 22 Jul 2026 17:38:16 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sANaIUVtlLAW9W8gzOS5zTpz4NRCQZWZEjrgsXFSsS4_1784734714 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6AZTJESZQLC35CKBEKX3IVC4Z3IF63EF X-Message-ID-Hash: 6AZTJESZQLC35CKBEKX3IVC4Z3IF63EF X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1784735949135158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Move the code directly to the only place that calls this function. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2fbd7bc3ee..909d51c8cb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3599,19 +3599,6 @@ doCoreDumpToAutoDumpPath(virQEMUDriver *driver, } -static void -qemuProcessGuestPanicEventInfo(virQEMUDriver *driver, - virDomainObj *vm, - qemuMonitorEventPanicInfo *info) -{ - g_autofree char *msg =3D qemuMonitorGuestPanicEventInfoFormatMsg(info); - g_autofree char *timestamp =3D virTimeStringNow(); - - if (msg && timestamp) - qemuDomainLogAppendMessage(driver, vm, "%s: panic %s\n", timestamp= , msg); -} - - static void processGuestPanicEvent(virQEMUDriver *driver, virDomainObj *vm, @@ -3632,8 +3619,13 @@ processGuestPanicEvent(virQEMUDriver *driver, goto endjob; } - if (info) - qemuProcessGuestPanicEventInfo(driver, vm, info); + if (info) { + g_autofree char *msg =3D qemuMonitorGuestPanicEventInfoFormatMsg(i= nfo); + g_autofree char *timestamp =3D virTimeStringNow(); + + if (msg && timestamp) + qemuDomainLogAppendMessage(driver, vm, "%s: panic %s\n", times= tamp, msg); + } virDomainObjSetState(vm, VIR_DOMAIN_CRASHED, VIR_DOMAIN_CRASHED_PANICK= ED); --=20 2.55.0