From nobody Tue May 7 17:40:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1591185470; cv=none; d=zohomail.com; s=zohoarc; b=ElvHRdSEGgU6gr6Oy82KQ/K9JWWIiBp0G8dlvQMDCT/OCF9LYs61E6B91pBbik4GlCBxqMZp06ibG7tJMigX013oeZxYSJ45OvCugsK0VjUYdM5DOqVXnPg9C69duvxN5cXU7ac/uCtCHErGVCX7cf8pkY+dTi67R499mpkPR4U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591185470; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=O7j+c5GsImYX6aFQqFEskcu7MZKYr/qwrh7SnlQXwzk=; b=MhAna7biCBsm3UyqAjC87HZlzrtqoTexIwuLokJNzs3RXfXh6EbFs/xttolmMbdQvEAPik/TeKzmK7UkfY2MNEAUBjTaX+Hf7CPlQUsWPcWJz87ZENiEQ8MmukBFVA1u8zbc3UGVp01X0ncaXYoqsbZ4m2kzKzy9nxOxKGHxdlQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1591185470514629.0513955255303; Wed, 3 Jun 2020 04:57:50 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-232-vexP1gilPoezVdpxGDn_ug-1; Wed, 03 Jun 2020 07:57:46 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C049280B72F; Wed, 3 Jun 2020 11:57:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EDAE82DE81; Wed, 3 Jun 2020 11:57:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 615351809543; Wed, 3 Jun 2020 11:57:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 053BvaB4010267 for ; Wed, 3 Jun 2020 07:57:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id B1BB82DE7C; Wed, 3 Jun 2020 11:57:36 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.41]) by smtp.corp.redhat.com (Postfix) with ESMTP id F1CA52DE74 for ; Wed, 3 Jun 2020 11:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591185469; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=O7j+c5GsImYX6aFQqFEskcu7MZKYr/qwrh7SnlQXwzk=; b=a/1oZ10DsveYioBhhiOAz91LWcKh1UifxRmD5SPy9WnUYIJXrBMw7SSQOCL6xPmQIr/I1I Wa2nHAyosSgs7LUzcdYn+PRvl81DuC41jLJ+d3z0TmBrOlueWvnKSpTeb1KX5ng4r1dXCv dztqLEgvfdWxG6Qar9rzYUPnz3XTy7w= X-MC-Unique: vexP1gilPoezVdpxGDn_ug-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] tools: libvirt-guests: correctly check shutdown value Date: Wed, 3 Jun 2020 13:57:30 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The variable cleanup introduced a typo. Signed-off-by: J=C3=A1n Tomko Fixes: 08071ec0f113bb1fe8dcc263cb6bf87529e8b76b Reported-by: Bronek Kozicki Closes: https://gitlab.com/libvirt/libvirt/-/issues/27 --- Pushed as trivial. tools/libvirt-guests.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 7af24dab3b..534c4d5e0f 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -444,7 +444,7 @@ stop() { # last stop was not followed by start [ -f "$LISTFILE" ] && return 0 =20 - if [ "/x$ON_SHUTDOWN" =3D xshutdown ]; then + if [ "x$ON_SHUTDOWN" =3D xshutdown ]; then suspending=3Dfalse if [ $SHUTDOWN_TIMEOUT -lt 0 ]; then gettext "SHUTDOWN_TIMEOUT must be equal or greater than 0" --=20 2.25.4