From nobody Sun Feb 8 12:31:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1644411509; cv=none; d=zohomail.com; s=zohoarc; b=XHVKV5PfO5LfDsPTRyZpIpsc9wiH29TCnIaJ8vy042/O0A6V23VX9OJ0AZQRqI9vrXI7yDgGUOi0p8XuSPXNxiylnAW3Vqjt+SRTFJOTO6Ua/0SjmEWYThhy/09ryw4Nupt1+qroTRhxhnTgorwnw2Lr5EDFoyjouwXksOiqlXk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644411509; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=GB5Y3cv3vBip4oVy4rSzkdk5SZvbFCHPQrMsM4cmmp4=; b=nxDT972VOd6mz8C99kVC/tFy7Xi7oEocU+vYYfTR9/ZcL9PQYpfVKMsoGfYu4Vnn/Z5pQYRyYBHhI6sKyZl4kXpyG56kzi+FuVDrSMb23IbBj0eYvYenzNvQtClLSuTLaRUUvszPGfhbjScc43YVKsDfPz/KRwFxJqtG2YD5uf8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1644411509227334.9033423090126; Wed, 9 Feb 2022 04:58:29 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-551-XNKhNFq-NuGQaqZp6Bn0Wg-1; Wed, 09 Feb 2022 07:58:26 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6513F83DD21; Wed, 9 Feb 2022 12:58:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 17A7D6F119; Wed, 9 Feb 2022 12:58:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 317AE4BB7C; Wed, 9 Feb 2022 12:58:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 219CwHiV017428 for ; Wed, 9 Feb 2022 07:58:17 -0500 Received: by smtp.corp.redhat.com (Postfix) id D9BCD7C0CA; Wed, 9 Feb 2022 12:58:17 +0000 (UTC) Received: from maggie.brq.redhat.com (unknown [10.34.244.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34D687C0CE for ; Wed, 9 Feb 2022 12:58:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644411508; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GB5Y3cv3vBip4oVy4rSzkdk5SZvbFCHPQrMsM4cmmp4=; b=SlxrfBhNfN7JOcOwkEJzPVnJbLkx661AuRWJV705wcwqQ88cMkjs/mQVDSQlt/rWI2ZaYm 2TQwkUGlDVBFDOgtaVYCLZQyut/5sarCL7176tjJ2xh/FVkIvqgy+U4f7lS52J2Htwc847 kFBbCiijeV+nYfhNI3N7hYB6ZMaqhb4= X-MC-Unique: XNKhNFq-NuGQaqZp6Bn0Wg-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] ch: Report VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER as supported Date: Wed, 9 Feb 2022 13:58:07 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1644411511423100001 Content-Type: text/plain; charset="utf-8" Even though the CH driver doesn't implement virNetworkUpdate() API, when it does it will see the arguments in correct order. This is similar to other drivers that don't implement the API, like ESX, libxl, LXC, etc. Enabling this driver feature stops clients from swapping the arguments (see comment in the API for more info). Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani --- src/ch/ch_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index e751ddba19..bb2959d108 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -934,6 +934,7 @@ chConnectSupportsFeature(virConnectPtr conn, =20 switch ((virDrvFeature) feature) { case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: return 1; case VIR_DRV_FEATURE_MIGRATION_V2: case VIR_DRV_FEATURE_MIGRATION_V3: @@ -949,7 +950,6 @@ chConnectSupportsFeature(virConnectPtr conn, case VIR_DRV_FEATURE_REMOTE: case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: - case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: default: return 0; } --=20 2.34.1