From nobody Thu May 2 21:55:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1675930767; cv=none; d=zohomail.com; s=zohoarc; b=GbjZxxCizdfJe2gbaHSUbnEK6B51sOyHN3siRkcRdjwT6mbkawr4/chwFWaj3eVXC0P4VgOXyZlmWQGs+Vy+rgBS5+1RQGFTgSyCQUEQev8oGPoXaNf34A5dX2Mg9d9up/bpdrOukRIbdOyKNBCT9t85mJRuJ51fYRcThk32Kt0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675930767; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=aUOaJ//HDPl1tb1hRDRf8wTNWJI2V7METJ10lshaUpA=; b=TnLp7LlCecOL3P5D+hNTT6U7r8GkUtTVBmTpo0djpsPluGJuOflP4JbiHJTMVyfvoPayVQVj9lpBlD3MMjWjThiq80bfDardu7nMMiQvjv5t6ueQtFKIG+6DSy+AXRA+d6GnR8YuOmNaV5Xf8xTOD4BRcsjxJBRez9In5vmlWS0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1675930767227135.43986606914598; Thu, 9 Feb 2023 00:19:27 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-C0rSq--aPri6DeNmfWKFPg-1; Thu, 09 Feb 2023 03:19:22 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 39170299E754; Thu, 9 Feb 2023 08:19:20 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C03BF2026D4B; Thu, 9 Feb 2023 08:19:17 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B09E1194658D; Thu, 9 Feb 2023 08:19:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4112F1946589 for ; Thu, 9 Feb 2023 08:19:17 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3308C18EC2; Thu, 9 Feb 2023 08:19:17 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF12744037 for ; Thu, 9 Feb 2023 08:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675930766; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=aUOaJ//HDPl1tb1hRDRf8wTNWJI2V7METJ10lshaUpA=; b=EXYV+uhdV5/VYnXOTCqxtd4z1pFNAKxGHFWelTBC7iccEdUezAVA74a5iXaWhBhgB1N3fN RLEdmI/HiCcqdjT//0eFPd++rIGXvpuJ47gj5LQWj5h1vRiqO8pwmF3sXfff4onG6Uu862 th0GLOXW61NvkRpWXjVhYmmbXa7YhX4= X-MC-Unique: C0rSq--aPri6DeNmfWKFPg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] remote_driver: Work around broken clang Date: Thu, 9 Feb 2023 09:19:13 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1675930768428100001 Content-Type: text/plain; charset="utf-8"; x-default="true" In recent commit of v9.0.0-191-gc71c159248 I've introduced remoteConnectFormatURI() function and in the function @query variable. Even though, the variable is used, clang-13 fails to see it. Surprisingly, never clang is not affected. Fortunately, swapping the order in which variables are set makes clang happy again. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/remote/remote_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 58cd0abe8c..a4c60be3d7 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -712,7 +712,7 @@ remoteConnectFormatURI(virURI *uri, virURIParamsSetIgnore(uri, false, names); } =20 - query =3D tmpuri.query =3D virURIFormatParams(uri); + tmpuri.query =3D query =3D virURIFormatParams(uri); =20 ret =3D virURIFormat(&tmpuri); =20 --=20 2.39.1