From nobody Sun Feb 8 12:43:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598969664; cv=none; d=zohomail.com; s=zohoarc; b=DfzX/BlXVJUR5j+FG6ANyjzO+U86SmSASnRrX2ip9tOJ5JAW90B9M8lL34tNeSFk5ZCczbLD4wM2tFZOhAUSUQP64RuSRmkpnOCQSMtUutHCLTAoCUS0nfpZqDqawk/QdrBhFx69yxBLfklJouNKACB0ZJ/xA4MWZZVrSE6gp04= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598969664; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=goJE8NwR4Ye4vJY1YfXqiJYstRzUMbQO7zXGDJ6pJu8=; b=SCAE5ZjpONDSNyEWdi/W4D2Auv/swakF6ndalCe0Ow3yCqtwaObS1Ry09WGBN8RBxvyfUSzAttaNwtbaenfziWJ8PtvlCbpNWDMa/kDmLfV/i6K6VLiOqobgoGReTcysDBUjGrbUNlOmnFUliiouAu4hHx3/sqhcz4rE/e9QqPk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1598969664201963.4044147612626; Tue, 1 Sep 2020 07:14:24 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-521-dpO39zLUPV6n8aZ7XhNjOw-1; Tue, 01 Sep 2020 10:00:33 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 792348030DD; Tue, 1 Sep 2020 14:00:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5639A78B56; Tue, 1 Sep 2020 14:00:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D7840181A720; Tue, 1 Sep 2020 14:00:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 081E0KUG013098 for ; Tue, 1 Sep 2020 10:00:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1A02F7AED4; Tue, 1 Sep 2020 14:00:20 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C0557B931 for ; Tue, 1 Sep 2020 14:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598969362; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=goJE8NwR4Ye4vJY1YfXqiJYstRzUMbQO7zXGDJ6pJu8=; b=YFi09xlQTtmRGyDKmFl8stm9GsIjIHUrs0kA4KEp1HNd/LzDH3DmDRDh399TizCfMb8faV +IO8AdDO1x/X7aOLSfH5A4BMdFgWcTXe4onaExg7GJdAA7Tw1kmdISDHGQYOPCMyICYDPW CXPsRHRhUaUWq1pn2bJ7sM1hkWw6UzE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598969662; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=goJE8NwR4Ye4vJY1YfXqiJYstRzUMbQO7zXGDJ6pJu8=; b=EmGLdErZorm4+Q1xVjewJuZr+AEkFWd6at3GZKh9KB4i38x3QBB302aeIxaJ5IVRCN7ncU zF7Yd9N5O/FJUnkHG3ENE2OSPlDuSumJ9zEBU8us/BL0Pmjan/kzne++Jf8Z697QwJ6IDK Vqb3sovBI9TQHGRl+p4+uE1X+umBEUo= X-MC-Unique: dpO39zLUPV6n8aZ7XhNjOw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/5] util: Check for HAVE_NET_IF_H correctly Date: Tue, 1 Sep 2020 16:00:10 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) (identity @redhat.com) Content-Type: text/plain; charset="utf-8" There are two places where we try to check whether the host system has net/if.h before including it. But the check is missing '_H' suffix. Fixes: 7f3eb533f44742071366e07a35ab41070956707b Signed-off-by: Michal Privoznik --- src/util/virnetdevbridge.c | 2 +- src/util/virnetdevtap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c index 8ce1a07c41..ccac97e8d0 100644 --- a/src/util/virnetdevbridge.c +++ b/src/util/virnetdevbridge.c @@ -27,7 +27,7 @@ #include "virstring.h" #include "virsocket.h" =20 -#ifdef HAVE_NET_IF +#ifdef HAVE_NET_IF_H # include #endif =20 diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index c0a7c3019e..931be9e36d 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -36,7 +36,7 @@ #ifndef WIN32 # include #endif -#ifdef HAVE_NET_IF +#ifdef HAVE_NET_IF_H # include #endif #include --=20 2.26.2